58736 2011-04-16 17:17:38 -0700 REGRESSION (r84096): <br> moved to the right in fast/block/float/032.html 2011-04-17 19:10:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED LayoutTestFailure, Regression P1 Normal --- 1 mitz webkit-unassigned hyatt inferno simon.fraser oldest_to_newest 387297 0 mitz 2011-04-16 17:17:38 -0700 After r84096, one of the <br> elements in fast/block/float/032.html is clearing a float that ends above it (so should not be cleared). This is a result of artificially extending the float so that its bottom touches the bottom of the line (the line is taller than the float, in this case). I am going to commit updated expected results for now. 387298 1 mitz 2011-04-16 17:21:08 -0700 r84098. 387306 2 89938 mitz 2011-04-16 19:25:33 -0700 Created attachment 89938 Patch 387497 3 89938 mjs 2011-04-17 19:03:47 -0700 Comment on attachment 89938 Patch r=me 387500 4 mitz 2011-04-17 19:10:23 -0700 Committed r84119. 89938 2011-04-16 19:25:33 -0700 2011-04-17 19:03:47 -0700 Patch bug-58736-20110416192532.patch text/plain 6304 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDk4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTYgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChyODQwOTYpOiA8YnI+IG1vdmVkIHRvIHRoZSBy aWdodCBpbiBmYXN0L2Jsb2NrL2Zsb2F0LzAzMi5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODczNgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6 YXBwZW5kRmxvYXRpbmdPYmplY3RUb0xhc3RMaW5lKTogSXQgaXMgZW5vdWdoIHRvIGV4dGVuZCB0 aGUgZmxvYXQgc28KKyAgICAgICAgdGhhdCBpdCB0b3VjaGVzIHRoZSBib3R0b20gb2YgdGhlIHBy ZXZpb3VzIGxpbmUsIHNpbmNlIFJlbmRlckJsb2NrOjptYXJrTGluZXNEaXJ0eUluQmxvY2tSYW5n ZSgpCisgICAgICAgIGFsd2F5cyBkaXJ0aWVzIHRoZSBsaW5lIGFmdGVyIHRoZSBsYXN0IG9uZSBp biB0aGUgcmFuZ2UuCisKIDIwMTEtMDQtMTYgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAkocmV2aXNp b24gODQwOTgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzE3LDggKzcxNywxMCBAQCBpbmxpbmUgQmlkaVJ1 biogUmVuZGVyQmxvY2s6OmhhbmRsZVRyYWlsCiB2b2lkIFJlbmRlckJsb2NrOjphcHBlbmRGbG9h dGluZ09iamVjdFRvTGFzdExpbmUoRmxvYXRpbmdPYmplY3QqIGZsb2F0aW5nT2JqZWN0KQogewog ICAgIC8vIEVuc3VyZSB0aGF0IHRoZSBmbG9hdCB0b3VjaGVzIHRoZSBsaW5lLgotICAgIGlmIChs b2dpY2FsQm90dG9tRm9yRmxvYXQoZmxvYXRpbmdPYmplY3QpIDwgbGFzdFJvb3RCb3goKS0+Ymxv Y2tMb2dpY2FsSGVpZ2h0KCkpCi0gICAgICAgIHNldExvZ2ljYWxIZWlnaHRGb3JGbG9hdChmbG9h dGluZ09iamVjdCwgbGFzdFJvb3RCb3goKS0+YmxvY2tMb2dpY2FsSGVpZ2h0KCkgLSBsb2dpY2Fs VG9wRm9yRmxvYXQoZmxvYXRpbmdPYmplY3QpKTsKKyAgICBpZiAoUm9vdElubGluZUJveCogcHJl dmlvdXNMaW5lID0gbGFzdFJvb3RCb3goKS0+cHJldlJvb3RCb3goKSkgeworICAgICAgICBpZiAo bG9naWNhbEJvdHRvbUZvckZsb2F0KGZsb2F0aW5nT2JqZWN0KSA8IHByZXZpb3VzTGluZS0+Ymxv Y2tMb2dpY2FsSGVpZ2h0KCkpCisgICAgICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0Rm9yRmxvYXQo ZmxvYXRpbmdPYmplY3QsIHByZXZpb3VzTGluZS0+YmxvY2tMb2dpY2FsSGVpZ2h0KCkgLSBsb2dp Y2FsVG9wRm9yRmxvYXQoZmxvYXRpbmdPYmplY3QpKTsKKyAgICB9CiAKICAgICBsYXN0Um9vdEJv eCgpLT5hcHBlbmRGbG9hdChmbG9hdGluZ09iamVjdC0+cmVuZGVyZXIoKSk7CiB9CkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiA4NDA5OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTE2ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UkVHUkVTU0lPTiAocjg0MDk2KTogPGJyPiBtb3ZlZCB0byB0aGUgcmlnaHQgaW4gZmFzdC9ibG9j ay9mbG9hdC8wMzIuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTg3MzYKKworICAgICAgICBSZXZlcnQgdG8gdGhlIGNvcnJlY3QgcmVzdWx0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLXdpbi9mYXN0L2Jsb2NrL2Zsb2F0LzAzMi1l eHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL2Zhc3QvYmxvY2svZmxvYXQvMDMy LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9ibG9jay9mbG9hdC8w MzItZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvYmxvY2svZmxvYXQv MDMyLWV4cGVjdGVkLnR4dDoKKwogMjAxMS0wNC0xNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIFVwZGF0ZWQgcmVzdWx0cyBmb3IgZmFzdC9ibG9jay9mbG9hdC8w MzIuaHRtbCBhZnRlciByODQwOTYuIEZpbGVkIGh0dHA6Ly93ZWJraXQub3JnL2IvNTg3MzYgdG8K SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi9mYXN0L2Jsb2NrL2Zsb2F0 LzAzMi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0td2luL2Zhc3QvYmxvY2svZmxvYXQvMDMyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gODQw OTgpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS13aW4vZmFzdC9ibG9jay9mbG9h dC8wMzItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIGxheWVy IGF0ICgwLDApIHNpemUgNzg1eDEwMzYKICAgICAgICAgUmVuZGVyVGV4dENvbnRyb2wge0lOUFVU fSBhdCAoMzA1LDUpIHNpemUgMTA0eDEwNiBbYmdjb2xvcj0jODAwMDgwXSBbYm9yZGVyOiAoMnB4 IGluc2V0ICMwMDAwMDApXQogICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6 ZSAweDAKICAgICAgIFJlbmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICgwLDc2MCkgc2l6ZSA3Njl4 MjAKLSAgICAgICAgUmVuZGVyQlIge0JSfSBhdCAoMTA1LDApIHNpemUgMHgxOQorICAgICAgICBS ZW5kZXJCUiB7QlJ9IGF0ICgwLDApIHNpemUgMHgxOQogICAgICAgUmVuZGVyQmxvY2sge0RJVn0g YXQgKDAsNzgwKSBzaXplIDc2OXgxMTAgW2JvcmRlcjogKDVweCBzb2xpZCAjMDAwMDAwKV0KICAg ICAgICAgUmVuZGVyQmxvY2sgKGZsb2F0aW5nKSB7RElWfSBhdCAoNSw1KSBzaXplIDEwMHgxMDAg W2JnY29sb3I9IzAwODAwMF0KICAgICAgICAgUmVuZGVyVGV4dENvbnRyb2wge0lOUFVUfSBhdCAo NTUsNSkgc2l6ZSAxMDR4MTA2IFtiZ2NvbG9yPSM4MDAwODBdIFtib3JkZXI6ICgycHggaW5zZXQg IzAwMDAwMCldCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9ibG9jay9mbG9h dC8wMzItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9mYXN0L2Jsb2NrL2Zsb2F0LzAzMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDg0MDk4KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvYmxvY2svZmxvYXQvMDMyLWV4cGVjdGVkLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMzUsNyArMzUsNyBAQCBsYXllciBhdCAoMCwwKSBzaXplIDc4 NHgxMDI5CiAgICAgICAgIFJlbmRlclRleHRDb250cm9sIHtJTlBVVH0gYXQgKDMwNSw1KSBzaXpl IDEwNngxMDYgW2JnY29sb3I9IzgwMDA4MF0gW2JvcmRlcjogKDJweCBpbnNldCAjMDAwMDAwKV0K ICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCiAgICAgICBSZW5k ZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCw3NTUpIHNpemUgNzY4eDE5Ci0gICAgICAgIFJlbmRl ckJSIHtCUn0gYXQgKDEwNSwwKSBzaXplIDB4MTkKKyAgICAgICAgUmVuZGVyQlIge0JSfSBhdCAo MCwwKSBzaXplIDB4MTkKICAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDc3NCkgc2l6ZSA3 Njh4MTEwIFtib3JkZXI6ICg1cHggc29saWQgIzAwMDAwMCldCiAgICAgICAgIFJlbmRlckJsb2Nr IChmbG9hdGluZykge0RJVn0gYXQgKDUsNSkgc2l6ZSAxMDB4MTAwIFtiZ2NvbG9yPSMwMDgwMDBd CiAgICAgICAgIFJlbmRlclRleHRDb250cm9sIHtJTlBVVH0gYXQgKDU1LDUpIHNpemUgMTA2eDEw NiBbYmdjb2xvcj0jODAwMDgwXSBbYm9yZGVyOiAoMnB4IGluc2V0ICMwMDAwMDApXQpJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmxvY2svZmxvYXQvMDMyLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9ibG9jay9mbG9h dC8wMzItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA4NDA5OCkKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L2Jsb2NrL2Zsb2F0LzAzMi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTM1LDcgKzM1LDcgQEAgbGF5ZXIgYXQgKDAsMCkgc2l6ZSA3ODV4MTAyMgogICAgICAgICBS ZW5kZXJUZXh0Q29udHJvbCB7SU5QVVR9IGF0ICgzMDUsNSkgc2l6ZSAxMDZ4MTA2IFtiZ2NvbG9y PSM4MDAwODBdIFtib3JkZXI6ICgycHggaW5zZXQgIzAwMDAwMCldCiAgICAgICAgIFJlbmRlclRl eHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MAogICAgICAgUmVuZGVyQmxvY2sgKGFub255bW91 cykgYXQgKDAsNzUwKSBzaXplIDc2OXgxOAotICAgICAgICBSZW5kZXJCUiB7QlJ9IGF0ICgxMDUs MCkgc2l6ZSAweDE4CisgICAgICAgIFJlbmRlckJSIHtCUn0gYXQgKDAsMCkgc2l6ZSAweDE4CiAg ICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCw3NjgpIHNpemUgNzY5eDExMCBbYm9yZGVyOiAo NXB4IHNvbGlkICMwMDAwMDApXQogICAgICAgICBSZW5kZXJCbG9jayAoZmxvYXRpbmcpIHtESVZ9 IGF0ICg1LDUpIHNpemUgMTAweDEwMCBbYmdjb2xvcj0jMDA4MDAwXQogICAgICAgICBSZW5kZXJU ZXh0Q29udHJvbCB7SU5QVVR9IGF0ICg1NSw1KSBzaXplIDEwNngxMDYgW2JnY29sb3I9IzgwMDA4 MF0gW2JvcmRlcjogKDJweCBpbnNldCAjMDAwMDAwKV0KSW5kZXg6IExheW91dFRlc3RzL3BsYXRm b3JtL3F0L2Zhc3QvYmxvY2svZmxvYXQvMDMyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2Jsb2NrL2Zsb2F0LzAzMi1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDg0MDk4KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9ibG9jay9m bG9hdC8wMzItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIGxh eWVyIGF0ICgwLDApIHNpemUgODAweDEwMjkKICAgICAgICAgUmVuZGVyVGV4dENvbnRyb2wge0lO UFVUfSBhdCAoMzA1LDUpIHNpemUgMTA2eDEwNiBbYm9yZGVyOiAoMnB4IGluc2V0ICMwMDAwMDAp XQogICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAweDAKICAgICAgIFJl bmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICgwLDc1NSkgc2l6ZSA3ODR4MTkKLSAgICAgICAgUmVu ZGVyQlIge0JSfSBhdCAoMTA1LDApIHNpemUgMHgxOQorICAgICAgICBSZW5kZXJCUiB7QlJ9IGF0 ICgwLDApIHNpemUgMHgxOQogICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsNzc0KSBzaXpl IDc4NHgxMTAgW2JvcmRlcjogKDVweCBzb2xpZCAjMDAwMDAwKV0KICAgICAgICAgUmVuZGVyQmxv Y2sgKGZsb2F0aW5nKSB7RElWfSBhdCAoNSw1KSBzaXplIDEwMHgxMDAgW2JnY29sb3I9IzAwODAw MF0KICAgICAgICAgUmVuZGVyVGV4dENvbnRyb2wge0lOUFVUfSBhdCAoNTUsNSkgc2l6ZSAxMDZ4 MTA2IFtib3JkZXI6ICgycHggaW5zZXQgIzAwMDAwMCldCg==