58731 2011-04-16 10:54:32 -0700 [Texmap] [Qt] Do not reset a texture if it comes from imageToTexture pool. 2012-02-14 04:35:43 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED INVALID Qt, QtTriaged P2 Normal --- 47070 58903 0 joybro201 webkit-unassigned benjamin eric kbr noam skyul oldest_to_newest 387263 0 joybro201 2011-04-16 10:54:32 -0700 imageToTexture is a pool of textures to share it between BitmapTextureGLs. The textures in the pool are already initialized and filled with image data, so they doesn't have to be initialized again when it comes from the pool. The current implementation always reset the texture whether it is found in the pool or new. This causes a problem that openGL draws a texture, which has garbage data, to screen. 387265 1 89926 joybro201 2011-04-16 11:06:08 -0700 Created attachment 89926 Patch 387267 2 noam 2011-04-16 11:15:04 -0700 LGTM 387346 3 89926 benjamin 2011-04-17 05:16:28 -0700 Comment on attachment 89926 Patch Any reason not to make a pixel test for the bug? 387503 4 joybro201 2011-04-17 19:36:27 -0700 I'm not sure it's possible to test animation features like this using a pixel test. If so, please let me know any hint. 387509 5 noam 2011-04-17 20:42:58 -0700 (In reply to comment #3) > (From update of attachment 89926 [details]) > Any reason not to make a pixel test for the bug? We still don't have a way to pixel-test the opengl backend. If we had, the tests under LayoutTests/compositing should be sufficient for these optimizations. 387790 6 89926 eric 2011-04-18 09:26:49 -0700 Comment on attachment 89926 Patch How do we test this? 387971 7 kbr 2011-04-18 13:16:33 -0700 In Chromium glReadPixels is used in order to run pixel tests for the accelerated compositor. 388208 8 joybro201 2011-04-18 18:49:39 -0700 (In reply to comment #7) > In Chromium glReadPixels is used in order to run pixel tests for the accelerated compositor. Could you refer me to the Chrominum's pixel test cases or DRT code for those tests which is using glReadPixels? I failed to find how Chromium does to test accelerated compositor in WebKit source. 388236 9 kbr 2011-04-18 19:20:32 -0700 (In reply to comment #8) > (In reply to comment #7) > > In Chromium glReadPixels is used in order to run pixel tests for the accelerated compositor. > > Could you refer me to the Chrominum's pixel test cases or DRT code for those tests which is using glReadPixels? > I failed to find how Chromium does to test accelerated compositor in WebKit source. Chromium's test expectations for tests involving the compositor are checked in under LayoutTests/platform/chromium-gpu/compositing/. There are several places in Chromium's code where the behavior is switched between the full browser and DRT. One example is using the real OpenGL on the system vs. the Mesa software renderer. However, the key place where the readback is done for DRT is in WebViewImpl::paint, Source/WebKit/chromium/src/WebViewImpl.cpp. When running in DRT, the passed-in WebCanvas is non-NULL, and the readback is done. 388536 10 joybro201 2011-04-19 09:08:04 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > In Chromium glReadPixels is used in order to run pixel tests for the accelerated compositor. > > > > Could you refer me to the Chrominum's pixel test cases or DRT code for those tests which is using glReadPixels? > > I failed to find how Chromium does to test accelerated compositor in WebKit source. > > Chromium's test expectations for tests involving the compositor are checked in under LayoutTests/platform/chromium-gpu/compositing/. > > There are several places in Chromium's code where the behavior is switched between the full browser and DRT. One example is using the real OpenGL on the system vs. the Mesa software renderer. However, the key place where the readback is done for DRT is in WebViewImpl::paint, Source/WebKit/chromium/src/WebViewImpl.cpp. When running in DRT, the passed-in WebCanvas is non-NULL, and the readback is done. Thanks for the detailed reply. It seems that Qt's WebKit and DRT also have to be modified in the same way for a pixel-test. I will try to patch this in the near future. 556214 11 noam 2012-02-14 04:35:43 -0800 Code has completely changed, this no longer applies. 89926 2011-04-16 11:06:08 -0700 2011-04-18 09:26:48 -0700 Patch Patch text/plain 1960 joybro201 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDg5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMTYgIFlvdW5nIEhh biBMZWUgIDxqb3licm9AY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1RleG1hcF0gW1F0XSBEbyBub3QgcmVzZXQgYSB0ZXh0 dXJlIGlmIGl0IGNvbWVzIGZyb20gaW1hZ2VUb1RleHR1cmUgcG9vbC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NzMxCisKKyAgICAgICAgZmluZE9y Q3JlYXRlIGZ1bmN0aW9uIHJldHVybnMgdGhlIGlkIG9mIGVpdGhlciBhIHRleHR1cmUgaW4gdGhl IHBvb2wgb3IgbmV3LgorICAgICAgICBJZiBpdCBpcyBhIG5ldyB0ZXh0dXJlLCBpdCBoYXZlIHRv IGJlIGludGlhbGl6ZWQgYW5kIGZpbGxlZCB3aXRoIHRoZSBpbWFnZS4KKyAgICAgICAgQnV0IGlm IGl0IGlzIGZyb20gdGhlIHBvb2wsIGl0IGRvZXNuJ3QgaGF2ZSB0byBkbyB0aGF0IGJlY2F1c2Ug aXQgaGFzIGFscmVhZHkgZG9uZQorICAgICAgICBpbiB0aGUgZm9ybWVyIGNhc2UuCisKKyAgICAg ICAgVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gYWx3YXlzIHJlc2V0IHRoZSB0ZXh0dXJlLCBh bmQgdGhpcyBjYXVzZXMgYSBwcm9ibGVtIHRoYXQgb3BlbkdMIGRyYXcKKyAgICAgICAgYSB0ZXh0 dXJlLCB3aGljaCBoYXMgZ2FyYmFnZSBkYXRhLCB0byBzY3JlZW4uCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkJpdG1hcFRleHR1cmVHTDo6c2V0Q29udGVudHNUb0ltYWdlKToKKwogMjAxMS0wNC0xNiAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L29wZW5nbC9UZXh0dXJlTWFwcGVyR0wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZXh0dXJlTWFwcGVyR0wuY3BwCShyZXZpc2lvbiA4 NDA4OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZXh0dXJl TWFwcGVyR0wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OTgsMTMgKzQ5OCwxMyBAQCB2b2lkIEJp dG1hcFRleHR1cmVHTDo6c2V0Q29udGVudHNUb0ltYWdlCiAgICAgaWYgKG5ld1RleHR1cmVJRCAh PSBtX2lkKSB7CiAgICAgICAgIGRlc3Ryb3koKTsKICAgICAgICAgbV9pZCA9IG5ld1RleHR1cmVJ RDsKLSAgICAgICAgcmVzZXQoaW1hZ2UtPnNpemUoKSwgZmFsc2UpOwotICAgICAgICBtX2ltYWdl ID0gbmF0aXZlSW1hZ2U7CiAgICAgICAgIGlmICghZm91bmQpIHsKKyAgICAgICAgICAgIHJlc2V0 KGltYWdlLT5zaXplKCksIGZhbHNlKTsKICAgICAgICAgICAgIEdyYXBoaWNzQ29udGV4dCBjb250 ZXh0KGJlZ2luUGFpbnQoSW50UmVjdCgwLCAwLCBtX3RleHR1cmVTaXplLndpZHRoKCksIG1fdGV4 dHVyZVNpemUuaGVpZ2h0KCkpKSk7CiAgICAgICAgICAgICBjb250ZXh0LmRyYXdJbWFnZShpbWFn ZSwgQ29sb3JTcGFjZURldmljZVJHQiwgSW50UG9pbnQoMCwgMCksIENvbXBvc2l0ZUNvcHkpOwog ICAgICAgICAgICAgZW5kUGFpbnQoKTsKICAgICAgICAgfQorICAgICAgICBtX2ltYWdlID0gbmF0 aXZlSW1hZ2U7CiAgICAgfQogfQogCg==