58716 2011-04-15 17:31:50 -0700 JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj 2011-04-15 19:28:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P1 Critical --- 1 timothy webkit-unassigned abarth dslomov eric levin lforschler mrowe timothy webkit.review.bot oldest_to_newest 387081 0 timothy 2011-04-15 17:31:50 -0700 In https://trac.webkit.org/changeset/83974 JavaScriptCore became dependant on an external project. This breaks the build under Apple's internal build system. In general anthing inside Source/JavaScriptCore (and WebCore, etc.) can't reference something outside that source root. So ../ThirdParty is a violation of that. 387084 1 timothy 2011-04-15 17:34:06 -0700 The correct way to do this would be to build gtest and have JSC depend on it and link against it. Like WebCore does with ANGLE. 387088 2 timothy 2011-04-15 17:40:47 -0700 Mark Rowe has told me the build still works. But this is still not the normal way we do cross project dependancy in WebKit. 387091 3 mrowe 2011-04-15 17:44:48 -0700 I think this change should be reverted. JavaScriptCore.xcodeproj isn’t the right place for this to live. JavaScriptCore.xcodeproj should not depend on this random third-party library. 387096 4 abarth 2011-04-15 17:50:59 -0700 Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built? 387097 5 mrowe 2011-04-15 17:52:37 -0700 (In reply to comment #4) > Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built? Does what mean that? 387100 6 timothy 2011-04-15 17:55:43 -0700 No, only the JavaScriptCore source tree exists when JavaScriptCore is built. 387103 7 timothy 2011-04-15 17:58:39 -0700 The build does not fail like I thought it did only because the All target does not build the wtftests target. If it did, it would fail because the gtest project can't be found. 387105 8 levin 2011-04-15 18:00:03 -0700 I'm working on rolling this out. 387112 9 abarth 2011-04-15 18:12:04 -0700 > > Does this mean that the entire Source directory exists when JavaScript.xcodeproj is built? > > Does what mean that? I was trying to understand why this didn't break the build entirely. Comment #7 has the answer. 387114 10 levin 2011-04-15 18:17:42 -0700 Committed as http://trac.webkit.org/changeset/84068 387166 11 webkit.review.bot 2011-04-15 19:28:54 -0700 http://trac.webkit.org/changeset/84068 might have broken Windows 7 Release (Tests) The following tests are not passing: http/tests/inspector/resource-tree-model.html