58709 2011-04-15 16:26:50 -0700 WebKit2: Stop using deprecated NSInputManager 2011-04-15 18:22:50 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 ap ap abarth eric webkit.review.bot oldest_to_newest 387012 0 ap 2011-04-15 16:26:50 -0700 We should be using NSInputContext. 387029 1 89878 ap 2011-04-15 16:36:57 -0700 Created attachment 89878 proposed patch 387083 2 ap 2011-04-15 17:33:57 -0700 Committed <http://trac.webkit.org/changeset/84062>. 387141 3 webkit.review.bot 2011-04-15 18:22:50 -0700 http://trac.webkit.org/changeset/84062 might have broken Leopard Intel Release (Build) 89878 2011-04-15 16:36:57 -0700 2011-04-15 16:54:43 -0700 proposed patch NSInputManager.txt text/plain 3496 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDQ3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTUgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MjogU3RvcCB1c2luZyBkZXByZWNhdGVkIE5TSW5w dXRNYW5hZ2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODcwOQorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAg ICAoLVtXS1ZpZXcgbW91c2VNb3ZlZDpdKToKKyAgICAgICAgKC1bV0tWaWV3IG1vdXNlRG93bjpd KToKKyAgICAgICAgKC1bV0tWaWV3IG1vdXNlVXA6XSk6CisgICAgICAgICgtW1dLVmlldyBtb3Vz ZURyYWdnZWQ6XSk6CisKIDIwMTEtMDQtMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gODM5OTcpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29w eSkKQEAgLTk0MiwxOSArOTQyLDI2IEBAIC0gKHZvaWQpX3NldE1vdXNlRG93bkV2ZW50OihOU0V2 ZW50ICopZXYKICNkZWZpbmUgRVZFTlRfSEFORExFUihTZWxlY3RvciwgVHlwZSkgXAogICAgIC0g KHZvaWQpU2VsZWN0b3I6KE5TRXZlbnQgKil0aGVFdmVudCBcCiAgICAgeyBcCisgICAgICAgIGlm IChbW3NlbGYgaW5wdXRDb250ZXh0XSBoYW5kbGVFdmVudDp0aGVFdmVudF0pIHsgXAorICAgICAg ICAgICAgTE9HKFRleHRJbnB1dCwgIiVzIHdhcyBoYW5kbGVkIGJ5IHRleHQgaW5wdXQgY29udGV4 dCIsIFN0cmluZygjU2VsZWN0b3IpLnN1YnN0cmluZygwLCBTdHJpbmcoI1NlbGVjdG9yKS5maW5k KCJJbnRlcm5hbCIpKS5hc2NpaSgpLmRhdGEoKSk7IFwKKyAgICAgICAgICAgIHJldHVybjsgXAor ICAgICAgICB9IFwKICAgICAgICAgV2ViIyNUeXBlIyNFdmVudCB3ZWJFdmVudCA9IFdlYkV2ZW50 RmFjdG9yeTo6Y3JlYXRlV2ViIyNUeXBlIyNFdmVudCh0aGVFdmVudCwgc2VsZik7IFwKICAgICAg ICAgX2RhdGEtPl9wYWdlLT5oYW5kbGUjI1R5cGUjI0V2ZW50KHdlYkV2ZW50KTsgXAogICAgIH0K IAogRVZFTlRfSEFORExFUihtb3VzZUVudGVyZWQsIE1vdXNlKQogRVZFTlRfSEFORExFUihtb3Vz ZUV4aXRlZCwgTW91c2UpCitFVkVOVF9IQU5ETEVSKG1vdXNlTW92ZWRJbnRlcm5hbCwgTW91c2Up CitFVkVOVF9IQU5ETEVSKG1vdXNlRG93bkludGVybmFsLCBNb3VzZSkKK0VWRU5UX0hBTkRMRVIo bW91c2VVcEludGVybmFsLCBNb3VzZSkKK0VWRU5UX0hBTkRMRVIobW91c2VEcmFnZ2VkSW50ZXJu YWwsIE1vdXNlKQogRVZFTlRfSEFORExFUihvdGhlck1vdXNlRG93biwgTW91c2UpCiBFVkVOVF9I QU5ETEVSKG90aGVyTW91c2VEcmFnZ2VkLCBNb3VzZSkKIEVWRU5UX0hBTkRMRVIob3RoZXJNb3Vz ZU1vdmVkLCBNb3VzZSkKIEVWRU5UX0hBTkRMRVIob3RoZXJNb3VzZVVwLCBNb3VzZSkKIEVWRU5U X0hBTkRMRVIocmlnaHRNb3VzZURvd24sIE1vdXNlKQogRVZFTlRfSEFORExFUihyaWdodE1vdXNl RHJhZ2dlZCwgTW91c2UpCi1FVkVOVF9IQU5ETEVSKHJpZ2h0TW91c2VNb3ZlZCwgTW91c2UpCiBF VkVOVF9IQU5ETEVSKHJpZ2h0TW91c2VVcCwgTW91c2UpCiBFVkVOVF9IQU5ETEVSKHNjcm9sbFdo ZWVsLCBXaGVlbCkKIApAQCAtOTY2LDE3ICs5NzMsNyBAQCAtICh2b2lkKW1vdXNlTW92ZWQ6KE5T RXZlbnQgKilldmVudAogICAgIGlmIChzZWxmID09IFtbc2VsZiB3aW5kb3ddIGZpcnN0UmVzcG9u ZGVyXSAmJiAhTlNQb2ludEluUmVjdChbc2VsZiBjb252ZXJ0UG9pbnQ6W2V2ZW50IGxvY2F0aW9u SW5XaW5kb3ddIGZyb21WaWV3Om5pbF0sIFtzZWxmIHZpc2libGVSZWN0XSkpCiAgICAgICAgIHJl dHVybjsKIAotICAgIFdlYk1vdXNlRXZlbnQgd2ViRXZlbnQgPSBXZWJFdmVudEZhY3Rvcnk6OmNy ZWF0ZVdlYk1vdXNlRXZlbnQoZXZlbnQsIHNlbGYpOwotICAgIF9kYXRhLT5fcGFnZS0+aGFuZGxl TW91c2VFdmVudCh3ZWJFdmVudCk7Ci19Ci0KLS0gKHZvaWQpX21vdXNlSGFuZGxlcjooTlNFdmVu dCAqKWV2ZW50Ci17Ci0gICAgTlNJbnB1dE1hbmFnZXIgKmN1cnJlbnRJbnB1dE1hbmFnZXIgPSBb TlNJbnB1dE1hbmFnZXIgY3VycmVudElucHV0TWFuYWdlcl07Ci0gICAgaWYgKFtjdXJyZW50SW5w dXRNYW5hZ2VyIHdhbnRzVG9IYW5kbGVNb3VzZUV2ZW50c10gJiYgW2N1cnJlbnRJbnB1dE1hbmFn ZXIgaGFuZGxlTW91c2VFdmVudDpldmVudF0pCi0gICAgICAgIHJldHVybjsKLSAgICBXZWJNb3Vz ZUV2ZW50IHdlYkV2ZW50ID0gV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KGV2 ZW50LCBzZWxmKTsKLSAgICBfZGF0YS0+X3BhZ2UtPmhhbmRsZU1vdXNlRXZlbnQod2ViRXZlbnQp OworICAgIFtzZWxmIG1vdXNlTW92ZWRJbnRlcm5hbDpldmVudF07CiB9CiAKIC0gKHZvaWQpbW91 c2VEb3duOihOU0V2ZW50ICopZXZlbnQKQEAgLTk4NCwyMCArOTgxLDIwIEBAIC0gKHZvaWQpbW91 c2VEb3duOihOU0V2ZW50ICopZXZlbnQKICAgICBbc2VsZiBfc2V0TW91c2VEb3duRXZlbnQ6ZXZl bnRdOwogICAgIF9kYXRhLT5faWdub3JpbmdNb3VzZURyYWdnZWRFdmVudHMgPSBOTzsKICAgICBf ZGF0YS0+X2RyYWdIYXNTdGFydGVkID0gTk87Ci0gICAgW3NlbGYgX21vdXNlSGFuZGxlcjpldmVu dF07CisgICAgW3NlbGYgbW91c2VEb3duSW50ZXJuYWw6ZXZlbnRdOwogfQogCiAtICh2b2lkKW1v dXNlVXA6KE5TRXZlbnQgKilldmVudAogewogICAgIFtzZWxmIF9zZXRNb3VzZURvd25FdmVudDpu aWxdOwotICAgIFtzZWxmIF9tb3VzZUhhbmRsZXI6ZXZlbnRdOworICAgIFtzZWxmIG1vdXNlVXBJ bnRlcm5hbDpldmVudF07CiB9CiAKIC0gKHZvaWQpbW91c2VEcmFnZ2VkOihOU0V2ZW50ICopZXZl bnQKIHsKICAgICBpZiAoX2RhdGEtPl9pZ25vcmluZ01vdXNlRHJhZ2dlZEV2ZW50cykKICAgICAg ICAgcmV0dXJuOwotICAgIFtzZWxmIF9tb3VzZUhhbmRsZXI6ZXZlbnRdOworICAgIFtzZWxmIG1v dXNlRHJhZ2dlZEludGVybmFsOmV2ZW50XTsKIH0KIAogLSAoQk9PTClhY2NlcHRzRmlyc3RNb3Vz ZTooTlNFdmVudCAqKWV2ZW50Cg==