58699 2011-04-15 15:09:09 -0700 Chromium DevTools: Network panel timing test is flaky 2011-04-19 10:42:04 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik webkit-unassigned abarth commit-queue eric ojan pfeldman webkit.review.bot oldest_to_newest 386970 0 vsevik 2011-04-15 15:09:09 -0700 Apparently following condition leads to flakiness: resource.endTime - resource.responseReceivedTime >= 0.1 I assume responseReceivedTime could come a bit later than expected causing failure. resource.endTime - resource.startTime >= 0.2 condition seems to be more reliable. What do you think? 387662 1 90023 vsevik 2011-04-18 05:55:53 -0700 Created attachment 90023 Patch 387664 2 90024 vsevik 2011-04-18 05:58:51 -0700 Created attachment 90024 Fixed formatting 387798 3 90024 eric 2011-04-18 09:35:02 -0700 Comment on attachment 90024 Fixed formatting This could only reduce flakiness, not eliminiate it. Is there a way to do this test not involving timings? 387813 4 vsevik 2011-04-18 09:50:27 -0700 First of all the whole point of this test is to check that timings information coming from network stack (through the net log) is correct, so it would be hard to test that without timings. Essentially, this is our way to test that devtools_netlog_observer working on the real network stack gives us correct data. Secondly, I believe this should eliminate flakiness. I guess the only reason test was failing before was flush() behavior on testserver. The beginning and the end of the response could have come in the same piece of data, thus making resource.endTime - resource.responseReceivedTime close to zero. 388548 5 90024 commit-queue 2011-04-19 09:36:21 -0700 Comment on attachment 90024 Fixed formatting Clearing flags on attachment: 90024 Committed r84258: <http://trac.webkit.org/changeset/84258> 388549 6 commit-queue 2011-04-19 09:36:28 -0700 All reviewed patches have been landed. Closing bug. 388591 7 webkit.review.bot 2011-04-19 10:42:04 -0700 http://trac.webkit.org/changeset/84258 might have broken Windows 7 Release (Tests) 90023 2011-04-18 05:55:53 -0700 2011-04-18 05:58:51 -0700 Patch fixed_tes text/plain 2151 vsevik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMmUyMzNkMC4uMTEzNjRlYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNC0xOCAgVnNldm9sb2Qg Vmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBEZXZUb29sczogTmV0d29yayBwYW5lbCB0 aW1pbmcgdGVzdCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTg2OTkKKworICAgICAgICBGaXhlZCBuZXR3b3JrIHRpbWluZyB0ZXN0IGZs YWtpbmVzcy4KKworICAgICAgICAqIHNyYy9qcy9UZXN0cy5qczoKKyAgICAgICAgKC5UZXN0U3Vp dGUucHJvdG90eXBlLnRlc3ROZXR3b3JrVGltaW5nLmZpbmlzaFJlc291cmNlKToKKwogMjAxMS0w NC0xNyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvanMvVGVzdHMuanMgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5q cwppbmRleCAxODg0NzA5Li5lNGY3YTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9qcy9UZXN0cy5qcworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9U ZXN0cy5qcwpAQCAtNjAwLDkgKzYwMCwxMyBAQCBUZXN0U3VpdGUucHJvdG90eXBlLnRlc3ROZXR3 b3JrVGltaW5nID0gZnVuY3Rpb24oKQogCiAgICAgZnVuY3Rpb24gZmluaXNoUmVzb3VyY2UocmVz b3VyY2UsIGZpbmlzaFRpbWUpCiAgICAgewotICAgICAgICB0ZXN0LmFzc2VydFRydWUocmVzb3Vy Y2UudGltaW5nLnJlY2VpdmVIZWFkZXJzRW5kIC0gcmVzb3VyY2UudGltaW5nLmNvbm5lY3RTdGFy dCA+PSAxMDAsICJUaW1lIGJldHdlZW4gY29ubmVjdFN0YXJ0IGFuZCByZWNlaXZlSGVhZGVyc0Vu ZCBzaG91bGQgYmUgbW9yZSB0aGFuIDEwMG1zLiIpOyAgICAgICAgCi0gICAgICAgIHRlc3QuYXNz ZXJ0VHJ1ZShyZXNvdXJjZS5lbmRUaW1lIC0gcmVzb3VyY2UucmVzcG9uc2VSZWNlaXZlZFRpbWUg Pj0gMC4xLCAiVGltZSBiZXR3ZWVuIGVuZFRpbWUgYW5kIHJlc3BvbnNlUmVjZWl2ZWRUaW1lIHNo b3VsZCBiZSBtb3JlIHRoYW4gMTAwbXMuIik7ICAgICAgICAKLSAgICAgICAgdGVzdC5hc3NlcnRU cnVlKHJlc291cmNlLnJlc3BvbnNlUmVjZWl2ZWRUaW1lIC0gcmVzb3VyY2Uuc3RhcnRUaW1lID49 IDAuMSwgIlRpbWUgYmV0d2VlbiByZXNwb25zZVJlY2VpdmVkVGltZSBhbmQgc3RhcnRUaW1lIHNo b3VsZCBiZSBtb3JlIHRoYW4gMTAwbXMuIik7ICAgICAgICAKKyAgICAgICAgdGVzdC5hc3NlcnRU cnVlKHJlc291cmNlLnRpbWluZy5yZWNlaXZlSGVhZGVyc0VuZCAtIHJlc291cmNlLnRpbWluZy5j b25uZWN0U3RhcnQgPj0gMTAwLCAKKyAgICAgICAgICAgICAgICAiVGltZSBiZXR3ZWVuIHJlY2Vp dmVIZWFkZXJzRW5kIGFuZCBjb25uZWN0U3RhcnQgc2hvdWxkIGJlID49MTAwbXMsIGJ1dCB3YXMg IiArCisgICAgICAgICAgICAgICAgInJlY2VpdmVIZWFkZXJzRW5kPSIgKyByZXNvdXJjZS50aW1p bmcucmVjZWl2ZUhlYWRlcnNFbmQgKyAiLCBjb25uZWN0U3RhcnQ9IiArIHJlc291cmNlLnRpbWlu Zy5jb25uZWN0U3RhcnQgKyAiLiIpOworICAgICAgICB0ZXN0LmFzc2VydFRydWUocmVzb3VyY2Uu ZW5kVGltZSAtIHJlc291cmNlLnN0YXJ0VGltZSA+PSAwLjIsIAorICAgICAgICAgICAgICAgICJU aW1lIGJldHdlZW4gZW5kVGltZSBhbmQgc3RhcnRUaW1lIHNob3VsZCBiZSA+PTIwMG1zLCBidXQg d2FzICIgKworICAgICAgICAgICAgICAgICJlbmR0aW1lPSIgKyByZXNvdXJjZS5lbmRUaW1lICsg Iiwgc3RhcnRUaW1lPSIgKyByZXNvdXJjZS5zdGFydFRpbWUgKyAiLiIpOworICAgICAgICAKICAg ICAgICAgdGVzdC5yZWxlYXNlQ29udHJvbCgpOwogICAgIH0KICAgICAK 90024 2011-04-18 05:58:51 -0700 2011-04-19 09:36:21 -0700 Fixed formatting fixed_tes text/plain 2183 vsevik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMmUyMzNkMC4uMTEzNjRlYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNC0xOCAgVnNldm9sb2Qg Vmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBEZXZUb29sczogTmV0d29yayBwYW5lbCB0 aW1pbmcgdGVzdCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTg2OTkKKworICAgICAgICBGaXhlZCBuZXR3b3JrIHRpbWluZyB0ZXN0IGZs YWtpbmVzcy4KKworICAgICAgICAqIHNyYy9qcy9UZXN0cy5qczoKKyAgICAgICAgKC5UZXN0U3Vp dGUucHJvdG90eXBlLnRlc3ROZXR3b3JrVGltaW5nLmZpbmlzaFJlc291cmNlKToKKwogMjAxMS0w NC0xNyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvanMvVGVzdHMuanMgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5q cwppbmRleCAxODg0NzA5Li4yMjBjZjg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9qcy9UZXN0cy5qcworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9U ZXN0cy5qcwpAQCAtNjAwLDkgKzYwMCwxMyBAQCBUZXN0U3VpdGUucHJvdG90eXBlLnRlc3ROZXR3 b3JrVGltaW5nID0gZnVuY3Rpb24oKQogCiAgICAgZnVuY3Rpb24gZmluaXNoUmVzb3VyY2UocmVz b3VyY2UsIGZpbmlzaFRpbWUpCiAgICAgewotICAgICAgICB0ZXN0LmFzc2VydFRydWUocmVzb3Vy Y2UudGltaW5nLnJlY2VpdmVIZWFkZXJzRW5kIC0gcmVzb3VyY2UudGltaW5nLmNvbm5lY3RTdGFy dCA+PSAxMDAsICJUaW1lIGJldHdlZW4gY29ubmVjdFN0YXJ0IGFuZCByZWNlaXZlSGVhZGVyc0Vu ZCBzaG91bGQgYmUgbW9yZSB0aGFuIDEwMG1zLiIpOyAgICAgICAgCi0gICAgICAgIHRlc3QuYXNz ZXJ0VHJ1ZShyZXNvdXJjZS5lbmRUaW1lIC0gcmVzb3VyY2UucmVzcG9uc2VSZWNlaXZlZFRpbWUg Pj0gMC4xLCAiVGltZSBiZXR3ZWVuIGVuZFRpbWUgYW5kIHJlc3BvbnNlUmVjZWl2ZWRUaW1lIHNo b3VsZCBiZSBtb3JlIHRoYW4gMTAwbXMuIik7ICAgICAgICAKLSAgICAgICAgdGVzdC5hc3NlcnRU cnVlKHJlc291cmNlLnJlc3BvbnNlUmVjZWl2ZWRUaW1lIC0gcmVzb3VyY2Uuc3RhcnRUaW1lID49 IDAuMSwgIlRpbWUgYmV0d2VlbiByZXNwb25zZVJlY2VpdmVkVGltZSBhbmQgc3RhcnRUaW1lIHNo b3VsZCBiZSBtb3JlIHRoYW4gMTAwbXMuIik7ICAgICAgICAKKyAgICAgICAgdGVzdC5hc3NlcnRU cnVlKHJlc291cmNlLnRpbWluZy5yZWNlaXZlSGVhZGVyc0VuZCAtIHJlc291cmNlLnRpbWluZy5j b25uZWN0U3RhcnQgPj0gMTAwLCAKKyAgICAgICAgICAgICAgICAgICAgICAgICJUaW1lIGJldHdl ZW4gcmVjZWl2ZUhlYWRlcnNFbmQgYW5kIGNvbm5lY3RTdGFydCBzaG91bGQgYmUgPj0xMDBtcywg YnV0IHdhcyAiICsKKyAgICAgICAgICAgICAgICAgICAgICAgICJyZWNlaXZlSGVhZGVyc0VuZD0i ICsgcmVzb3VyY2UudGltaW5nLnJlY2VpdmVIZWFkZXJzRW5kICsgIiwgY29ubmVjdFN0YXJ0PSIg KyByZXNvdXJjZS50aW1pbmcuY29ubmVjdFN0YXJ0ICsgIi4iKTsKKyAgICAgICAgdGVzdC5hc3Nl cnRUcnVlKHJlc291cmNlLmVuZFRpbWUgLSByZXNvdXJjZS5zdGFydFRpbWUgPj0gMC4yLCAKKyAg ICAgICAgICAgICAgICAgICAgICAgICJUaW1lIGJldHdlZW4gZW5kVGltZSBhbmQgc3RhcnRUaW1l IHNob3VsZCBiZSA+PTIwMG1zLCBidXQgd2FzICIgKworICAgICAgICAgICAgICAgICAgICAgICAg ImVuZHRpbWU9IiArIHJlc291cmNlLmVuZFRpbWUgKyAiLCBzdGFydFRpbWU9IiArIHJlc291cmNl LnN0YXJ0VGltZSArICIuIik7CisgICAgICAgIAogICAgICAgICB0ZXN0LnJlbGVhc2VDb250cm9s KCk7CiAgICAgfQogICAgIAo=