58698 2011-04-15 15:05:00 -0700 Hang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading http://www.webkit.org/demos/calendar 2011-04-15 18:22:00 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All Windows 7 RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin abarth eric jberlin jer.noble jhoneycutt webkit.review.bot oldest_to_newest 386965 0 jberlin 2011-04-15 15:05:00 -0700 ntdll.dll!_RtlCompareMemoryUlong@12() + 0x10 bytes ntdll.dll!_RtlAllocateHeap@12() + 0x502a bytes ntdll.dll!_RtlDebugAllocateHeap@12() + 0xb5 bytes ntdll.dll!@RtlpAllocateHeap@24() + 0x57b22 bytes ntdll.dll!_RtlAllocateHeap@12() + 0x502a bytes msvcr80.dll!_malloc() + 0x7a bytes > JavaScriptCore.dll!WTF::fastMalloc(unsigned int n=92) Line 251 + 0xc bytes C++ WebKit.dll!WTF::StringImpl::createUninitialized(unsigned int length=36, wchar_t * & data=0xcccccccc) Line 87 + 0x9 bytes C++ WebKit.dll!WTF::StringImpl::create(const wchar_t * characters=0x0078ee1e, unsigned int length=36) Line 99 + 0x11 bytes C++ WebKit.dll!WTF::String::String(const wchar_t * characters=0x0078ee1e, unsigned int length=36) Line 44 + 0x3e bytes C++ WebKit.dll!WebCore::createCanonicalUUIDString() Line 72 + 0x1d bytes C++ WebKit.dll!WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory(WebCore::SharedBuffer * data=0x07837ca8, const WTF::String & directory={...}, WTF::String & path={...}) Line 1236 + 0x9 bytes C++ WebKit.dll!WebCore::ApplicationCacheStorage::store(WebCore::ApplicationCacheResource * resource=0x07761fa8, unsigned int cacheStorageID=1) Line 807 + 0x19 bytes C++ WebKit.dll!WebCore::ApplicationCacheStorage::store(WebCore::ApplicationCache * cache=0x07845418, WebCore::StorageIDJournal<WebCore::ApplicationCacheResource> * storageIDJournal=0x0078f15c) Line 718 + 0x1f bytes C++ WebKit.dll!WebCore::ApplicationCacheStorage::storeNewestCache(WebCore::ApplicationCacheGroup * group=0x07844878, WebCore::ApplicationCache * oldCache=0x00000000, WebCore::ApplicationCacheStorage::FailureReason & failureReason=-858993460) Line 993 + 0x15 bytes C++ WebKit.dll!WebCore::ApplicationCacheGroup::checkIfLoadIsComplete() Line 872 + 0x1d bytes C++ WebKit.dll!WebCore::ApplicationCacheGroup::finishedLoadingMainResource(WebCore::DocumentLoader * loader=0x0772a4a0) Line 276 C++ WebKit.dll!WebCore::ApplicationCacheGroup::deliverDelayedMainResources() Line 982 C++ WebKit.dll!WebCore::ApplicationCacheGroup::startLoadingEntry() Line 955 C++ WebKit.dll!WebCore::ApplicationCacheGroup::didFinishLoading(WebCore::ResourceHandle * handle=0x077c54a0, double <rdar://problem/9292486> 386989 1 89865 jberlin 2011-04-15 15:37:53 -0700 Created attachment 89865 Patch 386996 2 89865 bweinstein 2011-04-15 15:51:38 -0700 Comment on attachment 89865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89865&action=review The changes to FileSystemWin look good. Is ApplicationCacheStorage a cross-platform file? If so, we should probably add the checks for both types of path separators. Would that break the Mac? > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1246 > + if (dirName.characterStartingAt(dirName.length() - 1) == '\\') { Should this also check for '/' on Mac? > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1247 > + // Remove any trailing "\". Should this also say '/'? 387010 3 89872 jberlin 2011-04-15 16:26:09 -0700 Created attachment 89872 Patch Moving the changes to be windows-specific only, in response to the points brought up by Brian. 387017 4 89872 bweinstein 2011-04-15 16:28:49 -0700 Comment on attachment 89872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89872&action=review > Source/WebCore/ChangeLog:10 > + Add breaks to the case statement in openFile and remove any trailing slash in Separate entries for each function that you changed would be nice for the ChangeLog. 387026 5 jberlin 2011-04-15 16:34:52 -0700 (In reply to comment #4) > (From update of attachment 89872 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89872&action=review > > > Source/WebCore/ChangeLog:10 > > + Add breaks to the case statement in openFile and remove any trailing slash in > > Separate entries for each function that you changed would be nice for the ChangeLog. For some reason the Changelog didn't add them, but I will. Thanks for the review! 387037 6 89872 jberlin 2011-04-15 16:51:51 -0700 Comment on attachment 89872 Patch Committed in http://trac.webkit.org/changeset/84051 387131 7 webkit.review.bot 2011-04-15 18:22:00 -0700 http://trac.webkit.org/changeset/84051 might have broken WinCairo Debug (Build) 89865 2011-04-15 15:37:53 -0700 2011-04-15 16:26:09 -0700 Patch fixHangOpeningCalendarDemo.patch text/plain 3116 jberlin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDQtMTUgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBIYW5nIHVuZGVybmVhdGggQXBwbGljYXRpb25DYWNoZVN0b3Jh Z2U6OndyaXRlRGF0YVRvVW5pcXVlRmlsZUluRGlyZWN0b3J5IHdoZW4gbG9hZGluZworICAgICAg ICBodHRwOi8vd3d3LndlYmtpdC5vcmcvZGVtb3MvY2FsZW5kYXIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY5OAorCisgICAgICAgICogbG9hZGVy L2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkFwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlOjp3cml0ZURhdGFUb1VuaXF1ZUZpbGVJbkRpcmVjdG9y eSk6CisgICAgICAgIFJlbW92ZSB0aGUgdHJhaWxpbmcgc2xhc2ggYmVmb3JlIGRvaW5nIHRoZSBk aXJlY3RvcnkgcGF0aCBjb21wYXJpc2lvbi4KKyAgICAgICAgSSBjb25zaWRlcmVkIG1vZGlmeWlu ZyBkaXJlY3RvcnlOYW1lIGluIEZpbGVTeXN0ZW1XaW4sIGJ1dCBkZXRlcm1pbmVkIHRoYXQgbGVh dmluZyB0aGUKKyAgICAgICAgdHJhaWxpbmcgc2xhc2ggd2FzIHRoZSBiZWhhdmlvciBwcmlvciB0 byByZWNlbnQgY2hhbmdlcyBhbmQgdGhlcmUgYXJlIG1vcmUgdGhhbiBhIGNvdXBsZQorICAgICAg ICBjYWxsZXJzIHdobyBkZXBlbmQgb24gdGhhdCB0cmFpbGluZyBzbGFzaCBiZWluZyBwcmVzZW50 LgorCisgICAgICAgICogcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwOgorICAgICAgICAo V2ViQ29yZTo6b3BlbkZpbGUpOgorICAgICAgICBBZGQgYnJlYWtzIHRvIHRoZSBjYXNlIHN0YXRl bWVudC4KKwogMjAxMS0wNC0xNSAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZVN0b3JhZ2UuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlU3Rv cmFnZS5jcHAJKHJldmlzaW9uIDgzOTkwKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNh Y2hlL0FwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzMSw3 ICsxMjMxLDggQEAgYm9vbCBBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZTo6c2hvdWxkU3RvcgogYm9v bCBBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZTo6d3JpdGVEYXRhVG9VbmlxdWVGaWxlSW5EaXJlY3Rv cnkoU2hhcmVkQnVmZmVyKiBkYXRhLCBjb25zdCBTdHJpbmcmIGRpcmVjdG9yeSwgU3RyaW5nJiBw YXRoKQogewogICAgIFN0cmluZyBmdWxsUGF0aDsKLSAgICAKKyAgICBTdHJpbmcgZGlyTmFtZTsK KwogICAgIGRvIHsKICAgICAgICAgcGF0aCA9IGVuY29kZUZvckZpbGVOYW1lKGNyZWF0ZUNhbm9u aWNhbFVVSURTdHJpbmcoKSk7CiAgICAgICAgIC8vIEd1YXJkIGFnYWluc3QgdGhlIGFib3ZlIGZ1 bmN0aW9uIGJlaW5nIGNhbGxlZCBvbiBhIHBsYXRmb3JtIHdoaWNoIGRvZXMgbm90IGltcGxlbWVu dApAQCAtMTI0MSw3ICsxMjQyLDEyIEBAIGJvb2wgQXBwbGljYXRpb25DYWNoZVN0b3JhZ2U6Ondy aXRlRGF0YVQKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgCiAgICAgICAgIGZ1 bGxQYXRoID0gcGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGRpcmVjdG9yeSwgcGF0aCk7Ci0gICAg fSB3aGlsZSAoZGlyZWN0b3J5TmFtZShmdWxsUGF0aCkgIT0gZGlyZWN0b3J5IHx8IGZpbGVFeGlz dHMoZnVsbFBhdGgpKTsKKyAgICAgICAgZGlyTmFtZSA9IGRpcmVjdG9yeU5hbWUoZnVsbFBhdGgp OworICAgICAgICBpZiAoZGlyTmFtZS5jaGFyYWN0ZXJTdGFydGluZ0F0KGRpck5hbWUubGVuZ3Ro KCkgLSAxKSA9PSAnXFwnKSB7CisgICAgICAgICAgICAvLyBSZW1vdmUgYW55IHRyYWlsaW5nICJc Ii4KKyAgICAgICAgICAgIGRpck5hbWUudHJ1bmNhdGUoZGlyTmFtZS5sZW5ndGgoKSAtIDEpOwor ICAgICAgICB9CisgICAgfSB3aGlsZSAoZGlyTmFtZSAhPSBkaXJlY3RvcnkgfHwgZmlsZUV4aXN0 cyhmdWxsUGF0aCkpOwogICAgIAogICAgIFBsYXRmb3JtRmlsZUhhbmRsZSBoYW5kbGUgPSBvcGVu RmlsZShmdWxsUGF0aCwgT3BlbkZvcldyaXRlKTsKICAgICBpZiAoIWhhbmRsZSkKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAJKHJldmlzaW9u IDgzOTkwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yNDEsOSArMjQxLDExIEBAIFBsYXRmb3JtRmlsZUhhbmRsZSBv cGVuRmlsZShjb25zdCBTdHJpbmcKICAgICBjYXNlIE9wZW5Gb3JSZWFkOgogICAgICAgICBkZXNp cmVkQWNjZXNzID0gR0VORVJJQ19SRUFEOwogICAgICAgICBjcmVhdGlvbkRpc3Bvc2l0aW9uID0g T1BFTl9FWElTVElORzsKKyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBPcGVuRm9yV3JpdGU6CiAg ICAgICAgIGRlc2lyZWRBY2Nlc3MgPSBHRU5FUklDX1dSSVRFOwogICAgICAgICBjcmVhdGlvbkRp c3Bvc2l0aW9uID0gQ1JFQVRFX0FMV0FZUzsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoK ICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQo= 89872 2011-04-15 16:26:09 -0700 2011-04-15 16:51:51 -0700 Patch fixHangOpeningCalendarDemo.patch text/plain 2090 jberlin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDQ3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTUgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBIYW5nIHVuZGVybmVhdGggQXBwbGljYXRpb25DYWNoZVN0b3Jh Z2U6OndyaXRlRGF0YVRvVW5pcXVlRmlsZUluRGlyZWN0b3J5IHdoZW4gbG9hZGluZworICAgICAg ICBodHRwOi8vd3d3LndlYmtpdC5vcmcvZGVtb3MvY2FsZW5kYXIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY5OAorCisgICAgICAgICogcGxhdGZv cm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwOgorICAgICAgICBBZGQgYnJlYWtzIHRvIHRoZSBjYXNl IHN0YXRlbWVudCBpbiBvcGVuRmlsZSBhbmQgcmVtb3ZlIGFueSB0cmFpbGluZyBzbGFzaCBpbgor ICAgICAgICBkaXJlY3RvcnlOYW1lLiBBZnRlciBjbG9zZXIgaW5zcGVjdGlvbiBvZiBhbGwgY2Fs bGVycywgaXQgYXBwZWFycyB0aGUgdGhhdCBjYWxsZXJzIGRvIG5vdAorICAgICAgICBuZWVkIHRo ZSB0cmFpbGluZyBzbGFzaCwgYW5kIHRob3NlIHRoYXQgdXNlIHRoZSBsZW5ndGggZG8gc28gb25s eSB0byBjaGFuZ2UgdGhlIGRpcmVjdGlvbgorICAgICAgICBvZiB0aGUgc2xhc2hlcyB0aHJvdWdo b3V0IHRoZSBsZW5ndGggb2YgdGhlIHBhdGguCisKIDIwMTEtMDQtMTUgIEtlbm5ldGggUnVzc2Vs bCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIENocm9taXVtIExpbnV4 IFJlbGVhc2UgYnVpbGQgZml4IGR1ZSB0byB1bnVzZWQgdmFyaWFibGVzLgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcAkocmV2aXNpb24gODM5 OTApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEzNiw3ICsxMzYsMTIgQEAgU3RyaW5nIHBhdGhHZXRGaWxlTmFtZShj b25zdCBTdHJpbmcmIHBhdAogCiBTdHJpbmcgZGlyZWN0b3J5TmFtZShjb25zdCBTdHJpbmcmIHBh dGgpCiB7Ci0gICAgcmV0dXJuIHBhdGgubGVmdChwYXRoLmxlbmd0aCgpIC0gcGF0aEdldEZpbGVO YW1lKHBhdGgpLmxlbmd0aCgpKTsKKyAgICBTdHJpbmcgbmFtZSA9IHBhdGgubGVmdChwYXRoLmxl bmd0aCgpIC0gcGF0aEdldEZpbGVOYW1lKHBhdGgpLmxlbmd0aCgpKTsKKyAgICBpZiAobmFtZS5j aGFyYWN0ZXJTdGFydGluZ0F0KG5hbWUubGVuZ3RoKCkgLSAxKSA9PSAnXFwnKSB7CisgICAgICAg IC8vIFJlbW92ZSBhbnkgdHJhaWxpbmcgIlwiLgorICAgICAgICBuYW1lLnRydW5jYXRlKG5hbWUu bGVuZ3RoKCkgLSAxKTsKKyAgICB9CisgICAgcmV0dXJuIG5hbWU7CiB9CiAKIHN0YXRpYyBTdHJp bmcgYnVuZGxlTmFtZSgpCkBAIC0yNDEsOSArMjQ2LDExIEBAIFBsYXRmb3JtRmlsZUhhbmRsZSBv cGVuRmlsZShjb25zdCBTdHJpbmcKICAgICBjYXNlIE9wZW5Gb3JSZWFkOgogICAgICAgICBkZXNp cmVkQWNjZXNzID0gR0VORVJJQ19SRUFEOwogICAgICAgICBjcmVhdGlvbkRpc3Bvc2l0aW9uID0g T1BFTl9FWElTVElORzsKKyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBPcGVuRm9yV3JpdGU6CiAg ICAgICAgIGRlc2lyZWRBY2Nlc3MgPSBHRU5FUklDX1dSSVRFOwogICAgICAgICBjcmVhdGlvbkRp c3Bvc2l0aW9uID0gQ1JFQVRFX0FMV0FZUzsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoK ICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQo=