58697 2011-04-15 14:41:37 -0700 Fade the find page overlay 2011-04-15 15:31:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 386949 0 andersca 2011-04-15 14:41:37 -0700 Fade the find page overlay 386962 1 89860 andersca 2011-04-15 14:56:01 -0700 Created attachment 89860 Patch 386977 2 89860 mitz 2011-04-15 15:19:11 -0700 Comment on attachment 89860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89860&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:727 > + bool shouldFadeIn = true; unused 386988 3 andersca 2011-04-15 15:31:33 -0700 Committed r84042: <http://trac.webkit.org/changeset/84042> 89860 2011-04-15 14:56:01 -0700 2011-04-15 15:19:10 -0700 Patch bug-58697-20110415145600.patch text/plain 5687 andersca SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDM0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTUgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGYWRlIHRoZSBmaW5kIHBhZ2Ugb3ZlcmxheQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2OTcKKworICAgICAg ICBBZGQgYSBzeW1ib2wgdGhhdCBXZWJLaXQyIG5lZWRzLgorCisgICAgICAgICogV2ViQ29yZS5l eHAuaW46CisKIDIwMTEtMDQtMTUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5leHAuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHJl dmlzaW9uIDgzOTg1KQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTUzOSw2ICs1MzksNyBAQCBfX1pON1dlYkNvcmUyMFNwYWNlU3BsaXRTdHJpbmdE YXRhMTJjcmVhCiBfX1pON1dlYkNvcmUyMFVzZXJHZXN0dXJlSW5kaWNhdG9yQzFFTlNfMjZQcm9j ZXNzaW5nVXNlckdlc3R1cmVTdGF0ZUUKIF9fWk43V2ViQ29yZTIwVXNlckdlc3R1cmVJbmRpY2F0 b3JEMUV2CiBfX1pON1dlYkNvcmUyMHByb3RvY29sSXNKYXZhU2NyaXB0RVJLTjNXVEY2U3RyaW5n RQorX19aTjdXZWJDb3JlMjBtYWtlUkdCQTMyRnJvbUZsb2F0c0VmZmZmCiBfX1pON1dlYkNvcmUy MUJhY2tGb3J3YXJkQ29udHJvbGxlcjExaXRlbUF0SW5kZXhFaQogX19aTjdXZWJDb3JlMjFQbGF0 Zm9ybUtleWJvYXJkRXZlbnQyNGRpc2FtYmlndWF0ZUtleURvd25FdmVudEVOUzBfNFR5cGVFYgog X19aTjdXZWJDb3JlMjFQbGF0Zm9ybUtleWJvYXJkRXZlbnRDMUVQN05TRXZlbnQKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cJKHJldmlzaW9uIDg0MDM2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDQtMTUgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGYWRlIHRoZSBmaW5kIHBhZ2Ugb3ZlcmxheQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2OTcKKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHA6CisgICAgICAgIE1ha2UgdGhlIGNvbG9y IGNvbXBvbmVudHMgZmxvYXRzLgorCisgICAgICAgIChXZWJLaXQ6Om92ZXJsYXlCYWNrZ3JvdW5k Q29sb3IpOgorICAgICAgICAoV2ViS2l0Ojpob2xlU2hhZG93Q29sb3IpOgorICAgICAgICAoV2Vi S2l0Ojpob2xlRmlsbENvbG9yKToKKyAgICAgICAgQWRkIGhlbHBlciBmdW5jdGlvbnMgZm9yIHJl dHVybmluZyB0aGUgY29sb3JzIGdpdmVuIHRoZSBmcmFjdGlvbiBmYWRlZCBpbi4KKworICAgICAg ICAoV2ViS2l0OjpGaW5kQ29udHJvbGxlcjo6ZHJhd1JlY3QpOgorICAgICAgICBVc2UgdGhlIG5l dyBoZWxwZXIgZnVuY3Rpb25zLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjppbnN0YWxsUGFnZU92ZXJsYXkpOgor ICAgICAgICBTdGFydCB0aGUgZmFkZSBhbmltYXRpb24gdW5sZXNzIHdlJ3JlIHJlcGxhY2luZyBh biBhbHJlYWR5IGV4aXN0aW5nIHBhZ2Ugb3ZlcmxheQorICAgICAgICB3aXRoIGFub3RoZXIuCisK IDIwMTEtMDQtMTUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggV2luZG93cyBidWlsZC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcAkocmV2aXNpb24gODQwMzQpCisr KyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yNzAsMjcgKzI3MCwzOSBAQCBzdGF0aWMgY29uc3QgZmxvYXQgc2hh ZG93T2Zmc2V0WSA9IDEuMDsKIHN0YXRpYyBjb25zdCBmbG9hdCBzaGFkb3dCbHVyUmFkaXVzID0g Mi4wOwogc3RhdGljIGNvbnN0IGZsb2F0IHdoaXRlRnJhbWVUaGlja25lc3MgPSAxLjA7CiAKLXN0 YXRpYyBjb25zdCBpbnQgb3ZlcmxheUJhY2tncm91bmRSZWQgPSAyNTsKLXN0YXRpYyBjb25zdCBp bnQgb3ZlcmxheUJhY2tncm91bmRHcmVlbiA9IDI1Owotc3RhdGljIGNvbnN0IGludCBvdmVybGF5 QmFja2dyb3VuZEJsdWUgPSAyNTsKLXN0YXRpYyBjb25zdCBpbnQgb3ZlcmxheUJhY2tncm91bmRB bHBoYSA9IDYzOworc3RhdGljIGNvbnN0IGZsb2F0IG92ZXJsYXlCYWNrZ3JvdW5kUmVkID0gMC4x Oworc3RhdGljIGNvbnN0IGZsb2F0IG92ZXJsYXlCYWNrZ3JvdW5kR3JlZW4gPSAwLjE7CitzdGF0 aWMgY29uc3QgZmxvYXQgb3ZlcmxheUJhY2tncm91bmRCbHVlID0gMC4xOworc3RhdGljIGNvbnN0 IGZsb2F0IG92ZXJsYXlCYWNrZ3JvdW5kQWxwaGEgPSAwLjI1OwogCi1zdGF0aWMgQ29sb3Igb3Zl cmxheUJhY2tncm91bmRDb2xvcigpCitzdGF0aWMgQ29sb3Igb3ZlcmxheUJhY2tncm91bmRDb2xv cihmbG9hdCBmcmFjdGlvbkZhZGVkSW4pCiB7Ci0gICAgcmV0dXJuIENvbG9yKG92ZXJsYXlCYWNr Z3JvdW5kUmVkLCBvdmVybGF5QmFja2dyb3VuZEdyZWVuLCBvdmVybGF5QmFja2dyb3VuZEJsdWUs IG92ZXJsYXlCYWNrZ3JvdW5kQWxwaGEpOworICAgIHJldHVybiBDb2xvcihvdmVybGF5QmFja2dy b3VuZFJlZCwgb3ZlcmxheUJhY2tncm91bmRHcmVlbiwgb3ZlcmxheUJhY2tncm91bmRCbHVlLCBv dmVybGF5QmFja2dyb3VuZEFscGhhICogZnJhY3Rpb25GYWRlZEluKTsKIH0KIAotdm9pZCBGaW5k Q29udHJvbGxlcjo6ZHJhd1JlY3QoUGFnZU92ZXJsYXkqLCBHcmFwaGljc0NvbnRleHQmIGdyYXBo aWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0KQorc3RhdGljIENvbG9yIGhvbGVT aGFkb3dDb2xvcihmbG9hdCBmcmFjdGlvbkZhZGVkSW4pCiB7CisgICAgcmV0dXJuIENvbG9yKDAu MGYsIDAuMGYsIDAuMGYsIGZyYWN0aW9uRmFkZWRJbik7Cit9CisKK3N0YXRpYyBDb2xvciBob2xl RmlsbENvbG9yKGZsb2F0IGZyYWN0aW9uRmFkZWRJbikKK3sKKyAgICByZXR1cm4gQ29sb3IoMS4w ZiwgMS4wZiwgMS4wZiwgZnJhY3Rpb25GYWRlZEluKTsKK30KKwordm9pZCBGaW5kQ29udHJvbGxl cjo6ZHJhd1JlY3QoUGFnZU92ZXJsYXkqIHBhZ2VPdmVybGF5LCBHcmFwaGljc0NvbnRleHQmIGdy YXBoaWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0KQoreworICAgIGZsb2F0IGZy YWN0aW9uRmFkZWRJbiA9IHBhZ2VPdmVybGF5LT5mcmFjdGlvbkZhZGVkSW4oKTsKKwogICAgIFZl Y3RvcjxJbnRSZWN0PiByZWN0cyA9IHJlY3RzRm9yVGV4dE1hdGNoZXMoKTsKIAogICAgIC8vIERy YXcgdGhlIGJhY2tncm91bmQuCi0gICAgZ3JhcGhpY3NDb250ZXh0LmZpbGxSZWN0KGRpcnR5UmVj dCwgb3ZlcmxheUJhY2tncm91bmRDb2xvcigpLCBDb2xvclNwYWNlU1JHQik7CisgICAgZ3JhcGhp Y3NDb250ZXh0LmZpbGxSZWN0KGRpcnR5UmVjdCwgb3ZlcmxheUJhY2tncm91bmRDb2xvcihmcmFj dGlvbkZhZGVkSW4pLCBDb2xvclNwYWNlU1JHQik7CiAKICAgICBncmFwaGljc0NvbnRleHQuc2F2 ZSgpOwotICAgIGdyYXBoaWNzQ29udGV4dC5zZXRTaGFkb3coRmxvYXRTaXplKHNoYWRvd09mZnNl dFgsIHNoYWRvd09mZnNldFkpLCBzaGFkb3dCbHVyUmFkaXVzLCBDb2xvcjo6YmxhY2ssIENvbG9y U3BhY2VTUkdCKTsKKyAgICBncmFwaGljc0NvbnRleHQuc2V0U2hhZG93KEZsb2F0U2l6ZShzaGFk b3dPZmZzZXRYLCBzaGFkb3dPZmZzZXRZKSwgc2hhZG93Qmx1clJhZGl1cywgaG9sZVNoYWRvd0Nv bG9yKGZyYWN0aW9uRmFkZWRJbiksIENvbG9yU3BhY2VTUkdCKTsKIAotICAgIGdyYXBoaWNzQ29u dGV4dC5zZXRGaWxsQ29sb3IoQ29sb3I6OndoaXRlLCBDb2xvclNwYWNlU1JHQik7CisgICAgZ3Jh cGhpY3NDb250ZXh0LnNldEZpbGxDb2xvcihob2xlRmlsbENvbG9yKGZyYWN0aW9uRmFkZWRJbiks IENvbG9yU3BhY2VTUkdCKTsKIAogICAgIC8vIERyYXcgd2hpdGUgZnJhbWVzIGFyb3VuZCB0aGUg aG9sZXMuCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCByZWN0cy5zaXplKCk7ICsraSkgewpJ bmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAko cmV2aXNpb24gODQwMzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyNCwxMSArNzI0LDIyIEBAIHZvaWQgV2ViUGFn ZTo6c2V0Rml4ZWRMYXlvdXRTaXplKGNvbnN0IEkKIAogdm9pZCBXZWJQYWdlOjppbnN0YWxsUGFn ZU92ZXJsYXkoUGFzc1JlZlB0cjxQYWdlT3ZlcmxheT4gcGFnZU92ZXJsYXkpCiB7Ci0gICAgaWYg KG1fcGFnZU92ZXJsYXkpCi0gICAgICAgIHBhZ2VPdmVybGF5LT5zZXRQYWdlKDApOworICAgIGJv b2wgc2hvdWxkRmFkZUluID0gdHJ1ZTsKKyAgICAKKyAgICBpZiAobV9wYWdlT3ZlcmxheSkgewor ICAgICAgICBtX3BhZ2VPdmVybGF5LT5zZXRQYWdlKDApOworCisgICAgICAgIGlmIChwYWdlT3Zl cmxheSkgeworICAgICAgICAgICAgLy8gV2UncmUgaW5zdGFsbGluZyBhIHBhZ2Ugb3ZlcmxheSB3 aGVuIGEgcGFnZSBvdmVybGF5IGlzIGFscmVhZHkgYWN0aXZlLgorICAgICAgICAgICAgLy8gSW4g dGhpcyBjYXNlIHdlIGRvbid0IHdhbnQgdG8gZmFkZSBpbiB0aGUgbmV3IG92ZXJsYXkuCisgICAg ICAgICAgICBzaG91bGRGYWRlSW4gPSBmYWxzZTsKKyAgICAgICAgfQorICAgIH0KIAogICAgIG1f cGFnZU92ZXJsYXkgPSBwYWdlT3ZlcmxheTsKICAgICBtX3BhZ2VPdmVybGF5LT5zZXRQYWdlKHRo aXMpOworICAgIG1fcGFnZU92ZXJsYXktPnN0YXJ0RmFkZUluQW5pbWF0aW9uKCk7CisKICAgICBt X2RyYXdpbmdBcmVhLT5kaWRJbnN0YWxsUGFnZU92ZXJsYXkoKTsKIH0KIAo=