58693 2011-04-15 14:06:18 -0700 REGRESSION: <progress> doesn't animate if it doesn't have value 2011-04-18 12:21:13 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 morrita morrita abarth eric webkit.review.bot yael oldest_to_newest 386910 0 morrita 2011-04-15 14:06:18 -0700 The indefinite progress bar, which is rendered by <progress> element without value property should animate. Looks introduced http://trac.webkit.org/changeset/83065. 386968 1 89862 morrita 2011-04-15 15:07:16 -0700 Created attachment 89862 Patch 387252 2 yael 2011-04-16 04:31:31 -0700 Thanks for fixing it. 387365 3 89862 abarth 2011-04-17 09:58:51 -0700 Comment on attachment 89862 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89862&action=review Nice patch. Yay for named constants. > Source/WebCore/ChangeLog:12 > + No new tests. Testing animated bar is not possible with DRT. Frown. This likely means we will continue to have regressions. 387499 4 89862 tkent 2011-04-17 19:09:22 -0700 Comment on attachment 89862 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89862&action=review > Source/WebCore/html/HTMLProgressElement.cpp:43 > +const double HTMLProgressElement::IndeterminatePosition = -1; > +const double HTMLProgressElement::InvalidPosition = -2; In RenderProgress::isDeterminate(), we should use these named constants, or add a comment that "0 <= " means neither indeterminate nor invalid. 387826 5 morrita 2011-04-18 10:07:43 -0700 Adam, Kent-san, thank you for reviewing! I'll land this with addressing Kent-san's point. 387834 6 morrita 2011-04-18 10:14:16 -0700 Committed r84156: <http://trac.webkit.org/changeset/84156> 387933 7 webkit.review.bot 2011-04-18 12:21:13 -0700 http://trac.webkit.org/changeset/84156 might have broken GTK Linux 32-bit Debug 89862 2011-04-15 15:07:16 -0700 2011-04-17 19:09:22 -0700 Patch bug-58693-20110415150715.patch text/plain 3313 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODM5OTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNTMwOTE2YzUxMWE1YjA0 NmVhZmZhYjJiNmM1Nzc5NmQ3NTNkNjUwLi5iNzRjMGJjZjVjZjgwMTQ2N2ZjOTRkZTZhZDA3YmU0 YmZiNDc2YjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDQtMTUgIE1PUklU QSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTjogPHByb2dyZXNzPiBkb2Vzbid0IGFu aW1hdGUgaWYgaXQgZG9lc24ndCBoYXZlIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY5MworCisgICAgICAgIFRoZSBpbml0aWFsIHZhbHVl IG9mIFJlbmRlclByb2dyZXNzOjptX3Bvc2l0aW9uIGlzIGFjY2lkZW50YWxseSBzYW1lIGFzCisg ICAgICAgIHRoZSBpbmRldGVybWluYXRlIHZhbHVlLCB0aGF0IG1ha2VzIHVwZGF0ZSBjb2RlIG9u IHVwZGF0ZUZyb21FbGVtZW50KCkgc2tpcHBlZC4KKyAgICAgICAgVGhpcyBjaGFuZ2Ugc2V0IHVu aXF1ZSBpbnZhbGlkIHZhbHVlIGZvciB0aGUgaW5pdGlhbCB2YWx1ZSBvZiBtX3Bvc2l0aW9uLgor ICAgICAgICAKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUZXN0aW5nIGFuaW1hdGVkIGJhciBpcyBu b3QgcG9zc2libGUgd2l0aCBEUlQuCisKKyAgICAgICAgKiBodG1sL0hUTUxQcm9ncmVzc0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFByb2dyZXNzRWxlbWVudDo6cG9zaXRpb24p OgorICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJQcm9ncmVzcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJQcm9ncmVz czo6UmVuZGVyUHJvZ3Jlc3MpOgorCiAyMDExLTA0LTE0ICBaaGVueWFvIE1vICA8em1vQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHAKaW5kZXggMzliMTI5Yjc2YTJjYTJl ODI3ODc5ODM1NmI2N2RjMjVmNmJjZDMyYS4uNzEwZjdlNDlkYzEwNjQwOTMzYjAxN2RiN2VjNzc3 ZTdmMmNhZGE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NF bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0VsZW1lbnQu Y3BwCkBAIC0zOSw2ICszOSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNpbmcgbmFtZXNw YWNlIEhUTUxOYW1lczsKIAorY29uc3QgZG91YmxlIEhUTUxQcm9ncmVzc0VsZW1lbnQ6OkluZGV0 ZXJtaW5hdGVQb3NpdGlvbiA9IC0xOworY29uc3QgZG91YmxlIEhUTUxQcm9ncmVzc0VsZW1lbnQ6 OkludmFsaWRQb3NpdGlvbiA9IC0yOworCiBIVE1MUHJvZ3Jlc3NFbGVtZW50OjpIVE1MUHJvZ3Jl c3NFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50KiBkb2N1bWVu dCwgSFRNTEZvcm1FbGVtZW50KiBmb3JtKQogICAgIDogSFRNTEZvcm1Db250cm9sRWxlbWVudCh0 YWdOYW1lLCBkb2N1bWVudCwgZm9ybSkKIHsKQEAgLTEyMyw3ICsxMjYsNyBAQCB2b2lkIEhUTUxQ cm9ncmVzc0VsZW1lbnQ6OnNldE1heChkb3VibGUgbWF4LCBFeGNlcHRpb25Db2RlJiBlYykKIGRv dWJsZSBIVE1MUHJvZ3Jlc3NFbGVtZW50Ojpwb3NpdGlvbigpIGNvbnN0CiB7CiAgICAgaWYgKCFo YXNBdHRyaWJ1dGUodmFsdWVBdHRyKSkKLSAgICAgICAgcmV0dXJuIC0xOworICAgICAgICByZXR1 cm4gSFRNTFByb2dyZXNzRWxlbWVudDo6SW5kZXRlcm1pbmF0ZVBvc2l0aW9uOwogICAgIHJldHVy biB2YWx1ZSgpIC8gbWF4KCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFByb2dyZXNzRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NF bGVtZW50LmgKaW5kZXggODc5MTIzNTIyNzJlMTBkYzMwN2ZmN2YzMGI5Yzc0YTAwOGJhYjkyZi4u NDIxMDlmNzYyNzU5OWM1ZTFjODg2NTQzOGM2MjczNDNlZmNjZWQ4MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmgKQEAgLTMwLDYgKzMwLDkgQEAgY2xhc3MgUHJv Z3Jlc3NWYWx1ZUVsZW1lbnQ7CiAKIGNsYXNzIEhUTUxQcm9ncmVzc0VsZW1lbnQgOiBwdWJsaWMg SFRNTEZvcm1Db250cm9sRWxlbWVudCB7CiBwdWJsaWM6CisgICAgc3RhdGljIGNvbnN0IGRvdWJs ZSBJbmRldGVybWluYXRlUG9zaXRpb247CisgICAgc3RhdGljIGNvbnN0IGRvdWJsZSBJbnZhbGlk UG9zaXRpb247CisKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxIVE1MUHJvZ3Jlc3NFbGVtZW50PiBj cmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50KiwgSFRNTEZvcm1FbGVtZW50Kik7 CiAKICAgICBkb3VibGUgdmFsdWUoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJQcm9ncmVzcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyUHJvZ3Jlc3MuY3BwCmluZGV4IDg1Y2YzMGE1N2UwZDVlZTRlMTJkZjE0ZDBjNGUyZmE4 ODBiYWEyNDUuLjQ1NTJiODI5N2ZlMGNmOTkwN2YzZDRlOGVkZDJiNDg3MWQ2ODMzZGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJQcm9ncmVzcy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclByb2dyZXNzLmNwcApAQCAtMzgsNyArMzgs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFJlbmRlclByb2dyZXNzOjpSZW5kZXJQcm9ncmVz cyhIVE1MUHJvZ3Jlc3NFbGVtZW50KiBlbGVtZW50KQogICAgIDogUmVuZGVyQmxvY2soZWxlbWVu dCkKLSAgICAsIG1fcG9zaXRpb24oLTEpCisgICAgLCBtX3Bvc2l0aW9uKEhUTUxQcm9ncmVzc0Vs ZW1lbnQ6OkludmFsaWRQb3NpdGlvbikKICAgICAsIG1fYW5pbWF0aW9uU3RhcnRUaW1lKDApCiAg ICAgLCBtX2FuaW1hdGlvblJlcGVhdEludGVydmFsKDApCiAgICAgLCBtX2FuaW1hdGlvbkR1cmF0 aW9uKDApCg==