58692 2011-04-15 14:03:11 -0700 old-run-webkit-tests: save the list of tests actually run to a file 2011-06-15 13:27:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth commit-queue dbates eric ojan ossy oldest_to_newest 386904 0 dpranke 2011-04-15 14:03:11 -0700 old-run-webkit-tests: save the list of tests actually run to a file 386907 1 89849 dpranke 2011-04-15 14:04:41 -0700 Created attachment 89849 Patch 386912 2 dpranke 2011-04-15 14:08:16 -0700 I don't actually care that much whether we land this or not, I'm just posting it in case other people might find it useful. 386915 3 89849 eric 2011-04-15 14:09:18 -0700 Comment on attachment 89849 Patch I think this could be quite useful, honestly. Does NRWT do similar? 386969 4 dpranke 2011-04-15 15:08:28 -0700 (In reply to comment #3) > (From update of attachment 89849 [details]) > I think this could be quite useful, honestly. Does NRWT do similar? Yes, NRWT saves a list per-worker. 387182 5 89849 commit-queue 2011-04-15 20:59:56 -0700 Comment on attachment 89849 Patch Clearing flags on attachment: 89849 Committed r84076: <http://trac.webkit.org/changeset/84076> 387183 6 commit-queue 2011-04-15 21:00:00 -0700 All reviewed patches have been landed. Closing bug. 389166 7 ossy 2011-04-20 06:01:56 -0700 I think it is a useful feature for debugging, but we can get similar list on stdout with -v option. I have two minor problems with it: - ~ 3Mb sized list file for every build is hard disk killer on buildbot masters It would be better to make this feature optional,or upload gzipped list.(~130Kb) - absolute path: Why do we use absolute paths in this list? I think relative paths to LayoutTests directory is more than enough. Reopen to discuss about my proposed changes. 389414 8 eric 2011-04-20 12:10:15 -0700 I like both of those suggestions. Just putting it behind a flag seems reasonable. 389421 9 ojan 2011-04-20 12:16:50 -0700 (In reply to comment #8) > I like both of those suggestions. Just putting it behind a flag seems reasonable. Noooo. We have way too many flags already. There's no reason to store the absolute path. I expect storing relative paths will be enough to make this file reasonably sized. If not that, writing out the zipped file is surely sufficient. 389461 10 dpranke 2011-04-20 13:10:11 -0700 I have no objection to either flags or shorter paths. I wouldn't bother gzipping the list. Or, feel free to revert it, even. We've made it this long without it :) 413060 11 dpranke 2011-05-31 18:35:02 -0700 Csaba, do you have an opinion on whether just relative paths but not a gzipped list would be sufficient? 421537 12 dpranke 2011-06-15 13:27:53 -0700 I'm going to close this due to lack of comments and post a separate patch that shortens the list to relative paths and call it a day. See bug 62751 for the patch. 89849 2011-04-15 14:04:41 -0700 2011-04-15 20:59:56 -0700 Patch bug-58692-20110415140440.patch text/plain 1698 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODM4OTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMDAzMWNhM2Y3NTQwYmQ5YTE0NzkzNGQyZDY4OWUxYmE1 OGM0MWU1Li5mNDQ1MzQ0NzZmMzY2MzRkNWE2YzU3MzY2YjNiMDIwNTQwZTExNmNmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgb2xkLXJ1bi13ZWJr aXQtdGVzdHM6IHNhdmUgdGhlIGxpc3Qgb2YgdGVzdHMgYWN0dWFsbHkgcnVuIHRvIGEgZmlsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2OTIKKwor ICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHM6CisKIDIwMTEtMDQtMTQgIERp cmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0 LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCA5M2EyZDFm ZTE0NjM4NTRkMTRmYWNiZDZjYmFhZTExNWM1YzM5MDBmLi5lYWNlZjNkYjkwMGRjYzkwYjA5YmE1 MWE1NzMxN2M1ZGY4NGRiZTg5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Vi a2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTY5 MCw2ICs2OTAsOSBAQCBmb3IgKG15ICRpID0gMTsgJGkgPCAkaXRlcmF0aW9uczsgJGkrKykgewog ICAgIHB1c2goQHRlc3RzLCBAb3JpZ2luYWxUZXN0cyk7CiB9CiAKK215ICRhYnNUZXN0UmVzdWx0 c0RpcmVjdG9yeSA9IHJlc29sdmVBbmRNYWtlVGVzdFJlc3VsdHNEaXJlY3RvcnkoKTsKK29wZW4g bXkgJHRlc3RzX3J1bl9maCwgJz4nLCAiJGFic1Rlc3RSZXN1bHRzRGlyZWN0b3J5L3Rlc3RzX3J1 bi50eHQiIG9yIGRpZSAkITsKKwogZm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKICAgICBteSAkbmV3 RHVtcFRvb2wgPSBub3QgJGlzRHVtcFRvb2xPcGVuOwogICAgIG9wZW5EdW1wVG9vbCgpOwpAQCAt NzQwLDYgKzc0Myw4IEBAIGZvciBteSAkdGVzdCAoQHRlc3RzKSB7CiAKICAgICBteSAkc3RhcnRU aW1lID0gdGltZSBpZiAkcmVwb3J0MTBTbG93ZXN0OwogCisgICAgcHJpbnQgJHRlc3RzX3J1bl9m aCAiJHRlc3REaXJlY3RvcnkvJHRlc3RcbiI7CisKICAgICAjIFRyeSB0byByZWFkIGV4cGVjdGVk IGhhc2ggZmlsZSBmb3IgcGl4ZWwgdGVzdHMKICAgICBteSAkc3VmZml4RXhwZWN0ZWRIYXNoID0g IiI7CiAgICAgaWYgKCRwaXhlbFRlc3RzICYmICEkcmVzZXRSZXN1bHRzKSB7CkBAIC0xMDg4LDYg KzEwOTMsOCBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogICAgIGxhc3QgaWYgc3RvcFJ1bm5p bmdUZXN0c0Vhcmx5SWZOZWVkZWQoKTsKIH0KIAorY2xvc2UoJHRlc3RzX3J1bl9maCk7CisKIG15 ICR0b3RhbFRlc3RpbmdUaW1lID0gdGltZSAtICRvdmVyYWxsU3RhcnRUaW1lOwogbXkgJHdhaXRU aW1lID0gZ2V0V2FpdFRpbWUoKTsKIGlmICgkd2FpdFRpbWUgPiAwLjEpIHsK