58690 2011-04-15 13:49:55 -0700 new-run-webkit-tests: save stderr into the layout-test-results dir 2011-04-18 12:52:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 58770 37739 1 dpranke dpranke ojan oldest_to_newest 386885 0 dpranke 2011-04-15 13:49:55 -0700 new-run-webkit-tests: save stderr into the layout-test-results dir 386886 1 89846 dpranke 2011-04-15 13:50:27 -0700 Created attachment 89846 Patch 386888 2 dpranke 2011-04-15 13:51:24 -0700 Splitting the saving of the error text out from the display of it (which I'll let Ojan fix in the original bug). 386895 3 89846 levin 2011-04-15 13:56:25 -0700 Comment on attachment 89846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89846&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:341 > tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True) btw, typo: keybaord > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:348 > + 'stuff going to stderr') What makes the file contain "stuff going to stderr"? 386902 4 dpranke 2011-04-15 14:02:06 -0700 (In reply to comment #3) > (From update of attachment 89846 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89846&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:341 > > tests_run = get_tests_run(['failures/expected/keybaord.html'], tests_included=True, flatten_batches=True) > > btw, typo: keybaord > Interesting. I'll fix that in a different bug. > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:348 > > + 'stuff going to stderr') > > What makes the file contain "stuff going to stderr"? That is done at port/test.py:147, which has custom logic to fake output going to stderr for that particular test. That code has been there forever. 386906 5 89846 ojan 2011-04-15 14:04:00 -0700 Comment on attachment 89846 Patch Does this mean we're writing stderr into the test and into the stderr.txt? We should only be doing the latter. Fine with that being part of this patch or a separate patch though. 386916 6 dpranke 2011-04-15 14:09:27 -0700 H(In reply to comment #5) > (From update of attachment 89846 [details]) > Does this mean we're writing stderr into the test and into the stderr.txt? We should only be doing the latter. Fine with that being part of this patch or a separate patch though. Hm. Good point, I had forgotten that the chromium ports were doing that. I'll fix that in a separate patch. 387422 7 dpranke 2011-04-17 14:49:47 -0700 Committed r84112: <http://trac.webkit.org/changeset/84112> 387870 8 dpranke 2011-04-18 11:08:25 -0700 grr. I don't know why I spaced and committed this yesterday w/o updating the baselines. This was rolled back in r84127 / bug 58690. 387959 9 dpranke 2011-04-18 12:52:25 -0700 double-grr: comment #8 applies to bug 58708, not this bug. This patch was fine and didn't need to be rolled out. 89846 2011-04-15 13:50:27 -0700 2011-04-15 14:04:00 -0700 Patch bug-58690-20110415135026.patch text/plain 3070 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODM4OTUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1YjliOWI4ZjNkNmIzYWZmYTkxZWFjNGIyZGY2MmMyYWE0 YWQwNGUxLi5jNWNlYjlmOTNiNWIxMjNiNmViYTkxZmE3NDQzYWU5NDU2NmFjYTE3IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IHNhdmUgc3RkZXJyIGludG8gdGhlIGxheW91dC10ZXN0LXJlc3VsdHMgZGlyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY5MAorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvdGVz dF9yZXN1bHRfd3JpdGVyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3QucHk6CisKIDIwMTEtMDQtMTQgIEVyaWMgU2Vp ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xh emtvdi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xh eW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcmVzdWx0X3dyaXRlci5weQppbmRl eCBlZWI5ODkwNWQyNmM4ZTA1NzMxYTE0NGYyMzQ1NDNhMjM1MjVhZmVmLi5iYzgzMDEwODNjNDVh ZjgyYWI0ZWU0MDdkM2QxYzJmNGEwY2FiZWJlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3Jlc3VsdF93cml0ZXIucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uv dGVzdF9yZXN1bHRfd3JpdGVyLnB5CkBAIC00Myw2ICs0Myw5IEBAIGRlZiB3cml0ZV90ZXN0X3Jl c3VsdChwb3J0LCBmaWxlbmFtZSwgZHJpdmVyX291dHB1dCwKICAgICBjaGVja3N1bXNfbWlzbWF0 Y2hfYnV0X2ltYWdlc19hcmVfc2FtZSA9IEZhbHNlCiAgICAgaW1hZ2VoYXNoX21pc21hdGNoX2Zh aWx1cmUgPSBOb25lCiAgICAgd3JpdGVyID0gVGVzdFJlc3VsdFdyaXRlcihwb3J0LCByb290X291 dHB1dF9kaXIsIGZpbGVuYW1lKQorICAgIGlmIGRyaXZlcl9vdXRwdXQuZXJyb3I6CisgICAgICAg IHdyaXRlci53cml0ZV9zdGRlcnIoZHJpdmVyX291dHB1dC5lcnJvcikKKwogICAgIGZvciBmYWls dXJlIGluIGZhaWx1cmVzOgogICAgICAgICAjIEZJWE1FOiBJbnN0ZWFkIG9mIHRoaXMgbG9uZyAn aWYnIGJsb2NrLCBlYWNoIGZhaWx1cmUgY2xhc3MgbWlnaHQKICAgICAgICAgIyBoYXZlIGEgcmVz cG9uc2liaWxpdHkgZm9yIHdyaXRpbmcgYSB0ZXN0IHJlc3VsdC4KQEAgLTE1NCw2ICsxNTcsMTIg QEAgY2xhc3MgVGVzdFJlc3VsdFdyaXRlcihvYmplY3QpOgogICAgICAgICBpZiBleHBlY3RlZCBp cyBub3QgTm9uZToKICAgICAgICAgICAgIGZzLndyaXRlX2JpbmFyeV9maWxlKGV4cGVjdGVkX2Zp bGVuYW1lLCBleHBlY3RlZCkKIAorICAgIGRlZiB3cml0ZV9zdGRlcnIoc2VsZiwgZXJyb3IpOgor ICAgICAgICBmcyA9IHNlbGYuX3BvcnQuX2ZpbGVzeXN0ZW0KKyAgICAgICAgZmlsZW5hbWUgPSBz ZWxmLm91dHB1dF9maWxlbmFtZSgiLXN0ZGVyci50eHQiKQorICAgICAgICBmcy5tYXliZV9tYWtl X2RpcmVjdG9yeShmcy5kaXJuYW1lKGZpbGVuYW1lKSkKKyAgICAgICAgZnMud3JpdGVfdGV4dF9m aWxlKGZpbGVuYW1lLCBlcnJvcikKKwogICAgIGRlZiB3cml0ZV9jcmFzaF9yZXBvcnQoc2VsZiwg ZXJyb3IpOgogICAgICAgICAiIiJXcml0ZSBjcmFzaCBpbmZvcm1hdGlvbi4iIiIKICAgICAgICAg ZnMgPSBzZWxmLl9wb3J0Ll9maWxlc3lzdGVtCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5w eQppbmRleCA2ZjM5YTkyMDcwODUzNjU3ZTIzZjEyNGU2ZDBkYjFiZjI1ZDA4NWIzLi45NzA1ZmZi YjQ3NjJhMjA0ZDEwY2U4MTJkODI5NDBiOGE4MTJlMjkzIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNf dW5pdHRlc3QucHkKQEAgLTM0MSw2ICszNDEsMTIgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgICAgICB0ZXN0c19ydW4gPSBnZXRfdGVzdHNfcnVuKFsnZmFpbHVyZXMv ZXhwZWN0ZWQva2V5YmFvcmQuaHRtbCddLCB0ZXN0c19pbmNsdWRlZD1UcnVlLCBmbGF0dGVuX2Jh dGNoZXM9VHJ1ZSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoW10sIHRlc3RzX3J1bikKIAor ICAgIGRlZiB0ZXN0X3N0ZGVycl9pc19zYXZlZChzZWxmKToKKyAgICAgICAgZnMgPSBwb3J0LnVu aXRfdGVzdF9maWxlc3lzdGVtKCkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVu KGZpbGVzeXN0ZW09ZnMpKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhmcy5yZWFkX3RleHRf ZmlsZSgnL3RtcC9sYXlvdXQtdGVzdC1yZXN1bHRzL3Bhc3Nlcy9lcnJvci1zdGRlcnIudHh0Jyks CisgICAgICAgICAgICAgICAgICAgICAgICAgICdzdHVmZiBnb2luZyB0byBzdGRlcnInKQorCiAg ICAgZGVmIHRlc3RfdGVzdF9saXN0KHNlbGYpOgogICAgICAgICBmcyA9IHBvcnQudW5pdF90ZXN0 X2ZpbGVzeXN0ZW0oKQogICAgICAgICBmaWxlbmFtZSA9ICcvdG1wL2Zvby50eHQnCg==