58688 2011-04-15 13:25:34 -0700 Implement localize strings for windows WebKit2 2011-04-15 18:20:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam abarth eric webkit.review.bot oldest_to_newest 386869 0 sam 2011-04-15 13:25:34 -0700 Implement localize strings for windows WebKit2 386871 1 89841 sam 2011-04-15 13:26:18 -0700 Created attachment 89841 Patch 386872 2 webkit.review.bot 2011-04-15 13:27:42 -0700 Attachment 89841 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/win/LocalizedStringsWin.cpp:33: "wtf/RetainPtr.h" already included at Source/WebCore/platform/win/LocalizedStringsWin.cpp:32 [build/include] [4] Source/WebCore/platform/win/LocalizedStringsWin.cpp:72: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 386911 3 89841 aroben 2011-04-15 14:07:24 -0700 Comment on attachment 89841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89841&action=review > Source/WebCore/platform/win/LocalizedStringsWin.cpp:49 > + ASSERT(length && length < WTF_ARRAY_LENGTH(dllPathBuffer)); This should be two separate assertions. > Source/WebCore/platform/win/LocalizedStringsWin.cpp:64 > +static CFBundleRef webKitBundle() > +{ > + static CFBundleRef bundle = createWebKitBundle(); > + ASSERT(bundle); > + return bundle; > +} We should expose this to WebKit1 and WebKit2 so they don't need their own definitions. 386918 4 sam 2011-04-15 14:10:43 -0700 (In reply to comment #3) > (From update of attachment 89841 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89841&action=review > > > Source/WebCore/platform/win/LocalizedStringsWin.cpp:49 > > + ASSERT(length && length < WTF_ARRAY_LENGTH(dllPathBuffer)); > > This should be two separate assertions. > > > Source/WebCore/platform/win/LocalizedStringsWin.cpp:64 > > +static CFBundleRef webKitBundle() > > +{ > > + static CFBundleRef bundle = createWebKitBundle(); > > + ASSERT(bundle); > > + return bundle; > > +} > > We should expose this to WebKit1 and WebKit2 so they don't need their own definitions. Indeed, will do that in a follow up so I don't break too much at once. 386927 5 sam 2011-04-15 14:18:24 -0700 Committed r84033: <http://trac.webkit.org/changeset/84033> 387123 6 webkit.review.bot 2011-04-15 18:20:35 -0700 http://trac.webkit.org/changeset/84033 might have broken GTK Linux 64-bit Debug and WinCE Release (Build) The following tests are not passing: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html 89841 2011-04-15 13:26:18 -0700 2011-04-15 14:07:24 -0700 Patch bug-58688-20110415132618.patch text/plain 3238 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0MDI1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTUgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbXBsZW1lbnQgbG9jYWxpemUgc3RyaW5ncyBmb3Igd2luZG93cyBXZWJL aXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY4 OAorCisgICAgICAgICogcGxhdGZvcm0vd2luL0xvY2FsaXplZFN0cmluZ3NXaW4uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Y3JlYXRlV2ViS2l0QnVuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6Ondl YktpdEJ1bmRsZSk6CisgICAgICAgIChXZWJDb3JlOjpsb2NhbGl6ZWRTdHJpbmcpOgorICAgICAg ICBBZGQgaW1wbGVtZW50YXRpb24gb2YgbG9jYWxpemVkU3RyaW5nIGZvciBXaW5kb3dzLgorCiAy MDExLTA0LTE1ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBS b2xsaW5nIG91dCBhY2NpZGVudGFsIHBhcnQgb2Ygcjg0MDEwLgpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd2luL0xvY2FsaXplZFN0cmluZ3NXaW4uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Mb2NhbGl6ZWRTdHJpbmdzV2luLmNwcAkocmV2aXNp b24gODM5ODQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vTG9jYWxpemVkU3RyaW5n c1dpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDE0ICsyNiw1NCBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogI2luY2x1ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKIAorI2luY2x1ZGUgIldlYkNv cmVJbnN0YW5jZUhhbmRsZS5oIgorI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NGQnVuZGxlLmg+ CisjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KKyNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+ CisjaW5jbHVkZSA8d3RmL1JldGFpblB0ci5oPgorI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMu aD4KKyNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3Ry aW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIENGQnVuZGxlUmVmIGNyZWF0 ZVdlYktpdEJ1bmRsZSgpCit7CisgICAgaWYgKENGQnVuZGxlUmVmIGV4aXN0aW5nQnVuZGxlID0g Q0ZCdW5kbGVHZXRCdW5kbGVXaXRoSWRlbnRpZmllcihDRlNUUigiY29tLmFwcGxlLldlYktpdCIp KSkgeworICAgICAgICBDRlJldGFpbihleGlzdGluZ0J1bmRsZSk7CisgICAgICAgIHJldHVybiBl eGlzdGluZ0J1bmRsZTsKKyAgICB9CisKKyAgICB3Y2hhcl90IGRsbFBhdGhCdWZmZXJbTUFYX1BB VEhdOworICAgIERXT1JEIGxlbmd0aCA9IDo6R2V0TW9kdWxlRmlsZU5hbWVXKGluc3RhbmNlSGFu ZGxlKCksIGRsbFBhdGhCdWZmZXIsIFdURl9BUlJBWV9MRU5HVEgoZGxsUGF0aEJ1ZmZlcikpOwor ICAgIEFTU0VSVChsZW5ndGggJiYgbGVuZ3RoIDwgV1RGX0FSUkFZX0xFTkdUSChkbGxQYXRoQnVm ZmVyKSk7CisKKyAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGRsbFBhdGgoQWRvcHRDRiwgQ0ZT dHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVyc05vQ29weSgwLCByZWludGVycHJldF9jYXN0PGNvbnN0 IFVuaUNoYXIqPihkbGxQYXRoQnVmZmVyKSwgbGVuZ3RoLCBrQ0ZBbGxvY2F0b3JOdWxsKSk7Cisg ICAgUmV0YWluUHRyPENGVVJMUmVmPiBkbGxVUkwoQWRvcHRDRiwgQ0ZVUkxDcmVhdGVXaXRoRmls ZVN5c3RlbVBhdGgoMCwgZGxsUGF0aC5nZXQoKSwga0NGVVJMV2luZG93c1BhdGhTdHlsZSwgZmFs c2UpKTsKKyAgICBSZXRhaW5QdHI8Q0ZVUkxSZWY+IGRsbERpcmVjdG9yeVVSTChBZG9wdENGLCBD RlVSTENyZWF0ZUNvcHlEZWxldGluZ0xhc3RQYXRoQ29tcG9uZW50KDAsIGRsbFVSTC5nZXQoKSkp OworICAgIFJldGFpblB0cjxDRlVSTFJlZj4gcmVzb3VyY2VzRGlyZWN0b3J5VVJMKEFkb3B0Q0Ys IENGVVJMQ3JlYXRlQ29weUFwcGVuZGluZ1BhdGhDb21wb25lbnQoMCwgZGxsRGlyZWN0b3J5VVJM LmdldCgpLCBDRlNUUigiV2ViS2l0LnJlc291cmNlcyIpLCB0cnVlKSk7CisKKyAgICByZXR1cm4g Q0ZCdW5kbGVDcmVhdGUoMCwgcmVzb3VyY2VzRGlyZWN0b3J5VVJMLmdldCgpKTsKK30KKworc3Rh dGljIENGQnVuZGxlUmVmIHdlYktpdEJ1bmRsZSgpCit7CisgICAgc3RhdGljIENGQnVuZGxlUmVm IGJ1bmRsZSA9IGNyZWF0ZVdlYktpdEJ1bmRsZSgpOworICAgIEFTU0VSVChidW5kbGUpOworICAg IHJldHVybiBidW5kbGU7Cit9CisKIFN0cmluZyBsb2NhbGl6ZWRTdHJpbmcoY29uc3QgY2hhciog a2V5KQogewotICAgIC8vIEZJWE1FOiA8cmRhcjovL3Byb2JsZW0vOTExOTQwNT4gV2luOiBXZWJL aXQyIG5lZWRzIHRvIGJlIG1hZGUgbG9jYWxpemFibGUKLSAgICByZXR1cm4gU3RyaW5nOjpmcm9t VVRGOChrZXksIHN0cmxlbihrZXkpKTsKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworCisg ICAgc3RhdGljIENGU3RyaW5nUmVmIG5vdEZvdW5kID0gQ0ZTVFIoImxvY2FsaXplZCBzdHJpbmcg bm90IGZvdW5kIik7CisKKyAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGtleVN0cmluZyhBZG9w dENGLCBDRlN0cmluZ0NyZWF0ZVdpdGhDU3RyaW5nTm9Db3B5KE5VTEwsIGtleSwga0NGU3RyaW5n RW5jb2RpbmdVVEY4LCBrQ0ZBbGxvY2F0b3JOdWxsKSk7CisgICAgUmV0YWluUHRyPENGU3RyaW5n UmVmPiByZXN1bHQoQWRvcHRDRiwgQ0ZDb3B5TG9jYWxpemVkU3RyaW5nV2l0aERlZmF1bHRWYWx1 ZShrZXlTdHJpbmcuZ2V0KCksIDAsIHdlYktpdEJ1bmRsZSgpLCBub3RGb3VuZCwgMCkpOworICAg IEFTU0VSVF9XSVRIX01FU1NBR0UocmVzdWx0LmdldCgpICE9IG5vdEZvdW5kLCAiY291bGQgbm90 IGZpbmQgbG9jYWxpemFibGUgc3RyaW5nICVzIGluIGJ1bmRsZSIsIGtleSk7CisKKyAgICByZXR1 cm4gcmVzdWx0LmdldCgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==