58682 2011-04-15 12:51:20 -0700 only show pretty-diff/wdiff if they were generated 2011-04-15 18:22:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth commit-queue dpranke eric webkit.review.bot oldest_to_newest 386843 0 ojan 2011-04-15 12:51:20 -0700 only show pretty-diff/wdiff if they were generated 386844 1 89834 ojan 2011-04-15 12:51:49 -0700 Created attachment 89834 Patch 386849 2 89834 dpranke 2011-04-15 12:57:36 -0700 Comment on attachment 89834 Patch looks fine. 387042 3 ojan 2011-04-15 17:00:07 -0700 Committed r84054: <http://trac.webkit.org/changeset/84054> 387134 4 webkit.review.bot 2011-04-15 18:22:15 -0700 http://trac.webkit.org/changeset/84054 might have broken WinCairo Debug (Build) 89834 2011-04-15 12:51:49 -0700 2011-04-15 13:03:20 -0700 Patch bug-58682-20110415125148.patch text/plain 4993 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODM5OTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNGVkYzdjNmNhZDlhY2Q0NDZiY2MwNTU2MzU4NDJkNThl NTBhOTNiLi5mZDFlZWNmN2YyNDc3OGM3NWZkOWY3ODM5YzViODZjZGZiZjgwNGNhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDQtMTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvbmx5IHNob3cgcHJldHR5 LWRpZmYvd2RpZmYgaWYgdGhleSB3ZXJlIGdlbmVyYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2ODIKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0cy5odG1sOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3Rf cnVubmVyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv YmFzZS5weToKKworMjAxMS0wNC0xNSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIGZpeCBwYXRoIHRv IGxheW91dCB0ZXN0IGluIG5ldyByZXN1bHRzIGZpbGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0cy5odG1s IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNv bl9yZXN1bHRzLmh0bWwKaW5kZXggMmQ2YWQ4NjNjN2YwOGFlZGYwMGU2ZjZjZmFjNzI1MmNkYTVm YmY1My4uOWVhODYyYzQ2MWY2ZDZiYjYxMzU2OTQ0NmI1N2YwODQ1YjYwMWJkMSAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNv bl9yZXN1bHRzLmh0bWwKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv bGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwKQEAgLTc3LDYgKzc3LDggQEAgZnVuY3Rp b24gcmVzdWx0TGluayh0ZXN0X3ByZWZpeCwgc3VmZml4LCBjb250ZW50cykKIC8vIEZJWE1FOiBz aG93IGV4cGVjdGVkL2FjdHVhbC9kaWZmIGNvbnRlbnRzIGlubGluZSBpbiBpZnJhbWVzCiAvLyBG SVhNRTogYWxsb3cgem9vbWluZyBpbiBvbiBwaXhlbCBkaWZmcwogLy8gRklYTUU6IHN0b3JlIHN0 ZGVyciBpbmZvcm1hdGlvbiBpbiB0aGUganNvbgorLy8gRklYTUU6IGFkZCBsaW5rcyB0byB0aGUg aHR0cGQgYWNjZXNzL2Vycm9yIGxvZ3MKKy8vIEZJWE1FOiBoYW5kbGUgbmV3IHRlc3RzCiAKIHZh ciBoYXNUZXh0RmFpbHVyZXMgPSBmYWxzZTsKIHZhciBoYXNJbWFnZUZhaWx1cmVzID0gZmFsc2U7 CkBAIC05MywyNiArOTUsMjkgQEAgZm9yICh2YXIgdGVzdCBpbiByZXN1bHRzLnRlc3RzKSB7CiAg IHZhciB0ZXN0X3ByZWZpeCA9IHN0cmlwRXh0ZW5zaW9uKHRlc3QpOwogCiAgIHJvdyArPSAnPHRk Pic7Ci0gIC8vIEZJWE1FOiBvbmx5IGluY2x1ZGUgdGltZW91dCBhY3R1YWwvZXhwZWN0ZWQgcmVz dWx0cyBoZXJlIGlmIHdlIGFjdHVhbGx5IHNwaXQgb3V0IHJlc3VsdHMgZm9yIHRpbWVvdXQgdGVz dHMuCiAgIGlmIChhY3R1YWwgPT0gJ0NSQVNIJykKLSAgICAgIHJvdyArPSByZXN1bHRMaW5rKHRl c3QsICctc3RhY2sudHh0JywgJ3N0YWNrJyk7CisgICAgICByb3cgKz0gcmVzdWx0TGluayh0ZXN0 X3ByZWZpeCwgJy1zdGFjay50eHQnLCAnc3RhY2snKTsKICAgZWxzZSBpZiAoYWN0dWFsLmluZGV4 T2YoJ1RFWFQnIHx8IGFjdHVhbCA9PSAnVElNRU9VVCcpICE9IC0xKSB7CisgICAgICAvLyBGSVhN RTogb25seSBpbmNsdWRlIHRpbWVvdXQgYWN0dWFsL2V4cGVjdGVkIHJlc3VsdHMgaGVyZSBpZiB3 ZSBhY3R1YWxseSBzcGl0IG91dCByZXN1bHRzIGZvciB0aW1lb3V0IHRlc3RzLgogICAgICAgaGFz VGV4dEZhaWx1cmVzID0gdHJ1ZTsKLSAgICAgIC8vIEZJWE1FOiBTaG93IHdkaWZmIGhlcmUgdG9v PwotICAgICAgLy8gRklYTUU6IHN0b3JlIGEgYml0IGluIHRoZSBKU09OIGFzIHRvIHdoZXRoZXIg cHJldHR5LWRpZmYvd2RpZmZzIHdlcmUgZ2VuZXJhdGVkCi0gICAgICByb3cgKz0gcmVzdWx0TGlu ayh0ZXN0LCAnLWV4cGVjdGVkLnR4dCcsICdleHBlY3RlZCcpICsKLSAgICAgICAgICByZXN1bHRM aW5rKHRlc3QsICctYWN0dWFsLnR4dCcsICdhY3R1YWwnKSArCi0gICAgICAgICAgcmVzdWx0TGlu ayh0ZXN0LCAnLWRpZmYudHh0JywgJ2RpZmYnKSArCi0gICAgICAgICAgcmVzdWx0TGluayh0ZXN0 LCAnLXByZXR0eS1kaWZmLmh0bWwnLCAncHJldHR5IGRpZmYnKTsKKyAgICAgIHJvdyArPSByZXN1 bHRMaW5rKHRlc3RfcHJlZml4LCAnLWV4cGVjdGVkLnR4dCcsICdleHBlY3RlZCcpICsKKyAgICAg ICAgICByZXN1bHRMaW5rKHRlc3RfcHJlZml4LCAnLWFjdHVhbC50eHQnLCAnYWN0dWFsJykgKwor ICAgICAgICAgIHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctZGlmZi50eHQnLCAnZGlmZicpOwor ICAgICAgICAKKyAgICAgIGlmIChyZXN1bHRzLmhhc19wcmV0dHlfcGF0Y2gpCisgICAgICAgICAg cm93ICs9IHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctcHJldHR5LWRpZmYuaHRtbCcsICdwcmV0 dHkgZGlmZicpOworCisgICAgICBpZiAocmVzdWx0cy5oYXNfd2RpZmYpCisgICAgICAgICAgcm93 ICs9IHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctd2RpZmYuaHRtbCcsICd3ZGlmZicpOwogICB9 CiAKICAgcm93ICs9ICc8L3RkPjx0ZD4nOwogCiAgIGlmIChhY3R1YWwuaW5kZXhPZignSU1BR0Un KSAhPSAtMSkgewogICAgICAgaGFzSW1hZ2VGYWlsdXJlcyA9IHRydWU7Ci0gICAgICByb3cgKz0g cmVzdWx0TGluayh0ZXN0LCAnLWV4cGVjdGVkLnBuZycsICdleHBlY3RlZCcpICsKLSAgICAgICAg ICByZXN1bHRMaW5rKHRlc3QsICctYWN0dWFsLnBuZycsICdhY3R1YWwnKSArCi0gICAgICAgICAg cmVzdWx0TGluayh0ZXN0LCAnLWRpZmYucG5nJywgJ2RpZmYnKTsKKyAgICAgIHJvdyArPSByZXN1 bHRMaW5rKHRlc3RfcHJlZml4LCAnLWV4cGVjdGVkLnBuZycsICdleHBlY3RlZCcpICsKKyAgICAg ICAgICByZXN1bHRMaW5rKHRlc3RfcHJlZml4LCAnLWFjdHVhbC5wbmcnLCAnYWN0dWFsJykgKwor ICAgICAgICAgIHJlc3VsdExpbmsodGVzdF9wcmVmaXgsICctZGlmZi5wbmcnLCAnZGlmZicpOwog ICB9CiAKICAgcm93ICs9ICc8L3RkPic7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5 CmluZGV4IGQ2MjcyNGE1YzUyMTg0ZGJlYzk5ZTFmMGUyZjE0YjM3YjkzNTdhZjYuLjJlN2FiNDY0 ZDdmNDkyZGMwMzBjOTdmNDA4YWUwZjdiZGQwYmZhM2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rlc3RfcnVubmVyLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3Rl c3RfcnVubmVyLnB5CkBAIC0xNTgsNiArMTU4LDggQEAgZGVmIHN1bW1hcml6ZV9yZXN1bHRzKHBv cnRfb2JqLCBleHBlY3RhdGlvbnMsIHJlc3VsdF9zdW1tYXJ5LCByZXRyeV9zdW1tYXJ5LCB0ZXMK ICAgICAjIHdlIHNob3VsZCBtYWtlIHRoaXMgY2hlY2sgbW9yZSByb2J1c3QuCiAgICAgcmVzdWx0 c1sndXNlc19leHBlY3RhdGlvbnNfZmlsZSddID0gcG9ydF9vYmoubmFtZSgpLmZpbmQoJ2Nocm9t aXVtJykgIT0gLTEKICAgICByZXN1bHRzWydsYXlvdXRfdGVzdHNfZGlyJ10gPSBwb3J0X29iai5s YXlvdXRfdGVzdHNfZGlyKCkKKyAgICByZXN1bHRzWydoYXNfd2RpZmYnXSA9IHBvcnRfb2JqLndk aWZmX2F2YWlsYWJsZSgpCisgICAgcmVzdWx0c1snaGFzX3ByZXR0eV9wYXRjaCddID0gcG9ydF9v YmoucHJldHR5X3BhdGNoX2F2YWlsYWJsZSgpCiAKICAgICByZXR1cm4gcmVzdWx0cwogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKaW5kZXgg OWFhZGIwZWJlMjkxMjEzMjM3OWFlMTA5NGI1MGE4NWU0OTM2ODIzMi4uYzJlNTY1ZWExNTI1NDc1 MWQyZTJkYmMwZWQ0NmY2ODQ4ZWM5MzU0NCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtMTQwLDYgKzE0MCwxMiBAQCBjbGFzcyBQ b3J0KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX211bHRpcHJvY2Vzc2luZ19pc19hdmFpbGFibGUg PSAobXVsdGlwcm9jZXNzaW5nIGlzIG5vdCBOb25lKQogICAgICAgICBzZWxmLl9yZXN1bHRzX2Rp cmVjdG9yeSA9IE5vbmUKIAorICAgIGRlZiB3ZGlmZl9hdmFpbGFibGUoc2VsZik6CisgICAgICAg IHJldHVybiBib29sKHNlbGYuX3dkaWZmX2F2YWlsYWJsZSkKKworICAgIGRlZiBwcmV0dHlfcGF0 Y2hfYXZhaWxhYmxlKHNlbGYpOgorICAgICAgICByZXR1cm4gYm9vbChzZWxmLl9wcmV0dHlfcGF0 Y2hfYXZhaWxhYmxlKQorCiAgICAgZGVmIGRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKHNlbGYpOgog ICAgICAgICAiIiJSZXR1cm4gdGhlIG51bWJlciBvZiBEdW1wUmVuZGVyVHJlZSBpbnN0YW5jZXMg dG8gdXNlIGZvciB0aGlzCiAgICAgICAgIHBvcnQuIiIiCg==