58680 2011-04-15 12:22:46 -0700 new-run-webkit-tests: add an --additional-drt-flag option 2011-04-18 16:31:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric mihaip ojan scroggo tony wjmaclean oldest_to_newest 386814 0 dpranke 2011-04-15 12:22:46 -0700 new-run-webkit-tests: add an --additional-drt-flag option 386817 1 89827 dpranke 2011-04-15 12:25:09 -0700 Created attachment 89827 Patch 386820 2 89827 eric 2011-04-15 12:28:07 -0700 Comment on attachment 89827 Patch What sort of flags? Should we just pass everything after -- to DRT? Should we have the flags listed one at a time in the NRWT arguments? 386824 3 dpranke 2011-04-15 12:33:51 -0700 (In reply to comment #2) > (From update of attachment 89827 [details]) > What sort of flags? Should we just pass everything after -- to DRT? Should we have the flags listed one at a time in the NRWT arguments? The syntax would be new-run-webkit-tests --additional-drt-flag=--foo=bar test1.html test2.html We can't use "--" to separate things easily because we need to be able to specify tests on the command line. Also, optparse would get confused, and so we'd have to do some preprocessing of sys.argv which could be a bit messy. This is intended to replace at least most if not all of the chromium-specific options (incl. the GPU flags), e.g., the dozen or so in run_webkit_tests.py:224, like --stress-opt, --enable-hardware-gpu, --accelerated-2d-canvas, --gp-fault-error-box, etc. 386827 4 eric 2011-04-15 12:38:00 -0700 FYI, the same sort of discussion just went on in bug 58370 about adding such a flag to webkit-patch. I think Adam convinced me to stay away from such for now. But I don't have hugely strong opinions here. I think it's somewhat awkward to tell devs the should use --additiona-drt-flag=--gpu instead of --enable-hardware-gpu for example. But this is really up to you all since this doesn't really affect non-chromium ports. 386842 5 dpranke 2011-04-15 12:51:10 -0700 (In reply to comment #4) > FYI, the same sort of discussion just went on in bug 58370 about adding such a flag to webkit-patch. I think Adam convinced me to stay away from such for now. But I don't have hugely strong opinions here. I think it's somewhat awkward to tell devs the should use --additiona-drt-flag=--gpu instead of --enable-hardware-gpu for example. But this is really up to you all since this doesn't really affect non-chromium ports. Hm. I looked through that bug but didn't see the sort of discussion I was expecting; was that the right number? I actually think this may make life slightly easier for devs since they can use the DRT flag names directly without having to remember how they are mapped through NRWT. Plus it allows us to get the python out of the loop when people are adding new options to test all these wacky GPU configurations. Note that this is largely for individual developers testing on their machines. This is *not* for the bots (which is perhaps the opposite of the case in bug 58370). The bots need to have predictable sets of flags which are largely determined by the port name; NRWT shouldn't grow other command line args for those cases (and I agree that we should minimize the # of flags we have to pass to NRWT). 388150 6 89827 eric 2011-04-18 16:15:33 -0700 Comment on attachment 89827 Patch OK. 388159 7 dpranke 2011-04-18 16:31:51 -0700 Committed r84207: <http://trac.webkit.org/changeset/84207> 89827 2011-04-15 12:25:09 -0700 2011-04-18 16:25:31 -0700 Patch bug-58680-20110415122507.patch text/plain 6464 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODM5MTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MzJjYmM5OTA4MGJkZjYwNTdjYTUyMDY4ZTRkNDExMjkw YjZhYzQxLi40MWI2NTk5ZThiOGE0MTA4OWRlNTNhZDYyOTMzNTczOTQ1YmU5NTJiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDQtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtdGVzdHM6IGFkZCBhbiAtLWFkZGl0aW9uYWwtZHJ0LWZsYWcgb3B0aW9uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY4MAorCisgICAgICAgIE5S V1QgaGFzIGEgYnVuY2ggb2YgY29tbWFuZCBsaW5lIGZsYWdzIHRoYXQgZXhpc3QgdG8gcGFzcwor ICAgICAgICBjdXN0b20gZmxhZ3MgdG8gRFJULCBlc3BlY2lhbGx5IG9uIGNocm9taXVtLiBJdCB3 b3VsZCBiZSBuaWNlCisgICAgICAgIGlmIHRoZXJlIHdhcyBhIGdlbmVyaWMgbWVjaGFuaXNtIHRv IHBhc3MgdGhyb3VnaCBmbGFncyBzbyB3ZQorICAgICAgICBkaWRuJ3QgaGF2ZSBhbGwgdGhlIGN1 c3RvbSBvbmVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L21vY2tfZHJ0X3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKwogMjAxMS0wNC0xMyAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy dGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggZWIxMGE5YmQxNGQ4OGMzYTE2YTVmYTgzMTg0OTNm Y2IwMjAyMGI5My4uYjc3MGQ5ZWQwZDhiMzhhMGU0NWUxOTVlMzFkMTFhZTY3NzI3NWRhYyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtLnB5CkBAIC0zODksNiArMzg5LDggQEAgY2xhc3MgQ2hyb21pdW1Ecml2ZXIoYmFzZS5Ecml2 ZXIpOgogICAgICAgICAgICAgY21kLmFwcGVuZCgnLS1lbmFibGUtYWNjZWxlcmF0ZWQtMmQtY2Fu dmFzJykKICAgICAgICAgaWYgc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCdlbmFibGVfaGFyZHdhcmVf Z3B1Jyk6CiAgICAgICAgICAgICBjbWQuYXBwZW5kKCctLWVuYWJsZS1oYXJkd2FyZS1ncHUnKQor CisgICAgICAgIGNtZC5leHRlbmQoc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCdhZGRpdGlvbmFsX2Ry dF9mbGFnJywgW10pKQogICAgICAgICByZXR1cm4gY21kCiAKICAgICBkZWYgc3RhcnQoc2VsZik6 CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21v Y2tfZHJ0X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9tb2NrX2RydF91bml0dGVzdC5weQppbmRleCAzNzYwOGY4YzNjMDRhNjFmYzQwODAwM2U0 OTljYzc1N2YzMWIwNDliLi5jNDg5ZTIwZWZlZmFlN2JjYzg0NDMzODU5OGJlMGEzYmJmYWYzMmQ0 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21v Y2tfZHJ0X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvbW9ja19kcnRfdW5pdHRlc3QucHkKQEAgLTM5LDEzICszOSwxNyBAQCBmcm9tIHdl YmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBmYWN0b3J5CiBmcm9tIHdlYmtpdHB5Lmxh eW91dF90ZXN0cy5wb3J0IGltcG9ydCBwb3J0X3Rlc3RjYXNlCiBmcm9tIHdlYmtpdHB5LmxheW91 dF90ZXN0cy5wb3J0IGltcG9ydCB0ZXN0CiAKK2Zyb20gd2Via2l0cHkudG9vbCBpbXBvcnQgbW9j a3Rvb2wKK21vY2tfb3B0aW9ucyA9IG1vY2t0b29sLk1vY2tPcHRpb25zKHVzZV9hcGFjaGU9VHJ1 ZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbmZpZ3VyYXRpb249J1Jl bGVhc2UnKQorCiAKIGNsYXNzIE1vY2tEUlRQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRUZXN0 Q2FzZSk6Ci0gICAgZGVmIG1ha2VfcG9ydChzZWxmKToKKyAgICBkZWYgbWFrZV9wb3J0KHNlbGYs IG9wdGlvbnM9bW9ja19vcHRpb25zKToKICAgICAgICAgaWYgc3lzLnBsYXRmb3JtID09ICd3aW4z Mic6CiAgICAgICAgICAgICAjIFdlIHVzZSB0aGlzIGJlY2F1c2UgdGhlICd3aW4nIHBvcnQgZG9l c24ndCB3b3JrIHlldC4KLSAgICAgICAgICAgIHJldHVybiBtb2NrX2RydC5Nb2NrRFJUUG9ydChw b3J0X25hbWU9J21vY2stY2hyb21pdW0td2luJykKLSAgICAgICAgcmV0dXJuIG1vY2tfZHJ0Lk1v Y2tEUlRQb3J0KCkKKyAgICAgICAgICAgIHJldHVybiBtb2NrX2RydC5Nb2NrRFJUUG9ydChwb3J0 X25hbWU9J21vY2stY2hyb21pdW0td2luJywgb3B0aW9ucz1vcHRpb25zKQorICAgICAgICByZXR1 cm4gbW9ja19kcnQuTW9ja0RSVFBvcnQob3B0aW9ucz1vcHRpb25zKQogCiAgICAgZGVmIHRlc3Rf ZGVmYXVsdF93b3JrZXJfbW9kZWwoc2VsZik6CiAgICAgICAgICMgb25seSBvdmVycmlkZGluZyB0 aGUgZGVmYXVsdCB0ZXN0OyB3ZSBkb24ndCBjYXJlIGFib3V0IHRoaXMgb25lLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNl LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3Rj YXNlLnB5CmluZGV4IDM5ZWE0NjNlNTFjODFlODE5N2Y2YmFhNzk2NDQ3MmMzYzdkYmI1NTIuLmNi MWI5MTVlMmRhOGIxMDJjMmI3NTBlZWMzNDU3NjljNWI3ZGQxNTMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2Uu cHkKQEAgLTc3LDYgKzc3LDEyIEBAIGNsYXNzIFBvcnRUZXN0Q2FzZSh1bml0dGVzdC5UZXN0Q2Fz ZSk6CiAgICAgICAgICAgICByZXR1cm4KICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKGxlbihwb3J0 LmRyaXZlcl9jbWRfbGluZSgpKSkKIAorICAgICAgICBvcHRpb25zID0gbW9ja3Rvb2wuTW9ja09w dGlvbnMoYWRkaXRpb25hbF9kcnRfZmxhZz1bJy0tZm9vPWJhcicsICctLWZvbz1iYXonXSkKKyAg ICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KG9wdGlvbnM9b3B0aW9ucykKKyAgICAgICAgY21k X2xpbmUgPSBwb3J0LmRyaXZlcl9jbWRfbGluZSgpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSgn LS1mb289YmFyJyBpbiBjbWRfbGluZSkKKyAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCctLWZvbz1i YXonIGluIGNtZF9saW5lKQorCiAgICAgZGVmIGRpc2FibGVkX3Rlc3RfaHR0cF9zZXJ2ZXIoc2Vs Zik6CiAgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydCgpCiAgICAgICAgIGlmIG5vdCBwb3J0 OgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC90 ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5 CmluZGV4IDQ5MDI4YzQ5YTNjODMxZGZkMDBmOTgzNjg4OTZhYTI5OTIzOTUxNmQuLmZlZDdlMTEw MmY0MGJhMDI0ZTMzZjU2MWZhMjE0ZDU2ZTA3ZTgzOTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rlc3QucHkKQEAgLTQyMiw3ICs0MjIsNyBAQCBj bGFzcyBUZXN0RHJpdmVyKGJhc2UuRHJpdmVyKToKICAgICAgICAgc2VsZi5fcG9ydCA9IHBvcnQK IAogICAgIGRlZiBjbWRfbGluZShzZWxmKToKLSAgICAgICAgcmV0dXJuIFtzZWxmLl9wb3J0Ll9w YXRoX3RvX2RyaXZlcigpXQorICAgICAgICByZXR1cm4gW3NlbGYuX3BvcnQuX3BhdGhfdG9fZHJp dmVyKCldICsgc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCdhZGRpdGlvbmFsX2RydF9mbGFnJywgW10p CiAKICAgICBkZWYgcG9sbChzZWxmKToKICAgICAgICAgcmV0dXJuIFRydWUKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggNDMw NjExM2QyZDdlMTUwZWI4ODZjYjliNTU4NWFhMTZjYjZiYTA4Ny4uNGFjNGExM2YyZmU1MWY3OGIz Mzk1NzExMjZjNDFiYjc4ZTU3NjlhOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKQEAgLTM3MiwxMSArMzcyLDExIEBAIGNsYXNz IFdlYktpdERyaXZlcihiYXNlLkRyaXZlcik6CiAKICAgICBkZWYgY21kX2xpbmUoc2VsZik6CiAg ICAgICAgIGNtZCA9IHNlbGYuX2NvbW1hbmRfd3JhcHBlcihzZWxmLl9wb3J0LmdldF9vcHRpb24o J3dyYXBwZXInKSkKLSAgICAgICAgY21kICs9IFtzZWxmLl9wb3J0Ll9wYXRoX3RvX2RyaXZlcigp LCAnLSddCi0KKyAgICAgICAgY21kLmFwcGVuZChzZWxmLl9wb3J0Ll9wYXRoX3RvX2RyaXZlcigp KQogICAgICAgICBpZiBzZWxmLl9wb3J0LmdldF9vcHRpb24oJ3BpeGVsX3Rlc3RzJyk6CiAgICAg ICAgICAgICBjbWQuYXBwZW5kKCctLXBpeGVsLXRlc3RzJykKLQorICAgICAgICBjbWQuZXh0ZW5k KHNlbGYuX3BvcnQuZ2V0X29wdGlvbignYWRkaXRpb25hbF9kcnRfZmxhZycsIFtdKSkKKyAgICAg ICAgY21kLmFwcGVuZCgnLScpCiAgICAgICAgIHJldHVybiBjbWQKIAogICAgIGRlZiBzdGFydChz ZWxmKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGVhNDJjYzM2OGE1ZTBlZTAzNmIxMjczOTZlNGUxZGJk MjUzMmVkYWEuLmJjNDkwYmEzZmE1MWJhN2Q5OWYzMDhmNGI3NWExYWExNGMwZTcyNmIgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVz dHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weQpAQCAtMjkyLDYgKzI5Miw5IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6 CiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJlc2V0LXJlc3VsdHMiLCBhY3Rpb249 InN0b3JlX3RydWUiLAogICAgICAgICAgICAgZGVmYXVsdD1GYWxzZSwgaGVscD0iUmVzZXQgYW55 IGV4aXN0aW5nIGJhc2VsaW5lcyB0byB0aGUgIgogICAgICAgICAgICAgICAgICAiZ2VuZXJhdGVk IHJlc3VsdHMiKSwKKyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tYWRkaXRpb25hbC1k cnQtZmxhZyIsIGFjdGlvbj0iYXBwZW5kIiwKKyAgICAgICAgICAgIGRlZmF1bHQ9W10sIGhlbHA9 IkFkZGl0aW9uYWwgY29tbWFuZCBsaW5lIGZsYWcgdG8gcGFzcyB0byBEdW1wUmVuZGVyVHJlZSAi CisgICAgICAgICAgICAgICAgICJTcGVjaWZ5IG11bHRpcGxlIHRpbWVzIHRvIGFkZCBtdWx0aXBs ZSBmbGFncy4iKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tYWRkaXRpb25hbC1w bGF0Zm9ybS1kaXJlY3RvcnkiLCBhY3Rpb249ImFwcGVuZCIsCiAgICAgICAgICAgICBkZWZhdWx0 PVtdLCBoZWxwPSJBZGRpdGlvbmFsIGRpcmVjdG9yeSB3aGVyZSB0byBsb29rIGZvciB0ZXN0ICIK ICAgICAgICAgICAgICAgICAgImJhc2VsaW5lcyAod2lsbCB0YWtlIHByZWNlbmRlbmNlIG92ZXIg cGxhdGZvcm0gYmFzZWxpbmVzKS4gIgo=