58677 2011-04-15 11:55:37 -0700 globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining 2011-04-15 18:20:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 msaboff msaboff abarth eric webkit.review.bot oldest_to_newest 386794 0 89824 msaboff 2011-04-15 11:55:37 -0700 Created attachment 89824 Patch to move globalObject() to JSObjectWithGlobalObject.h As part of r60057, globalObject() was moved from JSDOMBinding.h to JSObjectWithGlobalObject.cpp. This limits a compilers ability to inline, especially in other components, namely WebCore. This is causing a performance regression. Moving globalObject() back to a .h file is worth ~5% on the dromaeo DOM benchmark. 386796 1 webkit.review.bot 2011-04-15 11:56:43 -0700 Attachment 89824 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 386850 2 89835 msaboff 2011-04-15 12:57:54 -0700 Created attachment 89835 Updated patch with bug reference in ChangeLog 386862 3 89835 mrowe 2011-04-15 13:09:20 -0700 Comment on attachment 89835 Updated patch with bug reference in ChangeLog “equivolent” 386867 4 89835 oliver 2011-04-15 13:16:19 -0700 Comment on attachment 89835 Updated patch with bug reference in ChangeLog r=me 386883 5 89835 jeffm 2011-04-15 13:47:42 -0700 Comment on attachment 89835 Updated patch with bug reference in ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=89835&action=review > Source/JavaScriptCore/ChangeLog:10 > + it for a performance benefit. An equivolent instance had been in Typo - equivolent 386889 6 msaboff 2011-04-15 13:51:30 -0700 Committed r84030: <http://trac.webkit.org/changeset/84030> 386901 7 msaboff 2011-04-15 14:01:59 -0700 Note that I fixed the "equivalent" typo before landing the patch. 387122 8 webkit.review.bot 2011-04-15 18:20:29 -0700 http://trac.webkit.org/changeset/84030 might have broken WinCE Release (Build) 89824 2011-04-15 11:55:37 -0700 2011-04-15 13:04:00 -0700 Patch to move globalObject() to JSObjectWithGlobalObject.h inlineGlobalObject.patch text/plain 2885 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM5OTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDQtMTUgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZWQgSlNPYmplY3RX aXRoR2xvYmFsT2JqZWN0OjpnbG9iYWxPYmplY3QoKSB0byAKKyAgICAgICAgcnVudGltZS9KU09i amVjdFdpdGhHbG9iYWxPYmplY3QuaCB0byBhbGxvdyB0aGUgY29tcGlsZXIgdG8gaW5saW5lCisg ICAgICAgIGl0IGZvciBhIHBlcmZvcm1hbmNlIGJlbmVmaXQuICBBbiBlcXVpdm9sZW50IGluc3Rh bmNlIGhhZCBiZWVuIGluCisgICAgICAgIGEgaGVhZGVyIGZpbGUgYmVmb3JlIHI2MDA1Ny4KKwor ICAgICAgICAqIEphdmFTY3JpcHRDb3JlLmV4cDoKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0 V2l0aEdsb2JhbE9iamVjdC5jcHA6CisgICAgICAgICogcnVudGltZS9KU09iamVjdFdpdGhHbG9i YWxPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0OjpnbG9i YWxPYmplY3QpOgorCiAyMDExLTA0LTE1ICBEbWl0cnkgTG9tb3YgIDxkc2xvbW92QGdvb2dsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAJKHJldmlzaW9uIDgzNzQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cAkod29ya2luZyBjb3B5KQpAQCAtNTI2 LDcgKzUyNiw2IEBAIF9fWk5LM0pTQzE4UHJvcGVydHlEZXNjcmlwdG9yNmdldHRlckV2CiBfX1pO SzNKU0MxOFByb3BlcnR5RGVzY3JpcHRvcjZzZXR0ZXJFdgogX19aTkszSlNDMThQcm9wZXJ0eURl c2NyaXB0b3I4d3JpdGFibGVFdgogX19aTkszSlNDMTlTb3VyY2VQcm92aWRlckNhY2hlOGJ5dGVT aXplRXYKLV9fWk5LM0pTQzI0SlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0MTJnbG9iYWxPYmplY3RF dgogX19aTkszSlNDNEhlYXAxMW9iamVjdENvdW50RXYKIF9fWk5LM0pTQzRIZWFwNHNpemVFdgog X19aTkszSlNDNEhlYXA4Y2FwYWNpdHlFdgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdFdpdGhHbG9iYWxPYmplY3QuY3BwCShyZXZp c2lvbiA4Mzc0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0V2l0 aEdsb2JhbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxLDkgKzQxLDQgQEAgSlNPYmpl Y3RXaXRoR2xvYmFsT2JqZWN0OjpKU09iamVjdFdpdGhHbAogICAgICAgICBwdXRBbm9ueW1vdXNW YWx1ZShnbG9iYWxPYmplY3QtPmdsb2JhbERhdGEoKSwgR2xvYmFsT2JqZWN0U2xvdCwgZ2xvYmFs T2JqZWN0KTsKIH0KIAotSlNHbG9iYWxPYmplY3QqIEpTT2JqZWN0V2l0aEdsb2JhbE9iamVjdDo6 Z2xvYmFsT2JqZWN0KCkgY29uc3QKLXsKLSAgICByZXR1cm4gYXNHbG9iYWxPYmplY3QoKGdldEFu b255bW91c1ZhbHVlKEdsb2JhbE9iamVjdFNsb3QpLmFzQ2VsbCgpKSk7Ci19Ci0KIH0gLy8gbmFt ZXNwYWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3RX aXRoR2xvYmFsT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0LmgJKHJldmlzaW9uIDgzNzQxKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0LmgJKHdv cmtpbmcgY29weSkKQEAgLTI2LDcgKzI2LDcgQEAKICNpZm5kZWYgSlNPYmplY3RXaXRoR2xvYmFs T2JqZWN0X2gKICNkZWZpbmUgSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0X2gKIAotI2luY2x1ZGUg IkpTT2JqZWN0LmgiCisjaW5jbHVkZSAiSlNHbG9iYWxPYmplY3QuaCIKIAogbmFtZXNwYWNlIEpT QyB7CiAKQEAgLTM5LDcgKzM5LDEwIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIFN0cnVjdHVy ZTo6Y3JlYXRlKGdsb2JhbERhdGEsIHByb3RvLCBUeXBlSW5mbyhPYmplY3RUeXBlLCBTdHJ1Y3R1 cmVGbGFncyksIEFub255bW91c1Nsb3RDb3VudCwgJnNfaW5mbyk7CiAgICAgfQogCi0gICAgSlNH bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCgpIGNvbnN0OworICAgIEpTR2xvYmFsT2JqZWN0KiBn bG9iYWxPYmplY3QoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGFzR2xvYmFsT2JqZWN0 KChnZXRBbm9ueW1vdXNWYWx1ZShHbG9iYWxPYmplY3RTbG90KS5hc0NlbGwoKSkpOworICAgIH0K IAogcHJvdGVjdGVkOgogICAgIEpTT2JqZWN0V2l0aEdsb2JhbE9iamVjdChKU0dsb2JhbE9iamVj dCosIE5vbk51bGxQYXNzUmVmUHRyPFN0cnVjdHVyZT4pOwo= 89835 2011-04-15 12:57:54 -0700 2011-04-15 13:47:42 -0700 Updated patch with bug reference in ChangeLog 58677.patch text/plain 3020 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM5OTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTEtMDQtMTUgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ2xvYmFsT2JqZWN0IG1v dmVkIHRvIEpTT2JqZWN0V2l0aEdsb2JhbE9iamVjdC5jcHAgaW5oaWJpdHMgaW5saW5pbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4Njc3CisKKyAg ICAgICAgTW92ZWQgSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0OjpnbG9iYWxPYmplY3QoKSB0byAK KyAgICAgICAgcnVudGltZS9KU09iamVjdFdpdGhHbG9iYWxPYmplY3QuaCB0byBhbGxvdyB0aGUg Y29tcGlsZXIgdG8gaW5saW5lCisgICAgICAgIGl0IGZvciBhIHBlcmZvcm1hbmNlIGJlbmVmaXQu ICBBbiBlcXVpdm9sZW50IGluc3RhbmNlIGhhZCBiZWVuIGluCisgICAgICAgIGEgaGVhZGVyIGZp bGUgYmVmb3JlIHI2MDA1Ny4KKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLmV4cDoKKyAgICAg ICAgKiBydW50aW1lL0pTT2JqZWN0V2l0aEdsb2JhbE9iamVjdC5jcHA6CisgICAgICAgICogcnVu dGltZS9KU09iamVjdFdpdGhHbG9iYWxPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3RX aXRoR2xvYmFsT2JqZWN0OjpnbG9iYWxPYmplY3QpOgorCiAyMDExLTA0LTE1ICBEbWl0cnkgTG9t b3YgIDxkc2xvbW92QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2 aW4uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAJKHJldmlz aW9uIDgzNzQxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cAko d29ya2luZyBjb3B5KQpAQCAtNTI2LDcgKzUyNiw2IEBAIF9fWk5LM0pTQzE4UHJvcGVydHlEZXNj cmlwdG9yNmdldHRlckV2CiBfX1pOSzNKU0MxOFByb3BlcnR5RGVzY3JpcHRvcjZzZXR0ZXJFdgog X19aTkszSlNDMThQcm9wZXJ0eURlc2NyaXB0b3I4d3JpdGFibGVFdgogX19aTkszSlNDMTlTb3Vy Y2VQcm92aWRlckNhY2hlOGJ5dGVTaXplRXYKLV9fWk5LM0pTQzI0SlNPYmplY3RXaXRoR2xvYmFs T2JqZWN0MTJnbG9iYWxPYmplY3RFdgogX19aTkszSlNDNEhlYXAxMW9iamVjdENvdW50RXYKIF9f Wk5LM0pTQzRIZWFwNHNpemVFdgogX19aTkszSlNDNEhlYXA4Y2FwYWNpdHlFdgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdFdpdGhH bG9iYWxPYmplY3QuY3BwCShyZXZpc2lvbiA4Mzc0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTT2JqZWN0V2l0aEdsb2JhbE9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQxLDkgKzQxLDQgQEAgSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0OjpKU09iamVjdFdpdGhHbAog ICAgICAgICBwdXRBbm9ueW1vdXNWYWx1ZShnbG9iYWxPYmplY3QtPmdsb2JhbERhdGEoKSwgR2xv YmFsT2JqZWN0U2xvdCwgZ2xvYmFsT2JqZWN0KTsKIH0KIAotSlNHbG9iYWxPYmplY3QqIEpTT2Jq ZWN0V2l0aEdsb2JhbE9iamVjdDo6Z2xvYmFsT2JqZWN0KCkgY29uc3QKLXsKLSAgICByZXR1cm4g YXNHbG9iYWxPYmplY3QoKGdldEFub255bW91c1ZhbHVlKEdsb2JhbE9iamVjdFNsb3QpLmFzQ2Vs bCgpKSk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIEpTQwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0LmgJKHJl dmlzaW9uIDgzNzQxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3RX aXRoR2xvYmFsT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDcgKzI2LDcgQEAKICNpZm5k ZWYgSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0X2gKICNkZWZpbmUgSlNPYmplY3RXaXRoR2xvYmFs T2JqZWN0X2gKIAotI2luY2x1ZGUgIkpTT2JqZWN0LmgiCisjaW5jbHVkZSAiSlNHbG9iYWxPYmpl Y3QuaCIKIAogbmFtZXNwYWNlIEpTQyB7CiAKQEAgLTM5LDcgKzM5LDEwIEBAIHB1YmxpYzoKICAg ICAgICAgcmV0dXJuIFN0cnVjdHVyZTo6Y3JlYXRlKGdsb2JhbERhdGEsIHByb3RvLCBUeXBlSW5m byhPYmplY3RUeXBlLCBTdHJ1Y3R1cmVGbGFncyksIEFub255bW91c1Nsb3RDb3VudCwgJnNfaW5m byk7CiAgICAgfQogCi0gICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCgpIGNvbnN0Owor ICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QoKSBjb25zdAorICAgIHsKKyAgICAgICAg cmV0dXJuIGFzR2xvYmFsT2JqZWN0KChnZXRBbm9ueW1vdXNWYWx1ZShHbG9iYWxPYmplY3RTbG90 KS5hc0NlbGwoKSkpOworICAgIH0KIAogcHJvdGVjdGVkOgogICAgIEpTT2JqZWN0V2l0aEdsb2Jh bE9iamVjdChKU0dsb2JhbE9iamVjdCosIE5vbk51bGxQYXNzUmVmUHRyPFN0cnVjdHVyZT4pOwo=