58676 2011-04-15 11:17:40 -0700 Views should be made visible before painting in WM_PRINTCLIENT messages 2011-04-15 12:47:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 bweinstein bweinstein aroben oldest_to_newest 386764 0 bweinstein 2011-04-15 11:17:40 -0700 If a view that is in the background (from a background tab) tries to paint to an HDC in response to a WM_PRINTCLIENT message, painting is suspended from the drawing area, so the paint will fail. We should tell the view that it is temporarily visible, so it is allowed to paint. <rdar://problem/9279211> 386766 1 89817 bweinstein 2011-04-15 11:21:15 -0700 Created attachment 89817 [PATCH] Fix 386774 2 89817 jeffm 2011-04-15 11:32:53 -0700 Comment on attachment 89817 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=89817&action=review > Source/WebKit2/UIProcess/win/WebView.cpp:693 > + bool isVisible = isViewVisible(); Maybe this should be wasVisible? 386775 3 bweinstein 2011-04-15 11:34:03 -0700 (In reply to comment #2) > (From update of attachment 89817 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89817&action=review > > > Source/WebKit2/UIProcess/win/WebView.cpp:693 > > + bool isVisible = isViewVisible(); > > Maybe this should be wasVisible? Yeah, I was waffling on a name here. wasVisible is good. Thanks! 386811 4 89817 aroben 2011-04-15 12:15:33 -0700 Comment on attachment 89817 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=89817&action=review > Source/WebKit2/UIProcess/win/WebView.cpp:700 > + if (!isVisible) > + setIsVisible(true); > + > paint(hdc, winRect); > > + if (!isVisible) > + setIsVisible(false); I think it's worth adding a comment explaining why we do this. It's a little unfortunate that we don't have more fine-grained control of this. Today, the visible state of the view only affects whether painting happens. In the future it could affect more things which we don't want to touch here. Maybe a FIXME saying that it would be good to have a more-direct way of telling the web process to draw even if we're invisible would be enough here. > Source/WebKit2/UIProcess/win/WebView.cpp:1482 > +void WebView::setIsVisible(bool isVisible) > +{ > + m_isVisible = isVisible; > + m_page->viewStateDidChange(WebPageProxy::ViewIsVisible); > +} Seems like onShowWindowEvent should call this function. 386834 5 89831 bweinstein 2011-04-15 12:42:10 -0700 Created attachment 89831 [PATCH] Fix v2 386837 6 bweinstein 2011-04-15 12:47:31 -0700 Landed in r84019. 89817 2011-04-15 11:21:15 -0700 2011-04-15 12:42:10 -0700 [PATCH] Fix background_printclient.patch text/plain 2396 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFZpZXdzIHNob3VsZCBiZSBtYWRlIHZpc2libGUgYmVm b3JlIHBhaW50aW5nIGluIFdNX1BSSU5UQ0xJRU5UIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY3NgorICAgICAgICA8cmRhcjovL3By b2JsZW0vOTI3OTIxMT4KKworICAgICAgICAqIFVJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlZpZXc6Om9uUHJpbnRDbGllbnRFdmVudCk6IElmIG91ciB2aWV3 IGlzbid0IGN1cnJlbnRseSB2aXNpYmxlIHNldCBpdCB0byB2aXNpYmxlCisgICAgICAgICAgICBi ZWZvcmUgcGFpbnRpbmcsIHRoZW4gcmVzZXQgaXQgYmFjayB0byBub3QgdmlzaWJsZSBhZnRlciBw YWludGluZy4KKyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6c2V0SXNWaXNpYmxlKTogU2V0IHRo ZSBtX2lzVmlzaWJsZSBmbGFnIGFuZCBjYWxsIHZpZXdTdGF0ZURpZENoYW5nZS4KKyAgICAgICAg KiBVSVByb2Nlc3Mvd2luL1dlYlZpZXcuaDoKKwogMjAxMS0wNC0xNCAgSmVyIE5vYmxlICA8amVy Lm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDgz OTgwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjkwLDggKzY5MCwxNSBAQCBMUkVTVUxUIFdlYlZpZXc6Om9uUHJpbnRDbGll bnRFdmVudChIV05ECiAgICAgUkVDVCB3aW5SZWN0OwogICAgIDo6R2V0Q2xpZW50UmVjdChoV25k LCAmd2luUmVjdCk7CiAKKyAgICBib29sIGlzVmlzaWJsZSA9IGlzVmlld1Zpc2libGUoKTsKKyAg ICBpZiAoIWlzVmlzaWJsZSkKKyAgICAgICAgc2V0SXNWaXNpYmxlKHRydWUpOworCiAgICAgcGFp bnQoaGRjLCB3aW5SZWN0KTsKIAorICAgIGlmICghaXNWaXNpYmxlKQorICAgICAgICBzZXRJc1Zp c2libGUoZmFsc2UpOworCiAgICAgaGFuZGxlZCA9IHRydWU7CiAgICAgcmV0dXJuIDA7CiB9CkBA IC0xNDY4LDYgKzE0NzUsMTIgQEAgdm9pZCBXZWJWaWV3OjpzZXRJc0luV2luZG93KGJvb2wgaXNJ bldpbgogICAgIG1fcGFnZS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYlBhZ2VQcm94eTo6Vmlld0lz SW5XaW5kb3cpOwogfQogCit2b2lkIFdlYlZpZXc6OnNldElzVmlzaWJsZShib29sIGlzVmlzaWJs ZSkKK3sKKyAgICBtX2lzVmlzaWJsZSA9IGlzVmlzaWJsZTsKKyAgICBtX3BhZ2UtPnZpZXdTdGF0 ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdJc1Zpc2libGUpOworfQorCiAjaWYgVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogCiB2b2lkIFdlYlZpZXc6OmVudGVyQWNjZWxlcmF0ZWRD b21wb3NpdGluZ01vZGUoY29uc3QgTGF5ZXJUcmVlQ29udGV4dCYpCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuaAkocmV2aXNpb24gODM5ODApCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAtNjAsNiArNjAs NyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRQYXJlbnRXaW5kb3coSFdORCk7CiAgICAgdm9pZCB3 aW5kb3dBbmNlc3RyeURpZENoYW5nZSgpOwogICAgIHZvaWQgc2V0SXNJbldpbmRvdyhib29sKTsK KyAgICB2b2lkIHNldElzVmlzaWJsZShib29sKTsKICAgICB2b2lkIHNldE92ZXJyaWRlQ3Vyc29y KEhDVVJTT1IpOwogICAgIHZvaWQgc2V0SW5pdGlhbEZvY3VzKGJvb2wgZm9yd2FyZCk7CiAgICAg dm9pZCBzZXRTY3JvbGxPZmZzZXRPbk5leHRSZXNpemUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYp Owo= 89831 2011-04-15 12:42:10 -0700 2011-04-15 12:42:58 -0700 [PATCH] Fix v2 background_printclient.patch text/plain 3486 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFZpZXdzIHNob3VsZCBiZSBtYWRlIHZpc2libGUgYmVm b3JlIHBhaW50aW5nIGluIFdNX1BSSU5UQ0xJRU5UIG1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY3NgorICAgICAgICA8cmRhcjovL3By b2JsZW0vOTI3OTIxMT4KKworICAgICAgICAqIFVJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlZpZXc6Om9uUHJpbnRDbGllbnRFdmVudCk6IElmIG91ciB2aWV3 IGlzbid0IGN1cnJlbnRseSB2aXNpYmxlIHNldCBpdCB0byB2aXNpYmxlCisgICAgICAgICAgICBi ZWZvcmUgcGFpbnRpbmcsIHRoZW4gcmVzZXQgaXQgYmFjayB0byBub3QgdmlzaWJsZSBhZnRlciBw YWludGluZy4KKyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6b25TaG93V2luZG93RXZlbnQpOiBD YWxsIHNldElzVmlzaWJsZSBpbnN0ZWFkIG9mIGR1cGxpY2F0aW5nIGxvZ2ljLgorICAgICAgICAo V2ViS2l0OjpXZWJWaWV3OjpzZXRJc1Zpc2libGUpOiBTZXQgdGhlIG1faXNWaXNpYmxlIGZsYWcg YW5kIGNhbGwgdmlld1N0YXRlRGlkQ2hhbmdlLgorICAgICAgICAqIFVJUHJvY2Vzcy93aW4vV2Vi Vmlldy5oOgorCiAyMDExLTA0LTE0ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gODM5ODApCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3Mvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OTAsOCAr NjkwLDIyIEBAIExSRVNVTFQgV2ViVmlldzo6b25QcmludENsaWVudEV2ZW50KEhXTkQKICAgICBS RUNUIHdpblJlY3Q7CiAgICAgOjpHZXRDbGllbnRSZWN0KGhXbmQsICZ3aW5SZWN0KTsKIAorICAg IC8vIFR3aWRkaW5nIHRoZSB2aXNpYmlsaXR5IGZsYWdzIHRlbGxzIHRoZSBEcmF3aW5nQXJlYSB0 byByZXN1bWUgcGFpbnRpbmcuIFJpZ2h0IG5vdywgdGhlCisgICAgLy8gdGhlIHZpc2libGUgc3Rh dGUgb2YgdGhlIHZpZXcgb25seSBhZmZlY3RzIHdoZXRoZXIgb3Igbm90IHBhaW50aW5nIGhhcHBl bnMsIGJ1dCBpbiB0aGUKKyAgICAvLyBmdXR1cmUgaXQgY291bGQgYWZmZWN0IG1vcmUsIHdoaWNo IHdlIHdvdWxkbid0IHdhbnQgdG8gdG91Y2ggaGVyZS4KKworICAgIC8vIEZJWE1FOiBXZSBzaG91 bGQgaGF2ZSBhIGJldHRlciB3YXkgb2YgdGVsbGluZyB0aGUgV2ViUHJvY2VzcyB0byBkcmF3IGV2 ZW4gaWYgd2UncmUKKyAgICAvLyBpbnZpc2libGUgdGhhbiB0d2lkZGxpbmcgdGhlIHZpc2liaWxp dHkgZmxhZy4KKworICAgIGJvb2wgd2FzVmlzaWJsZSA9IGlzVmlld1Zpc2libGUoKTsKKyAgICBp ZiAoIXdhc1Zpc2libGUpCisgICAgICAgIHNldElzVmlzaWJsZSh0cnVlKTsKKwogICAgIHBhaW50 KGhkYywgd2luUmVjdCk7CiAKKyAgICBpZiAoIXdhc1Zpc2libGUpCisgICAgICAgIHNldElzVmlz aWJsZShmYWxzZSk7CisKICAgICBoYW5kbGVkID0gdHJ1ZTsKICAgICByZXR1cm4gMDsKIH0KQEAg LTc1MSwxMSArNzY1LDggQEAgTFJFU1VMVCBXZWJWaWV3OjpvblNob3dXaW5kb3dFdmVudChIV05E CiAgICAgLy8gbFBhcmFtIGlzIDAgd2hlbiB0aGUgbWVzc2FnZSBpcyBzZW50IGJlY2F1c2Ugb2Yg YSBTaG93V2luZG93IGNhbGwuCiAgICAgLy8gRklYTUU6IFNpbmNlIHdlIGRvbid0IGdldCBub3Rp ZmllZCB3aGVuIGFuIGFuY2VzdG9yIHdpbmRvdyBpcyBoaWRkZW4gb3Igc2hvd24sIHdlIHdpbGwg a2VlcAogICAgIC8vIHBhaW50aW5nIGV2ZW4gd2hlbiB3ZSBoYXZlIGEgaGlkZGVuIGFuY2VzdG9y LiA8aHR0cDovL3dlYmtpdC5vcmcvYi81NDEwND4KLSAgICBpZiAoIWxQYXJhbSkgewotICAgICAg ICBtX2lzVmlzaWJsZSA9IHdQYXJhbTsKLSAgICAgICAgaWYgKG1fcGFnZSkKLSAgICAgICAgICAg IG1fcGFnZS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYlBhZ2VQcm94eTo6Vmlld0lzVmlzaWJsZSk7 Ci0gICAgfQorICAgIGlmICghbFBhcmFtKQorICAgICAgICBzZXRJc1Zpc2libGUod1BhcmFtKTsK IAogICAgIGhhbmRsZWQgPSBmYWxzZTsKICAgICByZXR1cm4gMDsKQEAgLTE0NjgsNiArMTQ3OSwx NCBAQCB2b2lkIFdlYlZpZXc6OnNldElzSW5XaW5kb3coYm9vbCBpc0luV2luCiAgICAgbV9wYWdl LT52aWV3U3RhdGVEaWRDaGFuZ2UoV2ViUGFnZVByb3h5OjpWaWV3SXNJbldpbmRvdyk7CiB9CiAK K3ZvaWQgV2ViVmlldzo6c2V0SXNWaXNpYmxlKGJvb2wgaXNWaXNpYmxlKQoreworICAgIG1faXNW aXNpYmxlID0gaXNWaXNpYmxlOworCisgICAgaWYgKG1fcGFnZSkKKyAgICAgICAgbV9wYWdlLT52 aWV3U3RhdGVEaWRDaGFuZ2UoV2ViUGFnZVByb3h5OjpWaWV3SXNWaXNpYmxlKTsKK30KKwogI2lm IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIAogdm9pZCBXZWJWaWV3OjplbnRlckFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdNb2RlKGNvbnN0IExheWVyVHJlZUNvbnRleHQmKQpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmgJKHJldmlzaW9uIDgzOTgwKQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTYw LDYgKzYwLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0UGFyZW50V2luZG93KEhXTkQpOwogICAg IHZvaWQgd2luZG93QW5jZXN0cnlEaWRDaGFuZ2UoKTsKICAgICB2b2lkIHNldElzSW5XaW5kb3co Ym9vbCk7CisgICAgdm9pZCBzZXRJc1Zpc2libGUoYm9vbCk7CiAgICAgdm9pZCBzZXRPdmVycmlk ZUN1cnNvcihIQ1VSU09SKTsKICAgICB2b2lkIHNldEluaXRpYWxGb2N1cyhib29sIGZvcndhcmQp OwogICAgIHZvaWQgc2V0U2Nyb2xsT2Zmc2V0T25OZXh0UmVzaXplKGNvbnN0IFdlYkNvcmU6Oklu dFNpemUmKTsK