58674 2011-04-15 10:53:00 -0700 JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations 2011-04-15 13:02:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned ap ddkilzer joepeck oldest_to_newest 386744 0 joepeck 2011-04-15 10:53:00 -0700 Possible JavaScript Allocation in the toJS call so we should take the JSLock beforehand: ScriptValue InjectedScriptHost::nodeAsScriptValue(ScriptState* state, Node* node) { return ScriptValue(state->globalData(), toJS(state, node)); } Path to follow. 386825 1 89829 joepeck 2011-04-15 12:34:06 -0700 Created attachment 89829 [PATCH] Proposed Fix 386830 2 89829 ddkilzer 2011-04-15 12:39:16 -0700 Comment on attachment 89829 [PATCH] Proposed Fix r=me 386856 3 joepeck 2011-04-15 13:02:25 -0700 <http://trac.webkit.org/changeset/84022> 89829 2011-04-15 12:34:06 -0700 2011-04-15 12:39:16 -0700 [PATCH] Proposed Fix patch.patch text/plain 1404 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNzY4MWVlLi4wMTVjMzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDQtMTUgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0xvY2sgQVNT RVJUIHNlZW4gb2Z0ZW4gd2hlbiB1c2luZyB0aGUgaW5zcGVjdG9yIGZvciBsb25nCisgICAgICAg IHBlcmlvZHMgb2YgdGltZS4gV2Ugc2hvdWxkIHRha2UgdGhlIEpTTG9jayB3aGVuZXZlciB3ZQor ICAgICAgICBtaWdodCBhbGxvY2F0ZSBtZW1vcnkgaW4gdGhlIEphdmFTY3JpcHQgSGVhcC4KKwor ICAgICAgICBKU0MgSW5qZWN0ZWRTY3JpcHRIb3N0Ojpub2RlQXNTY3JpcHRWYWx1ZSBzaG91bGQg dGFrZSBKU0xvY2sgYmVmb3JlIHBvc3NpYmxlIEphdmFTY3JpcHQgQWxsb2NhdGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4Njc0CisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0luamVjdGVkU2NyaXB0SG9zdEN1c3RvbS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbmplY3RlZFNjcmlwdEhvc3Q6Om5vZGVBc1NjcmlwdFZhbHVlKTogdGFrZSB0 aGUgSlNMb2NrLgorCiAyMDExLTA0LTEzICBYaWFvbWVpIEppICA8eGppQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luamVjdGVkU2NyaXB0SG9zdEN1c3RvbS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luamVjdGVkU2NyaXB0SG9zdEN1c3RvbS5jcHAKaW5k ZXggZDU2MjUxZi4uMjQ1MzIxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNJbmplY3RlZFNjcmlwdEhvc3RDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTSW5qZWN0ZWRTY3JpcHRIb3N0Q3VzdG9tLmNwcApAQCAtNzAsNiArNzAsNyBA QCBOb2RlKiBJbmplY3RlZFNjcmlwdEhvc3Q6OnNjcmlwdFZhbHVlQXNOb2RlKFNjcmlwdFZhbHVl IHZhbHVlKQogCiBTY3JpcHRWYWx1ZSBJbmplY3RlZFNjcmlwdEhvc3Q6Om5vZGVBc1NjcmlwdFZh bHVlKFNjcmlwdFN0YXRlKiBzdGF0ZSwgTm9kZSogbm9kZSkKIHsKKyAgICBKU0xvY2sgbG9jayhT aWxlbmNlQXNzZXJ0aW9uc09ubHkpOwogICAgIHJldHVybiBTY3JpcHRWYWx1ZShzdGF0ZS0+Z2xv YmFsRGF0YSgpLCB0b0pTKHN0YXRlLCBub2RlKSk7CiB9CiAK