58670 2011-04-15 10:12:52 -0700 hide unused static function when SKIA_GPU is enabled 2011-04-15 18:19:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 reed reed abarth commit-queue darin eric kbr webkit.review.bot oldest_to_newest 386705 0 reed 2011-04-15 10:12:52 -0700 hide unused static function when SKIA_GPU is enabled 386707 1 89801 reed 2011-04-15 10:14:01 -0700 Created attachment 89801 Patch 386708 2 reed 2011-04-15 10:15:42 -0700 This local function is not referenced when SKIA_GPU is enabled, and so we get a warning (which we treat as an error). This is just to address that warning: there is no functional change. 386785 3 89801 commit-queue 2011-04-15 11:46:41 -0700 Comment on attachment 89801 Patch Rejecting attachment 89801 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8459206 386806 4 kbr 2011-04-15 12:09:14 -0700 This actually landed as http://trac.webkit.org/changeset/84000 , but the update of the bug failed. Closing it manually. 387118 5 webkit.review.bot 2011-04-15 18:19:18 -0700 http://trac.webkit.org/changeset/84000 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-82-t.svg 89801 2011-04-15 10:14:01 -0700 2011-04-15 12:09:24 -0700 Patch bug-58670-20110415131400.patch text/plain 1502 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTUgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBoaWRlIHVudXNlZCBzdGF0aWMgZnVuY3Rpb24gd2hlbiBTS0lBX0dQVSBp cyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01ODY3MAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSnVzdCBmaXhlcyBhIHdhcm5pbmcgKHRy ZWF0ZWQgYXMgYW4gZXJyb3IpIHdoZW4gU0tJQV9HUFUgaXMgZW5hYmxlZAorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwOgorCiAyMDExLTA0LTE1ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0 YWNob3dpYWsuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0lt YWdlU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9JbWFnZVNraWEuY3BwCShyZXZpc2lvbiA4Mzk2MSkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NjYsNiArNjYsNyBAQCBlbnVtIFJlc2FtcGxpbmdNb2RlIHsKICAgICBSRVNBTVBMRV9BV0VTT01F LAogfTsKIAorI2lmICFFTkFCTEUoU0tJQV9HUFUpCiBzdGF0aWMgUmVzYW1wbGluZ01vZGUgY29t cHV0ZVJlc2FtcGxpbmdNb2RlKFBsYXRmb3JtQ29udGV4dFNraWEqIHBsYXRmb3JtQ29udGV4dCwg Y29uc3QgTmF0aXZlSW1hZ2VTa2lhJiBiaXRtYXAsIGludCBzcmNXaWR0aCwgaW50IHNyY0hlaWdo dCwgZmxvYXQgZGVzdFdpZHRoLCBmbG9hdCBkZXN0SGVpZ2h0KQogewogICAgIGlmIChwbGF0Zm9y bUNvbnRleHQtPmhhc0ltYWdlUmVzYW1wbGluZ0hpbnQoKSkgewpAQCAtMTUwLDYgKzE1MSw3IEBA IHN0YXRpYyBSZXNhbXBsaW5nTW9kZSBjb21wdXRlUmVzYW1wbGluZ00KICAgICAKICAgICByZXR1 cm4gUkVTQU1QTEVfTElORUFSOwogfQorI2VuZGlmCiAKIC8vIERyYXdzIHRoZSBnaXZlbiBiaXRt YXAgdG8gdGhlIGdpdmVuIGNhbnZhcy4gVGhlIHN1YnNldCBvZiB0aGUgc291cmNlIGJpdG1hcAog Ly8gaWRlbnRpZmllZCBieSBzcmNfcmVjdCBpcyBkcmF3biB0byB0aGUgZ2l2ZW4gZGVzdGluYXRp b24gcmVjdC4gVGhlIGJpdG1hcAo=