58667 2011-04-15 08:38:53 -0700 [GTK] editing/selection/select-out-of-editable.html failing after r83967 2011-05-02 09:23:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 svillar mrobinson mrobinson oldest_to_newest 386644 0 svillar 2011-04-15 08:38:53 -0700 The diff: --- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt 2011-04-15 07:06:09.978467441 -0700 +++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt 2011-04-15 07:06:09.959742392 -0700 @@ -1,4 +1,4 @@ hello world -Dragging to the left: PASS -Dragging to the left: PASS +Dragging to the left: FAIL - expected 0 but got 7 +Dragging to the left: FAIL - expected 11 but got 10 I'll skip it for the moment. 386653 1 svillar 2011-04-15 08:45:26 -0700 Committed r83979: <http://trac.webkit.org/changeset/83979> 389502 2 mrobinson 2011-04-20 14:02:58 -0700 The issue here seems to be that triggering another mouseDown event while the mouse button is already down can interfere with drags in Xvfb. 389504 3 90406 mrobinson 2011-04-20 14:04:05 -0700 Created attachment 90406 Patch 392619 4 90406 xan.lopez 2011-04-26 12:02:43 -0700 Comment on attachment 90406 Patch We need to check that the button we are getting now is the same one that was already pressed. 393422 5 91249 mrobinson 2011-04-27 00:45:58 -0700 Created attachment 91249 Updated patch with improved ChangeLog 393424 6 mrobinson 2011-04-27 00:46:56 -0700 (In reply to comment #4) > (From update of attachment 90406 [details]) > We need to check that the button we are getting now is the same one that was already pressed. Thanks for the review. I've updated the patch to allow consecutive mouse down events from different buttons and verified that it passes Daniel's test for this issue.(In reply to comment #0) > The diff: > > --- /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-expected.txt 2011-04-15 07:06:09.978467441 -0700 > +++ /home/slave/webkitgtk/gtk-linux-32-debug/build/layout-test-results/editing/selection/select-out-of-editable-actual.txt 2011-04-15 07:06:09.959742392 -0700 > @@ -1,4 +1,4 @@ > hello world > -Dragging to the left: PASS > -Dragging to the left: PASS > +Dragging to the left: FAIL - expected 0 but got 7 > +Dragging to the left: FAIL - expected 11 but got 10 > > I'll skip it for the moment. 396058 7 91249 eric 2011-05-01 14:52:29 -0700 Comment on attachment 91249 Updated patch with improved ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=91249&action=review > Tools/DumpRenderTree/gtk/EventSender.cpp:65 > +static unsigned int buttonCurrentlyDown; unsigned is all you need, not "int". 396405 8 91249 mrobinson 2011-05-02 09:23:15 -0700 Comment on attachment 91249 Updated patch with improved ChangeLog Clearing flags on attachment: 91249 Committed r85481: <http://trac.webkit.org/changeset/85481> 396406 9 mrobinson 2011-05-02 09:23:18 -0700 All reviewed patches have been landed. Closing bug. 90406 2011-04-20 14:04:05 -0700 2011-04-27 00:45:40 -0700 Patch bug-58667-20110420140406.patch text/plain 2975 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODQzNzgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyYzdjNjJiODcwZGMwM2Y3NDJhMjdh OWNmNTdmZTg0MzMxZTk0ODQ3Li5iN2ViNWZmMDdiZTAxZGEwZjk4N2JjN2UyOGFjYzdhYTJjMjlk MzA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDQtMjAgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHVEtdIGVkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1vdXQtb2YtZWRp dGFibGUuaHRtbCBmYWlsaW5nIGFmdGVyIHI4Mzk2NworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2NjcKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9T a2lwcGVkOiBVbnNraXAgYSB0ZXN0IHdoaWNoIGlzIG5vdyBwYXNzaW5nLgorCisyMDExLTA0LTIw ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAgICBwbGF0 Zm9ybS9ndGsvZmFzdC9kb20vZ2MtMTAtZXhwZWN0ZWQucG5nIGlzIGNvcnJ1cHQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4OTQwCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1NraXBwZWQKaW5kZXggMDU4ZmQ1ZGY1ZjgyOTM2ZmNmYzFlZWYyODZkZTM5Y2NiODRj YmZkNS4uNWIzODZiMmM1NjBlYjA0YjgxNmJiZDA3Y2NjYTIxMTlkOWI1YmMxMCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKQEAgLTEzODcsOSArMTM4Nyw2IEBAIGZhc3QvZm9ybXMvaW5wdXQt bnVtYmVyLWxhcmdlLXBhZGRpbmcuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTgzMDkKIGZhc3QvY2FudmFzL0RyYXdJbWFnZVNpbmdsZVBpeGVsU3RyZXRj aC5odG1sCiAKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NjY3 Ci1lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3Qtb3V0LW9mLWVkaXRhYmxlLmh0bWwKLQogIyBRdW90 YSBBUEkgaXMgbm90IHN1cHBvcnRlZC4KIHN0b3JhZ2Uvc3RvcmFnZWluZm8tcXVlcnktdXNhZ2Uu aHRtbAogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggOTUwY2FhYjVjZmMxZWYzNjU0OTFmZjRiODViYzk0NmZhMDQ5ODdkNS4uN2U0YzE2YzhhYWI2 M2I3YTAxYzI0NmYyMjZjOThhNWM1YzE4ZjQ2MSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTIwICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBlZGl0aW5nL3NlbGVjdGlvbi9zZWxl Y3Qtb3V0LW9mLWVkaXRhYmxlLmh0bWwgZmFpbGluZyBhZnRlciByODM5NjcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NjY3CisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwOgorICAgICAgICAobW91c2VEb3duQ2Fs bGJhY2spOiBEbyBub3QgdHJpZ2dlciBhbm90aGVyIG1vdXNlIGJ1dHRvbiBkb3duIGV2ZW50IGlm IHRoZSBtb3VzZSBidXR0b24KKyAgICAgICAgaXMgYWxyZWFkeSBkb3duLiBUaGlzIGNhbiBpbnRl cmZlcmUgd2l0aCBkcmFncyBpbiBYdmZiLgorCiAyMDExLTA0LTIwICBBZGFtIFJvYmVuICA8YXJv YmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBsYWNlIG9sZC1ydW4td2Via2l0LXRlc3RzJ3Mg d2luLTcgcGxhdGZvcm0gd2l0aCB3aW4tN3NwMApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVu dFNlbmRlci5jcHAKaW5kZXggMDY4ZGQ1YTk3NzE4NGU3MDI4MDE1ZDIxMmQ0NzdiYTNiN2M0OGFh OS4uMTk4MmE2NDdjMjVmMmNiOGQyNDQ5MjRjNzJmOTRlMTllMWQ2ZDNhYiAxMDA2NDQKLS0tIGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCkBAIC0zMDQsNiArMzA0LDEwIEBAIHN0YXRp YyBndWludCBnZGtNb2RpZmVyc0Zyb21KU1ZhbHVlKEpTQ29udGV4dFJlZiBjb250ZXh0LCBjb25z dCBKU1ZhbHVlUmVmIG1vZGlmCiAKIHN0YXRpYyBKU1ZhbHVlUmVmIG1vdXNlRG93bkNhbGxiYWNr KEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwgSlNPYmplY3RSZWYg dGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVSZWYgYXJndW1l bnRzW10sIEpTVmFsdWVSZWYqIGV4Y2VwdGlvbikKIHsKKyAgICAvLyBJZiB0aGUgbW91c2UgaXMg YWxyZWFkeSBpbiB0aGUgZG93biBwb3NpdGlvbiBkb24ndCBzZW5kIGFub3RoZXIgZXZlbnQgYXMg aXQgbWF5IGNvbmZ1c2UgWHZmYi4KKyAgICBpZiAoYnV0dG9uQ3VycmVudGx5RG93bikKKyAgICAg ICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworCiAgICAgaW50IGJ1dHRv biA9IDA7CiAgICAgaWYgKGFyZ3VtZW50Q291bnQgPT0gMSkgewogICAgICAgICBidXR0b24gPSBz dGF0aWNfY2FzdDxpbnQ+KEpTVmFsdWVUb051bWJlcihjb250ZXh0LCBhcmd1bWVudHNbMF0sIGV4 Y2VwdGlvbikpOwo= 91249 2011-04-27 00:45:58 -0700 2011-05-02 09:23:14 -0700 Updated patch with improved ChangeLog bug-58667-20110427004556.patch text/plain 3325 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODUwMjcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNjk5NjJmODkwNzBmZTY4Y2U0ZjUw Y2FiNDI4NDhhOTQwOGM0Y2RlLi5iZTk4MjZlN2IxMmE1NjcwMDI4ZjFiNTVhZDE1NzcwNjQ1MmU3 YzEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMjcgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHVEtdIGVkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdC1vdXQtb2YtZWRp dGFibGUuaHRtbCBmYWlsaW5nIGFmdGVyIHI4Mzk2NworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2NjcKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9T a2lwcGVkOiBVbnNraXAgYSB0ZXN0IHdoaWNoIGlzIG5vdyBwYXNzaW5nLgorCiAyMDExLTA0LTI2 ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBJ bXByb3BlciByZW5kZXJpbmcgb2YgPGJ1dHRvbj4gdGFnIHdoZW4gaXQgY29udGFpbnMgYSA8YnI+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IGRiODM3NDRkNWUyMWU3YWZiZmNmM2NkZDVj NzMzY2QxNjg5ZTY0NzUuLjM0MmM3MjZkMGIzYWY1NzU1NjAyM2ViYTBjNDFhNjQ2YTY2OTQzMDQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC0xMzc1LDkgKzEzNzUsNiBAQCBmYXN0L2Zv cm1zL2lucHV0LW51bWJlci1sYXJnZS1wYWRkaW5nLmh0bWwKICMgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU4MzA5CiBmYXN0L2NhbnZhcy9EcmF3SW1hZ2VTaW5nbGVQ aXhlbFN0cmV0Y2guaHRtbAogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01ODY2NwotZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LW91dC1vZi1lZGl0YWJsZS5odG1s Ci0KICMgUXVvdGEgQVBJIGlzIG5vdCBzdXBwb3J0ZWQuCiBzdG9yYWdlL3N0b3JhZ2VpbmZvLXF1 ZXJ5LXVzYWdlLmh0bWwKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hh bmdlTG9nCmluZGV4IDFkZjYyNThlMmM4ZjlkMzZlZDVjMTRhNWY2NTM0NzE4NGI5YmE1OTQuLmM1 ZmQyOTdlMGJiNDM2ZWMxMzkwZDliMzM3OGJhNmY4MGQwZDY4MjAgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0w NC0yNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gZWRpdGluZy9zZWxl Y3Rpb24vc2VsZWN0LW91dC1vZi1lZGl0YWJsZS5odG1sIGZhaWxpbmcgYWZ0ZXIgcjgzOTY3Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODY2NworCisg ICAgICAgIERvIG5vdCB0cmlnZ2VyIG1vdXNlIGRvd24gZXZlbnRzIHdoZW4gdGhlIEV2ZW50U2Vu ZGVyIGtub3dzIHRoYXQgYSBtb3VzZSBidXR0b24gaXMKKyAgICAgICAgYWxyZWFkeSBkb3duLiBU aGVzZSB0eXBlIG9mIHNpdHVhdGlvbnMgY2FuIGNvbmZ1c2UgWHZmYiBhbmQgY2F1c2UgZHJhZ2dp bmcgZmFpbHVyZXMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIu Y3BwOgorICAgICAgICAobW91c2VEb3duQ2FsbGJhY2spOiBEbyBub3QgdHJpZ2dlciBhbm90aGVy IG1vdXNlIGJ1dHRvbiBkb3duIGV2ZW50IGlmIHRoZSBtb3VzZSBidXR0b24KKyAgICAgICAgaXMg YWxyZWFkeSBkb3duLiBUaGlzIGNhbiBpbnRlcmZlcmUgd2l0aCBkcmFncyBpbiBYdmZiLgorCiAy MDExLTA0LTI2ICBEYXZpZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2d0ay9FdmVudFNlbmRlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRT ZW5kZXIuY3BwCmluZGV4IGQ3ZTk5YjIxMGZjNTI5ZGFkMjk4NDVkZGEyYTBjNmU3YjNhNWRiODUu LjgyODQxNDEwNTNlYjM0YWU2MjA5ZTI1YWQwZjljZTI5ZTM4MzU3MmEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKKysrIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcApAQCAtNjIsNyArNjIsNyBAQCBzdGF0aWMgaW50 IGxhc3RDbGlja1Bvc2l0aW9uWDsKIHN0YXRpYyBpbnQgbGFzdENsaWNrUG9zaXRpb25ZOwogc3Rh dGljIGludCBsYXN0Q2xpY2tUaW1lT2Zmc2V0Owogc3RhdGljIGludCBsYXN0Q2xpY2tCdXR0b247 Ci1zdGF0aWMgaW50IGJ1dHRvbkN1cnJlbnRseURvd247CitzdGF0aWMgdW5zaWduZWQgaW50IGJ1 dHRvbkN1cnJlbnRseURvd247CiBzdGF0aWMgaW50IGNsaWNrQ291bnQ7CiBHZGtEcmFnQ29udGV4 dCogY3VycmVudERyYWdTb3VyY2VDb250ZXh0OwogCkBAIC0zMTUsNiArMzE1LDEwIEBAIHN0YXRp YyBKU1ZhbHVlUmVmIG1vdXNlRG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09i amVjdFJlZiBmdW5jdGlvbiwKICAgICBpZiAoIXByZXBhcmVNb3VzZUJ1dHRvbkV2ZW50KGV2ZW50 LCBidXR0b24sIG1vZGlmaWVycykpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5l ZChjb250ZXh0KTsKIAorICAgIC8vIElmIHRoZSBzYW1lIG1vdXNlIGJ1dHRvbiBpcyBhbHJlYWR5 IGluIHRoZSBkb3duIHBvc2l0aW9uIGRvbid0IHNlbmQgYW5vdGhlciBldmVudCBhcyBpdCBtYXkg Y29uZnVzZSBYdmZiLgorICAgIGlmIChidXR0b25DdXJyZW50bHlEb3duID09IGV2ZW50LT5idXR0 b24uYnV0dG9uKQorICAgICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7 CisKICAgICBidXR0b25DdXJyZW50bHlEb3duID0gZXZlbnQtPmJ1dHRvbi5idXR0b247CiAKICAg ICAvLyBOb3JtYWxseSBHREsgd2lsbCBzZW5kIGJvdGggR0RLX0JVVFRPTl9QUkVTUyBhbmQgR0RL XzJCVVRUT05fUFJFU1MgZm9yCg==