58651 2011-04-15 05:05:57 -0700 [Qt][Symbian] Need to export ViewportAttributes class 2011-04-15 09:20:24 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 1 nancy.piedra nancy.piedra commit-queue oldest_to_newest 386527 0 nancy.piedra 2011-04-15 05:05:57 -0700 On Symbian build for ARM it seems we need to export the ViewportAttributes class. Otherwise, we get linking errors. I will upload a patch soon. 386535 1 89771 nancy.piedra 2011-04-15 05:43:52 -0700 Created attachment 89771 Export ViewportAttributes class On Symbian, the ViewportAttributes class needs to be exported otherwise there will be linking errors. 386561 2 89771 laszlo.gombos 2011-04-15 06:40:53 -0700 Comment on attachment 89771 Export ViewportAttributes class r=me. 386667 3 commit-queue 2011-04-15 09:17:26 -0700 The commit-queue encountered the following flaky tests while processing attachment 89771: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch. 386668 4 89771 commit-queue 2011-04-15 09:20:21 -0700 Comment on attachment 89771 Export ViewportAttributes class Clearing flags on attachment: 89771 Committed r83982: <http://trac.webkit.org/changeset/83982> 386669 5 commit-queue 2011-04-15 09:20:24 -0700 All reviewed patches have been landed. Closing bug. 89771 2011-04-15 05:43:52 -0700 2011-04-15 09:20:21 -0700 Export ViewportAttributes class viewportattributes.diff text/plain 1212 nancy.piedra SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTYxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTUgIE5hbmN5IFBp ZWRyYSAgPG5hbmN5LnBpZWRyYUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XVtTeW1iaWFuXSBOZWVkIHRvIGV4cG9ydCBWaWV3 cG9ydEF0dHJpYnV0ZXMgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU4NjUxCisKKyAgICAgICAgT24gU3ltYmlhbiwgaWYgdGhlIFZpZXdwb3J0 QXR0cmlidXRlcyBjbGFzcyBpcyBub3QgZXhwb3J0ZWQgd2UgZ2V0CisgICAgICAgIGxpbmtpbmcg ZXJyb3JzLgorCisgICAgICAgIFNpbmNlIHRoaXMgaXMgYSBjb21waWxhdGlvbiBpc3N1ZSwgbm8g bmV3IHRlc3RzIGFkZGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmg6 CisKIDIwMTEtMDQtMTUgIEFubmEgQ2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5oCShyZXZpc2lvbiA4Mzg4NCkKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw3ICs0 OCw3IEBAIHB1YmxpYzoKICAgICAgICAgV2ViQWN0aW9uQ291bnQKICAgICB9OwogCi0gICAgY2xh c3MgVmlld3BvcnRBdHRyaWJ1dGVzIHsKKyAgICBjbGFzcyBRV0VCS0lUX0VYUE9SVCBWaWV3cG9y dEF0dHJpYnV0ZXMgewogICAgIHB1YmxpYzoKICAgICAgICAgVmlld3BvcnRBdHRyaWJ1dGVzKCk7 CiAgICAgICAgIFZpZXdwb3J0QXR0cmlidXRlcyhjb25zdCBRV0tQYWdlOjpWaWV3cG9ydEF0dHJp YnV0ZXMmIG90aGVyKTsK