58632 2011-04-14 22:28:24 -0700 REGRESSION(75137): directly composited images are double-drawn sometimes 2011-04-25 17:29:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://trac.webkit.org/export/83947/trunk/LayoutTests/compositing/direct-image-compositing.html InRadar P2 Normal --- 1 jamesr cmarrin cmarrin simon.fraser vangelis oldest_to_newest 386383 0 jamesr 2011-04-14 22:28:24 -0700 Load http://trac.webkit.org/export/83947/trunk/LayoutTests/compositing/direct-image-compositing.html in a WebKit nightly or chromium. The first, third, and last images render incorrectly until the window is resized - it appears that the image is composited on top of itself and so the semitranslucent parts of the image look too dark. Forcing a repaint of the root window (by resizing the window or whatnot) seems to fix it. I can't reproduce in Safari 5.0.4, so guessing that this regressed at some point. 386385 1 simon.fraser 2011-04-14 22:35:27 -0700 Would be good to know when this regressed. 386386 2 simon.fraser 2011-04-14 22:35:58 -0700 <rdar://problem/9289398> 386393 3 jamesr 2011-04-14 22:52:11 -0700 bisect-builds says http://trac.webkit.org/log/trunk/?rev=75294&stop_rev=74229 - sadly large range. 386410 4 jamesr 2011-04-14 23:36:57 -0700 Tighter range (using chromium continuous builds): http://trac.webkit.org/log/trunk/?rev=75164&stop_rev=74761. Perhaps http://trac.webkit.org/changeset/75137 ? 386639 5 simon.fraser 2011-04-15 08:30:51 -0700 That's possible. 386743 6 simon.fraser 2011-04-15 10:51:19 -0700 I narrowed this down to between r75123 and r75154. 386896 7 jamesr 2011-04-15 13:56:47 -0700 Confirmed that reverting 75137 locally fixes the bug. 391936 8 90959 cmarrin 2011-04-25 15:31:33 -0700 Created attachment 90959 Patch 391962 9 90959 jamesr 2011-04-25 15:45:37 -0700 Comment on attachment 90959 Patch It should be possible to construct a pixel test for this, right? 392054 10 cmarrin 2011-04-25 16:26:25 -0700 (In reply to comment #9) > (From update of attachment 90959 [details]) > It should be possible to construct a pixel test for this, right? You'd think. I tried and failed. Running in DRT doesn't show the error. I assume that's because DRT does funny rendering tricks to get a consistently sized window, which must change the ordering and avoid tickling the bug. Of course that might make my claim that https://bugs.webkit.org/show_bug.cgi?id=59352 would allow us to test this logic. 392156 11 cmarrin 2011-04-25 17:24:58 -0700 Committed r84856: <http://trac.webkit.org/changeset/84856> 392158 12 cmarrin 2011-04-25 17:29:38 -0700 (In reply to comment #10) > (In reply to comment #9) > > (From update of attachment 90959 [details] [details]) > > It should be possible to construct a pixel test for this, right? > > You'd think. I tried and failed. Running in DRT doesn't show the error. I assume that's because DRT does funny rendering tricks to get a consistently sized window, which must change the ordering and avoid tickling the bug. Of course that might make my claim that https://bugs.webkit.org/show_bug.cgi?id=59352 would allow us to test this logic. (to finish that sentence) That would make my claim that ... would allow us to test this logic suspect. There may be no practical way to do a good test for this bug. 90959 2011-04-25 15:31:33 -0700 2011-04-25 15:45:37 -0700 Patch bug-58632-20110425153133.patch text/plain 1959 cmarrin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0ODA0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDQtMjUgIENocmlzIE1h cnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04oNzUxMzcpOiBkaXJlY3RseSBjb21wb3NpdGVk IGltYWdlcyBhcmUgZG91YmxlLWRyYXduIHNvbWV0aW1lcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg2MzIKKworICAgICAgICBEZXBlbmRpbmcgb24g dGhlIG9yZGVyIG9mIG9wZXJhdGlvbnMgKGxheW91dCwgY3JlYXRpbmcgY29tcG9zaXRpbmcgCisg ICAgICAgIGxheWVycyBhbmQgY3JlYXRpbmcgc2ltcGxlIGltYWdlIGxheWVycykgYSBsYXllciBj YW4gaGF2ZSBib3RoIGltYWdlCisgICAgICAgIGNvbnRlbnQgYW5kIGhhdmUgbV9kcmF3c0NvbnRl bnQ9dHJ1ZS4gSW4gdGhpcyBjYXNlIDIgY29waWVzIG9mIHRoZSBpbWFnZQorICAgICAgICBhcmUg ZHJhd24gaW4gdGhlIGxheWVyLiBJZiB0aGUgaW1hZ2UgaGFzIGFscGhhLCBpdCBsb29rcyB3cm9u Zy4KKworICAgICAgICBJIGFkZGVkIGFuIHVwZGF0ZURyYXdzQ29udGVudCgpIGNhbGwgYWZ0ZXIg c2V0dGluZyB0aGUgaW1hZ2UgY29udGVudHMKKyAgICAgICAgdG8gbWFrZSBzdXJlIGl0J3MgY29y cmVjdC4KKworICAgICAgICBJIGNvdWxkbid0IGNyZWF0ZSBhIHRlc3QgY2FzZSB0aGF0IHNob3dz IHRoZSBwcm9ibGVtIGJlY2F1c2UgbGF5ZXJUcmVlQXNUZXh0KCkKKyAgICAgICAgZG9lc24ndCBl bWl0IGVub3VnaCBpbmZvIHRvIHNob3cgdGhpcyBsZXZlbCBvZiBkZXRhaWwuIEkndmUgb3BlbmVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTM1MiB0 byBmaXggdGhhdC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVJbWFnZUNvbnRl bnRzKToKKwogMjAxMS0wNC0yNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAJKHJldmlzaW9uIDg0NDMzKQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTk2Nyw2ICs5NjcsNyBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6dXBk YXRlSW1hZ2VDb250CiAKICAgICAvLyBUaGlzIGlzIGEgbm8tb3AgaWYgdGhlIGxheWVyIGRvZXNu J3QgaGF2ZSBhbiBpbm5lciBsYXllciBmb3IgdGhlIGltYWdlLgogICAgIG1fZ3JhcGhpY3NMYXll ci0+c2V0Q29udGVudHNUb0ltYWdlKGltYWdlKTsKKyAgICB1cGRhdGVEcmF3c0NvbnRlbnQoKTsK ICAgICAKICAgICAvLyBJbWFnZSBhbmltYXRpb24gaXMgImxhenkiLCBpbiB0aGF0IGl0IGF1dG9t YXRpY2FsbHkgc3RvcHMgdW5sZXNzIHNvbWVvbmUgaXMgZHJhd2luZwogICAgIC8vIHRoZSBpbWFn ZS4gU28gd2UgaGF2ZSB0byBraWNrIHRoZSBhbmltYXRpb24gZWFjaCB0aW1lOyB0aGlzIGhhcyB0 aGUgZG93bnNpZGUgdGhhdCB0aGUK