58621 2011-04-14 18:19:28 -0700 Update webglcontextlost / webglcontextrestored delivery to match spec changes 2011-07-21 14:43:19 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr amarinichev cmarrin jamesr senorblanco zmo oldest_to_newest 386256 0 kbr 2011-04-14 18:19:28 -0700 Based on feedback from Glenn Maynard, the WebGL spec was just updated to avoid side-effects of registering event handlers. Now, in order for webglcontextrestored to be delivered to the application, the developer must have registered a webglcontextlost handler, and that handler needs to call preventDefault() against the event object. WebKit's WebGL implementation needs to be updated to track this change, and ideally layout tests written using the WEBKIT_lose_context extension either created or updated. 440258 1 101556 kbr 2011-07-20 22:02:36 -0700 Created attachment 101556 Patch 440624 2 101556 jamesr 2011-07-21 13:39:44 -0700 Comment on attachment 101556 Patch OK 440643 3 kbr 2011-07-21 14:43:19 -0700 Committed r91504: <http://trac.webkit.org/changeset/91504> 101556 2011-07-20 22:02:36 -0700 2011-07-21 13:39:43 -0700 Patch bug-58621-20110720220235.patch text/plain 6568 kbr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNDQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMjAgIEtlbm5ldGgg UnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSB3ZWJnbGNvbnRleHRs b3N0IC8gd2ViZ2xjb250ZXh0cmVzdG9yZWQgZGVsaXZlcnkgdG8gbWF0Y2ggc3BlYyBjaGFuZ2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODYyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQg Y29uZGl0aW9ucyB1bmRlciB3aGljaCB3ZWJnbGNvbnRleHRyZXN0b3JlZCBldmVudCBpcworICAg ICAgICBkZWxpdmVyZWQgdG8gYmUgc3BlYyBjb21wbGlhbnQuCisKKyAgICAgICAgKiBodG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xS ZW5kZXJpbmdDb250ZXh0OjpXZWJHTFJlbmRlcmluZ0NvbnRleHQpOgorICAgICAgICAoV2ViQ29y ZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojpsb3NlQ29udGV4dCk6CisgICAgICAgIChXZWJDb3Jl OjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6Om1heWJlUmVzdG9yZUNvbnRleHQpOgorICAgICAgICAq IGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oOgorCiAyMDExLTA3LTIwICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENocm9taXVtIGJ1aWxkIGZp eCBhZnRlciByOTE0NDAuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAJKHJldmlzaW9uIDkxNDQzKQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzc3LDYgKzM3Nyw3IEBAIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6V2ViR0xSZW5k ZXJpbmdDb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdy YXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMpCiAgICAgOiBDYW52YXNSZW5k ZXJpbmdDb250ZXh0KHBhc3NlZENhbnZhcykKICAgICAsIG1fY29udGV4dChjb250ZXh0KQorICAg ICwgbV9yZXN0b3JlQWxsb3dlZChmYWxzZSkKICAgICAsIG1fcmVzdG9yZVRpbWVyKHRoaXMpCiAg ICAgLCBtX3ZpZGVvQ2FjaGUoNCkKICAgICAsIG1fY29udGV4dExvc3QoZmFsc2UpCkBAIC00NzY4 LDcgKzQ3NjksOSBAQCB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6bG9zZUNvbnRleHQoCiAg ICAgfQogICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0M0Q6 OkNPTlRFWFRfTE9TVF9XRUJHTCk7CiAKLSAgICBjYW52YXMoKS0+ZGlzcGF0Y2hFdmVudChXZWJH TENvbnRleHRFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRsb3N0RXZlbnQs IGZhbHNlLCB0cnVlLCAiIikpOworICAgIFJlZlB0cjxXZWJHTENvbnRleHRFdmVudD4gZXZlbnQg PSBXZWJHTENvbnRleHRFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRsb3N0 RXZlbnQsIGZhbHNlLCB0cnVlLCAiIik7CisgICAgY2FudmFzKCktPmRpc3BhdGNoRXZlbnQoZXZl bnQpOworICAgIG1fcmVzdG9yZUFsbG93ZWQgPSBldmVudC0+ZGVmYXVsdFByZXZlbnRlZCgpOwog fQogCiB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6bWF5YmVSZXN0b3JlQ29udGV4dChXZWJH TFJlbmRlcmluZ0NvbnRleHQ6Okxvc3RDb250ZXh0TW9kZSBtb2RlKQpAQCAtNDc3OSwxMCArNDc4 Miw5IEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0OjptYXliZVJlc3RvcmUKICAgICAgICAg cmV0dXJuOwogICAgIH0KIAotICAgIC8vIFRoZSByZW5kZXJpbmcgY29udGV4dCBpcyBub3QgcmVz dG9yZWQgaWYgdGhlcmUgaXMgbm8gaGFuZGxlciBmb3IgdGhlCi0gICAgLy8gY29udGV4dCByZXN0 b3JlZCBldmVudC4gKEZJWE1FOiB0aGlzIGlzIG5vdCBzcGVjIGNvbXBsaWFudC4gQSBmb2xsb3ct b24KLSAgICAvLyBwYXRjaCB3aWxsIGJyaW5nIHRoaXMgdG8gc3BlYyBjb21wbGlhbmNlLikKLSAg ICBpZiAoIWNhbnZhcygpLT5oYXNFdmVudExpc3RlbmVycyhldmVudE5hbWVzKCkud2ViZ2xjb250 ZXh0cmVzdG9yZWRFdmVudCkpIHsKKyAgICAvLyBUaGUgcmVuZGVyaW5nIGNvbnRleHQgaXMgbm90 IHJlc3RvcmVkIHVubGVzcyB0aGUgZGVmYXVsdAorICAgIC8vIGJlaGF2aW9yIG9mIHRoZSB3ZWJn bGNvbnRleHRsb3N0IGV2ZW50IHdhcyBwcmV2ZW50ZWQgZWFybGllci4KKyAgICBpZiAoIW1fcmVz dG9yZUFsbG93ZWQpIHsKICAgICAgICAgaWYgKG1vZGUgPT0gU3ludGhldGljTG9zdENvbnRleHQp CiAgICAgICAgICAgICBtX2NvbnRleHQtPnN5bnRoZXNpemVHTEVycm9yKEdyYXBoaWNzQ29udGV4 dDNEOjpJTlZBTElEX09QRVJBVElPTik7CiAgICAgICAgIHJldHVybjsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oCShyZXZp c2lvbiA5MTQ0MykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNjMsNiArMzYzLDcgQEAgcHVibGljOgogICAg ICAgICBXZWJHTFJlbmRlcmluZ0NvbnRleHQqIG1fY29udGV4dDsKICAgICB9OwogCisgICAgYm9v bCBtX3Jlc3RvcmVBbGxvd2VkOwogICAgIFdlYkdMUmVuZGVyaW5nQ29udGV4dFJlc3RvcmVUaW1l ciBtX3Jlc3RvcmVUaW1lcjsKIAogICAgIGJvb2wgbV9uZWVkc1VwZGF0ZTsKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDkxNDQzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFVwZGF0ZSB3ZWJnbGNvbnRleHRsb3N0IC8gd2ViZ2xjb250ZXh0cmVz dG9yZWQgZGVsaXZlcnkgdG8gbWF0Y2ggc3BlYyBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODYyMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgbGF5b3V0IHRlc3QgdG8gdGVzdCBz cGVjIGNvbXBsaWFudCBiZWhhdmlvci4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2Nv bnRleHQtbG9zdC1yZXN0b3JlZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jYW52YXMv d2ViZ2wvY29udGV4dC1sb3N0LXJlc3RvcmVkLmh0bWw6CisKIDIwMTEtMDctMjAgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGNyYXNoIGV4cGVjdGF0aW9u IHRvIGZhc3QvY2FudmFzL3dlYmdsL3JlbmRlcmJ1ZmZlci1pbml0aWFsaXphdGlvbi5odG1sIG9u IENocm9taXVtIFdpbmRvd3MsCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9j b250ZXh0LWxvc3QtcmVzdG9yZWQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvY2FudmFzL3dlYmdsL2NvbnRleHQtbG9zdC1yZXN0b3JlZC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDkxNDQzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvY29udGV4 dC1sb3N0LXJlc3RvcmVkLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAs NyBAQCBQQVNTIGdsLmJpbmRUZXh0dXJlKGdsLlRFWFRVUkVfMkQsIHRleHR1CiBQQVNTIGdsLnVz ZVByb2dyYW0ocHJvZ3JhbSkgd2FzIGV4cGVjdGVkIHZhbHVlOiBOT19FUlJPUi4KIFBBU1MgZ2wu YmluZEJ1ZmZlcihnbC5BUlJBWV9CVUZGRVIsIGJ1ZmZlck9iamVjdHNbMF0pIHdhcyBleHBlY3Rl ZCB2YWx1ZTogTk9fRVJST1IuCiAKK1BBU1MgZXh0ZW5zaW9uLnJlc3RvcmVDb250ZXh0KCkgd2Fz IGV4cGVjdGVkIHZhbHVlOiBOT19FUlJPUi4KIAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQogCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9jb250ZXh0LWxvc3Qt cmVzdG9yZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJn bC9jb250ZXh0LWxvc3QtcmVzdG9yZWQuaHRtbAkocmV2aXNpb24gOTE0NDMpCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9jb250ZXh0LWxvc3QtcmVzdG9yZWQuaHRtbAkod29ya2lu ZyBjb3B5KQpAQCAtMTUsNiArMTUsNyBAQCB2YXIgYnVmZmVyT2JqZWN0czsKIHZhciBwcm9ncmFt OwogdmFyIHRleHR1cmU7CiB2YXIgdGV4Q29sb3IgPSBbMjU1LCAxMCwgMjAsIDI1NV07Cit2YXIg YWxsb3dSZXN0b3JlOwogCiBmdW5jdGlvbiBpbml0KCkKIHsKQEAgLTU4LDEwICs1OSwxMSBAQCBm dW5jdGlvbiB0ZXN0TG9zaW5nQ29udGV4dCgpCiAgICAgZGVidWcoIlRlc3QgbG9zaW5nIGEgY29u dGV4dCBhbmQgaW5hYmlsaXR5IHRvIHJlc3RvcmUgaXQuIik7CiAKICAgICBjYW52YXMuYWRkRXZl bnRMaXN0ZW5lcigid2ViZ2xjb250ZXh0bG9zdCIsIHRlc3RMb3N0Q29udGV4dCk7CisgICAgY2Fu dmFzLmFkZEV2ZW50TGlzdGVuZXIoIndlYmdsY29udGV4dHJlc3RvcmVkIiwgdGVzdFNob3VsZE5v dFJlc3RvcmVDb250ZXh0KTsKKyAgICBhbGxvd1Jlc3RvcmUgPSBmYWxzZTsKIAogICAgIHRlc3RP cmlnaW5hbENvbnRleHQoKTsKICAgICBleHRlbnNpb24ubG9zZUNvbnRleHQoKTsKLSAgICAvLyBG SVhNRTogdGhpcyBpc24ndCB5ZXQgc3BlYyBjb21wbGlhbnQuCiAgICAgc2hvdWxkR2VuZXJhdGVH TEVycm9yKGdsLCBnbC5JTlZBTElEX09QRVJBVElPTiwgImV4dGVuc2lvbi5yZXN0b3JlQ29udGV4 dCgpIik7CiAgICAgZGVidWcoIiIpOwogfQpAQCAtNzUsMTAgKzc3LDExIEBAIGZ1bmN0aW9uIHRl c3RMb3NpbmdBbmRSZXN0b3JpbmdDb250ZXh0KCkKIAogICAgIGNhbnZhcy5hZGRFdmVudExpc3Rl bmVyKCJ3ZWJnbGNvbnRleHRsb3N0IiwgdGVzdExvc3RDb250ZXh0KTsKICAgICBjYW52YXMuYWRk RXZlbnRMaXN0ZW5lcigid2ViZ2xjb250ZXh0cmVzdG9yZWQiLCB0ZXN0UmVzdG9yZWRDb250ZXh0 KTsKKyAgICBhbGxvd1Jlc3RvcmUgPSB0cnVlOwogCiAgICAgdGVzdE9yaWdpbmFsQ29udGV4dCgp OwogICAgIGV4dGVuc2lvbi5sb3NlQ29udGV4dCgpOwotICAgIGV4dGVuc2lvbi5yZXN0b3JlQ29u dGV4dCgpOworICAgIHNob3VsZEdlbmVyYXRlR0xFcnJvcihnbCwgZ2wuTk9fRVJST1IsICJleHRl bnNpb24ucmVzdG9yZUNvbnRleHQoKSIpOwogICAgIGRlYnVnKCIiKTsKIH0KIApAQCAtMTEwLDEz ICsxMTMsMjEgQEAgZnVuY3Rpb24gdGVzdE9yaWdpbmFsQ29udGV4dCgpCiAgICAgZGVidWcoIiIp OwogfQogCi1mdW5jdGlvbiB0ZXN0TG9zdENvbnRleHQoKQorZnVuY3Rpb24gdGVzdExvc3RDb250 ZXh0KGUpCiB7CiAgICAgZGVidWcoIlRlc3QgbG9zdCBjb250ZXh0Iik7CiAgICAgc2hvdWxkQmVU cnVlKCJnbC5pc0NvbnRleHRMb3N0KCkiKTsKICAgICBzaG91bGRCZSgiZ2wuZ2V0RXJyb3IoKSIs ICJnbC5DT05URVhUX0xPU1RfV0VCR0wiKTsKICAgICBzaG91bGRCZSgiZ2wuZ2V0RXJyb3IoKSIs ICJnbC5OT19FUlJPUiIpOwogICAgIGRlYnVnKCIiKTsKKyAgICBpZiAoYWxsb3dSZXN0b3JlKQor ICAgICAgICBlLnByZXZlbnREZWZhdWx0KCk7Cit9CisKK2Z1bmN0aW9uIHRlc3RTaG91bGROb3RS ZXN0b3JlQ29udGV4dChlKQoreworICAgIHRlc3RGYWlsZWQoIlNob3VsZCBub3QgcmVzdG9yZSB0 aGUgY29udGV4dCB1bmxlc3MgcHJldmVudERlZmF1bHQgaXMgY2FsbGVkIG9uIHRoZSBjb250ZXh0 IGxvc3QgZXZlbnQiKTsKKyAgICBkZWJ1ZygiIik7CiB9CiAKIGZ1bmN0aW9uIHRlc3RSZXNvdXJj ZXMoZXhwZWN0ZWQpCg==