58595 2011-04-14 16:01:07 -0700 Menu is not displayed for <input type=search results="5"> 2011-04-14 16:13:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 386142 0 beidson 2011-04-14 16:01:07 -0700 Menu is not displayed for <input type=search results="5"> The primary cause of the menu not even displaying is the WebSearchPopupMenu returned "false" for enabled. That's a 1-liner. I also included Mac-only code to get the Mac position correct. Note that my planned fix for this won't actually implement setting/restoring the past searches - that's a logically separate task I'll track with another bug. In radar as <rdar://problem/8665102> 386147 1 beidson 2011-04-14 16:02:55 -0700 Adding the results memory is tracked in https://bugs.webkit.org/show_bug.cgi?id=58596 386148 2 89678 beidson 2011-04-14 16:05:29 -0700 Created attachment 89678 Patch v1 386152 3 beidson 2011-04-14 16:13:43 -0700 r83909 89678 2011-04-14 16:05:29 -0700 2011-04-14 16:08:50 -0700 Patch v1 patch.txt text/plain 5662 beidson SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTA2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDQtMTQgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NjY1MTAyPiBhbmQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NTk1CisgICAgICAgIE1lbnUgaXMgbm90 IGRpc3BsYXllZCBmb3IgPGlucHV0IHR5cGU9c2VhcmNoIHJlc3VsdHM9IjUiPgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJTZWFyY2hQb3B1cE1lbnUuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJTZWFyY2hQb3B1cE1lbnU6OmVuYWJsZWQpOiBSZXR1cm4gdHJ1ZSwg bGlrZSBhbGwgZ29vZCBzZWFyY2ggcG9wdXAgbWVudXMgc2hvdWxkLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViUG9wdXBNZW51TWFjLm1tOgorICAgICAgICAo V2ViS2l0OjpXZWJQb3B1cE1lbnU6OnNldFVwUGxhdGZvcm1EYXRhKTogUmVtZW1iZXIgdGhlIHNo b3VsZFBvcE92ZXItbmVzcy4KKworICAgICAgICAqIFNoYXJlZC9QbGF0Zm9ybVBvcHVwTWVudURh dGEuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9ybVBvcHVwTWVudURhdGE6OmVuY29kZSk6 IFJlbWVtYmVyIHRoZSBzaG91bGRQb3BPdmVyLW5lc3MuCisgICAgICAgIChXZWJLaXQ6OlBsYXRm b3JtUG9wdXBNZW51RGF0YTo6ZGVjb2RlKTogUmVtZW1iZXIgdGhlIHNob3VsZFBvcE92ZXItbmVz cy4KKyAgICAgICAgKiBTaGFyZWQvUGxhdGZvcm1Qb3B1cE1lbnVEYXRhLmg6CisKKyAgICAgICAg KiBVSVByb2Nlc3MvbWFjL1dlYlBvcHVwTWVudVByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJQb3B1cE1lbnVQcm94eU1hYzo6c2hvd1BvcHVwTWVudSk6IFVzZSB0aGUgc2hvdWxkUG9w T3Zlci1uZXNzIHRvIGFkanVzdCBkaXNwbGF5IHBvc2l0aW9uLgorCiAyMDExLTA0LTE0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFuIEJlcm5zdGVpbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbGF0Zm9ybVBvcHVw TWVudURhdGEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbGF0Zm9y bVBvcHVwTWVudURhdGEuY3BwCShyZXZpc2lvbiA4Mzg5NSkKKysrIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9QbGF0Zm9ybVBvcHVwTWVudURhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSw2ICs2 MSw3IEBAIHZvaWQgUGxhdGZvcm1Qb3B1cE1lbnVEYXRhOjplbmNvZGUoQ29yZUkKICAgICBlbmNv ZGVyLT5lbmNvZGUoc2VsZWN0ZWRCYWNraW5nU3RvcmVIYW5kbGUpOwogI2VsaWYgUExBVEZPUk0o TUFDKQogICAgIGVuY29kZXItPmVuY29kZShmb250SW5mbyk7CisgICAgZW5jb2Rlci0+ZW5jb2Rl KHNob3VsZFBvcE92ZXIpOwogI2VuZGlmCiB9CiAKQEAgLTkyLDYgKzkzLDggQEAgYm9vbCBQbGF0 Zm9ybVBvcHVwTWVudURhdGE6OmRlY29kZShDb3JlSQogI2VsaWYgUExBVEZPUk0oTUFDKQogICAg IGlmICghZGVjb2Rlci0+ZGVjb2RlKGRhdGEuZm9udEluZm8pKQogICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoZGF0YS5zaG91bGRQb3BPdmVyKSkKKyAgICAg ICAgcmV0dXJuIGZhbHNlOwogI2VuZGlmCiAgICAgCiAgICAgcmV0dXJuIHRydWU7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGxhdGZvcm1Qb3B1cE1lbnVEYXRhLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1BsYXRmb3JtUG9wdXBNZW51RGF0YS5oCShyZXZpc2lv biA4Mzg5NSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbGF0Zm9ybVBvcHVwTWVudURhdGEu aAkod29ya2luZyBjb3B5KQpAQCAtNTQsNiArNTQsNyBAQCBzdHJ1Y3QgUGxhdGZvcm1Qb3B1cE1l bnVEYXRhIHsKICAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBtX3NlbGVjdGVkQmFja2luZ1N0 b3JlOwogI2VsaWYgUExBVEZPUk0oTUFDKQogICAgIEZvbnRJbmZvIGZvbnRJbmZvOworICAgIGJv b2wgc2hvdWxkUG9wT3ZlcjsKICNlbmRpZgogfTsKIApJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XZWJQb3B1cE1lbnVQcm94eU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYlBvcHVwTWVudVByb3h5TWFjLm1tCShyZXZpc2lvbiA4 Mzg5NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViUG9wdXBNZW51UHJveHlN YWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwOCwxMSArMTA4LDE3IEBAIHZvaWQgV2ViUG9wdXBN ZW51UHJveHlNYWM6OnNob3dQb3B1cE1lbnUKIAogICAgIC8vIFRoZXNlIHZhbHVlcyB3ZXJlIGJv cnJvd2VkIGZyb20gQXBwS2l0IHRvIG1hdGNoIHRoZWlyIHBsYWNlbWVudCBvZiB0aGUgbWVudS4K ICAgICBjb25zdCBpbnQgcG9wT3Zlckhvcml6b250YWxBZGp1c3QgPSAtMTA7Ci0gICAgTlNSZWN0 IHRpdGxlRnJhbWUgPSBbbV9wb3B1cC5nZXQoKSAgdGl0bGVSZWN0Rm9yQm91bmRzOnJlY3RdOwot ICAgIGlmICh0aXRsZUZyYW1lLnNpemUud2lkdGggPD0gMCB8fCB0aXRsZUZyYW1lLnNpemUuaGVp Z2h0IDw9IDApCi0gICAgICAgIHRpdGxlRnJhbWUgPSByZWN0OwotICAgIGZsb2F0IHZlcnRPZmZz ZXQgPSByb3VuZGYoKE5TTWF4WShyZWN0KSAtIE5TTWF4WSh0aXRsZUZyYW1lKSkgKyBOU0hlaWdo dCh0aXRsZUZyYW1lKSk7Ci0gICAgTlNQb2ludCBsb2NhdGlvbiA9IE5TTWFrZVBvaW50KE5TTWlu WChyZWN0KSArIHBvcE92ZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocmVjdCkgLSB2ZXJ0T2Zm c2V0KTsKKyAgICBjb25zdCBpbnQgcG9wVW5kZXJIb3Jpem9udGFsQWRqdXN0ID0gNjsKKyAgICBj b25zdCBpbnQgcG9wVW5kZXJWZXJ0aWNhbEFkanVzdCA9IDY7CisgICAgTlNQb2ludCBsb2NhdGlv bjsKKyAgICBpZiAoZGF0YS5zaG91bGRQb3BPdmVyKSB7CisgICAgICAgIE5TUmVjdCB0aXRsZUZy YW1lID0gW21fcG9wdXAuZ2V0KCkgIHRpdGxlUmVjdEZvckJvdW5kczpyZWN0XTsKKyAgICAgICAg aWYgKHRpdGxlRnJhbWUuc2l6ZS53aWR0aCA8PSAwIHx8IHRpdGxlRnJhbWUuc2l6ZS5oZWlnaHQg PD0gMCkKKyAgICAgICAgICAgIHRpdGxlRnJhbWUgPSByZWN0OworICAgICAgICBmbG9hdCB2ZXJ0 T2Zmc2V0ID0gcm91bmRmKChOU01heFkocmVjdCkgLSBOU01heFkodGl0bGVGcmFtZSkpICsgTlNI ZWlnaHQodGl0bGVGcmFtZSkpOworICAgICAgICBsb2NhdGlvbiA9IE5TTWFrZVBvaW50KE5TTWlu WChyZWN0KSArIHBvcE92ZXJIb3Jpem9udGFsQWRqdXN0LCBOU01heFkocmVjdCkgLSB2ZXJ0T2Zm c2V0KTsKKyAgICB9IGVsc2UKKyAgICAgICAgbG9jYXRpb24gPSBOU01ha2VQb2ludChOU01pblgo cmVjdCkgKyBwb3BVbmRlckhvcml6b250YWxBZGp1c3QsIE5TTWF4WShyZWN0KSArIHBvcFVuZGVy VmVydGljYWxBZGp1c3QpOyAgCiAKICAgICBSZXRhaW5QdHI8TlNWaWV3PiBkdW1teVZpZXcoQWRv cHROUywgW1tOU1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6cmVjdF0pOwogICAgIFttX3dlYlZp ZXcgYWRkU3VidmlldzpkdW1teVZpZXcuZ2V0KCldOwpJbmRleDogU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJTZWFyY2hQb3B1cE1lbnUuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViU2VhcmNoUG9w dXBNZW51LmNwcAkocmV2aXNpb24gODM4OTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L1dlYlNlYXJjaFBvcHVwTWVudS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEsNiArMSw2IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDEwIE5va2lhIENvcnBvcmF0aW9u IGFuZC9vciBpdHMgc3Vic2lkaWFyeSgtaWVzKS4KLSAqIENvcHlyaWdodCAoQykgMjAxMCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAsIDIwMTEg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFRoaXMgbGlicmFyeSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqIG1vZGlmeSBp dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC01 Miw3ICs1Miw3IEBAIHZvaWQgV2ViU2VhcmNoUG9wdXBNZW51Ojpsb2FkUmVjZW50U2VhcmMKIAog Ym9vbCBXZWJTZWFyY2hQb3B1cE1lbnU6OmVuYWJsZWQoKQogewotICAgIHJldHVybiBmYWxzZTsK KyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9XZWJQb3B1cE1lbnVNYWMu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9tYWMvV2ViUG9wdXBNZW51TWFjLm1tCShyZXZpc2lvbiA4Mzg5NSkKKysrIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYlBvcHVwTWVudU1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTAgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEwLCAyMDEx IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucwpAQCAtNDYsNiArNDYsNyBAQCB2b2lkIFdlYlBvcHVwTWVudTo6c2V0VXBQbGF0Zm9y bURhdGEoY29uCiAgICAgICAgIHJldHVybjsKICAgICAKICAgICBkYXRhLmZvbnRJbmZvLmZvbnRB dHRyaWJ1dGVEaWN0aW9uYXJ5ID0gZm9udERlc2NyaXB0b3JBdHRyaWJ1dGVzOworICAgIGRhdGEu c2hvdWxkUG9wT3ZlciA9IG1fcG9wdXBDbGllbnQtPnNob3VsZFBvcE92ZXIoKTsKIH0KIAogfSAv LyBuYW1lc3BhY2UgV2ViS2l0Cg==