58592 2011-04-14 15:57:23 -0700 WebKit2: Need a way to keep the WebProcess alive for testing purposes 2011-04-15 10:43:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin beidson jberlin sam oldest_to_newest 386137 0 jberlin 2011-04-14 15:57:23 -0700 <rdar://problem/9278779> 386157 1 89679 jberlin 2011-04-14 16:22:20 -0700 Created attachment 89679 Patch 386180 2 89679 bweinstein 2011-04-14 16:50:20 -0700 Comment on attachment 89679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89679&action=review I feel like everywhere this should be webProcessCanTerminate instead of webProcessCanTerminateEarly. > Source/WebKit2/UIProcess/WebContext.cpp:267 > + m_webProcessCanTerminateEarly = allowed; Is an early return if allowed == m_webProcessCanTerminateEarly helpful? > Source/WebKit2/UIProcess/WebContext.h:265 > + bool m_webProcessCanTerminateEarly; Blank line before this might be nice. > Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:64 > +// FIXME: This is a workaround for testing purposes only. So is this the FIXME to remove this? I'm not sure what the FIXME represents here. 386186 3 jberlin 2011-04-14 16:54:47 -0700 (In reply to comment #2) > (From update of attachment 89679 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89679&action=review > > I feel like everywhere this should be webProcessCanTerminate instead of webProcessCanTerminateEarly. Ok, I don't feel strongly about this. Changed to webProcessCanTerminate. > > > Source/WebKit2/UIProcess/WebContext.cpp:267 > > + m_webProcessCanTerminateEarly = allowed; > > Is an early return if allowed == m_webProcessCanTerminateEarly helpful? I don't think so, given the current implementation of shouldTerminate, but I will add it in case shouldTerminate for some reason gets more complicated. > > > Source/WebKit2/UIProcess/WebContext.h:265 > > + bool m_webProcessCanTerminateEarly; > > Blank line before this might be nice. Done. > > > Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:64 > > +// FIXME: This is a workaround for testing purposes only. > > So is this the FIXME to remove this? I'm not sure what the FIXME represents here. Yes, we should come up with a way to do the testing such that this is not necessary. I will revise the comment to say: // FIXME: This is a workaround for testing purposes only and should be removed once a better solution has been found for testing. 386191 4 89679 andersca 2011-04-14 17:00:25 -0700 Comment on attachment 89679 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89679&action=review > Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:66 > +WK_EXPORT void WKContextSetWebProcessCanTerminateEarly(WKContextRef context, bool canTerminate); > + I don't like this name. Could we instead have WKContextDisableProcessTermination and WKContextEnableProcessTermination? 386652 5 jberlin 2011-04-15 08:43:10 -0700 (In reply to comment #4) > (From update of attachment 89679 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89679&action=review > > > Source/WebKit2/UIProcess/API/C/WKContextPrivate.h:66 > > +WK_EXPORT void WKContextSetWebProcessCanTerminateEarly(WKContextRef context, bool canTerminate); > > + > > I don't like this name. Could we instead have > > WKContextDisableProcessTermination and WKContextEnableProcessTermination? I will change it to use those names, and since that is so much of the patch I will send it out for review again. 386683 6 89798 jberlin 2011-04-15 09:40:18 -0700 Created attachment 89798 Patch (Take 2) 386737 7 89798 jberlin 2011-04-15 10:43:36 -0700 Comment on attachment 89798 Patch (Take 2) Committed in http://trac.webkit.org/changeset/83988 89679 2011-04-14 16:22:20 -0700 2011-04-15 09:40:18 -0700 Patch needWayToKeepWebProcessOpenForTesting.patch text/plain 4373 jberlin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTA2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDQtMTQgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJLaXQyOiBOZWVkIGEgd2F5IHRvIGtlZXAgdGhlIFdlYlBy b2Nlc3MgYWxpdmUgZm9yIHRlc3RpbmcgcHVycG9zZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODU5MgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9DL1dLQ29udGV4dC5jcHA6CisgICAgICAgIChXS0NvbnRleHRTZXRXZWJQcm9jZXNzQ2FuVGVy bWluYXRlRWFybHkpOgorICAgICAgICBDYWxsIHRocm91Z2ggdG8gdGhlIFdlYkNvbnRleHQuCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUuaDoKKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6 V2ViQ29udGV4dCk6CisgICAgICAgIEluaXRpYWxpemUgbV93ZWJQcm9jZXNzQ2FuVGVybWluYXRl RWFybHkgdG8gdHJ1ZS4KKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6c2V0V2ViUHJvY2Vz c0NhblRlcm1pbmF0ZUVhcmx5KToKKyAgICAgICAgSWYgdGhlIHdlYiBwcm9jZXNzIGlzIGFsbG93 ZWQgdG8gdGVybWluYXRlIGVhcmx5IGFuZCBzaG91bGRUZXJtaW5hdGUgcmV0dXJucyB0cnVlLCB0 ZWxsIHRoZQorICAgICAgICBXZWJQcm9jZXNzIHRvIHRlcm1pbmF0ZS4KKyAgICAgICAgKFdlYktp dDo6V2ViQ29udGV4dDo6c2hvdWxkVGVybWluYXRlKToKKyAgICAgICAgUmV0dXJuIGZhbHNlIGlm IHRoZSB3ZWIgcHJvY2VzcyBpcyBub3QgYWxsb3dlZCB0byB0ZXJtaW5hdGUgZWFybHkuCisgICAg ICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHQuaDoKKwogMjAxMS0wNC0xNCAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJu c3RlaW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCShyZXZp c2lvbiA4Mzg2OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTI2LDYgKzEyNiw3IEBAIFdlYkNvbnRleHQ6OldlYkNvbnRleHQo UHJvY2Vzc01vZGVsIHByb2MKICAgICAsIG1fc2hvdWxkUGFpbnROYXRpdmVDb250cm9scyh0cnVl KQogICAgICwgbV9pbml0aWFsSFRUUENvb2tpZUFjY2VwdFBvbGljeShIVFRQQ29va2llQWNjZXB0 UG9saWN5QWx3YXlzKQogI2VuZGlmCisgICAgLCBtX3dlYlByb2Nlc3NDYW5UZXJtaW5hdGVFYXJs eSh0cnVlKQogewogI2lmbmRlZiBOREVCVUcKICAgICBXZWJLaXQ6OmluaXRpYWxpemVMb2dDaGFu bmVsc0lmTmVjZXNzYXJ5KCk7CkBAIC0yNjEsMTEgKzI2MiwyMSBAQCB2b2lkIFdlYkNvbnRleHQ6 OmVuc3VyZVdlYlByb2Nlc3MoKQogICAgIG1fcGVuZGluZ01lc3NhZ2VzVG9Qb3N0VG9JbmplY3Rl ZEJ1bmRsZS5jbGVhcigpOwogfQogCit2b2lkIFdlYkNvbnRleHQ6OnNldFdlYlByb2Nlc3NDYW5U ZXJtaW5hdGVFYXJseShib29sIGFsbG93ZWQpCit7CisgICAgbV93ZWJQcm9jZXNzQ2FuVGVybWlu YXRlRWFybHkgPSBhbGxvd2VkOworICAgIGlmIChzaG91bGRUZXJtaW5hdGUobV9wcm9jZXNzLmdl dCgpKSkKKyAgICAgICAgbV9wcm9jZXNzLT50ZXJtaW5hdGUoKTsKK30KKwogYm9vbCBXZWJDb250 ZXh0OjpzaG91bGRUZXJtaW5hdGUoV2ViUHJvY2Vzc1Byb3h5KiBwcm9jZXNzKQogewogICAgIC8v IEZJWE1FOiBPbmNlIHdlIHN1cHBvcnQgbXVsdGlwbGUgcHJvY2Vzc2VzIHBlciBjb250ZXh0LCB0 aGlzIGFzc2VydGlvbiB3b24ndCBob2xkLgogICAgIEFTU0VSVChwcm9jZXNzID09IG1fcHJvY2Vz cyk7CiAKKyAgICBpZiAoIW1fd2ViUHJvY2Vzc0NhblRlcm1pbmF0ZUVhcmx5KQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKICAgICBpZiAoIW1fZG93bmxvYWRzLmlzRW1wdHkoKSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4 dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgJ KHJldmlzaW9uIDgzODY5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQu aAkod29ya2luZyBjb3B5KQpAQCAtMTY4LDYgKzE2OCw4IEBAIHB1YmxpYzoKIAogICAgIGJvb2wg c2hvdWxkVGVybWluYXRlKFdlYlByb2Nlc3NQcm94eSopOwogCisgICAgdm9pZCBzZXRXZWJQcm9j ZXNzQ2FuVGVybWluYXRlRWFybHkoYm9vbCk7CisKIHByaXZhdGU6CiAgICAgV2ViQ29udGV4dChQ cm9jZXNzTW9kZWwsIGNvbnN0IFN0cmluZyYgaW5qZWN0ZWRCdW5kbGVQYXRoKTsKIApAQCAtMjYw LDYgKzI2Miw3IEBAIHByaXZhdGU6CiAgICAgU3RyaW5nIG1fb3ZlcnJpZGVEYXRhYmFzZURpcmVj dG9yeTsKICAgICBTdHJpbmcgbV9vdmVycmlkZUljb25EYXRhYmFzZVBhdGg7CiAgICAgU3RyaW5n IG1fb3ZlcnJpZGVMb2NhbFN0b3JhZ2VEaXJlY3Rvcnk7CisgICAgYm9vbCBtX3dlYlByb2Nlc3ND YW5UZXJtaW5hdGVFYXJseTsKIH07CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFU+IGlubGluZSBib29s IFdlYkNvbnRleHQ6OnNlbmRUb0FsbFByb2Nlc3Nlcyhjb25zdCBVJiBtZXNzYWdlKQpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAJKHJldmlzaW9u IDgzODY5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIxNywzICsyMTcsOCBAQCB2b2lkIFdLQ29udGV4dFNldExvY2Fs U3RvcmFnZURpcmVjdG9yeShXCiB7CiAgICAgdG9JbXBsKGNvbnRleHRSZWYpLT5zZXRMb2NhbFN0 b3JhZ2VEaXJlY3RvcnkodG9JbXBsKGxvY2FsU3RvcmFnZURpcmVjdG9yeSktPnN0cmluZygpKTsK IH0KKwordm9pZCBXS0NvbnRleHRTZXRXZWJQcm9jZXNzQ2FuVGVybWluYXRlRWFybHkoV0tDb250 ZXh0UmVmIGNvbnRleHRSZWYsIGJvb2wgY2FuVGVybWluYXRlKQoreworICAgIHRvSW1wbChjb250 ZXh0UmVmKS0+c2V0V2ViUHJvY2Vzc0NhblRlcm1pbmF0ZUVhcmx5KGNhblRlcm1pbmF0ZSk7Cit9 CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0UHJpdmF0ZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRQ cml2YXRlLmgJKHJldmlzaW9uIDgzODY5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9DL1dLQ29udGV4dFByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsOSBAQCBX S19FWFBPUlQgdm9pZCBXS0NvbnRleHRTZXRJY29uRGF0YWJhc2VQCiBXS19FWFBPUlQgdm9pZCBX S0NvbnRleHRTZXREYXRhYmFzZURpcmVjdG9yeShXS0NvbnRleHRSZWYgY29udGV4dCwgV0tTdHJp bmdSZWYgZGF0YWJhc2VEaXJlY3RvcnkpOwogV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0U2V0TG9j YWxTdG9yYWdlRGlyZWN0b3J5KFdLQ29udGV4dFJlZiBjb250ZXh0LCBXS1N0cmluZ1JlZiBsb2Nh bFN0b3JhZ2VEaXJlY3RvcnkpOwogCisvLyBGSVhNRTogVGhpcyBpcyBhIHdvcmthcm91bmQgZm9y IHRlc3RpbmcgcHVycG9zZXMgb25seS4KK1dLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFNldFdlYlBy b2Nlc3NDYW5UZXJtaW5hdGVFYXJseShXS0NvbnRleHRSZWYgY29udGV4dCwgYm9vbCBjYW5UZXJt aW5hdGUpOworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgo= 89798 2011-04-15 09:40:18 -0700 2011-04-15 10:43:36 -0700 Patch (Take 2) needWayToKeepWebProcessOpenForTestingTake2.patch text/plain 4659 jberlin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTgwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDQtMTUgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWJLaXQyOiBOZWVkIGEgd2F5IHRvIGtlZXAgdGhlIFdlYlBy b2Nlc3MgYWxpdmUgZm9yIHRlc3RpbmcgcHVycG9zZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODU5MgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9DL1dLQ29udGV4dC5jcHA6CisgICAgICAgIChXS0NvbnRleHREaXNhYmxlUHJvY2Vzc1Rlcm1p bmF0aW9uKToKKyAgICAgICAgKFdLQ29udGV4dEVuYWJsZVByb2Nlc3NUZXJtaW5hdGlvbik6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUuaDoKKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6 V2ViQ29udGV4dCk6CisgICAgICAgIEluaXRpYWxpemUgbV9wcm9jZXNzVGVybWluYXRpb25FbmFi bGVkIHRvIHRydWUuCisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmVuYWJsZVByb2Nlc3NU ZXJtaW5hdGlvbik6CisgICAgICAgIFNldCBtX3Byb2Nlc3NUZXJtaW5hdGlvbkVuYWJsZWQgdG8g dHJ1ZSwgYW5kIHRyeSB0byB0ZXJtaW5hdGUgdGhlIHdlYiBwcm9jZXNzLgorICAgICAgICAoV2Vi S2l0OjpXZWJDb250ZXh0OjpzaG91bGRUZXJtaW5hdGUpOgorICAgICAgICBJZiAhbV9wcm9jZXNz VGVybWluYXRpb25FbmFibGVkLCByZXR1cm4gZmFsc2UuCisgICAgICAgICogVUlQcm9jZXNzL1dl YkNvbnRleHQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6ZGlzYWJsZVByb2Nlc3NU ZXJtaW5hdGlvbik6CisgICAgICAgIFNldCBtX3Byb2Nlc3NUZXJtaW5hdGlvbkVuYWJsZWQgdG8g ZmFsc2U7CisKIDIwMTEtMDQtMTUgIEFubmEgQ2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAJKHJldmlzaW9uIDgzOTczKQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjYsNiAr MTI2LDcgQEAgV2ViQ29udGV4dDo6V2ViQ29udGV4dChQcm9jZXNzTW9kZWwgcHJvYwogICAgICwg bV9zaG91bGRQYWludE5hdGl2ZUNvbnRyb2xzKHRydWUpCiAgICAgLCBtX2luaXRpYWxIVFRQQ29v a2llQWNjZXB0UG9saWN5KEhUVFBDb29raWVBY2NlcHRQb2xpY3lBbHdheXMpCiAjZW5kaWYKKyAg ICAsIG1fcHJvY2Vzc1Rlcm1pbmF0aW9uRW5hYmxlZCh0cnVlKQogewogI2lmbmRlZiBOREVCVUcK ICAgICBXZWJLaXQ6OmluaXRpYWxpemVMb2dDaGFubmVsc0lmTmVjZXNzYXJ5KCk7CkBAIC0yNjEs MTEgKzI2MiwyMSBAQCB2b2lkIFdlYkNvbnRleHQ6OmVuc3VyZVdlYlByb2Nlc3MoKQogICAgIG1f cGVuZGluZ01lc3NhZ2VzVG9Qb3N0VG9JbmplY3RlZEJ1bmRsZS5jbGVhcigpOwogfQogCit2b2lk IFdlYkNvbnRleHQ6OmVuYWJsZVByb2Nlc3NUZXJtaW5hdGlvbigpCit7CisgICAgbV9wcm9jZXNz VGVybWluYXRpb25FbmFibGVkID0gdHJ1ZTsKKyAgICBpZiAoc2hvdWxkVGVybWluYXRlKG1fcHJv Y2Vzcy5nZXQoKSkpCisgICAgICAgIG1fcHJvY2Vzcy0+dGVybWluYXRlKCk7Cit9CisKIGJvb2wg V2ViQ29udGV4dDo6c2hvdWxkVGVybWluYXRlKFdlYlByb2Nlc3NQcm94eSogcHJvY2VzcykKIHsK ICAgICAvLyBGSVhNRTogT25jZSB3ZSBzdXBwb3J0IG11bHRpcGxlIHByb2Nlc3NlcyBwZXIgY29u dGV4dCwgdGhpcyBhc3NlcnRpb24gd29uJ3QgaG9sZC4KICAgICBBU1NFUlQocHJvY2VzcyA9PSBt X3Byb2Nlc3MpOwogCisgICAgaWYgKCFtX3Byb2Nlc3NUZXJtaW5hdGlvbkVuYWJsZWQpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKwogICAgIGlmICghbV9kb3dubG9hZHMuaXNFbXB0eSgpKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJD b250ZXh0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRl eHQuaAkocmV2aXNpb24gODM5NzMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29u dGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgsNiArMTY4LDkgQEAgcHVibGljOgogCiAgICAg Ym9vbCBzaG91bGRUZXJtaW5hdGUoV2ViUHJvY2Vzc1Byb3h5Kik7CiAKKyAgICB2b2lkIGRpc2Fi bGVQcm9jZXNzVGVybWluYXRpb24oKSB7IG1fcHJvY2Vzc1Rlcm1pbmF0aW9uRW5hYmxlZCA9IGZh bHNlOyB9CisgICAgdm9pZCBlbmFibGVQcm9jZXNzVGVybWluYXRpb24oKTsKKwogcHJpdmF0ZToK ICAgICBXZWJDb250ZXh0KFByb2Nlc3NNb2RlbCwgY29uc3QgU3RyaW5nJiBpbmplY3RlZEJ1bmRs ZVBhdGgpOwogCkBAIC0yNjAsNiArMjYzLDggQEAgcHJpdmF0ZToKICAgICBTdHJpbmcgbV9vdmVy cmlkZURhdGFiYXNlRGlyZWN0b3J5OwogICAgIFN0cmluZyBtX292ZXJyaWRlSWNvbkRhdGFiYXNl UGF0aDsKICAgICBTdHJpbmcgbV9vdmVycmlkZUxvY2FsU3RvcmFnZURpcmVjdG9yeTsKKworICAg IGJvb2wgbV9wcm9jZXNzVGVybWluYXRpb25FbmFibGVkOwogfTsKIAogdGVtcGxhdGU8dHlwZW5h bWUgVT4gaW5saW5lIGJvb2wgV2ViQ29udGV4dDo6c2VuZFRvQWxsUHJvY2Vzc2VzKGNvbnN0IFUm IG1lc3NhZ2UpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250 ZXh0LmNwcAkocmV2aXNpb24gODM5NzMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0MvV0tDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE3LDMgKzIxNywxMyBAQCB2b2lk IFdLQ29udGV4dFNldExvY2FsU3RvcmFnZURpcmVjdG9yeShXCiB7CiAgICAgdG9JbXBsKGNvbnRl eHRSZWYpLT5zZXRMb2NhbFN0b3JhZ2VEaXJlY3RvcnkodG9JbXBsKGxvY2FsU3RvcmFnZURpcmVj dG9yeSktPnN0cmluZygpKTsKIH0KKwordm9pZCBXS0NvbnRleHREaXNhYmxlUHJvY2Vzc1Rlcm1p bmF0aW9uKFdLQ29udGV4dFJlZiBjb250ZXh0UmVmKQoreworICAgIHRvSW1wbChjb250ZXh0UmVm KS0+ZGlzYWJsZVByb2Nlc3NUZXJtaW5hdGlvbigpOworfQorCit2b2lkIFdLQ29udGV4dEVuYWJs ZVByb2Nlc3NUZXJtaW5hdGlvbihXS0NvbnRleHRSZWYgY29udGV4dFJlZikKK3sKKyAgICB0b0lt cGwoY29udGV4dFJlZiktPmVuYWJsZVByb2Nlc3NUZXJtaW5hdGlvbigpOworfQpJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0UHJpdmF0ZS5oCShy ZXZpc2lvbiA4Mzk3MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRl eHRQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDExIEBAIFdLX0VYUE9SVCB2 b2lkIFdLQ29udGV4dFNldEljb25EYXRhYmFzZVAKIFdLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFNl dERhdGFiYXNlRGlyZWN0b3J5KFdLQ29udGV4dFJlZiBjb250ZXh0LCBXS1N0cmluZ1JlZiBkYXRh YmFzZURpcmVjdG9yeSk7CiBXS19FWFBPUlQgdm9pZCBXS0NvbnRleHRTZXRMb2NhbFN0b3JhZ2VE aXJlY3RvcnkoV0tDb250ZXh0UmVmIGNvbnRleHQsIFdLU3RyaW5nUmVmIGxvY2FsU3RvcmFnZURp cmVjdG9yeSk7CiAKKy8vIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgdGVzdGluZyBw dXJwb3NlcyBvbmx5IGFuZCBzaG91bGQgYmUgcmVtb3ZlZCBvbmNlIGEgYmV0dGVyCisvLyBzb2x1 dGlvbiBoYXMgYmVlbiBmb3VuZCBmb3IgdGVzdGluZy4KK1dLX0VYUE9SVCB2b2lkIFdLQ29udGV4 dERpc2FibGVQcm9jZXNzVGVybWluYXRpb24oV0tDb250ZXh0UmVmIGNvbnRleHQpOworV0tfRVhQ T1JUIHZvaWQgV0tDb250ZXh0RW5hYmxlUHJvY2Vzc1Rlcm1pbmF0aW9uKFdLQ29udGV4dFJlZiBj b250ZXh0KTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK