58589 2011-04-14 15:48:34 -0700 commit-queue fails to catch IOError when results.html is missing 2011-04-14 15:56:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth oldest_to_newest 386124 0 eric 2011-04-14 15:48:34 -0700 commit-queue fails to catch IOError when results.html is missing 386128 1 89675 eric 2011-04-14 15:49:31 -0700 Created attachment 89675 Patch 386129 2 eric 2011-04-14 15:50:09 -0700 Traceback (most recent call last): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 108, in run if not self._delegate.process_work_item(work_item): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 281, in process_work_item if task.run(): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py", line 252, in run if not self._test_patch(): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py", line 189, in _test_patch if self._test(): File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py", line 149, in _test self._expected_failures.shrink_expected_failures(self._delegate.layout_test_results(), success) File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 331, in layout_test_results results = self._create_layout_test_results() File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 325, in _create_layout_test_results results_html = self._read_file_contents(results_path) File "/Projects/CommitQueue/Tools/Scripts/webkitpy/tool/commands/queues.py", line 318, in _read_file_contents return self._tool.filesystem.read_text_file(path) File "/Projects/CommitQueue/Tools/Scripts/webkitpy/common/system/filesystem.py", line 263, in read_text_file with codecs.open(path, 'r', 'utf8') as f: File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/codecs.py", line 865, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: '/tmp/layout-test-results/results.html' ORWT doesn't create a results.html file if all tests pass. :) 386136 3 eric 2011-04-14 15:56:16 -0700 Committed r83906: <http://trac.webkit.org/changeset/83906> 89675 2011-04-14 15:49:31 -0700 2011-04-14 15:54:23 -0700 Patch bug-58589-20110414154928.patch text/plain 2694 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODM5MDMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZDNkNTJiZGY0MTk4NTY3YTk2YjU5MjkwMDg4MTRjNzc0 YWU1YTZlLi4xNjBhOGM5YjkwMjVlNzY0MTUwNzhhNTJkYzUwNDQ3M2UwMWY5MWU2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMTQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBmYWls cyB0byBjYXRjaCBJT0Vycm9yIHdoZW4gcmVzdWx0cy5odG1sIGlzIG1pc3NpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NTg5CisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHk6CisKIDIwMTEt MDQtMTQgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAg ICAgW3d4XSBVbnJldmlld2VkIGJ1aWxkIGZpeCBmb3IgTWFjIGluc3RhbGxhdGlvbiBzY3JpcHQu CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVz LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQppbmRl eCA4YzdkZTA1NTFjYWE4YTBmNTA3YzkwNjAyYjM5NWVkMWE5MGJlYmIwLi40ZWFkYjBlNWFiZmY2 OTU4NjRmYjhjMjVlNDc0MjU3ODFiN2UxNTc3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKQEAgLTMxNiw3ICszMTYsNyBAQCBjbGFzcyBDb21t aXRRdWV1ZShBYnN0cmFjdFBhdGNoUXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlciwgQ29t bWl0UXVldWVUYXNrRAogICAgIGRlZiBfcmVhZF9maWxlX2NvbnRlbnRzKHNlbGYsIHBhdGgpOgog ICAgICAgICB0cnk6CiAgICAgICAgICAgICByZXR1cm4gc2VsZi5fdG9vbC5maWxlc3lzdGVtLnJl YWRfdGV4dF9maWxlKHBhdGgpCi0gICAgICAgIGV4Y2VwdCBPU0Vycm9yLCBlOiAgIyBGaWxlIGRv ZXMgbm90IGV4aXN0IG9yIGNhbid0IGJlIHJlYWQuCisgICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBl OiAgIyBGaWxlIGRvZXMgbm90IGV4aXN0IG9yIGNhbid0IGJlIHJlYWQuCiAgICAgICAgICAgICBy ZXR1cm4gTm9uZQogCiAgICAgIyBGSVhNRTogVGhpcyBsb2dpYyBzaG91bGQgbW92ZSB0byB0aGUg cG9ydCBvYmplY3QuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQppbmRleCA5YWMwYjA0YjQwZmFmMDdlYjM4MzRkMjY0 ZmVhMDI4NDMyNjI1N2M4Li5kNTc3YmFhNTVkNWMxYjQ1OTBlN2U5MDU5MjdiMTE0M2JhNTcwZmM2 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVz X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x dWV1ZXNfdW5pdHRlc3QucHkKQEAgLTM3OCw2ICszNzgsMTcgQEAgVGhlIGNvbW1pdC1xdWV1ZSBp cyBjb250aW51aW5nIHRvIHByb2Nlc3MgeW91ciBwYXRjaC4KIAogICAgICAgICBPdXRwdXRDYXB0 dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcXVldWUucmVwb3J0X2ZsYWt5X3Rlc3RzLCBbUXVl dWVzVGVzdC5tb2NrX3dvcmtfaXRlbSwgdGVzdF9yZXN1bHRzLCBNb2NrWmlwRmlsZSgpXSwgZXhw ZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAorICAgIGRlZiB0ZXN0X21pc3NpbmdfbGF5 b3V0X3Rlc3RfcmVzdWx0cyhzZWxmKToKKyAgICAgICAgcXVldWUgPSBDb21taXRRdWV1ZSgpCisg ICAgICAgIHRvb2wgPSBNb2NrVG9vbCgpCisgICAgICAgIHJlc3VsdHNfcGF0aCA9ICcvbW9jay9y ZXN1bHRzLmh0bWwnCisgICAgICAgIHRvb2wuZmlsZXN5c3RlbSA9IE1vY2tGaWxlU3lzdGVtKHty ZXN1bHRzX3BhdGg6IE5vbmV9KQorICAgICAgICBxdWV1ZS5iaW5kX3RvX3Rvb2wodG9vbCkKKyAg ICAgICAgIyBNYWtlIHN1cmUgdGhhdCBvdXIgZmlsZXN5c3RlbSBtb2NrIGZ1bmN0aW9ucyBhcyB3 ZSBleHBlY3QuCisgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKElPRXJyb3IsIHRvb2wuZmlsZXN5 c3RlbS5yZWFkX3RleHRfZmlsZSwgcmVzdWx0c19wYXRoKQorICAgICAgICAjIGxheW91dF90ZXN0 X3Jlc3VsdHMgc2hvdWxkbid0IHJhaXNlIGV2ZW4gaWYgdGhlIHJlc3VsdHMuaHRtbCBmaWxlIGlz IG1pc3NpbmcuCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHF1ZXVlLmxheW91dF90ZXN0X3Jl c3VsdHMoKSwgTm9uZSkKKwogICAgIGRlZiB0ZXN0X2xheW91dF90ZXN0X3Jlc3VsdHMoc2VsZik6 CiAgICAgICAgIHF1ZXVlID0gQ29tbWl0UXVldWUoKQogICAgICAgICBxdWV1ZS5iaW5kX3RvX3Rv b2woTW9ja1Rvb2woKSkK