58581 2011-04-14 15:07:58 -0700 sort columns in the new json_results.html file 2011-04-14 15:22:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan arv eric mihaip tony oldest_to_newest 386081 0 ojan 2011-04-14 15:07:58 -0700 sort columns in the new json_results.html file 386087 1 89667 ojan 2011-04-14 15:10:42 -0700 Created attachment 89667 Patch 386102 2 89667 tony 2011-04-14 15:20:00 -0700 Comment on attachment 89667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89667&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:166 > + var bText = b.childNodes[sortColumn].textContent Nit: missing semi-colon 386104 3 ojan 2011-04-14 15:22:53 -0700 Committed r83902: <http://trac.webkit.org/changeset/83902> 89667 2011-04-14 15:10:42 -0700 2011-04-14 15:20:00 -0700 Patch bug-58581-20110414151041.patch text/plain 5305 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODM4ODEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1YjliOWI4ZjNkNmIzYWZmYTkxZWFjNGIyZGY2MmMyYWE0 YWQwNGUxLi5mYWU1MjQ0MDY4MjY2MjI5MDg4NWY4MDQ2NjE0ZWVkYzNkNDM5NTBhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDQtMTQgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzb3J0IGNvbHVtbnMgaW4g dGhlIG5ldyBqc29uX3Jlc3VsdHMuaHRtbCBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODU4MQorCisgICAgICAgIEFsc28gZml4IHBhZGRpbmcg b24gVERzIGFuZCB0aGUgcGF0aCB0byBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHMuaHRtbDoK KwogMjAxMS0wNC0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzLmh0bWwgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jl c3VsdHMuaHRtbAppbmRleCA0MThkMzJkMDBkN2M0OGUyNzQ3NjI0ZjQxZGYzNjU0NzRkYjY3NWE4 Li5kY2FkNDQxODg4MmEyOTNmN2ViOThjNDcxZjA4MmI5OGZjMWVkYjQwIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jl c3VsdHMuaHRtbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlv dXRfcGFja2FnZS9qc29uX3Jlc3VsdHMuaHRtbApAQCAtMTMsMTIgKzEzLDE3IEBAIHRoZWFkIHRy LCB0cjpudGgtY2hpbGQoZXZlbikgewogfQogCiB0ZCB7Ci0gICAgcGFkZGluZzogMCA0MHB4Owor ICAgIHBhZGRpbmc6IDAgNHB4OwogfQogCiB0aDplbXB0eSwgdGQ6ZW1wdHkgewogICAgIHBhZGRp bmc6IDA7CiB9CisKK3RoIHsKKyAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lOworICAgIC1t b3otdXNlci1zZWxlY3Q6IG5vbmU7Cit9CiA8L3N0eWxlPgogCiA8c2NyaXB0PgpAQCAtNTAsMTUg KzU1LDEzIEBAIHZhciBodG1sID0gJ1Rlc3RzIHdoZXJlIHJlc3VsdHMgZGlkIG5vdCBtYXRjaCBl eHBlY3RlZCByZXN1bHRzOjx0YWJsZT4nICsKICAgICAnPC90cj48L3RoZWFkPic7CiAKIC8vIEZJ WE1FOiBTaG91bGQgdGhpcyBwb2ludCB0byB0aGUgbG9jYWwgZmlsZSBpbnN0ZWFkPyBTaG91bGQg aXQgZHluYW1pY2FsbHkgZmlndXJlIG91dCB3aGVyZSB0byBwb2ludD8KLS8vIEZJWE1FOiByZW1v dmUgdGhlIHZlcnNpb24gbnVtYmVyIGZyb20gdGhlIFVSTCBpZiBwb3NzaWJsZS4KLXZhciB0ZXN0 X2Jhc2VfcGF0aCA9ICdodHRwOi8vdHJhYy53ZWJraXQub3JnL2V4cG9ydC83NjA1My90cnVuay9M YXlvdXRUZXN0cy8nOwordmFyIHRlc3RfYmFzZV9wYXRoID0gJ2h0dHA6Ly90cmFjLndlYmtpdC5v cmcvYnJvd3Nlci90cnVuay9MYXlvdXRUZXN0cy8nOwogCiBmdW5jdGlvbiByZXN1bHRMaW5rKHRl c3RfcHJlZml4LCBzdWZmaXgsIGNvbnRlbnRzKQogewogICAgIHJldHVybiAnPGEgaHJlZj0iJyAr IHRlc3RfcHJlZml4ICsgc3VmZml4ICsgJyI+JyArIGNvbnRlbnRzICsgJzwvYT4gJzsKIH0KIAot Ly8gRklYTUU6IGFsbG93IHNvcnRpbmcgdGhlIHRhYmxlIGJ5IGNvbHVtbnMKIC8vIEZJWE1FOiBz aG93IGV4cGVjdGVkL2FjdHVhbC9kaWZmIGNvbnRlbnRzIGlubGluZSBpbiBpZnJhbWVzCiAvLyBG SVhNRTogYWxsb3cgem9vbWluZyBpbiBvbiBwaXhlbCBkaWZmcwogLy8gRklYTUU6IHN0b3JlIHN0 ZGVyciBpbmZvcm1hdGlvbiBpbiB0aGUganNvbgpAQCAtNjcsNiArNzAsNyBAQCBmdW5jdGlvbiBy ZXN1bHRMaW5rKHRlc3RfcHJlZml4LCBzdWZmaXgsIGNvbnRlbnRzKQogdmFyIGhhc1RleHRGYWls dXJlcyA9IGZhbHNlOwogdmFyIGhhc0ltYWdlRmFpbHVyZXMgPSBmYWxzZTsKIAoraHRtbCArPSAn PHRib2R5Pic7CiBmb3IgKHZhciB0ZXN0IGluIHJlc3VsdHMudGVzdHMpIHsKICAgdmFyIHJvdyA9 ICc8dGQ+PGEgaHJlZj0iJyArIHRlc3RfYmFzZV9wYXRoICsgdGVzdCArICciPicgKyB0ZXN0ICsg JzwvYT48L3RkPic7CiAgIHZhciB0ZXN0X3ByZWZpeCA9IHN0cmlwRXh0ZW5zaW9uKHRlc3QpOwpA QCAtMTAyLDggKzEwNiw5MSBAQCBmb3IgKHZhciB0ZXN0IGluIHJlc3VsdHMudGVzdHMpIHsKICAg aHRtbCArPSAnPHRyPicgKyByb3cgKyAnPC90cj4nOwogfQogCitodG1sICs9ICc8L3Rib2R5Pjwv dGFibGU+JwogZG9jdW1lbnQud3JpdGUoaHRtbCk7CiAKK2Z1bmN0aW9uIHRvQXJyYXkobm9kZUxp c3QpCit7CisgICAgcmV0dXJuIEFycmF5LnByb3RvdHlwZS5zbGljZS5jYWxsKG5vZGVMaXN0KTsK K30KKworZnVuY3Rpb24gdHJpbShzdHJpbmcpCit7CisgICAgcmV0dXJuIHN0cmluZy5yZXBsYWNl KC9eW1xzXHhhMF0rfFtcc1x4YTBdKyQvZywgJycpOworfQorCisvLyBKdXN0IGEgbmFtZXNwYWNl IGZvciBjb2RlIG1hbmFnZW1lbnQuCit2YXIgVGFibGVTb3J0ZXIgPSB7fTsKKworVGFibGVTb3J0 ZXIuX2ZvcndhcmRBcnJvdyA9ICc8c3ZnIHN0eWxlPSJ3aWR0aDoxMHB4O2hlaWdodDoxMHB4Ij48 cG9seWdvbiBwb2ludHM9IjAsMCAxMCwwIDUsMTAiIHN0eWxlPSJmaWxsOiNhYWEiPjwvc3ZnPic7 CisKK1RhYmxlU29ydGVyLl9iYWNrd2FyZEFycm93ID0gJzxzdmcgc3R5bGU9IndpZHRoOjEwcHg7 aGVpZ2h0OjEwcHgiPjxwb2x5Z29uIHBvaW50cz0iMCwxMCAxMCwxMCA1LDAiIHN0eWxlPSJmaWxs OiNhYWEiPjwvc3ZnPic7CisKK1RhYmxlU29ydGVyLl9zb3J0ZWRDb250ZW50cyA9IGZ1bmN0aW9u KGhlYWRlciwgYXJyb3cpCit7CisgICAgcmV0dXJuIGFycm93ICsgJyAnICsgdHJpbShoZWFkZXIu dGV4dENvbnRlbnQpICsgJyAnICsgYXJyb3c7Cit9CisKK1RhYmxlU29ydGVyLl91cGRhdGVIZWFk ZXJDbGFzc05hbWVzID0gZnVuY3Rpb24obmV3SGVhZGVyKQoreworICAgIHZhciBzb3J0SGVhZGVy ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignLnNvcnRIZWFkZXInKTsKKyAgICBpZiAoc29ydEhl YWRlcikgeworICAgICAgICBpZiAoc29ydEhlYWRlciA9PSBuZXdIZWFkZXIpIHsKKyAgICAgICAg ICAgIHZhciBpc0FscmVhZHlSZXZlcnNlZCA9IHNvcnRIZWFkZXIuY2xhc3NMaXN0LmNvbnRhaW5z KCdyZXZlcnNlZCcpOworICAgICAgICAgICAgaWYgKGlzQWxyZWFkeVJldmVyc2VkKQorICAgICAg ICAgICAgICAgIHNvcnRIZWFkZXIuY2xhc3NMaXN0LnJlbW92ZSgncmV2ZXJzZWQnKTsKKyAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBzb3J0SGVhZGVyLmNsYXNzTGlzdC5hZGQoJ3Jl dmVyc2VkJyk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBzb3J0SGVhZGVyLnRleHRD b250ZW50ID0gc29ydEhlYWRlci50ZXh0Q29udGVudDsKKyAgICAgICAgICAgIHNvcnRIZWFkZXIu Y2xhc3NMaXN0LnJlbW92ZSgnc29ydEhlYWRlcicpOworICAgICAgICAgICAgc29ydEhlYWRlci5j bGFzc0xpc3QucmVtb3ZlKCdyZXZlcnNlZCcpOworICAgICAgICB9CisgICAgfQorCisgICAgbmV3 SGVhZGVyLmNsYXNzTGlzdC5hZGQoJ3NvcnRIZWFkZXInKTsKK30KKworVGFibGVTb3J0ZXIuX3Nv cnRSb3dzID0gZnVuY3Rpb24obmV3SGVhZGVyLCByZXZlcnNlZCkKK3sKKyAgICB2YXIgdGVzdHNU YWJsZSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3RhYmxlJyk7CisgICAgdmFyIGhlYWRlcnMg PSB0b0FycmF5KHRlc3RzVGFibGUucXVlcnlTZWxlY3RvckFsbCgndGgnKSk7CisgICAgdmFyIHNv cnRDb2x1bW4gPSBoZWFkZXJzLmluZGV4T2YobmV3SGVhZGVyKTsKKworICAgIHZhciB0Ym9keSA9 IHRlc3RzVGFibGUucXVlcnlTZWxlY3RvcigndGJvZHknKTsKKyAgICB2YXIgcm93cyA9IHRvQXJy YXkodGJvZHkucXVlcnlTZWxlY3RvckFsbCgndHInKSk7CisKKyAgICByb3dzLnNvcnQoZnVuY3Rp b24oYSwgYikgeworICAgICAgICAvLyBPbmx5IG5lZWQgdG8gc3VwcG9ydCBsZXhpY29ncmFwaGlj IHNvcnQgZm9yIG5vdy4KKyAgICAgICAgdmFyIGFUZXh0ID0gYS5jaGlsZE5vZGVzW3NvcnRDb2x1 bW5dLnRleHRDb250ZW50OworICAgICAgICB2YXIgYlRleHQgPSBiLmNoaWxkTm9kZXNbc29ydENv bHVtbl0udGV4dENvbnRlbnQKKyAgICAgICAgaWYgKHJldmVyc2VkKQorICAgICAgICAgICAgcmV0 dXJuIGFUZXh0IDwgYlRleHQ7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJldHVybiBiVGV4 dCA8IGFUZXh0OworICAgIH0pOworCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByb3dzLmxlbmd0 aDsgaSsrKQorICAgICAgICB0Ym9keS5hcHBlbmRDaGlsZChyb3dzW2ldKTsKK30KKworVGFibGVT b3J0ZXIuaGFuZGxlQ2xpY2sgPSBmdW5jdGlvbihlKQoreworICAgIHZhciBuZXdIZWFkZXIgPSBl LnRhcmdldDsKKyAgICBpZiAobmV3SGVhZGVyLmxvY2FsTmFtZSAhPSAndGgnKQorICAgICAgICBy ZXR1cm47CisgICAgCisgICAgVGFibGVTb3J0ZXIuX3VwZGF0ZUhlYWRlckNsYXNzTmFtZXMobmV3 SGVhZGVyKTsKKyAgICAKKyAgICB2YXIgcmV2ZXJzZWQgPSBuZXdIZWFkZXIuY2xhc3NMaXN0LmNv bnRhaW5zKCdyZXZlcnNlZCcpOworICAgIHZhciBzb3J0QXJyb3cgPSByZXZlcnNlZCA/IFRhYmxl U29ydGVyLl9iYWNrd2FyZEFycm93IDogVGFibGVTb3J0ZXIuX2ZvcndhcmRBcnJvdzsKKyAgICBu ZXdIZWFkZXIuaW5uZXJIVE1MID0gVGFibGVTb3J0ZXIuX3NvcnRlZENvbnRlbnRzKG5ld0hlYWRl ciwgc29ydEFycm93KTsKKyAgICAKKyAgICBUYWJsZVNvcnRlci5fc29ydFJvd3MobmV3SGVhZGVy LCByZXZlcnNlZCk7Cit9CisKK2RvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3RhYmxlJykuYWRkRXZl bnRMaXN0ZW5lcignY2xpY2snLCBUYWJsZVNvcnRlci5oYW5kbGVDbGljaywgZmFsc2UpOworCiBp ZiAoIWhhc1RleHRGYWlsdXJlcykKICAgZG9jdW1lbnQuYm9keS5xdWVyeVNlbGVjdG9yKCcjdGV4 dC1yZXN1bHRzLWhlYWRlcicpLnRleHRDb250ZW50ID0gJyc7CiBpZiAoIWhhc0ltYWdlRmFpbHVy ZXMpCg==