58579 2011-04-14 14:53:04 -0700 Presence of vsnprintf is not depending on compiler, but on windows C runtime used 2011-05-04 15:56:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 0 fridrich.strba webkit-unassigned ap buildbot commit-queue dglazkov webkit.review.bot oldest_to_newest 386063 0 fridrich.strba 2011-04-14 14:53:04 -0700 The vsnprintf is part of Microsoft C runtime. So, don't condition its use on COMPILER(MSVC), but on OS(WINDOWS) 386069 1 89661 fridrich.strba 2011-04-14 14:57:23 -0700 Created attachment 89661 Patch 386291 2 ap 2011-04-14 19:05:24 -0700 As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? 386363 3 fridrich.strba 2011-04-14 21:40:21 -0700 (In reply to comment #2) > As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? Because the only relevant compilers out there and used by Webkit (MSVC and MinGW) link against the Microsoft C runtime 386419 4 89744 fridrich.strba 2011-04-15 00:00:48 -0700 Created attachment 89744 Modified patch: instead of OS(WINDOWS) test, add just COMPILER(MINGW) to that branch 386420 5 fridrich.strba 2011-04-15 00:03:56 -0700 (In reply to comment #2) > As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? I modified the patch so that it only adds the COMPILER(MINGW) to the test. On a second thought, one can imagine a Windows compiler that comes with its own C runtime that is different from the Microsoft one. 386421 6 webkit.review.bot 2011-04-15 00:05:04 -0700 Attachment 89744 did not build on chromium: Build output: http://queues.webkit.org/results/8452070 386422 7 89745 fridrich.strba 2011-04-15 00:06:43 -0700 Created attachment 89745 A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp 386439 8 buildbot 2011-04-15 00:22:47 -0700 Attachment 89744 did not build on win: Build output: http://queues.webkit.org/results/8452076 387337 9 89745 abarth 2011-04-17 01:38:03 -0700 Comment on attachment 89745 A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp Ok. 397016 10 fridrich.strba 2011-05-03 02:24:37 -0700 This one has a positive review. Anybody can put a nice "+" to the commit-queue too? 398220 11 89745 xan.lopez 2011-05-04 13:45:47 -0700 Comment on attachment 89745 A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp cq+ 398341 12 89745 commit-queue 2011-05-04 15:56:03 -0700 Comment on attachment 89745 A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp Clearing flags on attachment: 89745 Committed r85800: <http://trac.webkit.org/changeset/85800> 398342 13 commit-queue 2011-05-04 15:56:09 -0700 All reviewed patches have been landed. Closing bug. 89661 2011-04-14 14:57:23 -0700 2011-04-15 00:00:44 -0700 Patch bug-58579-20110414235721.patch text/plain 1546 fridrich.strba SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzODk2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTQgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBjb25kaXRpb24gdGhlIHVzZSBvZiB2 c25wcmludGYgb24gdGhlIGNvbXBpbGVyIHVzZWQsIGJ1dCBvbiB0aGUgQyBydW50aW1lLgorICAg ICAgICBUaGUgdnNucHJpbnRmIGlzIHBhcnQgb2YgTWljcm9zb2Z0IEMgcnVudGltZSB1c2VkIGFs c28gYnkgTWluR1cgKEdDQykgdG9vbGNoYWluLgorICAgICAgICBTbywgd2UgZG9uJ3QgbWFrZSBp dCBkZXBlbmQgb24gQ09NUElMRVIoTVNWQykgdGVzdCwgYnV0IG9uIE9TKFdJTkRPV1MpIG9uZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NTc5CisK KyAgICAgICAgKiBkb20vWE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlhNTERvY3VtZW50UGFyc2VyOjplcnJvcik6CisKIDIwMTEtMDQtMTQgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBI dW50LgpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGli eG1sMi5jcHAJKHJldmlzaW9uIDgzODkyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL1hNTERvY3Vt ZW50UGFyc2VyTGlieG1sMi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkzOCw3ICs5MzgsNyBAQCB2 b2lkIFhNTERvY3VtZW50UGFyc2VyOjplcnJvcihFcnJvclR5cGUKICAgICBpZiAoaXNTdG9wcGVk KCkpCiAgICAgICAgIHJldHVybjsKIAotI2lmIENPTVBJTEVSKE1TVkMpIHx8IENPTVBJTEVSKFJW Q1QpCisjaWYgT1MoV0lORE9XUykgfHwgQ09NUElMRVIoUlZDVCkKICAgICBjaGFyIG1bMTAyNF07 CiAgICAgdnNucHJpbnRmKG0sIHNpemVvZihtKSAtIDEsIG1lc3NhZ2UsIGFyZ3MpOwogI2Vsc2UK QEAgLTk1Miw3ICs5NTIsNyBAQCB2b2lkIFhNTERvY3VtZW50UGFyc2VyOjplcnJvcihFcnJvclR5 cGUKICAgICBlbHNlCiAgICAgICAgIGhhbmRsZUVycm9yKHR5cGUsIG0sIGxpbmVOdW1iZXIoKSwg Y29sdW1uTnVtYmVyKCkpOwogCi0jaWYgIUNPTVBJTEVSKE1TVkMpICYmICFDT01QSUxFUihSVkNU KQorI2lmICFPUyhXSU5ET1dTKSAmJiAhQ09NUElMRVIoUlZDVCkKICAgICBmcmVlKG0pOwogI2Vu ZGlmCiB9Cg== 89744 2011-04-15 00:00:48 -0700 2011-04-15 00:06:38 -0700 Modified patch: instead of OS(WINDOWS) test, add just COMPILER(MINGW) to that branch bug-58579-20110415090046.patch text/plain 1818 fridrich.strba SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTUxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTQgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQ09NUElMRVIoTUlOR1cpIHRvIHRoZSBj b21waWxlcnMgdXNpbmcgdGhlIE1pY3Jvc29mdCBDIFJ1bnRpbWUncyB2c25wcmludGYuCisgICAg ICAgIFRoZSB2c25wcmludGYgaXMgcGFydCBvZiBNaWNyb3NvZnQgQyBydW50aW1lIHVzZWQgYWxz byBieSBNaW5HVyAoR0NDKSB0b29sY2hhaW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01ODU3OQorCisgICAgICAgICogZG9tL1hNTERvY3VtZW50UGFy c2VyTGlieG1sMi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVudFBhcnNlcjo6ZXJy b3IpOgorCiAyMDExLTA0LTE0ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYkNv cmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAJKHJldmlzaW9uIDgzOTAy KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTUzNyw3ICs1MzcsNyBAQCBQYXNzUmVmUHRyPFhNTFBhcnNlckNvbnRl eHQ+IFhNTFBhcnNlckNvCiAKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAK LWJvb2wgWE1MRG9jdW1lbnRQYXJzZXI6OnN1cHBvcnRzWE1MVmVyc2lvbihjb25zdCBTdHJpbmcm IHZlcnNpb24pCitib29sIFhNTERvY3VtZW50UGFyc2VyOjpzdXBwb3J0c1hNTFZlcnNpb24oI2lm IENPTVBJTEVSKE1TVkMpIHx8IENPTVBJTEVSKFJWQ1QpY29uc3QgU3RyaW5nJiB2ZXJzaW9uKQog ewogICAgIHJldHVybiB2ZXJzaW9uID09ICIxLjAiOwogfQpAQCAtOTM4LDcgKzkzOCw3IEBAIHZv aWQgWE1MRG9jdW1lbnRQYXJzZXI6OmVycm9yKEVycm9yVHlwZQogICAgIGlmIChpc1N0b3BwZWQo KSkKICAgICAgICAgcmV0dXJuOwogCi0jaWYgQ09NUElMRVIoTVNWQykgfHwgQ09NUElMRVIoUlZD VCkKKyNpZiBDT01QSUxFUihNU1ZDKSB8fCBDT01QSUxFUihSVkNUKSB8fCBDT01QSUxFUihNSU5H VykKICAgICBjaGFyIG1bMTAyNF07CiAgICAgdnNucHJpbnRmKG0sIHNpemVvZihtKSAtIDEsIG1l c3NhZ2UsIGFyZ3MpOwogI2Vsc2UKQEAgLTk1Miw3ICs5NTIsNyBAQCB2b2lkIFhNTERvY3VtZW50 UGFyc2VyOjplcnJvcihFcnJvclR5cGUKICAgICBlbHNlCiAgICAgICAgIGhhbmRsZUVycm9yKHR5 cGUsIG0sIGxpbmVOdW1iZXIoKSwgY29sdW1uTnVtYmVyKCkpOwogCi0jaWYgIUNPTVBJTEVSKE1T VkMpICYmICFDT01QSUxFUihSVkNUKQorI2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09NUElMRVIo UlZDVCkgJiYgIUNPTVBJTEVSKE1JTkdXKQogICAgIGZyZWUobSk7CiAjZW5kaWYKIH0K 89745 2011-04-15 00:06:43 -0700 2011-05-04 15:56:03 -0700 A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp bug-58579-20110415090641.patch text/plain 1510 fridrich.strba SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTUxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMTQgIEZyaWRyaWNo IFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQ09NUElMRVIoTUlOR1cpIHRvIHRoZSBj b21waWxlcnMgdXNpbmcgdGhlIE1pY3Jvc29mdCBDIFJ1bnRpbWUncyB2c25wcmludGYuCisgICAg ICAgIFRoZSB2c25wcmludGYgaXMgcGFydCBvZiBNaWNyb3NvZnQgQyBydW50aW1lIHVzZWQgYWxz byBieSBNaW5HVyAoR0NDKSB0b29sY2hhaW4uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01ODU3OQorCisgICAgICAgICogZG9tL1hNTERvY3VtZW50UGFy c2VyTGlieG1sMi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVudFBhcnNlcjo6ZXJy b3IpOgorCiAyMDExLTA0LTE0ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYkNv cmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAJKHJldmlzaW9uIDgzOTAy KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTkzOCw3ICs5MzgsNyBAQCB2b2lkIFhNTERvY3VtZW50UGFyc2VyOjpl cnJvcihFcnJvclR5cGUKICAgICBpZiAoaXNTdG9wcGVkKCkpCiAgICAgICAgIHJldHVybjsKIAot I2lmIENPTVBJTEVSKE1TVkMpIHx8IENPTVBJTEVSKFJWQ1QpCisjaWYgQ09NUElMRVIoTVNWQykg fHwgQ09NUElMRVIoUlZDVCkgfHwgQ09NUElMRVIoTUlOR1cpCiAgICAgY2hhciBtWzEwMjRdOwog ICAgIHZzbnByaW50ZihtLCBzaXplb2YobSkgLSAxLCBtZXNzYWdlLCBhcmdzKTsKICNlbHNlCkBA IC05NTIsNyArOTUyLDcgQEAgdm9pZCBYTUxEb2N1bWVudFBhcnNlcjo6ZXJyb3IoRXJyb3JUeXBl CiAgICAgZWxzZQogICAgICAgICBoYW5kbGVFcnJvcih0eXBlLCBtLCBsaW5lTnVtYmVyKCksIGNv bHVtbk51bWJlcigpKTsKIAotI2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09NUElMRVIoUlZDVCkK KyNpZiAhQ09NUElMRVIoTVNWQykgJiYgIUNPTVBJTEVSKFJWQ1QpICYmICFDT01QSUxFUihNSU5H VykKICAgICBmcmVlKG0pOwogI2VuZGlmCiB9Cg==