58574 2011-04-14 14:36:55 -0700 Drain the mark stack while marking weak handles, not after. 2011-04-17 17:17:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oliver oldest_to_newest 386040 0 ggaren 2011-04-14 14:36:55 -0700 Make sure that all marking is complete before marking weak handles 386053 1 89657 ggaren 2011-04-14 14:48:19 -0700 Created attachment 89657 Patch 386155 2 ggaren 2011-04-14 16:20:31 -0700 Committed r83910: <http://trac.webkit.org/changeset/83910> 89657 2011-04-14 14:48:19 -0700 2011-04-14 14:59:04 -0700 Patch bug-58574-20110414144818.patch text/plain 4787 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM4OTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAK KzIwMTEtMDQtMTQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcmFpbiB0aGUgbWFyayBz dGFjayB3aGlsZSBtYXJraW5nIHdlYWsgaGFuZGxlcywgbm90IGFmdGVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg1NzQKKworICAgICAgICBPdGhl cndpc2UsIGl0ZW1zIHRoYXQgd291bGQgaGF2ZSBjYXVzZWQgbW9yZSB3ZWFrIGhhbmRsZSBtYXJr aW5nIGFyZQorICAgICAgICBwcm9jZXNzZWQgYWZ0ZXIgYWxsIHdlYWsgaGFuZGxlIG1hcmtpbmcg aGFzIGZpbmlzaGVkLCBhbmQgcmVmZXJlbmNlZAorICAgICAgICB3ZWFrIGhhbmRsZXMgZ2V0IHJl Y3ljbGVkLgorCisgICAgICAgICogaGVhcC9IYW5kbGVIZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6 SGFuZGxlSGVhcDo6bWFya1dlYWtIYW5kbGVzKTogUmVtb3ZlZCBsb29waW5nIGZyb20gaGVyZSwg c2luY2Ugd2UKKyAgICAgICAgd2FudCBIZWFwOjptYXJrUm9vdHMgdG8gYmUgcmVzcG9uc2libGUg Zm9yIGRyYWluaW5nIHRoZSBtYXJrIHN0YWNrLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoK KyAgICAgICAgKEpTQzo6SGVhcDo6bWFya1Jvb3RzKTogTW92ZWQgbG9vcGluZyB0byBoZXJlLCBh cyBleHBsYWluZWQgYWJvdmUuCisgICAgICAgIAorICAgICAgICBGb3IgZWZmaWNpZW5jeSdzIHNh a2UsIGRyYWluIHRoZSBtYXJrIHN0YWNrIGJlZm9yZSBzdGFydGluZyB0byBtYXJrIHdlYWsKKyAg ICAgICAgaGFuZGxlcy4gT3RoZXJ3aXNlLCBpdGVtcyBkcmFpbmVkIHdoaWxlIG1hcmtpbmcgd2Vh ayBoYW5kbGVzIG1heSBmb3JjZQorICAgICAgICBhbiBleHRyYSB0cmlwIHRocm91Z2ggdGhlIHdl YWsgaGFuZGxlIGxpc3QuCisKKyAgICAgICAgRm9yIGNvcnJlY3RuZXNzJ3Mgc2FrZSwgZHJhaW4g dGhlIG1hcmsgc3RhY2sgZWFjaCB0aW1lIHRocm91Z2ggdGhlIHdlYWsKKyAgICAgICAgaGFuZGxl IGxpc3QuIE90aGVyd2lzZSwgb3BhcXVlIHJvb3RzIHRoYXQgd291bGQgbWFrZSB3ZWFrIGhhbmRs ZXMgcmVhY2hhYmxlCisgICAgICAgIGFyZSBub3QgZGlzY292ZXJlZCB1bnRpbCBhZnRlciB3ZWFr IGhhbmRsZSBtYXJraW5nIGlzIG92ZXIuCisKIDIwMTEtMDQtMTQgIE9saXZlciBIdW50ICA8b2xp dmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUZW1wb3JhcmlseSByZW1vdmUgYXNzZXJ0aW9uIHRo YXQncyBmaXJpbmcgYWxsIHRoZSB0aW1lLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGFuZGxlSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGFuZGxlSGVhcC5jcHAJKHJldmlzaW9uIDgzODgxKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvSGFuZGxlSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcxLDI3ICs3MSwyMiBA QCB2b2lkIEhhbmRsZUhlYXA6Om1hcmtXZWFrSGFuZGxlcyhIZWFwUm9vCiB7CiAgICAgTWFya1N0 YWNrJiBtYXJrU3RhY2sgPSBoZWFwUm9vdE1hcmtlci5tYXJrU3RhY2soKTsKIAotICAgIGludCBv bGRDb3VudDsKLSAgICBkbyB7Ci0gICAgICAgIG9sZENvdW50ID0gbWFya1N0YWNrLm9wYXF1ZVJv b3RDb3VudCgpOwotCi0gICAgICAgIE5vZGUqIGVuZCA9IG1fd2Vha0xpc3QuZW5kKCk7Ci0gICAg ICAgIGZvciAoTm9kZSogbm9kZSA9IG1fd2Vha0xpc3QuYmVnaW4oKTsgbm9kZSAhPSBlbmQ7IG5v ZGUgPSBub2RlLT5uZXh0KCkpIHsKLSAgICAgICAgICAgIEFTU0VSVChpc1ZhbGlkV2Vha05vZGUo bm9kZSkpOwotICAgICAgICAgICAgSlNDZWxsKiBjZWxsID0gbm9kZS0+c2xvdCgpLT5hc0NlbGwo KTsKLSAgICAgICAgICAgIGlmIChIZWFwOjppc01hcmtlZChjZWxsKSkKLSAgICAgICAgICAgICAg ICBjb250aW51ZTsKKyAgICBOb2RlKiBlbmQgPSBtX3dlYWtMaXN0LmVuZCgpOworICAgIGZvciAo Tm9kZSogbm9kZSA9IG1fd2Vha0xpc3QuYmVnaW4oKTsgbm9kZSAhPSBlbmQ7IG5vZGUgPSBub2Rl LT5uZXh0KCkpIHsKKyAgICAgICAgQVNTRVJUKGlzVmFsaWRXZWFrTm9kZShub2RlKSk7CisgICAg ICAgIEpTQ2VsbCogY2VsbCA9IG5vZGUtPnNsb3QoKS0+YXNDZWxsKCk7CisgICAgICAgIGlmIChI ZWFwOjppc01hcmtlZChjZWxsKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOwogCi0gICAgICAgICAg ICBXZWFrSGFuZGxlT3duZXIqIHdlYWtPd25lciA9IG5vZGUtPndlYWtPd25lcigpOwotICAgICAg ICAgICAgaWYgKCF3ZWFrT3duZXIpCi0gICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAg IFdlYWtIYW5kbGVPd25lciogd2Vha093bmVyID0gbm9kZS0+d2Vha093bmVyKCk7CisgICAgICAg IGlmICghd2Vha093bmVyKQorICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgICAgIGlm ICghd2Vha093bmVyLT5pc1JlYWNoYWJsZUZyb21PcGFxdWVSb290cyhIYW5kbGU8VW5rbm93bj46 OndyYXBTbG90KG5vZGUtPnNsb3QoKSksIG5vZGUtPndlYWtPd25lckNvbnRleHQoKSwgbWFya1N0 YWNrKSkKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgaWYgKCF3ZWFrT3duZXIt PmlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKEhhbmRsZTxVbmtub3duPjo6d3JhcFNsb3Qobm9k ZS0+c2xvdCgpKSwgbm9kZS0+d2Vha093bmVyQ29udGV4dCgpLCBtYXJrU3RhY2spKQorICAgICAg ICAgICAgY29udGludWU7CiAKLSAgICAgICAgICAgIGhlYXBSb290TWFya2VyLm1hcmsobm9kZS0+ c2xvdCgpKTsKLSAgICAgICAgfQotICAgIH0gd2hpbGUgKG9sZENvdW50ICE9IG1hcmtTdGFjay5v cGFxdWVSb290Q291bnQoKSk7IC8vIElmIHRoZSBzZXQgb2Ygb3BhcXVlIHJvb3RzIGhhcyBncm93 biwgbW9yZSBoYW5kbGVzIG1heSBoYXZlIGJlY29tZSByZWFjaGFibGUuCisgICAgICAgIGhlYXBS b290TWFya2VyLm1hcmsobm9kZS0+c2xvdCgpKTsKKyAgICB9CiB9CiAKIHZvaWQgSGFuZGxlSGVh cDo6ZmluYWxpemVXZWFrSGFuZGxlcygpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmNwcAkocmV2aXNpb24gODM4ODEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQwLDE2ICsyNDAsMjcgQEAgdm9pZCBIZWFwOjptYXJr Um9vdHMoKQogICAgIG1hcmtTdGFjay5kcmFpbigpOwogCiAgICAgbV9oYW5kbGVIZWFwLm1hcmtT dHJvbmdIYW5kbGVzKGhlYXBSb290TWFya2VyKTsKLSAgICBtX2hhbmRsZVN0YWNrLm1hcmsoaGVh cFJvb3RNYXJrZXIpOworICAgIG1hcmtTdGFjay5kcmFpbigpOwogCi0gICAgbV9oYW5kbGVIZWFw Lm1hcmtXZWFrSGFuZGxlcyhoZWFwUm9vdE1hcmtlcik7CisgICAgbV9oYW5kbGVTdGFjay5tYXJr KGhlYXBSb290TWFya2VyKTsKICAgICBtYXJrU3RhY2suZHJhaW4oKTsKIAotICAgIC8vIE1hcmsg dGhlIHNtYWxsIHN0cmluZ3MgY2FjaGUgbGFzdCwgc2luY2UgaXQgd2lsbCBjbGVhciBpdHNlbGYg aWYgbm90aGluZwotICAgIC8vIGVsc2UgaGFzIG1hcmtlZCBpdC4KKyAgICAvLyBNYXJrIHRoZSBz bWFsbCBzdHJpbmdzIGNhY2hlIGFzIGxhdGUgYXMgcG9zc2libGUsIHNpbmNlIGl0IHdpbGwgY2xl YXIKKyAgICAvLyBpdHNlbGYgaWYgbm90aGluZyBlbHNlIGhhcyBtYXJrZWQgaXQuCisgICAgLy8g RklYTUU6IENoYW5nZSB0aGUgc21hbGwgc3RyaW5ncyBjYWNoZSB0byB1c2UgV2VhazxUPi4KICAg ICBtX2dsb2JhbERhdGEtPnNtYWxsU3RyaW5ncy5tYXJrQ2hpbGRyZW4oaGVhcFJvb3RNYXJrZXIp OwogICAgIG1hcmtTdGFjay5kcmFpbigpOwogICAgIAorICAgIC8vIFdlYWsgaGFuZGxlcyBtdXN0 IGJlIG1hcmtlZCBsYXN0LCBiZWNhdXNlIHRoZWlyIG93bmVycyB1c2UgdGhlIHNldCBvZgorICAg IC8vIG9wYXF1ZSByb290cyB0byBkZXRlcm1pbmUgcmVhY2hhYmlsaXR5LgorICAgIGludCBsYXN0 T3BhcXVlUm9vdENvdW50OworICAgIGRvIHsKKyAgICAgICAgbGFzdE9wYXF1ZVJvb3RDb3VudCA9 IG1hcmtTdGFjay5vcGFxdWVSb290Q291bnQoKTsKKyAgICAgICAgbV9oYW5kbGVIZWFwLm1hcmtX ZWFrSGFuZGxlcyhoZWFwUm9vdE1hcmtlcik7CisgICAgICAgIG1hcmtTdGFjay5kcmFpbigpOwor ICAgIC8vIElmIHRoZSBzZXQgb2Ygb3BhcXVlIHJvb3RzIGhhcyBncm93biwgbW9yZSB3ZWFrIGhh bmRsZXMgbWF5IGhhdmUgYmVjb21lIHJlYWNoYWJsZS4KKyAgICB9IHdoaWxlIChsYXN0T3BhcXVl Um9vdENvdW50ICE9IG1hcmtTdGFjay5vcGFxdWVSb290Q291bnQoKSk7CisKICAgICBtYXJrU3Rh Y2sucmVzZXQoKTsKIAogICAgIG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9IE5vT3BlcmF0aW9uOwo=