<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>58573</bug_id>
          
          <creation_ts>2011-04-14 14:34:38 -0700</creation_ts>
          <short_desc>Since gcc 4.5.0, windows x64 symbols are not prefixed by underscore</short_desc>
          <delta_ts>2011-04-15 18:21:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Fridrich Strba">fridrich.strba</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>aroben</cc>
    
    <cc>barraclough</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>mrobinson</cc>
    
    <cc>oliver</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>386037</commentid>
    <comment_count>0</comment_count>
    <who name="Fridrich Strba">fridrich.strba</who>
    <bug_when>2011-04-14 14:34:38 -0700</bug_when>
    <thetext>Fix this in JavaScriptCore</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386041</commentid>
    <comment_count>1</comment_count>
      <attachid>89649</attachid>
    <who name="Fridrich Strba">fridrich.strba</who>
    <bug_when>2011-04-14 14:38:10 -0700</bug_when>
    <thetext>Created attachment 89649
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386048</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-14 14:40:43 -0700</bug_when>
    <thetext>Attachment 89649 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1

Source/JavaScriptCore/jit/JITStubs.cpp:84:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>386103</commentid>
    <comment_count>3</comment_count>
      <attachid>89669</attachid>
    <who name="Fridrich Strba">fridrich.strba</who>
    <bug_when>2011-04-14 15:20:07 -0700</bug_when>
    <thetext>Created attachment 89669
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387023</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-15 16:33:14 -0700</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 89669:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387027</commentid>
    <comment_count>5</comment_count>
      <attachid>89669</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-15 16:36:07 -0700</bug_when>
    <thetext>Comment on attachment 89669
Patch

Clearing flags on attachment: 89669

Committed r84048: &lt;http://trac.webkit.org/changeset/84048&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387028</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2011-04-15 16:36:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>387128</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-15 18:21:44 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84048 might have broken WinCairo Debug (Build)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89649</attachid>
            <date>2011-04-14 14:38:10 -0700</date>
            <delta_ts>2011-04-14 15:20:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58573-20110414233808.patch</filename>
            <type>text/plain</type>
            <size>1526</size>
            <attacher name="Fridrich Strba">fridrich.strba</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM4OTQpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTEtMDQtMTQgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0
bHkgcHJlZml4IHN5bWJvbHMuIFNpbmNlIGdjYyA0LjUuMCwgV2luZG93cyB4NjQgc3ltYm9scwor
ICAgICAgICBhcmUgbm90IHByZWZpeGVkIGJ5IHVuZGVyc2NvcmUgYW55bW9yZS4gVGhpcyBpcyBj
b25zaXN0ZW50IHdpdGgKKyAgICAgICAgd2hhdCBNU1ZDIGRvZXMuCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODU3MworCisgICAgICAgICogaml0L0pJ
VFN0dWJzLmNwcDoKKwogMjAxMS0wNC0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29t
PgogCiAgICAgICAgIFRlbXBvcmFyaWx5IHJlbW92ZSBhc3NlcnRpb24gdGhhdCdzIGZpcmluZyBh
bGwgdGhlIHRpbWUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcAko
cmV2aXNpb24gODM4OTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcsNyBAQCB1c2luZyBuYW1lc3BhY2Ugc3RkOwog
CiBuYW1lc3BhY2UgSlNDIHsKIAotI2lmIE9TKERBUldJTikgfHwgT1MoV0lORE9XUykKKyNpZiBP
UyhEQVJXSU4pIHx8IChPUyhXSU5ET1dTKSAmJiBDUFUoWDg2KSkKICNkZWZpbmUgU1lNQk9MX1NU
UklORyhuYW1lKSAiXyIgI25hbWUKICNlbHNlCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkcobmFtZSkg
I25hbWUKQEAgLTgxLDcgKzgxLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICNpZiAoT1MoTElOVVgp
IHx8IE9TKEZSRUVCU0QpKSAmJiBDUFUoWDg2XzY0KQogI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JF
TE9DQVRJT04obmFtZSkgI25hbWUgIkBwbHQiCi0jZWxpZiBPUyhEQVJXSU4pCisjZWxpZiBPUyhE
QVJXSU4pIHx8IChDUFUoWDg2XzY0KSAmJiBDT01QSUxFUihNSU5HVykgJiYgIUdDQ19WRVJTSU9O
X0FUX0xFQVNUKDQsNSwwKSkKICNkZWZpbmUgU1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUp
ICJfIiAjbmFtZQogI2VsaWYgQ1BVKFg4NikgJiYgQ09NUElMRVIoTUlOR1cpCiAjZGVmaW5lIFNZ
TUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAiQCIgI25hbWUgIkA0Igo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>89669</attachid>
            <date>2011-04-14 15:20:07 -0700</date>
            <delta_ts>2011-04-15 16:36:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-58573-20110415002005.patch</filename>
            <type>text/plain</type>
            <size>1528</size>
            <attacher name="Fridrich Strba">fridrich.strba</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM4OTUpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTEtMDQtMTQgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3JyZWN0
bHkgcHJlZml4IHN5bWJvbHMuIFNpbmNlIGdjYyA0LjUuMCwgV2luZG93cyB4NjQgc3ltYm9scwor
ICAgICAgICBhcmUgbm90IHByZWZpeGVkIGJ5IHVuZGVyc2NvcmUgYW55bW9yZS4gVGhpcyBpcyBj
b25zaXN0ZW50IHdpdGgKKyAgICAgICAgd2hhdCBNU1ZDIGRvZXMuCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODU3MworCisgICAgICAgICogaml0L0pJ
VFN0dWJzLmNwcDoKKwogMjAxMS0wNC0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29t
PgogCiAgICAgICAgIFRlbXBvcmFyaWx5IHJlbW92ZSBhc3NlcnRpb24gdGhhdCdzIGZpcmluZyBh
bGwgdGhlIHRpbWUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcAko
cmV2aXNpb24gODM4OTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNw
cAkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcsNyBAQCB1c2luZyBuYW1lc3BhY2Ugc3RkOwog
CiBuYW1lc3BhY2UgSlNDIHsKIAotI2lmIE9TKERBUldJTikgfHwgT1MoV0lORE9XUykKKyNpZiBP
UyhEQVJXSU4pIHx8IChPUyhXSU5ET1dTKSAmJiBDUFUoWDg2KSkKICNkZWZpbmUgU1lNQk9MX1NU
UklORyhuYW1lKSAiXyIgI25hbWUKICNlbHNlCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkcobmFtZSkg
I25hbWUKQEAgLTgxLDcgKzgxLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICNpZiAoT1MoTElOVVgp
IHx8IE9TKEZSRUVCU0QpKSAmJiBDUFUoWDg2XzY0KQogI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JF
TE9DQVRJT04obmFtZSkgI25hbWUgIkBwbHQiCi0jZWxpZiBPUyhEQVJXSU4pCisjZWxpZiBPUyhE
QVJXSU4pIHx8IChDUFUoWDg2XzY0KSAmJiBDT01QSUxFUihNSU5HVykgJiYgIUdDQ19WRVJTSU9O
X0FUX0xFQVNUKDQsIDUsIDApKQogI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFt
ZSkgIl8iICNuYW1lCiAjZWxpZiBDUFUoWDg2KSAmJiBDT01QSUxFUihNSU5HVykKICNkZWZpbmUg
U1lNQk9MX1NUUklOR19SRUxPQ0FUSU9OKG5hbWUpICJAIiAjbmFtZSAiQDQiCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>