58572 2011-04-14 14:28:32 -0700 Implement a cross-platform version of ExecutableAllocator::intializePageSize() 2011-06-02 08:26:57 -0700 1 1 1 Unclassified WebKit Java 528+ (Nightly build) Mac (Intel) Windows 2000 RESOLVED DUPLICATE 61384 P2 Normal --- 0 fridrich.strba webkit-unassigned aroben gustavo.noronha gustavo mrobinson xan.lopez oldest_to_newest 386033 0 fridrich.strba 2011-04-14 14:28:32 -0700 Get page size on windows using win32 api 386035 1 89648 fridrich.strba 2011-04-14 14:31:54 -0700 Created attachment 89648 Patch 386110 2 mrobinson 2011-04-14 15:35:22 -0700 How is this working on the Safari Windows port? 386541 3 aroben 2011-04-15 06:19:57 -0700 We don't use ExecutableAllocatorFixedVMPool.cpp on Windows, apparently. 386550 4 fridrich.strba 2011-04-15 06:31:31 -0700 (In reply to comment #3) > We don't use ExecutableAllocatorFixedVMPool.cpp on Windows, apparently. So, it should not hurt anybody to get this in then :) 386993 5 89648 oliver 2011-04-15 15:43:15 -0700 Comment on attachment 89648 Patch A better solution would be to replace the call to getpagesize with WTF::pageSize() which does the right thing for every platform. 398365 6 92341 fridrich.strba 2011-05-04 16:15:44 -0700 Created attachment 92341 Patch 398368 7 92341 fridrich.strba 2011-05-04 16:16:47 -0700 Comment on attachment 92341 Patch Using WTF::pageSize() as per review comment. 398612 8 gustavo.noronha 2011-05-05 01:29:15 -0700 Attachment 92341 did not build on gtk: Build output: http://queues.webkit.org/results/8571356 403436 9 93417 fridrich.strba 2011-05-13 01:56:45 -0700 Created attachment 93417 Patch 403442 10 fridrich.strba 2011-05-13 02:21:41 -0700 Since now the EWS is showing no breakages, can this one get a positive review and commit queue approval? 410757 11 fridrich.strba 2011-05-26 12:57:32 -0700 Ping someone? 410760 12 aroben 2011-05-26 13:03:35 -0700 Looks like this was fixed in r87198. *** This bug has been marked as a duplicate of bug 61384 *** 414134 13 93417 eric 2011-06-02 08:26:57 -0700 Comment on attachment 93417 Patch Cleared review? from attachment 93417 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 89648 2011-04-14 14:31:54 -0700 2011-05-04 16:15:36 -0700 Patch bug-58572-20110414233152.patch text/plain 1600 fridrich.strba SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM4OTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDQtMTQgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1l bnQgdGhlIFdpbmRvd3MgdmVyc2lvbiBFeGVjdXRhYmxlQWxsb2NhdG9yOjppbnRpYWxpemVQYWdl U2l6ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 ODU3MgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHA6 CisgICAgICAgIChKU0M6OkV4ZWN1dGFibGVBbGxvY2F0b3I6OmludGlhbGl6ZVBhZ2VTaXplKToK KwogMjAxMS0wNC0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFRlbXBvcmFyaWx5IHJlbW92ZSBhc3NlcnRpb24gdGhhdCdzIGZpcmluZyBhbGwgdGhlIHRpbWUu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhl ZFZNUG9vbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVj dXRhYmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCShyZXZpc2lvbiA4Mzg5MikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzIsOCArMzIsMTIgQEAKICNpbmNsdWRlIDxlcnJuby5oPgogCiAj aW5jbHVkZSAiVENTcGluTG9jay5oIgorI2lmIE9TKFdJTkRPV1MpCisjaW5jbHVkZSA8d2luZG93 cy5oPgorI2Vsc2UKICNpbmNsdWRlIDxzeXMvbW1hbi5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgor I2VuZGlmCiAjaW5jbHVkZSA8d3RmL0FWTFRyZWUuaD4KICNpbmNsdWRlIDx3dGYvUGFnZVJlc2Vy dmF0aW9uLmg+CiAjaW5jbHVkZSA8d3RmL1ZNVGFncy5oPgpAQCAtNDkzLDcgKzQ5NywxMyBAQCBz aXplX3QgRXhlY3V0YWJsZUFsbG9jYXRvcjo6Y29tbWl0dGVkQnl0CiAKIHZvaWQgRXhlY3V0YWJs ZUFsbG9jYXRvcjo6aW50aWFsaXplUGFnZVNpemUoKQogeworI2lmIE9TKFdJTkRPV1MpCisgICAg U1lTVEVNX0lORk8gc3lzdGVtSW5mbzsKKyAgICBHZXRTeXN0ZW1JbmZvKCZzeXN0ZW1JbmZvKTsK KyAgICBFeGVjdXRhYmxlQWxsb2NhdG9yOjpwYWdlU2l6ZSA9IHN5c3RlbUluZm8uZHdQYWdlU2l6 ZTsKKyNlbHNlCiAgICAgRXhlY3V0YWJsZUFsbG9jYXRvcjo6cGFnZVNpemUgPSBnZXRwYWdlc2l6 ZSgpOworI2VuZGlmCiB9CiAKIGJvb2wgRXhlY3V0YWJsZUFsbG9jYXRvcjo6aXNWYWxpZCgpIGNv bnN0Cg== 92341 2011-05-04 16:15:44 -0700 2011-05-13 01:56:35 -0700 Patch bug-58572-20110505011542.patch text/plain 1521 fridrich.strba SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODU3OTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDUtMDUgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1l bnQgYSBjcm9zcy1wbGF0Zm9ybSB2ZXJzaW9uIG9mIEV4ZWN1dGFibGVBbGxvY2F0b3I6OmludGlh bGl6ZVBhZ2VTaXplKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU4NTcyCisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Q b29sLmNwcDoKKyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZUFsbG9jYXRvcjo6aW50aWFsaXplUGFn ZVNpemUpOiB1c2UgV1RGOjpwYWdlU2l6ZSgpIHRvIGdldCB0aGUKKyAgICAgICAgcGFnZSBzaXpl IGluIGEgY3Jvc3MtcGxhdGZvcm0gd2F5LgorCiAyMDExLTA1LTA0ICBUYW8gQmFpICA8bWljaGFl bGJhaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRW TVBvb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0 YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkocmV2aXNpb24gODU3ODgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTMyLDggKzMyLDEwIEBACiAjaW5jbHVkZSA8ZXJybm8uaD4KIAogI2lu Y2x1ZGUgIlRDU3BpbkxvY2suaCIKKyNpZiAhT1MoV0lORE9XUykKICNpbmNsdWRlIDxzeXMvbW1h bi5oPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgorI2VuZGlmCiAjaW5jbHVkZSA8d3RmL0FWTFRyZWUu aD4KICNpbmNsdWRlIDx3dGYvUGFnZVJlc2VydmF0aW9uLmg+CiAjaW5jbHVkZSA8d3RmL1ZNVGFn cy5oPgpAQCAtNDkzLDcgKzQ5NSw3IEBAIHNpemVfdCBFeGVjdXRhYmxlQWxsb2NhdG9yOjpjb21t aXR0ZWRCeXQKIAogdm9pZCBFeGVjdXRhYmxlQWxsb2NhdG9yOjppbnRpYWxpemVQYWdlU2l6ZSgp CiB7Ci0gICAgRXhlY3V0YWJsZUFsbG9jYXRvcjo6cGFnZVNpemUgPSBnZXRwYWdlc2l6ZSgpOwor ICAgIEV4ZWN1dGFibGVBbGxvY2F0b3I6OnBhZ2VTaXplID0gcGFnZVNpemUoKTsKIH0KIAogYm9v bCBFeGVjdXRhYmxlQWxsb2NhdG9yOjppc1ZhbGlkKCkgY29uc3QK 93417 2011-05-13 01:56:45 -0700 2011-06-02 08:26:57 -0700 Patch bug-58572-20110513105643.patch text/plain 1525 fridrich.strba SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODY0MjApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDUtMTMgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1ZXdpbi5jaD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1l bnQgYSBjcm9zcy1wbGF0Zm9ybSB2ZXJzaW9uIG9mIEV4ZWN1dGFibGVBbGxvY2F0b3I6OmludGlh bGl6ZVBhZ2VTaXplKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU4NTcyCisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Q b29sLmNwcDoKKyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZUFsbG9jYXRvcjo6aW50aWFsaXplUGFn ZVNpemUpOiB1c2UgV1RGOjpwYWdlU2l6ZSgpIHRvIGdldCB0aGUKKyAgICAgICAgcGFnZSBzaXpl IGluIGEgY3Jvc3MtcGxhdGZvcm0gd2F5LgorCiAyMDExLTA1LTEyICBNYWNpZWogU3RhY2hvd2lh ayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZN UG9vbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRh YmxlQWxsb2NhdG9yRml4ZWRWTVBvb2wuY3BwCShyZXZpc2lvbiA4NjQyMCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzIsOCArMzIsMTAgQEAKICNpbmNsdWRlIDxlcnJuby5oPgogCiAjaW5j bHVkZSAiVENTcGluTG9jay5oIgorI2lmICFPUyhXSU5ET1dTKQogI2luY2x1ZGUgPHN5cy9tbWFu Lmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CisjZW5kaWYKICNpbmNsdWRlIDx3dGYvQVZMVHJlZS5o PgogI2luY2x1ZGUgPHd0Zi9QYWdlUmVzZXJ2YXRpb24uaD4KICNpbmNsdWRlIDx3dGYvVk1UYWdz Lmg+CkBAIC00OTMsNyArNDk1LDcgQEAgc2l6ZV90IEV4ZWN1dGFibGVBbGxvY2F0b3I6OmNvbW1p dHRlZEJ5dAogCiB2b2lkIEV4ZWN1dGFibGVBbGxvY2F0b3I6OmludGlhbGl6ZVBhZ2VTaXplKCkK IHsKLSAgICBFeGVjdXRhYmxlQWxsb2NhdG9yOjpwYWdlU2l6ZSA9IGdldHBhZ2VzaXplKCk7Cisg ICAgRXhlY3V0YWJsZUFsbG9jYXRvcjo6cGFnZVNpemUgPSBXVEY6OnBhZ2VTaXplKCk7CiB9CiAK IGJvb2wgRXhlY3V0YWJsZUFsbG9jYXRvcjo6aXNWYWxpZCgpIGNvbnN0Cg==