58570 2011-04-14 14:27:55 -0700 Make creating WebPreferences lazy 2011-04-14 14:39:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 386031 0 sam 2011-04-14 14:27:55 -0700 Make creating WebPreferences lazy 386034 1 89647 sam 2011-04-14 14:29:04 -0700 Created attachment 89647 Patch 386036 2 89647 andersca 2011-04-14 14:34:15 -0700 Comment on attachment 89647 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89647&action=review > Source/WebKit2/ChangeLog:14 > + Don't create the WebPrefernece object until it is requested. Typo > Source/WebKit2/UIProcess/WebPageGroup.cpp:101 > + m_preferences->addPageGroup(this); We don't need to call preferencesDidChange() here? 386043 3 sam 2011-04-14 14:39:30 -0700 Landed in r83895. 89647 2011-04-14 14:29:04 -0700 2011-04-14 14:34:15 -0700 Patch bug-58570-20110414142903.patch text/plain 3387 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzODk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTQgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIGNyZWF0aW5nIFdlYlByZWZlcmVuY2VzIGxhenkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NTcwCisKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZUdyb3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZUdy b3VwOjpXZWJQYWdlR3JvdXApOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlR3JvdXA6On5XZWJQ YWdlR3JvdXApOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlR3JvdXA6OnNldFByZWZlcmVuY2Vz KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZUdyb3VwOjpwcmVmZXJlbmNlcyk6CisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VHcm91cC5oOgorICAgICAgICBEb24ndCBjcmVhdGUgdGhlIFdl YlByZWZlcm5lY2Ugb2JqZWN0IHVudGlsIGl0IGlzIHJlcXVlc3RlZC4KKwogMjAxMS0wNC0xNCAg UHJhdGlrIFNvbGFua2kgIDxwc29sYW5raUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgS2lsemVyLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VH cm91cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VH cm91cC5jcHAJKHJldmlzaW9uIDgzODkxKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VHcm91cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDE0ICs2NSwxMCBAQCBXZWJQYWdl R3JvdXA6OldlYlBhZ2VHcm91cChjb25zdCBTdHJpbmcmCiB7CiAgICAgbV9kYXRhLnBhZ2VHcm91 cElEID0gZ2VuZXJhdGVQYWdlR3JvdXBJRCgpOwogCi0gICAgaWYgKCFpZGVudGlmaWVyLmlzTnVs bCgpKSB7CisgICAgaWYgKCFpZGVudGlmaWVyLmlzTnVsbCgpKQogICAgICAgICBtX2RhdGEuaWRl bnRpZmVyID0gaWRlbnRpZmllcjsKLSAgICAgICAgbV9wcmVmZXJlbmNlcyA9IFdlYlByZWZlcmVu Y2VzOjpjcmVhdGUoaWRlbnRpZmllcik7Ci0gICAgfSBlbHNlIHsKKyAgICBlbHNlCiAgICAgICAg IG1fZGF0YS5pZGVudGlmZXIgPSBtX2RhdGEuaWRlbnRpZmVyID0gbWFrZVN0cmluZygiX191bmlx dWVQYWdlR3JvdXBJRC0iLCBTdHJpbmc6Om51bWJlcihtX2RhdGEucGFnZUdyb3VwSUQpKTsKLSAg ICAgICAgbV9wcmVmZXJlbmNlcyA9IFdlYlByZWZlcmVuY2VzOjpjcmVhdGUoKTsKLSAgICB9Ci0g ICAgbV9wcmVmZXJlbmNlcy0+YWRkUGFnZUdyb3VwKHRoaXMpOwogCiAgICAgbV9kYXRhLnZpc2li bGVUb0luamVjdGVkQnVuZGxlID0gdmlzaWJsZVRvSW5qZWN0ZWRCdW5kbGU7CiAgICAgbV9kYXRh LnZpc2libGVUb0hpc3RvcnlDbGllbnQgPSB2aXNpYmxlVG9IaXN0b3J5Q2xpZW50OwpAQCAtODAs NyArNzYsOCBAQCBXZWJQYWdlR3JvdXA6OldlYlBhZ2VHcm91cChjb25zdCBTdHJpbmcmCiAKIFdl YlBhZ2VHcm91cDo6fldlYlBhZ2VHcm91cCgpCiB7Ci0gICAgbV9wcmVmZXJlbmNlcy0+cmVtb3Zl UGFnZUdyb3VwKHRoaXMpOworICAgIGlmIChtX3ByZWZlcmVuY2VzKQorICAgICAgICBtX3ByZWZl cmVuY2VzLT5yZW1vdmVQYWdlR3JvdXAodGhpcyk7CiAgICAgd2ViUGFnZUdyb3VwTWFwKCkucmVt b3ZlKHBhZ2VHcm91cElEKCkpOwogfQogCkBAIC05OSwxNSArOTYsMjcgQEAgdm9pZCBXZWJQYWdl R3JvdXA6OnNldFByZWZlcmVuY2VzKFdlYlByZQogICAgIGlmIChwcmVmZXJlbmNlcyA9PSBtX3By ZWZlcmVuY2VzKQogICAgICAgICByZXR1cm47CiAKLSAgICBtX3ByZWZlcmVuY2VzLT5yZW1vdmVQ YWdlR3JvdXAodGhpcyk7Ci0gICAgbV9wcmVmZXJlbmNlcyA9IHByZWZlcmVuY2VzOwotICAgIG1f cHJlZmVyZW5jZXMtPmFkZFBhZ2VHcm91cCh0aGlzKTsKKyAgICBpZiAoIW1fcHJlZmVyZW5jZXMp IHsKKyAgICAgICAgbV9wcmVmZXJlbmNlcyA9IHByZWZlcmVuY2VzOworICAgICAgICBtX3ByZWZl cmVuY2VzLT5hZGRQYWdlR3JvdXAodGhpcyk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgbV9wcmVm ZXJlbmNlcy0+cmVtb3ZlUGFnZUdyb3VwKHRoaXMpOworICAgICAgICBtX3ByZWZlcmVuY2VzID0g cHJlZmVyZW5jZXM7CisgICAgICAgIG1fcHJlZmVyZW5jZXMtPmFkZFBhZ2VHcm91cCh0aGlzKTsK IAotICAgIHByZWZlcmVuY2VzRGlkQ2hhbmdlKCk7CisgICAgICAgIHByZWZlcmVuY2VzRGlkQ2hh bmdlKCk7CisgICAgfQogfQogCiBXZWJQcmVmZXJlbmNlcyogV2ViUGFnZUdyb3VwOjpwcmVmZXJl bmNlcygpIGNvbnN0CiB7CisgICAgaWYgKCFtX3ByZWZlcmVuY2VzKSB7CisgICAgICAgIGlmICgh bV9kYXRhLmlkZW50aWZlci5pc051bGwoKSkKKyAgICAgICAgICAgIG1fcHJlZmVyZW5jZXMgPSBX ZWJQcmVmZXJlbmNlczo6Y3JlYXRlKG1fZGF0YS5pZGVudGlmZXIpOworICAgICAgICBlbHNlCisg ICAgICAgICAgICBtX3ByZWZlcmVuY2VzID0gV2ViUHJlZmVyZW5jZXM6OmNyZWF0ZSgpOworICAg ICAgICBtX3ByZWZlcmVuY2VzLT5hZGRQYWdlR3JvdXAoY29uc3RfY2FzdDxXZWJQYWdlR3JvdXAq Pih0aGlzKSk7CisgICAgfQogICAgIHJldHVybiBtX3ByZWZlcmVuY2VzLmdldCgpOwogfQogCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZUdyb3VwLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VHcm91cC5oCShyZXZpc2lvbiA4Mzg5 MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlR3JvdXAuaAkod29ya2luZyBj b3B5KQpAQCAtNjMsNyArNjMsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgVHlwZSB0eXBlKCkg Y29uc3QgeyByZXR1cm4gQVBJVHlwZTsgfQogCiAgICAgV2ViUGFnZUdyb3VwRGF0YSBtX2RhdGE7 Ci0gICAgUmVmUHRyPFdlYlByZWZlcmVuY2VzPiBtX3ByZWZlcmVuY2VzOworICAgIG11dGFibGUg UmVmUHRyPFdlYlByZWZlcmVuY2VzPiBtX3ByZWZlcmVuY2VzOwogICAgIEhhc2hTZXQ8V2ViUGFn ZVByb3h5Kj4gbV9wYWdlczsKIH07CiAK