58562 2011-04-14 13:01:06 -0700 queues.webkit.org should display when a bot last rebooted 2011-04-15 00:54:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue mihaip ojan oldest_to_newest 385969 0 eric 2011-04-14 13:01:06 -0700 queues.webkit.org should display when a bot last rebooted 385974 1 89632 eric 2011-04-14 13:04:19 -0700 Created attachment 89632 Patch 385989 2 89632 mihaip 2011-04-14 13:16:56 -0700 Comment on attachment 89632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89632&action=review > Tools/QueueStatusServer/templates/queuestatus.html:12 > +Last Pass: {{ last_pass.date|timesince }} ago You may be able to move this to a sub-template that you then use {% with "foo" as param %} {%include "summary_snippet.html" %} {% endwidth %} However, this is kind of awkward pre-Django 1.3 (where you can specify the parameters directly in the include tag: http://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#include), since you need a with statement per parameter. I'd say the repetition is fine for just two places. 386460 3 89632 commit-queue 2011-04-15 00:54:43 -0700 Comment on attachment 89632 Patch Clearing flags on attachment: 89632 Committed r83956: <http://trac.webkit.org/changeset/83956> 386461 4 commit-queue 2011-04-15 00:54:49 -0700 All reviewed patches have been landed. Closing bug. 89632 2011-04-14 13:04:19 -0700 2011-04-15 00:54:43 -0700 Patch bug-58562-20110414130418.patch text/plain 3519 eric U3VidmVyc2lvbiBSZXZpc2lvbjogODM4ODEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1YjliOWI4ZjNkNmIzYWZmYTkxZWFjNGIyZGY2MmMyYWE0 YWQwNGUxLi5iOTA4NzQ0NzQ2OTNkZjkzZThjMjU5ZTdjZWIwZDAwMWIxYWEwMzA1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMDQtMTQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXVlcy53ZWJraXQub3Jn IHNob3VsZCBkaXNwbGF5IHdoZW4gYSBib3QgbGFzdCByZWJvb3RlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg1NjIKKworICAgICAgICBUaGVyZSBp cyBtb3JlIHJlcGVhdGVkIGNvZGUgaGVyZSB0aGFuIEkgd291bGQgbGlrZS4gIEkgZmVhcgorICAg ICAgICBteSBkamFuZ28tZnUgaXNuJ3QgcXVpdGUgdXAgdG8gc251ZmYuCisKKyAgICAgICAgKiBR dWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weToKKyAgICAgICAgKiBRdWV1 ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcXVldWVzdGF0dXMuaHRtbDoKKworMjAxMS0wNC0xNCAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlt aXRyaSBHbGF6a292LgogCiAgICAgICAgIHF1ZXVlcy53ZWJraXQub3JnIHNob3VsZCBkaXNwbGF5 IHdoZW4gYSBib3QgbGFzdCBwYXNzZWQgYSBwYXRjaApkaWZmIC0tZ2l0IGEvVG9vbHMvUXVldWVT dGF0dXNTZXJ2ZXIvaGFuZGxlcnMvcXVldWVzdGF0dXMucHkgYi9Ub29scy9RdWV1ZVN0YXR1c1Nl cnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weQppbmRleCBmYzgzOGY0MjViMjkzYTNmNDk1NTc4 NDViMjE0YzFmMzU3YjM0YmYxLi43YTVmYmQ4OGM5MGYyMGZmZGIxOWNlZmJjNWQ2ZjgxYjI4ZmUz MWZlIDEwMDY0NAotLS0gYS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0 YXR1cy5weQorKysgYi9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1 cy5weQpAQCAtNjMsMTIgKzYzLDEyIEBAIGNsYXNzIFF1ZXVlU3RhdHVzKHdlYmFwcC5SZXF1ZXN0 SGFuZGxlcik6CiAgICAgICAgICAgICBzdGF0dXNlcy5maWx0ZXIoImJvdF9pZCA9IiwgYm90X2lk KQogICAgICAgICByZXR1cm4gc3RhdHVzZXMub3JkZXIoIi1kYXRlIikuZmV0Y2goMTUpCiAKLSAg ICBkZWYgX2ZldGNoX2xhc3RfcGFzcyhzZWxmLCBxdWV1ZSwgYm90X2lkKToKKyAgICBkZWYgX2Zl dGNoX2xhc3RfbWVzc2FnZV9tYXRjaGluZyhzZWxmLCBxdWV1ZSwgYm90X2lkLCBtZXNzYWdlKToK ICAgICAgICAgc3RhdHVzZXMgPSBxdWV1ZXN0YXR1cy5RdWV1ZVN0YXR1cy5hbGwoKQogICAgICAg ICBzdGF0dXNlcyA9IHN0YXR1c2VzLmZpbHRlcigicXVldWVfbmFtZSA9IiwgcXVldWUubmFtZSgp KQogICAgICAgICBpZiBib3RfaWQ6CiAgICAgICAgICAgICBzdGF0dXNlcy5maWx0ZXIoImJvdF9p ZCA9IiwgYm90X2lkKQotICAgICAgICBzdGF0dXNlcy5maWx0ZXIoIm1lc3NhZ2UgPSIsICJQYXNz IikKKyAgICAgICAgc3RhdHVzZXMuZmlsdGVyKCJtZXNzYWdlID0iLCBtZXNzYWdlKQogICAgICAg ICByZXR1cm4gc3RhdHVzZXMub3JkZXIoIi1kYXRlIikuZ2V0KCkKIAogICAgIGRlZiBfcGFnZV90 aXRsZShzZWxmLCBxdWV1ZSwgYm90X2lkKToKQEAgLTg1LDEyICs4NSwxMiBAQCBjbGFzcyBRdWV1 ZVN0YXR1cyh3ZWJhcHAuUmVxdWVzdEhhbmRsZXIpOgogICAgICAgICAgICAgcmV0dXJuCiAKICAg ICAgICAgc3RhdHVzZXMgPSBzZWxmLl9mZXRjaF9zdGF0dXNlcyhxdWV1ZSwgYm90X2lkKQotICAg ICAgICBsYXN0X3Bhc3MgPSBzZWxmLl9mZXRjaF9sYXN0X3Bhc3MocXVldWUsIGJvdF9pZCkKICAg ICAgICAgdGVtcGxhdGVfdmFsdWVzID0gewogICAgICAgICAgICAgInBhZ2VfdGl0bGUiOiBzZWxm Ll9wYWdlX3RpdGxlKHF1ZXVlLCBib3RfaWQpLAogICAgICAgICAgICAgIndvcmtfaXRlbV9yb3dz Ijogc2VsZi5fcm93c19mb3Jfd29ya19pdGVtcyhxdWV1ZSksCiAgICAgICAgICAgICAic3RhdHVz X2dyb3VwcyI6IHNlbGYuX2J1aWxkX3N0YXR1c19ncm91cHMoc3RhdHVzZXMpLAogICAgICAgICAg ICAgImJvdF9pZCI6IGJvdF9pZCwKLSAgICAgICAgICAgICJsYXN0X3Bhc3MiOiBsYXN0X3Bhc3Ms CisgICAgICAgICAgICAibGFzdF9wYXNzIjogc2VsZi5fZmV0Y2hfbGFzdF9tZXNzYWdlX21hdGNo aW5nKHF1ZXVlLCBib3RfaWQsICJQYXNzIiksCisgICAgICAgICAgICAibGFzdF9ib290Ijogc2Vs Zi5fZmV0Y2hfbGFzdF9tZXNzYWdlX21hdGNoaW5nKHF1ZXVlLCBib3RfaWQsICJTdGFydGluZyBR dWV1ZSIpLAogICAgICAgICB9CiAgICAgICAgIHNlbGYucmVzcG9uc2Uub3V0LndyaXRlKHRlbXBs YXRlLnJlbmRlcigidGVtcGxhdGVzL3F1ZXVlc3RhdHVzLmh0bWwiLCB0ZW1wbGF0ZV92YWx1ZXMp KQpkaWZmIC0tZ2l0IGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVtcGxhdGVzL3F1ZXVlc3Rh dHVzLmh0bWwgYi9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcXVldWVzdGF0dXMu aHRtbAppbmRleCA1Y2UwMmU1NDhjMmMyYzAxNWE5ZTU3YTM4MzYwYzg1MGJiNzEyZGRhLi45Y2Q3 ZTQ4OThmYjE0YjUwNTVhM2I0NWNiZTA4YWZhYzFhZDRlYzk5IDEwMDY0NAotLS0gYS9Ub29scy9R dWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcXVldWVzdGF0dXMuaHRtbAorKysgYi9Ub29scy9R dWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcXVldWVzdGF0dXMuaHRtbApAQCAtNywxMCArNywx OSBAQAogPGJvZHk+CiA8aDE+e3sgcGFnZV90aXRsZSB9fTwvaDE+CiAKLXslIGlmIGxhc3RfcGFz cyAlfQogPGgzPlN1bW1hcnk8L2gzPgotPGRpdj5MYXN0IFBhc3M6IHt7IGxhc3RfcGFzcy5kYXRl fHRpbWVzaW5jZSB9fSBhZ288L2Rpdj4KKzxkaXY+CitMYXN0IFBhc3M6IHt7IGxhc3RfcGFzcy5k YXRlfHRpbWVzaW5jZSB9fSBhZ28KK3slIGlmIG5vdCBib3RfaWQgYW5kIGxhc3RfcGFzcy5ib3Rf aWQgJX0KK2J5IDxhIGhyZWY9Ii9xdWV1ZS1zdGF0dXMve3tsYXN0X3Bhc3MucXVldWVfbmFtZX19 L2JvdHMve3tsYXN0X3Bhc3MuYm90X2lkfX0iPnt7IGxhc3RfcGFzcy5ib3RfaWQgfX08L2E+CiB7 JSBlbmRpZiAlfQorPC9kaXY+Cis8ZGl2PgorTGFzdCBCb290OiB7eyBsYXN0X2Jvb3QuZGF0ZXx0 aW1lc2luY2UgfX0gYWdvCit7JSBpZiBub3QgYm90X2lkIGFuZCBsYXN0X2Jvb3QuYm90X2lkICV9 CitieSA8YSBocmVmPSIvcXVldWUtc3RhdHVzL3t7bGFzdF9ib290LnF1ZXVlX25hbWV9fS9ib3Rz L3t7bGFzdF9ib290LmJvdF9pZH19Ij57eyBsYXN0X2Jvb3QuYm90X2lkIH19PC9hPgoreyUgZW5k aWYgJX0KKzwvZGl2PgogCiA8aDM+UmVjZW50IFN0YXR1czwvaDM+CiAK