58544 2011-04-14 08:01:34 -0700 Don't emit RegExp tables for chromium where they are not used 2011-04-14 08:48:00 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 satish webkit-unassigned oldest_to_newest 385762 0 satish 2011-04-14 08:01:34 -0700 The character tables generated by the create_regex_tables script are used only by the Yarr (Yet another regex runtime) JIT feature. Since the chromium port does not use the Yarr JIT feature, we don't need these tables in the generated code. 385764 1 89583 satish 2011-04-14 08:03:30 -0700 Created attachment 89583 Patch 385773 2 89583 andersca 2011-04-14 08:16:57 -0700 Comment on attachment 89583 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89583&action=review > Source/JavaScriptCore/create_regex_tables:38 > +emitTables = (len(sys.argv) < 2 or sys.argv[1] != "--notables") Could we call this --no-tables instead? 385786 3 satish 2011-04-14 08:48:00 -0700 Committed r83860: <http://trac.webkit.org/changeset/83860> 89583 2011-04-14 08:03:30 -0700 2011-04-14 08:16:57 -0700 Patch bug-58544-20110414160328.patch text/plain 2829 satish ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhmZjRkZjhlMWIxMGI1NDk1Y2VkN2JmMzVkNzhi NDliOTA5YmMxOTkuLjBjMjhmYTAyNzM2ODgzZDNjZDdiZjdiM2UzNDBjOTUwMmM0OGNiZmIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA0LTE0ICBTYXRp c2ggU2FtcGF0aCAgPHNhdGlzaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgZW1pdCBSZWdFeHAgdGFibGVzIGZvciBj aHJvbWl1bSB3aGVyZSB0aGV5IGFyZSBub3QgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg1NDQKKworICAgICAgICAqIEphdmFTY3JpcHRDb3Jl Lmd5cC9KYXZhU2NyaXB0Q29yZS5neXA6CisgICAgICAgICogY3JlYXRlX3JlZ2V4X3RhYmxlczog QWRkZWQgdGhlICItLW5vdGFibGVzIiBjb21tYW5kIGxpbmUgYXJndW1lbnQuCisKIDIwMTEtMDQt MTQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBXaW5DRSBidWlsZCBmaXggZm9yIHI4MzgwOC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAK aW5kZXggOWI5M2Q5NzYxODdiYTUwZjZkZGMxOTcwMDY0ZmQ2ZmVkMGRjMWEzZS4uNGU0ZTM1MWY4 YTY3MjVlOTIzYjYzYzdiMDMyMGQyNjY5MGM3ZGU3MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmd5cC9KYXZhU2NyaXB0Q29yZS5neXAK QEAgLTIwNiwxMCArMjA2LDEzIEBACiAgICAgICAgICAgJ2lucHV0cyc6IFsKICAgICAgICAgICAg ICcuLi9jcmVhdGVfcmVnZXhfdGFibGVzJywKICAgICAgICAgICBdLAorICAgICAgICAgICdhcmd1 bWVudHMnOiBbCisgICAgICAgICAgICAnLS1ub3RhYmxlcycsCisgICAgICAgICAgXSwKICAgICAg ICAgICAnb3V0cHV0cyc6IFsKICAgICAgICAgICAgICc8KElOVEVSTUVESUFURV9ESVIpL1JlZ0V4 cEppdFRhYmxlcy5oJywKICAgICAgICAgICBdLAotICAgICAgICAgICdhY3Rpb24nOiBbJ3B5dGhv bicsICc8QChfaW5wdXRzKScsICc8QChfb3V0cHV0cyknXSwKKyAgICAgICAgICAnYWN0aW9uJzog WydweXRob24nLCAnPEAoX2lucHV0cyknLCAnPEAoX2FyZ3VtZW50cyknLCAnPEAoX291dHB1dHMp J10sCiAgICAgICAgIH0sCiAgICAgICBdLAogICAgICAgJ2luY2x1ZGVfZGlycyc6IFsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jcmVhdGVfcmVnZXhfdGFibGVzIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9yZWdleF90YWJsZXMKaW5kZXggYzZjZTk5NTEyNjM0ZmI4 MWZiMmU1ZDNmMzJhZDdjOGIxOWI1M2NhNi4uYzlmMWU0YzJhMThhNTI0MjZlMTIwNGJmYzg5OWQ5 YTFkOTZlNzhlOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9yZWdl eF90YWJsZXMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9yZWdleF90YWJsZXMK QEAgLTM1LDYgKzM1LDcgQEAgdHlwZXMgPSB7CiBlbnRyaWVzUGVyTGluZSA9IDUwCiBhcnJheXMg PSAiIjsKIGZ1bmN0aW9ucyA9ICIiOworZW1pdFRhYmxlcyA9IChsZW4oc3lzLmFyZ3YpIDwgMiBv ciBzeXMuYXJndlsxXSAhPSAiLS1ub3RhYmxlcyIpCiAKIGZvciBuYW1lLCBjbGFzc2VzIGluIHR5 cGVzLml0ZW1zKCk6CiAgICAgcmFuZ2VzID0gW107CkBAIC01Niw3ICs1Nyw3IEBAIGZvciBuYW1l LCBjbGFzc2VzIGluIHR5cGVzLml0ZW1zKCk6CiAgICAgICAgICAgICByYW5nZXMuYXBwZW5kKCht aW4sbWF4KSkKICAgICByYW5nZXMuc29ydCgpOwogICAgIAotICAgIGlmIGNsYXNzZXNbIlVzZVRh YmxlIl0gYW5kIChub3QgIkludmVyc2UiIGluIGNsYXNzZXMpOgorICAgIGlmIGVtaXRUYWJsZXMg YW5kIGNsYXNzZXNbIlVzZVRhYmxlIl0gYW5kIChub3QgIkludmVyc2UiIGluIGNsYXNzZXMpOgog ICAgICAgICBhcnJheSA9ICgic3RhdGljIGNvbnN0IGNoYXIgXyVzRGF0YVs2NTUzNl0gPSB7XG4i ICUgbmFtZSk7CiAgICAgICAgIGkgPSAwCiAgICAgICAgIGZvciAobWluLG1heCkgaW4gcmFuZ2Vz OgpAQCAtODcsNyArODgsNyBAQCBmb3IgbmFtZSwgY2xhc3NlcyBpbiB0eXBlcy5pdGVtcygpOgog ICAgIGZ1bmN0aW9uID0gIiI7CiAgICAgZnVuY3Rpb24gKz0gKCJDaGFyYWN0ZXJDbGFzcyogJXND cmVhdGUoKVxuIiAlIG5hbWUpCiAgICAgZnVuY3Rpb24gKz0gKCJ7XG4iKQotICAgIGlmIGNsYXNz ZXNbIlVzZVRhYmxlIl06CisgICAgaWYgZW1pdFRhYmxlcyBhbmQgY2xhc3Nlc1siVXNlVGFibGUi XToKICAgICAgICAgaWYgIkludmVyc2UiIGluIGNsYXNzZXM6CiAgICAgICAgICAgICBmdW5jdGlv biArPSAoIiAgICBDaGFyYWN0ZXJDbGFzcyogY2hhcmFjdGVyQ2xhc3MgPSBuZXcgQ2hhcmFjdGVy Q2xhc3MoQ2hhcmFjdGVyQ2xhc3NUYWJsZTo6Y3JlYXRlKF8lc0RhdGEsIHRydWUpKTtcbiIgJSAo Y2xhc3Nlc1siSW52ZXJzZSJdKSkKICAgICAgICAgZWxzZToK