5854 2005-11-28 13:50:09 -0800 Please update build-webkit script to accept additional build arguments from command line 2006-01-07 23:39:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 0 dwood eric oldest_to_newest 24771 0 dwood 2005-11-28 13:50:09 -0800 Often, I want to build webkit with some additional parameters passed into xcodebuild, for instance, DEPLOYMENT_POSTPROCESSING=YES. Currently, this does not seem reasonably easy to do; you have to modify the project files or the build- webkit script. If we could have additional parameters from the command line passed to xcodebuild, it would be possible without much hassle to vary the building process, to do useful things like strip symbols, build universal binary, change the install path, and so forth. 24877 1 dwood 2005-11-29 11:40:44 -0800 MacDome says it's just a matter of adding @ARGV to the lines with xcodebuild ... can somebody confirm? 27290 2 5393 eric 2005-12-30 22:25:46 -0800 Created attachment 5393 fix. 27291 3 dwood 2005-12-30 22:50:30 -0800 The patch seems to do the trick for me. I built webkit as a fat, stripped binary using the following invocation: build-webkit GCC_OPTIMIZATION_LEVEL=s ARCHS='ppc i386' SDKROOT=/Developer/SDKs/ MacOSX10.4u.sdk DEPLOYMENT_POSTPROCESSING=YES GCC_TREAT_WARNINGS_AS_ERRORS=NO Being the probable only client for this fix (except for perhaps bdash), I'm satisfied with the patch. 27294 4 5393 darin 2005-12-30 23:46:40 -0800 Comment on attachment 5393 fix. What removes the "-svg" (or is it "--svg"?) if that is passed as an argument? 27538 5 mjs 2006-01-02 20:34:59 -0800 Moving to r- until Darin's comment is addressed. 27541 6 eric 2006-01-02 20:40:16 -0800 (In reply to comment #4) > (From update of attachment 5393 [edit]) > What removes the "-svg" (or is it "--svg"?) if that is passed as an argument? > Oh, that's automatically done by Getopt::Long At least when it's loaded wiht the "pass through" option, like it is in this script: use Getopt::Long qw(:config pass_through); 27542 7 5393 eric 2006-01-02 20:40:37 -0800 Comment on attachment 5393 fix. I've addressed darin's question in the bug. 27645 8 5393 darin 2006-01-03 13:51:35 -0800 Comment on attachment 5393 fix. OK, r=me. 5393 2005-12-30 22:25:46 -0800 2006-01-03 13:51:35 -0800 fix. build.patch text/plain 1828 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzNgpkaWZmIC1wIC11IC1yMS4x MzYgQ2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMzAgRGVjIDIwMDUgMDc6MDQ6MTAgLTAwMDAJMS4x MzYKKysrIENoYW5nZUxvZwkzMSBEZWMgMjAwNSAwNjoyNzowMSAtMDAwMApAQCAtMSwzICsxLDEy IEBACisyMDA1LTEyLTMxICBFcmljIFNlaWRlbCAgPGVzZWlkZWxAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1aWxkLXdlYmtpdCBz aG91bGQgcGFzcyBvbiBidWlsZCBhcmd1bWVudHMgZnJvbSBjb21tYW5kIGxpbmUKKyAgICAgICAg aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD01ODU0CisKKyAg ICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAwNS0xMi0zMCAgRXJpYyBTZWlkZWwg IDxlc2VpZGVsQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBtanMuCkluZGV4OiBT Y3JpcHRzL2J1aWxkLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0 VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTkKZGlm ZiAtcCAtdSAtcjEuMTkgU2NyaXB0cy9idWlsZC13ZWJraXQKLS0tIFNjcmlwdHMvYnVpbGQtd2Vi a2l0CTE2IERlYyAyMDA1IDAyOjIxOjI3IC0wMDAwCTEuMTkKKysrIFNjcmlwdHMvYnVpbGQtd2Vi a2l0CTMxIERlYyAyMDA1IDA2OjI3OjA0IC0wMDAwCkBAIC03OCwxMyArNzgsMTMgQEAgZm9yIG15 ICRkaXIgKEBwcm9qZWN0cykgewogICAgIGNoZGlyICRkaXIgb3IgZGllOwogICAgIG15ICRyZXN1 bHQ7CiAgICAgaWYgKCEkc3ZnU3VwcG9ydCAmJiAoJGRpciBlcSAiV2ViQ29yZSIpKSB7Ci0gICAg ICAgICRyZXN1bHQgPSBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXByb2plY3QiLCAiJGRpci54Y29k ZXByb2oiLCBAb3B0aW9ucywgIi10YXJnZXQiLCAiJGRpci1uby1TVkciOworICAgICAgICAkcmVz dWx0ID0gc3lzdGVtICJ4Y29kZWJ1aWxkIiwgIi1wcm9qZWN0IiwgIiRkaXIueGNvZGVwcm9qIiwg Ii10YXJnZXQiLCAiJGRpci1uby1TVkciLCBAb3B0aW9ucywgQEFSR1Y7CiAgICAgfSBlbHNlIHsK LSAgICAgICAgJHJlc3VsdCA9IHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVjdCIsICIkZGly Lnhjb2RlcHJvaiIsIEBvcHRpb25zOworICAgICAgICAkcmVzdWx0ID0gc3lzdGVtICJ4Y29kZWJ1 aWxkIiwgIi1wcm9qZWN0IiwgIiRkaXIueGNvZGVwcm9qIiwgQG9wdGlvbnMsIEBBUkdWOwogICAg IH0KICAgICBleGl0ICRyZXN1bHQgaWYgJHJlc3VsdDsKICAgICBpZiAoJGRpciBlcSAiSmF2YVNj cmlwdENvcmUiKSB7Ci0gICAgICAgICRyZXN1bHQgPSBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXBy b2plY3QiLCAiJGRpci54Y29kZXByb2oiLCBAb3B0aW9ucywgIi10YXJnZXQiLCAidGVzdGtqcyI7 CisgICAgICAgICRyZXN1bHQgPSBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXByb2plY3QiLCAiJGRp ci54Y29kZXByb2oiLCAiLXRhcmdldCIsICJ0ZXN0a2pzIiwgQG9wdGlvbnMsIEBBUkdWOwogICAg ICAgICBleGl0ICRyZXN1bHQgaWYgJHJlc3VsdDsKICAgICB9CiAgICAgY2hkaXIgIi4uIiBvciBk aWU7Cg==