58536 2011-04-14 06:16:29 -0700 [Qt][WK2] Qt should use the mac-wk2 skipped list 2011-04-22 04:54:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs commit-queue ossy robert oldest_to_newest 385701 0 kbalazs 2011-04-14 06:16:29 -0700 To avoid skipped list maintenance burden we should use the mac-wk2 list additionally to our own's as the Apple Windows bots do. Nearly all of the skipped tests for WebKit2 on Mac are due to cross platform issues so we won't miss many tests that we could pass (if we even miss any). 385726 1 kbalazs 2011-04-14 06:44:49 -0700 Current bot results: 16027 test cases (99%) succeeded 6 test cases (<1%) were new 17 test cases (<1%) had stderr output Results with the mac-wk2 list - runned in an environment that is mostly identical with the bot 15410 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) were new 17 test cases (<1%) had stderr output So we have almost 600 passing test that we won't run with the change. 388798 2 kbalazs 2011-04-19 14:28:07 -0700 Robert, have you got an idea about which tests are we running that are skipped on Mac? I guess we run those tests with DRT as well. 390113 3 kbalazs 2011-04-21 10:15:20 -0700 My bad. Locally I ran the tests with --no-http. With this configuration, these are results without the mac skiplist: 15463 test cases (99%) succeeded 6 test cases (<1%) had incorrect layout 22 test cases (<1%) were new 1 test case (<1%) crashed 15 test cases (<1%) had stderr output ... and with it: 15428 test cases (99%) succeeded 5 test cases (<1%) had incorrect layout 21 test cases (<1%) were new 15 test cases (<1%) had stderr output So we have 36 passing test that we would skip with the change. These are the following tests: dom/html/level2/html/HTMLAppletElement01.html dom/html/level2/html/HTMLAppletElement02.html dom/html/level2/html/HTMLAppletElement03.html dom/html/level2/html/HTMLAppletElement04.html dom/html/level2/html/HTMLAppletElement05.html dom/html/level2/html/HTMLAppletElement06.html dom/html/level2/html/HTMLAppletElement07.html dom/html/level2/html/HTMLAppletElement08.html dom/html/level2/html/HTMLAppletElement09.html dom/html/level2/html/HTMLAppletElement10.html dom/xhtml/level2/html/HTMLAppletElement01.xhtml dom/xhtml/level2/html/HTMLAppletElement02.xhtml dom/xhtml/level2/html/HTMLAppletElement03.xhtml dom/xhtml/level2/html/HTMLAppletElement04.xhtml dom/xhtml/level2/html/HTMLAppletElement05.xhtml dom/xhtml/level2/html/HTMLAppletElement06.xhtml dom/xhtml/level2/html/HTMLAppletElement07.xhtml dom/xhtml/level2/html/HTMLAppletElement08.xhtml dom/xhtml/level2/html/HTMLAppletElement09.xhtml dom/xhtml/level2/html/HTMLAppletElement10.xhtml editing/selection/click-below-rtl-text.html fast/block/basic/truncation-rtl.html fast/dom/global-constructors.html fast/dom/timer-increase-min-interval-and-reset-part-2.html fast/dom/StyleSheet/detached-style-2.html fast/dom/StyleSheet/detached-style-pi-2.xhtml fast/dom/StyleSheet/detached-style-pi.xhtml fast/dom/StyleSheet/detached-style.html fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html fast/forms/select-live-pseudo-selectors.html fast/history/history-replace-updates-current-item.html fast/history/same-document-iframes-changing-fragment.html fast/history/same-document-iframes-changing-pushstate.html fast/images/animated-gif-restored-from-bfcache.html fast/text/zero-font-size.html svg/css/cursor-replace.svg We should check these tests on Mac to see how many of them is passing and remove them from the skiplist but I don't think it should block the change of using the mac skiplist. 390677 4 90679 kbalazs 2011-04-22 01:59:22 -0700 Created attachment 90679 Patch 390691 5 90679 ossy 2011-04-22 03:10:27 -0700 Comment on attachment 90679 Patch r=me 390692 6 ossy 2011-04-22 03:11:49 -0700 After this patch landed, could you remove unnecessary files from qt-wk2 skipped list? 390695 7 90679 commit-queue 2011-04-22 03:39:45 -0700 Comment on attachment 90679 Patch Clearing flags on attachment: 90679 Committed r84615: <http://trac.webkit.org/changeset/84615> 390696 8 commit-queue 2011-04-22 03:39:50 -0700 All reviewed patches have been landed. Closing bug. 390715 9 kbalazs 2011-04-22 04:54:55 -0700 (In reply to comment #6) > After this patch landed, could you remove unnecessary files from qt-wk2 skipped list? I don't think that we should remove those. In the future when WebKit2 and the Qt WebKit2 port will be more stable we would likely want to have our own skip list again. Creating our skip list at that time could be easier if we leave these items. 90679 2011-04-22 01:59:22 -0700 2011-04-22 03:39:45 -0700 Patch bug-58536-20110422085921.patch text/plain 1634 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogODQ2MTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNGIxYWZmZmM0MThhM2NmYTQ3OGFmYjgyOTIwY2VmZGE2 MzY3MmRmLi5iZDQ5OWQ0ZDU0YzhkZmVkYjVhNGI0MGU4MTQ4ZGY2OTMwM2YyODAyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMjIgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF1bV0syXSBR dCBzaG91bGQgdXNlIHRoZSBtYWMtd2syIHNraXBwZWQgbGlzdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg1MzYKKworICAgICAgICAqIFNjcmlwdHMv b2xkLXJ1bi13ZWJraXQtdGVzdHM6CisKIDIwMTEtMDQtMjEgIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNaWhhaSBQYXJwYXJpdGEuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwppbmRleCA0ODZhMzBjZjk2MTJjMzc0ZTM2MmY1MzU3NzY5 ZTEyNTZkNmI0MmE5Li5lYjUwNDZhNGUwZmE4MDQ5ZjY5YTc5NThjODdlZTgxNTkyNmY0MGE5IDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xz L1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKQEAgLTI0MjIsOSArMjQyMiw5IEBAIHN1YiBy ZWFkU2tpcHBlZEZpbGVzKCQpCiAgICAgbXkgQHNraXBwZWRGaWxlRGlyZWN0b3JpZXMgPSBAcGxh dGZvcm1UZXN0SGllcmFyY2h5OwogCiAgICAgIyBCZWNhdXNlIG5lYXJseSBhbGwgb2YgdGhlIHNr aXBwZWQgdGVzdHMgZm9yIFdlYktpdCAyIG9uIE1hYyBhcmUgZHVlIHRvCi0gICAgIyBjcm9zcy1w bGF0Zm9ybSBpc3N1ZXMsIFdpbmRvd3Mgd2lsbCB1c2UgYm90aCB0aGUgTWFjIGFuZCBXaW5kb3dz IHNraXBwZWQKLSAgICAjIGxpc3RzIHRvIGF2b2lkIG1haW50YWluaW5nIHNlcGFyYXRlIGxpc3Rz LgotICAgIHB1c2goQHNraXBwZWRGaWxlRGlyZWN0b3JpZXMsIGNhdGRpcigkcGxhdGZvcm1CYXNl RGlyZWN0b3J5LCAibWFjLXdrMiIpKSBpZiAkcGxhdGZvcm0gZXEgIndpbi13azIiOworICAgICMg Y3Jvc3MtcGxhdGZvcm0gaXNzdWVzLCB0aGUgV2luZG93cyBhbmQgUXQgcG9ydHMgdXNlIHRoZSBN YWMgc2tpcHBlZCBsaXN0CisgICAgIyBhZGRpdGlvbmFsbHkgdG8gdGhlaXIgb3duIHRvIGF2b2lk IG1haW50YWluaW5nIHNlcGFyYXRlIGxpc3RzLgorICAgIHB1c2goQHNraXBwZWRGaWxlRGlyZWN0 b3JpZXMsIGNhdGRpcigkcGxhdGZvcm1CYXNlRGlyZWN0b3J5LCAibWFjLXdrMiIpKSBpZiAoJHBs YXRmb3JtIGVxICJ3aW4td2syIiB8fCAkcGxhdGZvcm0gZXEgInF0LXdrMiIpOwogCiAgICAgZm9y ZWFjaCBteSAkbGV2ZWwgKEBza2lwcGVkRmlsZURpcmVjdG9yaWVzKSB7CiAgICAgICAgIGlmIChv cGVuIFNLSVBQRUQsICI8IiwgIiRsZXZlbC9Ta2lwcGVkIikgewo=