58527 2011-04-14 04:25:59 -0700 [Qt] Compilation errors in GraphicsContex3DQt.cpp 2011-04-14 05:40:33 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED DUPLICATE 58478 P2 Normal --- 0 jarkko.j.sakkinen webkit-unassigned benjamin jarkko.j.sakkinen oldest_to_newest 385634 0 jarkko.j.sakkinen 2011-04-14 04:25:59 -0700 In the line 694, deprecated QString constructor is used. In the line 662, additional brackets are needed. 385635 1 jarkko.j.sakkinen 2011-04-14 04:27:43 -0700 I'm putting fixes that do not belong to #57530 here. 385642 2 89555 jarkko.j.sakkinen 2011-04-14 04:39:44 -0700 Created attachment 89555 fixes 385647 3 89555 benjamin 2011-04-14 04:44:13 -0700 Comment on attachment 89555 fixes View in context: https://bugs.webkit.org/attachment.cgi?id=89555&action=review > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:597 > + void* addr = m_glWidget->context()->getProcAddress(QString::fromUtf8(nameWithExt.utf8().data())); Youc an convert directly from String to QString: QString(nameWithExt) 385679 4 benjamin 2011-04-14 05:40:18 -0700 *** This bug has been marked as a duplicate of bug 58478 *** 89555 2011-04-14 04:39:44 -0700 2011-04-14 05:40:33 -0700 fixes 58527.diff text/plain 1809 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMTlhNzEzLi4wMWFlZjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDQtMTQgIEphcmtrbyBTYWtraW5lbiAgPGphcmtrby5qLnNha2tpbmVuQGdtYWls LmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIENvbXBpbGF0aW9uIGVycm9ycyBpbiBHcmFwaGljc0NvbnRleDNEUXQuY3BwCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODUyNworCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzREludGVybmFsOjpnZXRQcm9jQWRkcmVzcyk6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cmVzaGFwZSk6CisKKzIwMTEtMDQt MTQgIEphcmtrbyBTYWtraW5lbiAgPGphcmtrby5qLnNha2tpbmVuQGdtYWlsLmNvbT4KKwogICAg ICAgICBSZXZpZXdlZCBieSBCZW5qYW1pbiBQb3VsYWluLgogCiAgICAgICAgIFtRdF0gR3JhcGhp Y3NDb250ZXh0M0QgaW50ZXJuYWwgYnVmZmVycyBhcmUgbm90IGZyZWVkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNE UXQuY3BwCmluZGV4IGMzNTA2ODEuLjA2ZjkzYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCkBA IC01OTQsNyArNTk0LDcgQEAgdm9pZCogR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6Z2V0UHJv Y0FkZHJlc3MoY29uc3QgU3RyaW5nJiBwcm9jKQogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgMzsg aSsrKSB7CiAgICAgICAgIFN0cmluZyBuYW1lV2l0aEV4dCA9IHByb2MgKyBleHRbaV07CiAKLSAg ICAgICAgdm9pZCogYWRkciA9IG1fZ2xXaWRnZXQtPmNvbnRleHQoKS0+Z2V0UHJvY0FkZHJlc3Mo bmFtZVdpdGhFeHQudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIHZvaWQqIGFkZHIgPSBtX2dsV2lk Z2V0LT5jb250ZXh0KCktPmdldFByb2NBZGRyZXNzKFFTdHJpbmc6OmZyb21VdGY4KG5hbWVXaXRo RXh0LnV0ZjgoKS5kYXRhKCkpKTsKICAgICAgICAgaWYgKGFkZHIpIAogICAgICAgICAgICAgcmV0 dXJuIGFkZHI7CiAgICAgfQpAQCAtNjYyLDcgKzY2Miw3IEBAIFBhc3NSZWZQdHI8SW1hZ2VEYXRh PiBHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRSZW5kZXJpbmdSZXN1bHRzVG9JbWFnZURhdGEoKQog CiB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpyZXNoYXBlKGludCB3aWR0aCwgaW50IGhlaWdodCkK IHsKLSAgICBpZiAod2lkdGggPT0gbV9jdXJyZW50V2lkdGggJiYgaGVpZ2h0ID09IG1fY3VycmVu dEhlaWdodCB8fCAoIW1faW50ZXJuYWwpKQorICAgIGlmICgod2lkdGggPT0gbV9jdXJyZW50V2lk dGggJiYgaGVpZ2h0ID09IG1fY3VycmVudEhlaWdodCkgfHwgKCFtX2ludGVybmFsKSkKICAgICAg ICAgcmV0dXJuOwogCiAgICAgbV9jdXJyZW50V2lkdGggPSB3aWR0aDsK