58525 2011-04-14 03:45:15 -0700 svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build 2011-04-14 05:27:20 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned zherczeg zimmermann oldest_to_newest 385622 0 pnormand 2011-04-14 03:45:15 -0700 #0 0x00002b82fcf8baa4 in WebCore::RenderSVGResourceFilterPrimitive::styleDidChange (this=0x539fea8, diff=WebCore::StyleDifferenceLayout, oldStyle=0x539fdf0) at ../../Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:48 48 ASSERT(filter->isSVGResourceFilter()); Thread 1 (Thread 4789): #0 0x00002b82fcf8baa4 in WebCore::RenderSVGResourceFilterPrimitive::styleDidChange (this=0x539fea8, diff=WebCore::StyleDifferenceLayout, oldStyle=0x539fdf0) at ../../Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:48 #1 0x00002b82fcef3d58 in WebCore::RenderObject::setStyle (this=0x539fea8, style=...) at ../../Source/WebCore/rendering/RenderObject.cpp:1759 #2 0x00002b82fcef38d5 in WebCore::RenderObject::setAnimatableStyle (this=0x539fea8, style=...) at ../../Source/WebCore/rendering/RenderObject.cpp:1676 #3 0x00002b82fc94b8c3 in WebCore::Node::setRenderStyle (this=0x539fb40, s=...) at ../../Source/WebCore/dom/Node.cpp:1554 #4 0x00002b82fc9261ed in WebCore::Element::recalcStyle (this=0x539fb40, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1109 #5 0x00002b82fc926587 in WebCore::Element::recalcStyle (this=0x53928b0, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1142 #6 0x00002b82fc926587 in WebCore::Element::recalcStyle (this=0x52e73e0, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1142 #7 0x00002b82fc926587 in WebCore::Element::recalcStyle (this=0x5328320, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1142 #8 0x00002b82fc8e1cc5 in WebCore::Document::recalcStyle (this=0x50eb9d0, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Document.cpp:1508 #9 0x00002b82fc8e6ab6 in WebCore::Document::styleSelectorChanged (this=0x50eb9d0, updateFlag=WebCore::RecalcStyleImmediately) at ../../Source/WebCore/dom/Document.cpp:2931 #10 0x00002b82fc99b4f4 in WebCore::XMLDocumentParser::end (this=0x5399ca0) at ../../Source/WebCore/dom/XMLDocumentParser.cpp:234 #11 0x00002b82fc99b598 in WebCore::XMLDocumentParser::finish (this=0x5399ca0) at ../../Source/WebCore/dom/XMLDocumentParser.cpp:254 #12 0x00002b82fc8e43f2 in WebCore::Document::finishParsing (this=0x50eb9d0) at ../../Source/WebCore/dom/Document.cpp:2262 #13 0x00002b82fcc1f035 in WebCore::DocumentWriter::endIfNotLoadingMainResource (this=0x2e330f0) at ../../Source/WebCore/loader/DocumentWriter.cpp:224 #14 0x00002b82fcc1ef8b in WebCore::DocumentWriter::end (this=0x2e330f0) at ../../Source/WebCore/loader/DocumentWriter.cpp:209 #15 0x00002b82fcc13113 in WebCore::DocumentLoader::finishedLoading (this=0x2e32ff0) at ../../Source/WebCore/loader/DocumentLoader.cpp:288 #16 0x00002b82fcc2b8cb in WebCore::FrameLoader::finishedLoading (this=0x845ca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2235 #17 0x00002b82fcc5dbfc in WebCore::MainResourceLoader::didFinishLoading (this=0x52b43d0, finishTime=0) at ../../Source/WebCore/loader/MainResourceLoader.cpp:467 #18 0x00002b82fcc69df5 in WebCore::ResourceLoader::didFinishLoading (this=0x52b43d0, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:436 #19 0x00002b82fc5a8780 in WebCore::readCallback (source=0x4533aa0, asyncResult=0x2b830c012300, data=0x0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:779 #20 0x00002b8300790f65 in async_ready_callback_wrapper (source_object=0x4533aa0, res=0x2b830c012300, user_data=0x0) at /tmp/buildd/glib2.0-2.27.91/./gio/ginputstream.c:470 #21 0x00002b83007a2628 in complete_in_idle_cb_for_thread (_data=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gio/gsimpleasyncresult.c:812 #22 0x00002b8301309362 in g_main_dispatch (context=0x7c8730) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:2440 #23 g_main_context_dispatch (context=0x7c8730) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3013 #24 0x00002b830130da28 in g_main_context_iterate (context=0x7c8730, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3091 #25 0x00002b830130df35 in g_main_loop_run (loop=0x5398e20) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3299 #26 0x00002b82ff27c657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #27 0x0000000000421360 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:702 #28 0x00000000004209fd in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:494 #29 0x0000000000422cbf in main (argc=2, argv=0x7fffa2a43428) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1179 385653 1 89556 zherczeg 2011-04-14 05:03:10 -0700 Created attachment 89556 patch 385655 2 89556 krit 2011-04-14 05:07:36 -0700 Comment on attachment 89556 patch View in context: https://bugs.webkit.org/attachment.cgi?id=89556&action=review > Source/WebCore/ChangeLog:11 > + Please add a comment, that we have a test that covers this problem. 385656 3 pnormand 2011-04-14 05:10:16 -0700 Thanks for the quick fix! Would you also mind unskipping the test on GTK? 385668 4 zherczeg 2011-04-14 05:27:20 -0700 Landed in: http://trac.webkit.org/changeset/83839 Unskipped the test in: http://trac.webkit.org/changeset/83840 89556 2011-04-14 05:03:10 -0700 2011-04-14 05:07:36 -0700 patch 0001-filter-fix.patch text/plain 2627 zherczeg RnJvbSBkZTk3YmExMWQ0ZTQ0NTk4MmU2ZGFkODE4YjczNGQ4NjY4NTU1ZGY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUaHUsIDE0IEFwciAyMDExIDE0OjAxOjE4ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gZmlsdGVyLWZpeAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiAuLi4vc3ZnL1NWR0ZpbHRlclBy aW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlcy5jcHAgICB8ICAgIDggKysrKysrKysKIC4uLi9zdmcv U1ZHRmlsdGVyUHJpbWl0aXZlU3RhbmRhcmRBdHRyaWJ1dGVzLmggICAgIHwgICAgMSArCiAzIGZp bGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDIxOWE3MTMuLjA1YjA4MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0w NC0xNCAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gc3ZnL1czQy1T VkctMS4xLVNFL3N2Z2RvbS1vdmVyLTAxLWYuc3ZnIGNyYXNoZXMgaW4gRGVidWcgYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU4NTI1CisKKyAg ICAgICAgQSByZW5kZXJlciBpcyBjcmVhdGVkIGV2ZW4gZm9yIHRob3NlIGZpbHRlciBwcmltaXRp dmVzCisgICAgICAgIHdoaWNoIHBhcmVudCBpcyBub3QgYSBmaWx0ZXIuIEEgcmVuZGVyZXJJc05l ZWRlZCgpIGlzCisgICAgICAgIGFkZGVkIHRvIFNWR0ZpbHRlclByaW1pdGl2ZVN0YW5kYXJkQXR0 cmlidXRlcy4KKworICAgICAgICAqIHN2Zy9TVkdGaWx0ZXJQcmltaXRpdmVTdGFuZGFyZEF0dHJp YnV0ZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHRmlsdGVyUHJpbWl0aXZlU3RhbmRhcmRB dHRyaWJ1dGVzOjpyZW5kZXJlcklzTmVlZGVkKToKKyAgICAgICAgKiBzdmcvU1ZHRmlsdGVyUHJp bWl0aXZlU3RhbmRhcmRBdHRyaWJ1dGVzLmg6CisKIDIwMTEtMDQtMTQgIEphcmtrbyBTYWtraW5l biAgPGphcmtrby5qLnNha2tpbmVuQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBC ZW5qYW1pbiBQb3VsYWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZpbHRl clByaW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH RmlsdGVyUHJpbWl0aXZlU3RhbmRhcmRBdHRyaWJ1dGVzLmNwcAppbmRleCBkMzRhMTMwLi5mZTVk MDljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRmlsdGVyUHJpbWl0aXZlU3Rh bmRhcmRBdHRyaWJ1dGVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRmlsdGVyUHJp bWl0aXZlU3RhbmRhcmRBdHRyaWJ1dGVzLmNwcApAQCAtMTY4LDYgKzE2OCwxNCBAQCBSZW5kZXJP YmplY3QqIFNWR0ZpbHRlclByaW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlczo6Y3JlYXRlUmVuZGVy ZXIoUmVuZGVyQXJlbmEqCiAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlclNWR1Jlc291cmNl RmlsdGVyUHJpbWl0aXZlKHRoaXMpOwogfQogCitib29sIFNWR0ZpbHRlclByaW1pdGl2ZVN0YW5k YXJkQXR0cmlidXRlczo6cmVuZGVyZXJJc05lZWRlZChSZW5kZXJTdHlsZSogc3R5bGUpCit7Cisg ICAgaWYgKHBhcmVudE5vZGUoKSAmJiAocGFyZW50Tm9kZSgpLT5oYXNUYWdOYW1lKFNWR05hbWVz OjpmaWx0ZXJUYWcpKSkKKyAgICAgICAgcmV0dXJuIFNWR1N0eWxlZEVsZW1lbnQ6OnJlbmRlcmVy SXNOZWVkZWQoc3R5bGUpOworCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB9CiAKICNlbmRpZiAv LyBFTkFCTEUoU1ZHKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZpbHRlclBy aW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlcy5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ZpbHRl clByaW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlcy5oCmluZGV4IDUyNjU5MmEuLjNmMjQ1NzMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdGaWx0ZXJQcmltaXRpdmVTdGFuZGFyZEF0 dHJpYnV0ZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRmlsdGVyUHJpbWl0aXZlU3Rh bmRhcmRBdHRyaWJ1dGVzLmgKQEAgLTY5LDYgKzY5LDcgQEAgcHJvdGVjdGVkOgogcHJpdmF0ZToK ICAgICB2aXJ0dWFsIGJvb2wgaXNGaWx0ZXJFZmZlY3QoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9 CiAKKyAgICB2aXJ0dWFsIGJvb2wgcmVuZGVyZXJJc05lZWRlZChSZW5kZXJTdHlsZSopOwogICAg IHZpcnR1YWwgUmVuZGVyT2JqZWN0KiBjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSosIFJlbmRl clN0eWxlKik7CiAKICAgICAvLyBBbmltYXRlZCBwcm9wZXJ0eSBkZWNsYXJhdGlvbnMKLS0gCjEu Ni41Cgo=