58501 2011-04-13 18:38:35 -0700 Use HTMLImageElement in Canvas 2D / WebGL before response is ready causes crash 2011-06-18 12:49:12 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo webkit-unassigned cmarrin darin gman kbr mdelaney7 zmo oldest_to_newest 385429 0 zmo 2011-04-13 18:38:35 -0700 This is because cachedImage()->response().url().string().impl() is null, and hash(null) is not expected, thus crash. 385431 1 zmo 2011-04-13 18:39:19 -0700 I am working on a fix for WebGL. If someone else more familiar with canvas 2d could fix this on the canvas 2d side, it would be great! 385437 2 zmo 2011-04-13 18:42:42 -0700 A test case for WebGL: svn checkout https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl -r 14468 sdk/tests/conformance/tex-image-and-sub-image-2d-with-image.html Current behavior: crash correct behavior: no crash 386284 3 89716 zmo 2011-04-14 18:53:06 -0700 Created attachment 89716 Patch 386286 4 zmo 2011-04-14 18:54:49 -0700 This patch makes sure WebGL won't process an HTMLImageElement if it's not ready yet. mdelaney is getting another patch ready for the rest. 386731 5 89716 kbr 2011-04-15 10:33:05 -0700 Comment on attachment 89716 Patch Looks good. 386755 6 zmo 2011-04-15 11:02:12 -0700 Committed r83992: <http://trac.webkit.org/changeset/83992> 89716 2011-04-14 18:53:06 -0700 2011-04-15 10:33:05 -0700 Patch bug-58501-20110414185304.patch text/plain 3717 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzOTI4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMTQgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVc2UgSFRNTEltYWdlRWxlbWVudCBpbiBDYW52YXMgMkQgLyBXZWJHTCBi ZWZvcmUgcmVzcG9uc2UgaXMgcmVhZHkgY2F1c2VzIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODUwMQorCisgICAgICAgICogaHRtbC9jYW52 YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVu ZGVyaW5nQ29udGV4dDo6dGV4SW1hZ2UyRCk6IENhbGwgdmFsaWRhdGVIVE1MSW1hZ2VFbGVtZW50 KCkuCisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnRleFN1YkltYWdl MkQpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6dmFs aWRhdGVIVE1MSW1hZ2VFbGVtZW50KTogTWFrZSBzdXJlIGltYWdlIGlzIHJlYWR5LgorICAgICAg ICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oOgorCiAyMDExLTA0LTE0ICBM dWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA4Mzc2MikK KysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTMxNDAsMTAgKzMxNDAsOCBAQCB2b2lkIFdlYkdMUmVuZGVyaW5n Q29udGV4dDo6dGV4SW1hZ2UyRChHCiAgICAgZWMgPSAwOwogICAgIGlmIChpc0NvbnRleHRMb3N0 KCkpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoIWltYWdlIHx8ICFpbWFnZS0+Y2FjaGVkSW1h Z2UoKSkgewotICAgICAgICBtX2NvbnRleHQtPnN5bnRoZXNpemVHTEVycm9yKEdyYXBoaWNzQ29u dGV4dDNEOjpJTlZBTElEX1ZBTFVFKTsKKyAgICBpZiAoIXZhbGlkYXRlSFRNTEltYWdlRWxlbWVu dChpbWFnZSkpCiAgICAgICAgIHJldHVybjsKLSAgICB9CiAgICAgY2hlY2tPcmlnaW4oaW1hZ2Up OwogICAgIHRleEltYWdlMkRJbXBsKHRhcmdldCwgbGV2ZWwsIGludGVybmFsZm9ybWF0LCBmb3Jt YXQsIHR5cGUsIGltYWdlLT5jYWNoZWRJbWFnZSgpLT5pbWFnZSgpLAogICAgICAgICAgICAgICAg ICAgIG1fdW5wYWNrRmxpcFksIG1fdW5wYWNrUHJlbXVsdGlwbHlBbHBoYSwgZWMpOwpAQCAtMzMz NCwxMCArMzMzMiw4IEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp0ZXhTdWJJbWFnZTIK ICAgICBlYyA9IDA7CiAgICAgaWYgKGlzQ29udGV4dExvc3QoKSkKICAgICAgICAgcmV0dXJuOwot ICAgIGlmICghaW1hZ2UgfHwgIWltYWdlLT5jYWNoZWRJbWFnZSgpKSB7Ci0gICAgICAgIG1fY29u dGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURfVkFMVUUp OworICAgIGlmICghdmFsaWRhdGVIVE1MSW1hZ2VFbGVtZW50KGltYWdlKSkKICAgICAgICAgcmV0 dXJuOwotICAgIH0KICAgICBjaGVja09yaWdpbihpbWFnZSk7CiAgICAgdGV4U3ViSW1hZ2UyRElt cGwodGFyZ2V0LCBsZXZlbCwgeG9mZnNldCwgeW9mZnNldCwgZm9ybWF0LCB0eXBlLCBpbWFnZS0+ Y2FjaGVkSW1hZ2UoKS0+aW1hZ2UoKSwKICAgICAgICAgICAgICAgICAgICAgICBtX3VucGFja0Zs aXBZLCBtX3VucGFja1ByZW11bHRpcGx5QWxwaGEsIGVjKTsKQEAgLTQ2MTMsNiArNDYwOSwyMCBA QCBXZWJHTEJ1ZmZlciogV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxpCiAgICAgcmV0dXJuIDA7 CiB9CiAKK2Jvb2wgV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxpZGF0ZUhUTUxJbWFnZUVsZW1l bnQoSFRNTEltYWdlRWxlbWVudCogaW1hZ2UpCit7CisgICAgaWYgKCFpbWFnZSB8fCAhaW1hZ2Ut PmNhY2hlZEltYWdlKCkpIHsKKyAgICAgICAgbV9jb250ZXh0LT5zeW50aGVzaXplR0xFcnJvcihH cmFwaGljc0NvbnRleHQzRDo6SU5WQUxJRF9WQUxVRSk7CisgICAgICAgIHJldHVybiBmYWxzZTsK KyAgICB9CisgICAgY29uc3QgS1VSTCYgdXJsID0gaW1hZ2UtPmNhY2hlZEltYWdlKCktPnJlc3Bv bnNlKCkudXJsKCk7CisgICAgaWYgKHVybC5pc051bGwoKSB8fCB1cmwuaXNFbXB0eSgpIHx8ICF1 cmwuaXNWYWxpZCgpKSB7CisgICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdMRXJyb3IoR3Jh cGhpY3NDb250ZXh0M0Q6OklOVkFMSURfVkFMVUUpOworICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgfQorICAgIHJldHVybiB0cnVlOworfQorCiB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6 dmVydGV4QXR0cmliZkltcGwoR0MzRHVpbnQgaW5kZXgsIEdDM0RzaXplaSBleHBlY3RlZFNpemUs IEdDM0RmbG9hdCB2MCwgR0MzRGZsb2F0IHYxLCBHQzNEZmxvYXQgdjIsIEdDM0RmbG9hdCB2MykK IHsKICAgICBpZiAoaXNDb250ZXh0TG9zdCgpKQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgJKHJldmlzaW9uIDgzNzYxKQor KysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmgJKHdv cmtpbmcgY29weSkKQEAgLTU5MCw2ICs1OTAsOSBAQCBwdWJsaWM6CiAgICAgLy8gUmV0dXJuIHRo ZSBjdXJyZW50IGJvdW5kIGJ1ZmZlciB0byB0YXJnZXQsIG9yIDAgaWYgcGFyYW1ldGVycyBhcmUg aW52YWxpZC4KICAgICBXZWJHTEJ1ZmZlciogdmFsaWRhdGVCdWZmZXJEYXRhUGFyYW1ldGVycyhH QzNEZW51bSB0YXJnZXQsIEdDM0RlbnVtIHVzYWdlKTsKIAorICAgIC8vIEhlbHBlciBmdW5jdGlv biBmb3IgdGV4e1N1Yn1JbWFnZTJEIHRvIG1ha2Ugc3VyZSBpbWFnZSBpcyByZWFkeS4KKyAgICBi b29sIHZhbGlkYXRlSFRNTEltYWdlRWxlbWVudChIVE1MSW1hZ2VFbGVtZW50Kik7CisKICAgICAv LyBIZWxwZXIgZnVuY3Rpb25zIGZvciB2ZXJ0ZXhBdHRyaWJOZnt2fS4KICAgICB2b2lkIHZlcnRl eEF0dHJpYmZJbXBsKEdDM0R1aW50IGluZGV4LCBHQzNEc2l6ZWkgZXhwZWN0ZWRTaXplLCBHQzNE ZmxvYXQsIEdDM0RmbG9hdCwgR0MzRGZsb2F0LCBHQzNEZmxvYXQpOwogICAgIHZvaWQgdmVydGV4 QXR0cmliZnZJbXBsKEdDM0R1aW50IGluZGV4LCBGbG9hdDMyQXJyYXkqLCBHQzNEc2l6ZWkgZXhw ZWN0ZWRTaXplKTsK