58479 2011-04-13 14:29:07 -0700 Change WebGraphicsContext3D virtuals to pure virtuals as intended 2011-04-15 21:40:42 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jbates jbates commit-queue jbates kbr oldest_to_newest 385235 0 jbates 2011-04-13 14:29:07 -0700 Roll chromium rev and change WebGraphicsContext3D virtuals to pure virtuals as intended 385237 1 89459 jbates 2011-04-13 14:29:39 -0700 Created attachment 89459 Patch 385309 2 89459 kbr 2011-04-13 15:33:12 -0700 Comment on attachment 89459 Patch Looks good esp since it passed the cr-linux EWS bot. Would have cq+'d this earlier but didn't realize the Chromium Mac EWS bot can't process patches from non-committers. 385612 3 89459 commit-queue 2011-04-14 02:40:39 -0700 Comment on attachment 89459 Patch Rejecting attachment 89459 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2 Last 500 characters of output: neth Russell', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/DEPS Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej patching file Source/WebKit/chromium/public/WebGraphicsContext3D.h Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8403545 385852 4 89603 jbates 2011-04-14 10:35:01 -0700 Created attachment 89603 Patch 385871 5 89603 kbr 2011-04-14 10:53:46 -0700 Comment on attachment 89603 Patch Looks fine. 386346 6 89603 commit-queue 2011-04-14 20:54:51 -0700 Comment on attachment 89603 Patch Rejecting attachment 89603 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: nneth Russell', u'--..." exit_code: 1 Parsed 3 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/DEPS Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej patching file Source/WebKit/chromium/public/WebGraphicsContext3D.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8450026 387115 7 89897 jbates 2011-04-15 18:17:47 -0700 Created attachment 89897 Patch 387119 8 jbates 2011-04-15 18:19:19 -0700 OK, let's just leave the DEPS as is this time. The chromium version has been rolled enough by others. 387121 9 89897 kbr 2011-04-15 18:20:28 -0700 Comment on attachment 89897 Patch OK. 387197 10 89897 commit-queue 2011-04-15 21:40:38 -0700 Comment on attachment 89897 Patch Clearing flags on attachment: 89897 Committed r84079: <http://trac.webkit.org/changeset/84079> 387198 11 commit-queue 2011-04-15 21:40:42 -0700 All reviewed patches have been landed. Closing bug. 89459 2011-04-13 14:29:39 -0700 2011-04-14 10:34:59 -0700 Patch bug-58479-20110413142938.patch text/plain 2337 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogODM3NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OTM2Njk5ZDAwZjlmMGE1OWY1OWYwNjRkMDQwNzY3MzUyMTM2NjE1Yi4uNWFjYWFkMGUzOGRiZWJl ZmRkNTlkYWQwNzAzZDliMDk2MmNiMzcxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wNC0xMyAgSm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJvbGwg Y2hyb21pdW0gcmV2IGFuZCBjaGFuZ2UgV2ViR3JhcGhpY3NDb250ZXh0M0QgdmlydHVhbHMgdG8g cHVyZSB2aXJ0dWFscyBhcyBpbnRlbmRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NzkKKworICAgICAgICAqIERFUFM6CisgICAgICAgICogcHVi bGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTEtMDQtMTMgIFpoZW55YW8gTW8gIDx6 bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJ1c3NlbGwuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0RFUFMKaW5kZXggMTQ0OGI1ZDlmMWVlYjJmOTE5ZjJmNWM1ODkxMTJjMGI5MmY4ZjA2 Ni4uYjQ3ZDRjNGU5ZTQzZTU0MTQ4YjZjZDBmYjYxZGZlNzdlOTA5N2NhMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v REVQUwpAQCAtMzIsNyArMzIsNyBAQAogCiB2YXJzID0gewogICAnY2hyb21pdW1fc3ZuJzogJ2h0 dHA6Ly9zcmMuY2hyb21pdW0ub3JnL3N2bi90cnVuay9zcmMnLAotICAnY2hyb21pdW1fcmV2Jzog JzgxMjc0JworICAnY2hyb21pdW1fcmV2JzogJzgxNDUzJwogfQogCiBkZXBzID0gewpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0Qu aCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgK aW5kZXggZmY3ZTUwMmNlNDYzMjdiYzk4YzkyYzYzMTc4ODVmMWFmY2Y2MzY5NS4uMmQ3YjBhNTU5 ZWU5YjNjYWVhYjczN2JjMGE5MjQ2ZGM3ZjRjOTZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCkBAIC0xNjksMTAgKzE2 OSwxMCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlbmRlcmJ1ZmZlclN0b3JhZ2VNdWx0 aXNhbXBsZUNIUk9NSVVNKFdHQzNEZW51bSB0YXJnZXQsIFdHQzNEc2l6ZWkgc2FtcGxlcywgV0dD M0RlbnVtIGludGVybmFsZm9ybWF0LCBXR0MzRHNpemVpIHdpZHRoLCBXR0MzRHNpemVpIGhlaWdo dCkgPSAwOwogCiAgICAgLy8gR0xfQ0hST01JVU1fbGF0Y2gKLSAgICB2aXJ0dWFsIHZvaWQgZ2V0 UGFyZW50VG9DaGlsZExhdGNoQ0hST01JVU0oV0dDM0R1aW50KiBsYXRjaElkKSB7fSAvLyBGSVhN RTogPSAwOwotICAgIHZpcnR1YWwgdm9pZCBnZXRDaGlsZFRvUGFyZW50TGF0Y2hDSFJPTUlVTShX R0MzRHVpbnQqIGxhdGNoSWQpIHt9IC8vIEZJWE1FOiA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIHdh aXRMYXRjaENIUk9NSVVNKFdHQzNEdWludCBsYXRjaElkKSB7fSAvLyBGSVhNRTogPSAwOwotICAg IHZpcnR1YWwgdm9pZCBzZXRMYXRjaENIUk9NSVVNKFdHQzNEdWludCBsYXRjaElkKSB7fSAvLyBG SVhNRTogPSAwOworICAgIHZpcnR1YWwgdm9pZCBnZXRQYXJlbnRUb0NoaWxkTGF0Y2hDSFJPTUlV TShXR0MzRHVpbnQqIGxhdGNoSWQpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgZ2V0Q2hpbGRUb1Bh cmVudExhdGNoQ0hST01JVU0oV0dDM0R1aW50KiBsYXRjaElkKSA9IDA7CisgICAgdmlydHVhbCB2 b2lkIHdhaXRMYXRjaENIUk9NSVVNKFdHQzNEdWludCBsYXRjaElkKSA9IDA7CisgICAgdmlydHVh bCB2b2lkIHNldExhdGNoQ0hST01JVU0oV0dDM0R1aW50IGxhdGNoSWQpID0gMDsKIAogICAgIC8v IFRoZSBlbnRyeSBwb2ludHMgYmVsb3cgbWFwIGRpcmVjdGx5IHRvIHRoZSBPcGVuR0wgRVMgMi4w IEFQSS4KICAgICAvLyBTZWU6IGh0dHA6Ly93d3cua2hyb25vcy5vcmcvcmVnaXN0cnkvZ2xlcy8K 89603 2011-04-14 10:35:01 -0700 2011-04-15 18:17:45 -0700 Patch bug-58479-20110414103500.patch text/plain 2339 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogODM4NjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZjJmNzE5NTJkYmIzNDhhMTM2OTVmZWZjYTg5ZTlhNGVjNDE4MjNmNC4uYTA5NjM4NzA0ODJlYjU3 MThhNTg1MjZmMzM2MWM3MDMwMjZlYWIwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wNC0xNCAgSm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJvbGwg Y2hyb21pdW0gcmV2IGFuZCBjaGFuZ2UgV2ViR3JhcGhpY3NDb250ZXh0M0QgdmlydHVhbHMgdG8g cHVyZSB2aXJ0dWFscyBhcyBpbnRlbmRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NzkKKworICAgICAgICAqIERFUFM6CisgICAgICAgICogcHVi bGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTEtMDQtMTQgIEJpbGwgQnVkZ2UgIDxi YnVkZ2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vREVQUwppbmRleCBmOWI5M2NjYzNiNjgwYTIxNjM2NTMzOGU4YjdmMDM4MDUwMzgz Nzk5Li5lMGFiMTYyNDQ1ODUwMTc1ZWE2YWVkNDlmODkwZmVhMGMzMTQxMGYwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAn aHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYn OiAnODEzNDEnCisgICdjaHJvbWl1bV9yZXYnOiAnODE1ODUnCiB9CiAKIGRlcHMgPSB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQz RC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0Qu aAppbmRleCBmZjdlNTAyY2U0NjMyN2JjOThjOTJjNjMxNzg4NWYxYWZjZjYzNjk1Li4yZDdiMGE1 NTllZTliM2NhZWFiNzM3YmMwYTkyNDZkYzdmNGM5NmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAgLTE2OSwxMCAr MTY5LDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVuZGVyYnVmZmVyU3RvcmFnZU11 bHRpc2FtcGxlQ0hST01JVU0oV0dDM0RlbnVtIHRhcmdldCwgV0dDM0RzaXplaSBzYW1wbGVzLCBX R0MzRGVudW0gaW50ZXJuYWxmb3JtYXQsIFdHQzNEc2l6ZWkgd2lkdGgsIFdHQzNEc2l6ZWkgaGVp Z2h0KSA9IDA7CiAKICAgICAvLyBHTF9DSFJPTUlVTV9sYXRjaAotICAgIHZpcnR1YWwgdm9pZCBn ZXRQYXJlbnRUb0NoaWxkTGF0Y2hDSFJPTUlVTShXR0MzRHVpbnQqIGxhdGNoSWQpIHt9IC8vIEZJ WE1FOiA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIGdldENoaWxkVG9QYXJlbnRMYXRjaENIUk9NSVVN KFdHQzNEdWludCogbGF0Y2hJZCkge30gLy8gRklYTUU6ID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQg d2FpdExhdGNoQ0hST01JVU0oV0dDM0R1aW50IGxhdGNoSWQpIHt9IC8vIEZJWE1FOiA9IDA7Ci0g ICAgdmlydHVhbCB2b2lkIHNldExhdGNoQ0hST01JVU0oV0dDM0R1aW50IGxhdGNoSWQpIHt9IC8v IEZJWE1FOiA9IDA7CisgICAgdmlydHVhbCB2b2lkIGdldFBhcmVudFRvQ2hpbGRMYXRjaENIUk9N SVVNKFdHQzNEdWludCogbGF0Y2hJZCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBnZXRDaGlsZFRv UGFyZW50TGF0Y2hDSFJPTUlVTShXR0MzRHVpbnQqIGxhdGNoSWQpID0gMDsKKyAgICB2aXJ0dWFs IHZvaWQgd2FpdExhdGNoQ0hST01JVU0oV0dDM0R1aW50IGxhdGNoSWQpID0gMDsKKyAgICB2aXJ0 dWFsIHZvaWQgc2V0TGF0Y2hDSFJPTUlVTShXR0MzRHVpbnQgbGF0Y2hJZCkgPSAwOwogCiAgICAg Ly8gVGhlIGVudHJ5IHBvaW50cyBiZWxvdyBtYXAgZGlyZWN0bHkgdG8gdGhlIE9wZW5HTCBFUyAy LjAgQVBJLgogICAgIC8vIFNlZTogaHR0cDovL3d3dy5raHJvbm9zLm9yZy9yZWdpc3RyeS9nbGVz Lwo= 89897 2011-04-15 18:17:47 -0700 2011-04-15 21:40:38 -0700 Patch bug-58479-20110415181746.patch text/plain 1907 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogODQwNjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MjFlMzM0NjMzYzliZTk5ZmFmNmUxOWQ0MDMzOWYyNmE4N2IzZWZlYi4uNmMwNWE0Njg1MzMzOTFi NjIyYjQ0Y2JkYTZkMWFlOWFkOTVmNGNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMS0wNC0xNSAgSm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5n ZSBXZWJHcmFwaGljc0NvbnRleHQzRCB2aXJ0dWFscyB0byBwdXJlIHZpcnR1YWxzIGFzIGludGVu ZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODQ3 OQorCisgICAgICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTEtMDQt MTUgIENoYXJsaWUgUmVpcyAgPGNyZWlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAppbmRleCBmZjdlNTAyY2U0NjMyN2JjOThjOTJjNjMx Nzg4NWYxYWZjZjYzNjk1Li4yZDdiMGE1NTllZTliM2NhZWFiNzM3YmMwYTkyNDZkYzdmNGM5NmNm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0Nv bnRleHQzRC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNz Q29udGV4dDNELmgKQEAgLTE2OSwxMCArMTY5LDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZv aWQgcmVuZGVyYnVmZmVyU3RvcmFnZU11bHRpc2FtcGxlQ0hST01JVU0oV0dDM0RlbnVtIHRhcmdl dCwgV0dDM0RzaXplaSBzYW1wbGVzLCBXR0MzRGVudW0gaW50ZXJuYWxmb3JtYXQsIFdHQzNEc2l6 ZWkgd2lkdGgsIFdHQzNEc2l6ZWkgaGVpZ2h0KSA9IDA7CiAKICAgICAvLyBHTF9DSFJPTUlVTV9s YXRjaAotICAgIHZpcnR1YWwgdm9pZCBnZXRQYXJlbnRUb0NoaWxkTGF0Y2hDSFJPTUlVTShXR0Mz RHVpbnQqIGxhdGNoSWQpIHt9IC8vIEZJWE1FOiA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIGdldENo aWxkVG9QYXJlbnRMYXRjaENIUk9NSVVNKFdHQzNEdWludCogbGF0Y2hJZCkge30gLy8gRklYTUU6 ID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQgd2FpdExhdGNoQ0hST01JVU0oV0dDM0R1aW50IGxhdGNo SWQpIHt9IC8vIEZJWE1FOiA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIHNldExhdGNoQ0hST01JVU0o V0dDM0R1aW50IGxhdGNoSWQpIHt9IC8vIEZJWE1FOiA9IDA7CisgICAgdmlydHVhbCB2b2lkIGdl dFBhcmVudFRvQ2hpbGRMYXRjaENIUk9NSVVNKFdHQzNEdWludCogbGF0Y2hJZCkgPSAwOworICAg IHZpcnR1YWwgdm9pZCBnZXRDaGlsZFRvUGFyZW50TGF0Y2hDSFJPTUlVTShXR0MzRHVpbnQqIGxh dGNoSWQpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgd2FpdExhdGNoQ0hST01JVU0oV0dDM0R1aW50 IGxhdGNoSWQpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0TGF0Y2hDSFJPTUlVTShXR0MzRHVp bnQgbGF0Y2hJZCkgPSAwOwogCiAgICAgLy8gVGhlIGVudHJ5IHBvaW50cyBiZWxvdyBtYXAgZGly ZWN0bHkgdG8gdGhlIE9wZW5HTCBFUyAyLjAgQVBJLgogICAgIC8vIFNlZTogaHR0cDovL3d3dy5r aHJvbm9zLm9yZy9yZWdpc3RyeS9nbGVzLwo=