58478 2011-04-13 14:17:27 -0700 Fix GraphicsContext3DQt.cpp compilation warnings treated as errors 2011-04-14 07:00:24 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 rectalogic webkit-unassigned commit-queue jarkko.j.sakkinen oldest_to_newest 385212 0 rectalogic 2011-04-13 14:17:27 -0700 GraphicsContext3DQt.cpp fails to build due to some compiler warnings that are treated as errors: cc1plus: warnings being treated as errors ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In member function 'void* WebCore::GraphicsContext3DInternal::getProcAddress(const WTF::String&)': ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:591: error: 'QString::QString(const char*)' is deprecated (declared at /opt/motionbox/foundation/6.1.4-6-gcfb3251-dirty/include/QtCore/qstring.h:426) ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp: In member function 'void WebCore::GraphicsContext3D::reshape(int, int)': ../../../Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:659: error: suggest parentheses around '&&' within '||' make[1]: *** [obj/release/GraphicsContext3DQt.o] Error 1 These were fixed in a patch for bug #57530 but should be in a separate patch as suggested. Separate patch will be attached. 385222 1 89457 rectalogic 2011-04-13 14:20:28 -0700 Created attachment 89457 fix compiler warnings 385680 2 benjamin 2011-04-14 05:40:18 -0700 *** Bug 58527 has been marked as a duplicate of this bug. *** 385739 3 89457 commit-queue 2011-04-14 07:00:19 -0700 Comment on attachment 89457 fix compiler warnings Clearing flags on attachment: 89457 Committed r83853: <http://trac.webkit.org/changeset/83853> 385740 4 commit-queue 2011-04-14 07:00:24 -0700 All reviewed patches have been landed. Closing bug. 89457 2011-04-13 14:20:28 -0700 2011-04-14 07:00:19 -0700 fix compiler warnings warning.diff text/plain 1835 rectalogic SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNzYzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMTMgIEFuZHJldyBX YXNvbiAgPHJlY3RhbG9naWNAcmVjdGFsb2dpYy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IEdyYXBoaWNzQ29udGV4dDNEUXQuY3BwIGNv bXBpbGF0aW9uIHdhcm5pbmdzIHRyZWF0ZWQgYXMgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODQ3OAorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6Z2V0UHJv Y0FkZHJlc3MpOgorICAgICAgICAgRG8gbm90IHVzZSBkZXByZWNhdGVkIFFTdHJpbmcgY29uc3Ry dWN0b3IgdG8gYXZvaWQgd2FybmluZy4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDNEOjpyZXNoYXBlKToKKyAgICAgICAgIFVzZSBwYXJlbnRoZXNpcyB0byBhdm9pZCB3YXJuaW5n LgorCiAyMDExLTA0LTEzICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0Nv bnRleHQzRFF0LmNwcAkocmV2aXNpb24gODM3NTkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTg4LDcgKzU4OCw3IEBAIHZvaWQqIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OmdldFByb2MK ICAgICBmb3IgKGludCBpID0gMDsgaSA8IDM7IGkrKykgewogICAgICAgICBTdHJpbmcgbmFtZVdp dGhFeHQgPSBwcm9jICsgZXh0W2ldOwogCi0gICAgICAgIHZvaWQqIGFkZHIgPSBtX2dsV2lkZ2V0 LT5jb250ZXh0KCktPmdldFByb2NBZGRyZXNzKG5hbWVXaXRoRXh0LnV0ZjgoKS5kYXRhKCkpOwor ICAgICAgICB2b2lkKiBhZGRyID0gbV9nbFdpZGdldC0+Y29udGV4dCgpLT5nZXRQcm9jQWRkcmVz cyhRU3RyaW5nKG5hbWVXaXRoRXh0KSk7CiAgICAgICAgIGlmIChhZGRyKSAKICAgICAgICAgICAg IHJldHVybiBhZGRyOwogICAgIH0KQEAgLTY1Niw3ICs2NTYsNyBAQCBQYXNzUmVmUHRyPEltYWdl RGF0YT4gR3JhcGhpY3NDb250ZXh0M0Q6CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnJlc2hh cGUoaW50IHdpZHRoLCBpbnQgaGVpZ2h0KQogewotICAgIGlmICh3aWR0aCA9PSBtX2N1cnJlbnRX aWR0aCAmJiBoZWlnaHQgPT0gbV9jdXJyZW50SGVpZ2h0IHx8ICghbV9pbnRlcm5hbCkpCisgICAg aWYgKCh3aWR0aCA9PSBtX2N1cnJlbnRXaWR0aCAmJiBoZWlnaHQgPT0gbV9jdXJyZW50SGVpZ2h0 KSB8fCAoIW1faW50ZXJuYWwpKQogICAgICAgICByZXR1cm47CiAKICAgICBtX2N1cnJlbnRXaWR0 aCA9IHdpZHRoOwo=