58474 2011-04-13 13:15:16 -0700 [chromium] Remove unnecessary #define now that chrome has rolled to the latest WebKit 2011-04-13 16:03:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jam jam jianli oldest_to_newest 385173 0 jam 2011-04-13 13:15:16 -0700 [chromium] Remove unnecessary #define nowthat chrome has rolled to the latest WebKit 385174 1 89442 jam 2011-04-13 13:19:43 -0700 Created attachment 89442 Patch 385175 2 89443 jam 2011-04-13 13:21:03 -0700 Created attachment 89443 Patch 385322 3 89443 jianli 2011-04-13 15:54:15 -0700 Comment on attachment 89443 Patch Please fix the following problem before you land it. View in context: https://bugs.webkit.org/attachment.cgi?id=89443&action=review > Source/WebKit/chromium/ChangeLog:5 > + [chromium] Remove unnecessary #define nowthat chrome has rolled to the latest WebKit Please add space between "now" and "that". 385334 4 jam 2011-04-13 16:03:57 -0700 Committed r83782: <http://trac.webkit.org/changeset/83782> 89442 2011-04-13 13:19:43 -0700 2011-04-13 13:21:01 -0700 Patch bug-58474-20110413131813.patch text/plain 1500 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4Mzc1NykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMTMgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB1bm5lY2Vzc2FyeSAjZGVmaW5lIG5vd3RoYXQgY2hyb21lIGhhcyByb2xsZWQgdG8g dGhlIGxhdGVzdCBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU4NDc0CisKKyAgICAgICAgKiBERVBTOgorICAgICAgICAqIHB1YmxpYy9XZWJT cGVsbENoZWNrQ2xpZW50Lmg6CisKIDIwMTEtMDQtMTMgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDog U291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vREVQUwkocmV2aXNpb24gODM3NTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L0RFUFMJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2No cm9taXVtX3N2bic6ICdodHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAg J2Nocm9taXVtX3Jldic6ICc4MTI3NCcKKyAgJ2Nocm9taXVtX3Jldic6ICc4MXh4eCcKIH0KIAog ZGVwcyA9IHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWxsQ2hl Y2tDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJTcGVsbENoZWNrQ2xpZW50LmgJKHJldmlzaW9uIDgzNzU1KQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViU3BlbGxDaGVja0NsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0z OSw4ICszOSw2IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgV2ViU3RyaW5nOwogY2xhc3Mg V2ViVGV4dENoZWNraW5nQ29tcGxldGlvbjsKIAotI2RlZmluZSBXRUJTUEVMTENIRUNLQ0xJRU5U X0hBU19TVUdHRVNUSU9OUwotCiBjbGFzcyBXZWJTcGVsbENoZWNrQ2xpZW50IHsKIHB1YmxpYzoK ICAgICAvLyBUaGUgY2xpZW50IHNob3VsZCBwZXJmb3JtIHNwZWxsLWNoZWNraW5nIG9uIHRoZSBn aXZlbiB0ZXh0LiBJZiB0aGUK 89443 2011-04-13 13:21:03 -0700 2011-04-13 15:54:15 -0700 Patch bug-58474-20110413131933.patch text/plain 1500 jam SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4Mzc1NykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDQtMTMgIEpvaG4gQWJkLUVsLU1hbGVrICA8amFtQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d IFJlbW92ZSB1bm5lY2Vzc2FyeSAjZGVmaW5lIG5vd3RoYXQgY2hyb21lIGhhcyByb2xsZWQgdG8g dGhlIGxhdGVzdCBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU4NDc0CisKKyAgICAgICAgKiBERVBTOgorICAgICAgICAqIHB1YmxpYy9XZWJT cGVsbENoZWNrQ2xpZW50Lmg6CisKIDIwMTEtMDQtMTMgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDog U291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vREVQUwkocmV2aXNpb24gODM3NTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L0RFUFMJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcgQEAKIAogdmFycyA9IHsKICAgJ2No cm9taXVtX3N2bic6ICdodHRwOi8vc3JjLmNocm9taXVtLm9yZy9zdm4vdHJ1bmsvc3JjJywKLSAg J2Nocm9taXVtX3Jldic6ICc4MTI3NCcKKyAgJ2Nocm9taXVtX3Jldic6ICc4MTM0MScKIH0KIAog ZGVwcyA9IHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWxsQ2hl Y2tDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJTcGVsbENoZWNrQ2xpZW50LmgJKHJldmlzaW9uIDgzNzU1KQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViU3BlbGxDaGVja0NsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0z OSw4ICszOSw2IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgV2ViU3RyaW5nOwogY2xhc3Mg V2ViVGV4dENoZWNraW5nQ29tcGxldGlvbjsKIAotI2RlZmluZSBXRUJTUEVMTENIRUNLQ0xJRU5U X0hBU19TVUdHRVNUSU9OUwotCiBjbGFzcyBXZWJTcGVsbENoZWNrQ2xpZW50IHsKIHB1YmxpYzoK ICAgICAvLyBUaGUgY2xpZW50IHNob3VsZCBwZXJmb3JtIHNwZWxsLWNoZWNraW5nIG9uIHRoZSBn aXZlbiB0ZXh0LiBJZiB0aGUK