<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>5846</bug_id>
          
          <creation_ts>2005-11-27 16:30:09 -0800</creation_ts>
          <short_desc>cvs-create-patch --include produces incorrect paths</short_desc>
          <delta_ts>2005-12-21 23:39:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P4</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>5845</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Oliver Hunt">oliver</reporter>
          <assigned_to name="Oliver Hunt">oliver</assigned_to>
          <cc>ap</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>24708</commentid>
    <comment_count>0</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2005-11-27 16:30:09 -0800</bug_when>
    <thetext>cvs-create-patch --include produces truncated paths for new files</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>24709</commentid>
    <comment_count>1</comment_count>
      <attachid>4823</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2005-11-27 16:31:19 -0800</bug_when>
    <thetext>Created attachment 4823
patch to fix problem</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>24713</commentid>
    <comment_count>2</comment_count>
      <attachid>4823</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2005-11-27 16:47:12 -0800</bug_when>
    <thetext>Comment on attachment 4823
patch to fix problem

r=me please use unidiff (cvs diff -u) format for future patches.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>25436</commentid>
    <comment_count>3</comment_count>
    <who name="">mitz</who>
    <bug_when>2005-12-03 08:52:34 -0800</bug_when>
    <thetext>The paths I&apos;m seeing for unknown files after the patch are missing the penultimate path component, e.g
LayoutTests/fast/sometest.html instead of LayoutTests/fast/js/sometest.html
I suspect this line in addNewFile:
    $indexPath =~ s|[^/]+$|| if defined $indexPath;
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>25461</commentid>
    <comment_count>4</comment_count>
      <attachid>4823</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-12-03 16:06:22 -0800</bug_when>
    <thetext>Comment on attachment 4823
patch to fix problem

Clearing review flag since the patch has been landed but the bug reopened (and
we don&apos;t want this in the &quot;patches to be landed&quot; list).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>26262</commentid>
    <comment_count>5</comment_count>
      <attachid>5181</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2005-12-20 05:32:57 -0800</bug_when>
    <thetext>Created attachment 5181
additional patch

The current version didn&apos;t always omit the penultimate component, but could
also duplicate it in some cases :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>26269</commentid>
    <comment_count>6</comment_count>
      <attachid>5181</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-12-20 09:14:01 -0800</bug_when>
    <thetext>Comment on attachment 5181
additional patch

Looks fine. r=me</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>4823</attachid>
            <date>2005-11-27 16:31:19 -0800</date>
            <delta_ts>2005-12-03 16:06:22 -0800</delta_ts>
            <desc>patch to fix problem</desc>
            <filename>cvs-create-patch.patch</filename>
            <type>text/plain</type>
            <size>449</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">SW5kZXg6IGN2cy1jcmVhdGUtcGF0Y2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl
YktpdFRvb2xzL1NjcmlwdHMvY3ZzLWNyZWF0ZS1wYXRjaCx2CnJldHJpZXZpbmcgcmV2aXNpb24g
MS44CmRpZmYgLXIxLjggY3ZzLWNyZWF0ZS1wYXRjaAoxNDRjMTQ0CjwgICAgICAgICAgICAgICAg
ICAgICBhZGROZXdEaXJlY3RvcnkoJGluZGV4UGF0aCwgJHVua25vd24pOwotLS0KPiAgICAgICAg
ICAgICAgICAgICAgIGFkZE5ld0RpcmVjdG9yeSgkZGlyLCAkdW5rbm93bik7CjE0NmMxNDYKPCAg
ICAgICAgICAgICAgICAgICAgIGFkZE5ld0ZpbGUoJGluZGV4UGF0aCwgJHVua25vd24pOwotLS0K
PiAgICAgICAgICAgICAgICAgICAgIGFkZE5ld0ZpbGUoJGRpciwgJHVua25vd24pOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>5181</attachid>
            <date>2005-12-20 05:32:57 -0800</date>
            <delta_ts>2005-12-20 09:14:01 -0800</delta_ts>
            <desc>additional patch</desc>
            <filename>NewFilePathsPatch.txt</filename>
            <type>text/plain</type>
            <size>2211</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0VG9v
bHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzMgpkaWZmIC1wIC11IC1yMS4x
MzIgQ2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMTkgRGVjIDIwMDUgMjE6MDM6NTMgLTAwMDAJMS4x
MzIKKysrIENoYW5nZUxvZwkyMCBEZWMgMjAwNSAxMzozODowMiAtMDAwMApAQCAtMSwzICsxLDEy
IEBACisyMDA1LTEyLTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAbnlwb3AuY29tPgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6
Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NgorICAgICAgICAg
IGN2cy1jcmVhdGUtcGF0Y2ggLS1pbmNsdWRlIHByb2R1Y2VzIGluY29ycmVjdCBwYXRocworCisg
ICAgICAgICogU2NyaXB0cy9jdnMtY3JlYXRlLXBhdGNoOiBIYW5kbGUgbmV3bHktYWRkZWQgZGly
ZWN0b3JpZXMgdXNpbmcgY2hkaXIuCisKIDIwMDUtMTItMTkgIEVyaWMgU2VpZGVsICA8ZXNlaWRl
bEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgZGFyaW4uCkluZGV4OiBTY3JpcHRz
L2N2cy1jcmVhdGUtcGF0Y2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYktpdFRv
b2xzL1NjcmlwdHMvY3ZzLWNyZWF0ZS1wYXRjaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS45CmRp
ZmYgLXAgLXUgLXIxLjkgU2NyaXB0cy9jdnMtY3JlYXRlLXBhdGNoCi0tLSBTY3JpcHRzL2N2cy1j
cmVhdGUtcGF0Y2gJMjggTm92IDIwMDUgMDY6MjE6MjEgLTAwMDAJMS45CisrKyBTY3JpcHRzL2N2
cy1jcmVhdGUtcGF0Y2gJMjAgRGVjIDIwMDUgMTM6Mzg6MDIgLTAwMDAKQEAgLTIsNiArMiw3IEBA
CiAKICMgQ29weXJpZ2h0IChDKSAyMDA1IEFwcGxlIENvbXB1dGVyLCBJbmMuICBBbGwgcmlnaHRz
IHJlc2VydmVkLgogIyBDb3B5cmlnaHQgKEMpIDIwMDUgQmVuIExhIE1vbmljYSA8YmVuLmxhbW9u
aWNhQGdtYWlsLmNvbT4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDA1
IEFsZXhleSBQcm9za3VyeWFrb3YgPGFwQG55cG9wLmNvbT4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K
ICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg
d2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0
aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTc3LDkgKzE3OCwxNSBAQCBzdWIgYWRk
TmV3RGlyZWN0b3J5CiAgICAgZm9yIG15ICRmaWxlIChAZmlsZXMpIHsKICAgICAgICAgbmV4dCBp
ZiAkZmlsZSBlcSAiLiIgfHwgJGZpbGUgZXEgIi4uIjsKICAgICAgICAgaWYgKC1kICIkZGlyLyRm
aWxlIikgewotICAgICAgICAgICAgYWRkTmV3RGlyZWN0b3J5KCRpbmRleFBhdGgsICIkZGlyLyRm
aWxlIik7CisgICAgICAgICAgICBteSAkb2xkRGlyID0gZ2V0Y3dkKCk7CisgICAgICAgICAgICBj
aGRpciAkZGlyOworICAgICAgICAgICAgYWRkTmV3RGlyZWN0b3J5KCRpbmRleFBhdGgsICIkZmls
ZSIpOworICAgICAgICAgICAgY2hkaXIgJG9sZERpcjsKICAgICAgICAgfSBlbHNlIHsKLSAgICAg
ICAgICAgIGFkZE5ld0ZpbGUoIiRpbmRleFBhdGgiLCAiJGRpci8kZmlsZSIpOworICAgICAgICAg
ICAgbXkgJG9sZERpciA9IGdldGN3ZCgpOworICAgICAgICAgICAgY2hkaXIgJGRpcjsKKyAgICAg
ICAgICAgIGFkZE5ld0ZpbGUoJGluZGV4UGF0aCwgIiRmaWxlIik7CisgICAgICAgICAgICBjaGRp
ciAkb2xkRGlyOwogICAgICAgICB9CiAgICAgfQogfQpAQCAtMjAzLDggKzIxMCw3IEBAIHN1YiBh
ZGROZXdGaWxlCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICAkaW5kZXhQYXRoID1+IHN8
W14vXSskfHwgaWYgZGVmaW5lZCAkaW5kZXhQYXRoOwotICAgICRpbmRleFBhdGggLj0gJG5ld0Zp
bGU7CisgICAgJGluZGV4UGF0aCAuPSAiLyIgLiAkbmV3RmlsZTsKIAogICAgICNnZXQgcmlkIG9m
IHRoZSBmaXJzdCAyIGxpbmVzCiAgICAgc2hpZnQgQGZpbGVDb250ZW50czsK
</data>
<flag name="review"
          id="1053"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>