58446 2011-04-13 08:59:58 -0700 ORWT needs a way to look in a user-specified directory for platform-specific results 2011-04-13 14:50:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben aroben dpranke mihaip sam oldest_to_newest 384923 0 aroben 2011-04-13 08:59:58 -0700 ORWT needs a way to look in a user-specified directory for platform-specific results 384925 1 89383 aroben 2011-04-13 09:01:30 -0700 Created attachment 89383 Patch 384927 2 aroben 2011-04-13 09:06:49 -0700 CCing Dirk since he is working on NRWT/ORWT parity. 384931 3 aroben 2011-04-13 09:12:44 -0700 Committed r83743: <http://trac.webkit.org/changeset/83743> 385252 4 dpranke 2011-04-13 14:37:59 -0700 Heh, we actually added this to NRWT in r82972, except that we called it --baseline-search-path. It would be good if we actually used the same parameter name. I don't have a strong leaning either way, but I might like --additional-platform-directory a bit more. Mihai, what do you think? 385256 5 mihaip 2011-04-13 14:44:23 -0700 Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree. 385262 6 aroben 2011-04-13 14:48:09 -0700 (In reply to comment #5) > Does --additional-platform-directory only let you specify directories inside LayoutTests/platform? The intent with --baseline-search-path was to allow local (not under version control) directories to be used too, and it made sense for those to live outside the LayoutTests tree. The directory does not have to be within LayoutTests/platform. 385263 7 mihaip 2011-04-13 14:50:12 -0700 (In reply to comment #6) > The directory does not have to be within LayoutTests/platform. OK, will rename --baseline-search-path then. 89383 2011-04-13 09:01:30 -0700 2011-04-13 09:06:51 -0700 Patch bug-58446-20110413120137.patch text/plain 2812 aroben U3VidmVyc2lvbiBSZXZpc2lvbjogODM3MjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhODFhZjNiOTc0ZTk3NmMxMWNlOTAyNjI1NjhmZDdiNTJh MTIzMDE4Li41NTU3MjVlMmZlZjQ4NzczY2NkZDI5MjlhYTJjYjA5MmU2OTA5OTcxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDQtMTMgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAg IFRlYWNoIE9SV1QgYWJvdXQgZXh0cmEgcGxhdGZvcm0tc3BlY2lmaWMgZGlyZWN0b3JpZXMgdG8g YmUgc2VhcmNoZWQgYmVmb3JlIHRoZSBkZWZhdWx0IG9uZXMKKworICAgICAgICBGaXhlcyA8aHR0 cDovL3dlYmtpdC5vcmcvYi81ODQ0Nj4gT1JXVCBuZWVkcyBhIHdheSB0byBsb29rIGluIGEgdXNl ci1zcGVjaWZpZWQgZGlyZWN0b3J5IGZvcgorICAgICAgICBwbGF0Zm9ybS1zcGVjaWZpYyByZXN1 bHRzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAgICAodG9wLWxldmVsKTogQWRkZWQg QGFkZGl0aW9uYWxQbGF0Zm9ybURpcmVjdG9yaWVzIGFuZCBob29rZWQgdXAKKyAgICAgICAgLS1h ZGRpdGlvbmFsLXBsYXRmb3JtLWRpcmVjdG9yaWVzIHRvIHBvcHVsYXRlIGl0LgorICAgICAgICAo YnVpbGRQbGF0Zm9ybVJlc3VsdEhpZXJhcmNoeSk6IFByZXBlbmQgdGhlIGFkZGl0aW9uYWwgcGxh dGZvcm0gZGlyZWN0b3JpZXMgdG8gdGhlIGRlZmF1bHQKKyAgICAgICAgbGlzdCAoYWZ0ZXIgZmls dGVyaW5nIG91dCBhbnkgb2YgdGhlIGFkZGl0aW9uYWwgZGlyZWN0b3JpZXMgdGhhdCBkb24ndCBl eGlzdCkuCisKIDIwMTEtMDQtMTIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Vi a2l0LXRlc3RzCmluZGV4IDUxZjA4M2YzYTE0NjM0Mjg5MGY3NjA1MzFlNTkxMjA2NTE2ODNmZTcu LjkzYTJkMWZlMTQ2Mzg1NGQxNGZhY2JkNmNiYWFlMTE1YzVjMzkwMGYgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9vbGQt cnVuLXdlYmtpdC10ZXN0cwpAQCAtMTI2LDYgKzEyNiw3IEBAIHN1YiB3cml0ZVRvRmlsZSgkJCk7 CiAKICMgQXJndW1lbnQgaGFuZGxpbmcKIG15ICRhZGRQbGF0Zm9ybUV4Y2VwdGlvbnMgPSAwOwor bXkgQGFkZGl0aW9uYWxQbGF0Zm9ybURpcmVjdG9yaWVzID0gKCk7CiBteSAkY29tcGxleFRleHQg PSAwOwogbXkgJGV4aXRBZnRlck5GYWlsdXJlcyA9IDA7CiBteSAkZXhpdEFmdGVyTkNyYXNoZXNP clRpbWVvdXRzID0gMDsKQEAgLTI3Niw2ICsyNzcsOCBAQCBteSAkc2FtcGxlRGVmYXVsdCA9ICRy dW5TYW1wbGUgPyAicnVuIiA6ICJkbyBub3QgcnVuIjsKIG15ICR1c2FnZSA9IDw8RU9GOwogVXNh Z2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW3Rlc3RkaXJ8dGVzdHBhdGggLi4uXQogICAtLWFk ZC1wbGF0Zm9ybS1leGNlcHRpb25zICAgICAgIFB1dCBuZXcgcmVzdWx0cyBmb3Igbm9uLXBsYXRm b3JtLXNwZWNpZmljIGZhaWxpbmcgdGVzdHMgaW50byB0aGUgcGxhdGZvcm0tc3BlY2lmaWMgcmVz dWx0cyBkaXJlY3RvcnkKKyAgLS1hZGRpdGlvbmFsLXBsYXRmb3JtLWRpcmVjdG9yeSBwYXRoL3Rv L2RpcmVjdG9yeQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExvb2sgaW4gdGhl IHNwZWNpZmllZCBkaXJlY3RvcnkgYmVmb3JlIGxvb2tpbmcgaW4gYW55IG9mIHRoZSBkZWZhdWx0 IHBsYXRmb3JtLXNwZWNpZmljIGRpcmVjdG9yaWVzCiAgIC0tY29tcGxleC10ZXh0ICAgICAgICAg ICAgICAgICAgVXNlIHRoZSBjb21wbGV4IHRleHQgY29kZSBwYXRoIGZvciBhbGwgdGV4dCAoTWFj IE9TIFggYW5kIFdpbmRvd3Mgb25seSkKICAgLWN8LS1jb25maWd1cmF0aW9uIGNvbmZpZyAgICAg ICBTZXQgRHVtcFJlbmRlclRyZWUgYnVpbGQgY29uZmlndXJhdGlvbgogICAtZ3wtLWd1YXJkLW1h bGxvYyAgICAgICAgICAgICAgIEVuYWJsZSBtYWxsb2MgZ3VhcmQKQEAgLTMyNCw2ICszMjcsNyBA QCBzZXRDb25maWd1cmF0aW9uKCk7CiAKIG15ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9u cygKICAgICAnYWRkLXBsYXRmb3JtLWV4Y2VwdGlvbnMnID0+IFwkYWRkUGxhdGZvcm1FeGNlcHRp b25zLAorICAgICdhZGRpdGlvbmFsLXBsYXRmb3JtLWRpcmVjdG9yeT1zJyA9PiBcQGFkZGl0aW9u YWxQbGF0Zm9ybURpcmVjdG9yaWVzLAogICAgICdjb21wbGV4LXRleHQnID0+IFwkY29tcGxleFRl eHQsCiAgICAgJ2V4aXQtYWZ0ZXItbi1mYWlsdXJlcz1pJyA9PiBcJGV4aXRBZnRlck5GYWlsdXJl cywKICAgICAnZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHM9aScgPT4gXCRleGl0QWZ0 ZXJOQ3Jhc2hlc09yVGltZW91dHMsCkBAIC0yMTcxLDYgKzIxNzUsOCBAQCBzdWIgYnVpbGRQbGF0 Zm9ybVJlc3VsdEhpZXJhcmNoeSgpCiAgICAgICAgIHB1c2goQGhpZXJhcmNoeSwgJHNjb3BlZCkg aWYgKC1kICRzY29wZWQpOwogICAgIH0KICAgICAKKyAgICB1bnNoaWZ0IEBoaWVyYXJjaHksIGdy ZXAgeyAtZCAkXyB9IEBhZGRpdGlvbmFsUGxhdGZvcm1EaXJlY3RvcmllczsKKwogICAgIHJldHVy biBAaGllcmFyY2h5OwogfQogCg==