58440 2011-04-13 08:04:09 -0700 Web Inspector: there is a problem if optional param is not at the end of param list 2011-04-13 08:44:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 384888 0 loislo 2011-04-13 08:04:09 -0700 the tail of the event params shifts if an optional property is not the last in the params list. 384901 1 89380 loislo 2011-04-13 08:20:47 -0700 Created attachment 89380 [patch] initial version 384909 2 89380 yurys 2011-04-13 08:37:17 -0700 Comment on attachment 89380 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=89380&action=review > Source/WebCore/inspector/CodeGeneratorInspector.pm:693 > + my $name = $domain . "." . $function->signature->name; Is there a function for this coalescing? 384917 3 loislo 2011-04-13 08:44:54 -0700 Committed r83739: <http://trac.webkit.org/changeset/83739> 89380 2011-04-13 08:20:47 -0700 2011-04-13 08:37:16 -0700 [patch] initial version patch text/plain 3539 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ODNlMmI5Li5kOTM1NTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDQtMTMgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IHRoZXJlIGlzIGEgcHJvYmxlbSBpZiBhbiBvcHRpb25hbCBwYXJhbSBpcyBub3QgYXQg dGhlIGVuZCBvZiBhIHBhcmFtcyBsaXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTg0NDAKKworICAgICAgICBJbiBJbnNwZWN0b3JCYWNrZW5kLmRp c3BhdGNoIG1ldGhvZCB3ZSBhcmUgY29udmVydGluZyB0aGUgbWVzc2FnZSdzIHBhcmFtcyBvYmpl Y3QgaW50byBhcnJheSBvZiBhcmd1bWVudHMKKyAgICAgICAgZm9yIGEgY2FsbGJhY2suIEJ1dCBp biBzb21lIGNhc2VzIHRoZSBvcHRpb25hbCBwYXJhbWV0ZXIgaXMgZGVjbGFyZWQgaW4gdGhlIG1p ZGRsZSBvZiB0aGUgcGFyYW1zIGxpc3QuCisgICAgICAgIFRoYXQgZ2V0cyB1cyBpbnRvIGEgcHJv YmxlbSBpZiB0aGlzIHBhcmFtIGhhcyBiZWVuIHNraXBwZWQgaW4gdGhlIG1lc3NhZ2UuIEluIHRo YXQgY2FzZSB0aGUgdGFpbCBvZiB0aGUKKyAgICAgICAgZXZlbnQgcGFyYW1zIHdpbGwgYmUgc2hp ZnRlZC4gV2UgY2FuIHNsaWdodGx5IG1vZGlmeSBkaXNwYXRjaGVyIGFuZCBpdCB3aWxsIHB1dCB0 aGUgcGFyYW1zIGluIHJpZ2h0IHBsYWNlcy4KKworICAgICAgICAqIGluc3BlY3Rvci9Db2RlR2Vu ZXJhdG9ySW5zcGVjdG9yLnBtOgorCiAyMDExLTA0LTEzICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRy ZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3Iu cG0gYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQpp bmRleCA0NTRkOTExZi4uZGU4ZTFkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0KQEAgLTIyMyw2ICsyMjMsNyBAQCBteSBAYmFj a2VuZENvbnN0YW50RGVjbGFyYXRpb25zOwogbXkgQGJhY2tlbmRDb25zdGFudERlZmluaXRpb25z OwogbXkgQGJhY2tlbmRGb290ZXI7CiBteSBAYmFja2VuZEpTU3R1YnM7CitteSBAYmFja2VuZEpT RXZlbnRzOwogbXkgJWJhY2tlbmREb21haW5zOwogCiBteSAkZnJvbnRlbmRDbGFzc05hbWU7CkBA IC0zNDgsNiArMzQ5LDcgQEAgc3ViIGdlbmVyYXRlRnVuY3Rpb25zCiAgICAgfQogCiAgICAgY29s bGVjdEJhY2tlbmRKU1N0dWJGdW5jdGlvbnMoJGludGVyZmFjZSk7CisgICAgY29sbGVjdEJhY2tl bmRKU1N0dWJFdmVudHMoJGludGVyZmFjZSk7CiB9CiAKIHN1YiBnZW5lcmF0ZUZyb250ZW5kRnVu Y3Rpb24KQEAgLTY4MSw5ICs2ODMsMjQgQEAgc3ViIGNvbGxlY3RCYWNrZW5kSlNTdHViRnVuY3Rp b25zCiAgICAgfQogfQogCitzdWIgY29sbGVjdEJhY2tlbmRKU1N0dWJFdmVudHMKK3sKKyAgICBt eSAkaW50ZXJmYWNlID0gc2hpZnQ7CisgICAgbXkgQGZ1bmN0aW9ucyA9IGdyZXAoJF8tPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57ImV2ZW50In0sIEB7JGludGVyZmFjZS0+ZnVuY3Rp b25zfSk7CisgICAgbXkgJGRvbWFpbiA9ICRpbnRlcmZhY2UtPm5hbWU7CisKKyAgICBmb3JlYWNo IG15ICRmdW5jdGlvbiAoQGZ1bmN0aW9ucykgeworICAgICAgICBteSAkbmFtZSA9ICRkb21haW4g LiAiLiIgLiAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZTsKKyAgICAgICAgbXkgQG91dEFyZ3Mg PSBncmVwKCRfLT5kaXJlY3Rpb24gZXEgIm91dCIsIEB7JGZ1bmN0aW9uLT5wYXJhbWV0ZXJzfSk7 CisgICAgICAgIG15ICRhcmd1bWVudE5hbWVzID0gam9pbigiLCIsIG1hcCgiXCIiIC4gJF8tPm5h bWUgLiAiXCIiICwgQG91dEFyZ3MpKTsKKyAgICAgICAgcHVzaChAYmFja2VuZEpTRXZlbnRzLCAi ICAgIHRoaXMuX2V2ZW50QXJnc1tcIiIgLiAkbmFtZSAuICJcIl0gPSBbIiAuICRhcmd1bWVudE5h bWVzIC4iXTsiKTsKKyAgICB9Cit9CisKIHN1YiBnZW5lcmF0ZUJhY2tlbmRTdHViSlMKIHsKICAg ICBteSAkSlNTdHVicyA9IGpvaW4oIlxuIiwgQGJhY2tlbmRKU1N0dWJzKTsKKyAgICBteSAkSlNF dmVudHMgPSBqb2luKCJcbiIsIEBiYWNrZW5kSlNFdmVudHMpOwogICAgIG15ICRpbnNwZWN0b3JC YWNrZW5kU3R1YkpTID0gPDwgIkVPRiI7CiAkbGljZW5zZVRlbXBsYXRlCiAKQEAgLTY5Myw3ICs3 MTAsOSBAQCBJbnNwZWN0b3JCYWNrZW5kU3R1YiA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9wZW5k aW5nUmVzcG9uc2VzQ291bnQgPSAwOwogICAgIHRoaXMuX2NhbGxiYWNrcyA9IHt9OwogICAgIHRo aXMuX2RvbWFpbkRpc3BhdGNoZXJzID0ge307CisgICAgdGhpcy5fZXZlbnRBcmdzID0ge307CiAk SlNTdHVicworJEpTRXZlbnRzCiB9CiAKIEluc3BlY3RvckJhY2tlbmRTdHViLnByb3RvdHlwZSA9 IHsKQEAgLTgxMSwxMCArODMwLDE2IEBAIEluc3BlY3RvckJhY2tlbmRTdHViLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAg IGlmICghdGhpcy5fZXZlbnRBcmdzW21lc3NhZ2VPYmplY3QubWV0aG9kXSkgeworICAgICAgICAg ICAgICAgIGNvbnNvbGUuZXJyb3IoIlByb3RvY29sIEVycm9yOiBBdHRlbXB0ZWQgdG8gZGlzcGF0 Y2ggYW4gdW5zcGVjaWZpZWQgbWV0aG9kICciICsgbWVzc2FnZU9iamVjdC5tZXRob2QgKyAiJyIp OworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAg dmFyIHBhcmFtcyA9IFtdOwogICAgICAgICAgICAgaWYgKG1lc3NhZ2VPYmplY3QucGFyYW1zKSB7 Ci0gICAgICAgICAgICAgICAgZm9yICh2YXIga2V5IGluIG1lc3NhZ2VPYmplY3QucGFyYW1zKQot ICAgICAgICAgICAgICAgICAgICBwYXJhbXMucHVzaChtZXNzYWdlT2JqZWN0LnBhcmFtc1trZXld KTsKKyAgICAgICAgICAgICAgICB2YXIgcGFyYW1OYW1lcyA9IHRoaXMuX2V2ZW50QXJnc1ttZXNz YWdlT2JqZWN0Lm1ldGhvZF07CisgICAgICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBw YXJhbU5hbWVzLmxlbmd0aDsgKytpKQorICAgICAgICAgICAgICAgICAgICBwYXJhbXMucHVzaCht ZXNzYWdlT2JqZWN0LnBhcmFtc1twYXJhbU5hbWVzW2ldXSk7CiAgICAgICAgICAgICB9CiAKICAg ICAgICAgICAgIGRpc3BhdGNoZXJbZnVuY3Rpb25OYW1lXS5hcHBseShkaXNwYXRjaGVyLCBwYXJh bXMpOwo=