58437 2011-04-13 06:10:09 -0700 WebKit fails to build with gcc 4.6 2011-04-18 01:30:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 thierry.reding webkit-unassigned commit-queue thierry.reding oldest_to_newest 384820 0 thierry.reding 2011-04-13 06:10:09 -0700 When the Source/WebCore/dom/make_names.pl script is run, the C preprocessor is run with the -P option. Apparently, the preprocessor behavior was changed in gcc 4.6 because running with the -P option makes it eat all empty lines, which gcc 4.5 doesn't. The make_names.pl script, however, relies on these empty lines when parsing. The attached patch removes the -P option when invoking the preprocessor. Apart from keeping the empty lines, this has the side-effect of outputting some preprocessor output. However these lines (starting with a #) are already being ignored by make_names.pl such that the preprocessed files can be properly parsed. 384823 1 89369 thierry.reding 2011-04-13 06:13:57 -0700 Created attachment 89369 Fix build with gcc 4.6. 385052 2 ap 2011-04-13 11:35:17 -0700 Thank you for reporting and fixing the problem! For this patch to be landed in trunk, it needs to be prepared in accordance with <http://www.webkit.org/coding/contributing.html>. Specifically, it must have a ChangeLog entry, and it must be marked for review. For the record, -P Inhibit generation of linemarkers in the output from the preprocessor. This might be useful when running the preprocessor on something that is not C code, and will be sent to a program which might be confused by the linemarkers. 385562 3 89542 thierry.reding 2011-04-14 00:14:50 -0700 Created attachment 89542 Fix build with gcc 4.6. 387526 4 89542 abarth 2011-04-17 21:43:12 -0700 Comment on attachment 89542 Fix build with gcc 4.6. Thanks! 387564 5 89542 commit-queue 2011-04-17 23:53:43 -0700 Comment on attachment 89542 Fix build with gcc 4.6. Clearing flags on attachment: 89542 Committed r84123: <http://trac.webkit.org/changeset/84123> 387565 6 commit-queue 2011-04-17 23:53:48 -0700 All reviewed patches have been landed. Closing bug. 387575 7 commit-queue 2011-04-18 01:03:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 89542: http/tests/xmlhttprequest/cross-origin-preflight-get.html bug 53976 The commit-queue is continuing to process your patch. 387582 8 commit-queue 2011-04-18 01:30:59 -0700 The commit-queue encountered the following flaky tests while processing attachment 89542: fast/canvas/webgl/gl-teximage.html bug 58766 (authors: kbr@google.com, mihaip@chromium.org, and zmo@google.com) fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) The commit-queue is continuing to process your patch. 89369 2011-04-13 06:13:57 -0700 2011-04-14 00:14:50 -0700 Fix build with gcc 4.6. gcc-4.6.patch text/plain 418 thierry.reding ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsIGIvU291cmNlL1dl YkNvcmUvZG9tL21ha2VfbmFtZXMucGwKaW5kZXggODM2MTM3ZS4uNTAzODZlMCAxMDA3NTUKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL21ha2VfbmFtZXMucGwKQEAgLTY1LDcgKzY1LDcgQEAgaWYgKCRFTlZ7Q0N9KSB7CiB9IGVs c2UgewogICAgICRnY2NMb2NhdGlvbiA9ICIvdXNyL2Jpbi9nY2MiOwogfQotbXkgJHByZXByb2Nl c3NvciA9ICRnY2NMb2NhdGlvbiAuICIgLUUgLVAgLXggYysrIjsKK215ICRwcmVwcm9jZXNzb3Ig PSAkZ2NjTG9jYXRpb24gLiAiIC1FIC14IGMrKyI7CiAKIEdldE9wdGlvbnMoCiAgICAgJ3RhZ3M9 cycgPT4gXCR0YWdzRmlsZSwgCg== 89542 2011-04-14 00:14:50 -0700 2011-04-17 23:53:43 -0700 Fix build with gcc 4.6. gcc-4.6.patch text/plain 1640 thierry.reding ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZDRiMmJjLi4zOGNhOTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMDQtMTQgIFRoaWVycnkgUmVkaW5nICA8dGhpZXJyeS5yZWRpbmdAYXZpb25pYy1k ZXNpZ24uZGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGJ1aWxkIHdpdGggR0NDIDQuNi4KKworICAgICAgICAqIGRvbS9tYWtlX25hbWVzLnBs OiBFeGVjdXRlIHByZXByb2Nlc3NvciB3aXRob3V0IHRoZSAtUCBvcHRpb24uIFRoZQorICAgICAg ICBwcmVwcm9jZXNzb3IgaW4gR0NDIDQuNiBlYXRzIGVtcHR5IGxpbmVzLCBlZmZlY3RpdmVseSBi cmVha2luZyB0aGUKKyAgICAgICAgcGFyc2luZyBwZXJmb3JtZWQgYnkgdGhpcyBzY3JpcHQuIERy b3BwaW5nIHRoZSAtUCBvcHRpb24gd2hlbiBpbnZva2luZworICAgICAgICB0aGUgcHJlcHJvY2Vz c29yIGtlZXBzIHRoZSBlbXB0eSBsaW5lcyBidXQgYXMgYSBzaWRlLWVmZmVjdCBhbHNvIGFkZHMK KyAgICAgICAgYWRkaXRpb25hbCBsaW5lbWFya2Vycy4KKworICAgICAgICBGcm9tIHRoZSBjcHAg bWFucGFnZToKKworICAgICAgICAgIC1QICBJbmhpYml0IGdlbmVyYXRpb24gb2YgbGluZW1hcmtl cnMgaW4gdGhlIG91dHB1dCBmcm9tIHRoZQorICAgICAgICAgICAgICBwcmVwcm9jZXNzb3IuIFRo aXMgbWlnaHQgYmUgdXNlZnVsIHdoZW4gcnVubmluZyB0aGUgcHJlcHJvY2Vzc29yCisgICAgICAg ICAgICAgIG9uIHNvbWV0aGluZyB0aGF0IGlzIG5vdCBDIGNvZGUsIGFuZCB3aWxsIGJlIHNlbnQg dG8gYSBwcm9ncmFtCisgICAgICAgICAgICAgIHdoaWNoIG1pZ2h0IGJlIGNvbmZ1c2VkIGJ5IHRo ZSBsaW5lbWFya2Vycy4KKworICAgICAgICBUaGUgbGluZW1hcmtlcnMgYXJlIG5vdCBwcm9ibGVt YXRpYywgaG93ZXZlciwgYmVjYXVzZSB0aGUgc2NyaXB0CisgICAgICAgIHByb3Blcmx5IGhhbmRs ZXMgdGhlbSBieSBpZ25vcmluZyBhbGwgbGluZXMgc3RhcnRpbmcgd2l0aCBhICMuCisKIDIwMTEt MDQtMTMgIENhcnkgQ2xhcmsgIDxjYXJ5Y2xhcmtAY2hyb21pdW0ub3JnPgogIAogICAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v bWFrZV9uYW1lcy5wbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCmluZGV4IDgz NjEzN2UuLjUwMzg2ZTAgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVz LnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCkBAIC02NSw3ICs2NSw3 IEBAIGlmICgkRU5We0NDfSkgewogfSBlbHNlIHsKICAgICAkZ2NjTG9jYXRpb24gPSAiL3Vzci9i aW4vZ2NjIjsKIH0KLW15ICRwcmVwcm9jZXNzb3IgPSAkZ2NjTG9jYXRpb24gLiAiIC1FIC1QIC14 IGMrKyI7CitteSAkcHJlcHJvY2Vzc29yID0gJGdjY0xvY2F0aW9uIC4gIiAtRSAteCBjKysiOwog CiBHZXRPcHRpb25zKAogICAgICd0YWdzPXMnID0+IFwkdGFnc0ZpbGUsIAo=