58432 2011-04-13 04:40:38 -0700 Change the representation of ShadowRoot nodes in render tree dumps 2011-04-13 18:12:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 57813 54179 1 tkent tkent commit-queue dglazkov dominicc rolandsteiner oldest_to_newest 384798 0 tkent 2011-04-13 04:40:38 -0700 We had better show ShadowRoot nodes explicitly in render tree dumps instead of showing #document-fragment. Example: Editing range dump: -EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > #document-fragment to 0 of DIV > #document-fragment affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > #shadow-root to 0 of DIV > #shadow-root affinity:NSSelectionAffinityDownstream stillSelecting:FALSE Caret dump: -caret: position 0 of child 0 {DIV} of child 0 {#document-fragment} of child 1 {INPUT} of child 3 {DIV} of body +caret: position 0 of child 0 {DIV} of {#shadow-root} of child 1 {INPUT} of child 3 {DIV} of body Selection dump: -selection start: position 0 of child 0 {#text} of child 0 {DIV} of child 0 {#document-fragment} of child 3 {INPUT} of child 1 {P} of body -selection end: position 15 of child 0 {#text} of child 0 {DIV} of child 0 {#document-fragment} of child 3 {INPUT} of child 1 {P} of body +selection start: position 0 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of child 1 {P} of body +selection end: position 15 of child 0 {#text} of child 0 {DIV} of {#shadow-root} of child 3 {INPUT} of child 1 {P} of body 384805 1 89366 tkent 2011-04-13 05:26:31 -0700 Created attachment 89366 Patch 384935 2 89366 dglazkov 2011-04-13 09:19:47 -0700 Comment on attachment 89366 Patch ok. 384936 3 dglazkov 2011-04-13 09:20:10 -0700 Roland, you might be interested in seeing this. 385417 4 89366 commit-queue 2011-04-13 18:12:03 -0700 Comment on attachment 89366 Patch Clearing flags on attachment: 89366 Committed r83796: <http://trac.webkit.org/changeset/83796> 385419 5 commit-queue 2011-04-13 18:12:08 -0700 All reviewed patches have been landed. Closing bug. 89366 2011-04-13 05:26:31 -0700 2011-04-13 18:12:02 -0700 Patch bug-58432-20110413212629.patch text/plain 3685 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODM3MTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkYjcwODRiMzgwNDYzYzEw OGI0M2YwYzRkM2QyYzZjZmI1MWY4NTE4Li4xZTE3NWZkYmY2MzlhMmU2YTA1Y2FlN2UwM2FmYzA5 NzkyZTk1NWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDQtMTMgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSB0aGUgcmVwcmVzZW50YXRpb24gb2YgU2hhZG93 Um9vdCBub2RlcyBpbiByZW5kZXIgdHJlZSBkdW1wcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0MzIKKworICAgICAgICBTaG93ICIjc2hhZG93LXJv b3QiIGZvciBTaGFkb3JSb290IG5vZGVzIGluc3RlYWQgb2YgIiNkb2N1bWVudC1mcmFnbWVudCIK KyAgICAgICAgaW4gRFJUIHJlc3VsdHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGNo YW5nZSBkb2Vzbid0IGFmZmVjdCBleGlzdGluZyB0ZXN0cyB5ZXQuCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnRGcmFnbWVudC5oOgorICAgICAgICAgIE1ha2Ugbm9kZU5hbWUoKSBwcm90ZWN0ZWQg aW4gb3JkZXIgdGhhdCBTaGRvd1Jvb3QgY2FuIG92ZXJyaWRlIGl0LgorICAgICAgICAqIGRvbS9T aGFkb3dSb290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd1Jvb3Q6Om5vZGVOYW1lKTog UmV0dXJucyAiI3NoYWRvdy1yb290Ii4KKyAgICAgICAgKiBkb20vU2hhZG93Um9vdC5oOiBEZWNs YXJlIG5vZGVOYW1lKCkuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6bm9kZVBvc2l0aW9uKTogRG9uJ3Qgc2hvdyAiY2hpbGQgTiAi IGlmIHRoZSBub2RlIGlzIGEgc2hhZG93IGJvdW5kYXJ5LgorICAgICAgICAgIFdlIGRvbid0IHVz ZSBpc1NoYWRvd1Jvb3QoKSBoZXJlIGJlY2F1c2UgdGhlIGxlZ2FjeSBzaGFkb3cgcm9vdCBub2Rl cworICAgICAgICAgIHJldHVybiB0cnVlIGZvciBpc1NoYWRvd1Jvb3QoKSBhbmQgd2UgZG9uJ3Qg d2FudCB0byB1cGRhdGUgZXhpc3RpbmcKKyAgICAgICAgICB0ZXN0IHJlc3VsdHMuCisKIDIwMTEt MDQtMTMgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50RnJhZ21lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudEZyYWdt ZW50LmgKaW5kZXggZjU2NzUzNmIyYjE0NzRmYjA0MTVjMGNiMTg2MzRmNmFmNDQ2Njc4OC4uMWY2 ZjEyMDRkYjhmMTU4ZTM3Yzc4ZTBkZTFkY2IzMTEwMTJhNDRlNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnRGcmFnbWVudC5oCkBAIC0zOCw5ICszOCw5IEBAIHB1YmxpYzoKIAogcHJvdGVjdGVk OgogICAgIERvY3VtZW50RnJhZ21lbnQoRG9jdW1lbnQqKTsKKyAgICB2aXJ0dWFsIFN0cmluZyBu b2RlTmFtZSgpIGNvbnN0OwogCiBwcml2YXRlOgotICAgIHZpcnR1YWwgU3RyaW5nIG5vZGVOYW1l KCkgY29uc3Q7CiAgICAgdmlydHVhbCBOb2RlVHlwZSBub2RlVHlwZSgpIGNvbnN0OwogICAgIHZp cnR1YWwgUGFzc1JlZlB0cjxOb2RlPiBjbG9uZU5vZGUoYm9vbCBkZWVwKTsKICAgICB2aXJ0dWFs IGJvb2wgY2hpbGRUeXBlQWxsb3dlZChOb2RlVHlwZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vU2hhZG93Um9vdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5j cHAKaW5kZXggZWFmNTgwODQyMzI4NTAxZmI2MzViMWExOTQzZmY3N2I5ZTIzMzQxOC4uOGZlNTZi NWM2OTUyMTYxYTJlYWI3NTRkY2JkNzAzNWJlZjYzMjU0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZG9tL1NoYWRvd1Jvb3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dS b290LmNwcApAQCAtMzUsNiArMzUsMTEgQEAgU2hhZG93Um9vdDo6U2hhZG93Um9vdChEb2N1bWVu dCogZG9jdW1lbnQpCiAgICAgQVNTRVJUKGRvY3VtZW50KTsKIH0KIAorU3RyaW5nIFNoYWRvd1Jv b3Q6Om5vZGVOYW1lKCkgY29uc3QKK3sKKyAgICByZXR1cm4gIiNzaGFkb3ctcm9vdCI7Cit9CisK IHZvaWQgU2hhZG93Um9vdDo6cmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2UgY2hhbmdlKQogewogICAg IGZvciAoTm9kZSogbiA9IGZpcnN0Q2hpbGQoKTsgbjsgbiA9IG4tPm5leHRTaWJsaW5nKCkpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5oIGIvU291cmNlL1dlYkNv cmUvZG9tL1NoYWRvd1Jvb3QuaAppbmRleCA5ZmZkZGZmM2YwYTIyOTFhYzQ4NmVhMWJiYTk0MzM2 YmQyM2E5YzIyLi5hZWNjZDhhNDYxM2RiNmRlNjRlNGE2MTViMWEzNjQ4ZDExOTJhZThiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9TaGFkb3dSb290LmgKQEAgLTQyLDYgKzQyLDcgQEAgcHVibGljOgogCiBwcml2YXRl OgogICAgIFNoYWRvd1Jvb3QoRG9jdW1lbnQqKTsKKyAgICB2aXJ0dWFsIFN0cmluZyBub2RlTmFt ZSgpIGNvbnN0OwogfTsKIAogaW5saW5lIFBhc3NSZWZQdHI8U2hhZG93Um9vdD4gU2hhZG93Um9v dDo6Y3JlYXRlKERvY3VtZW50KiBkb2N1bWVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUcmVlQXNUZXh0LmNwcAppbmRleCA4ODU3MzkxYzk5YzUwMDI2NmE5NjE1MzA4NWU1 ZWYxYjNiMjEzYzAyLi4yZjViZDc0MGJiMWNkYTJiNGNlNjkxNGIyNTQ3MzZlYzA1NTVjNDkzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQuY3BwCkBAIC03 MjIsNyArNzIyLDEwIEBAIHN0YXRpYyBTdHJpbmcgbm9kZVBvc2l0aW9uKE5vZGUqIG5vZGUpCiAg ICAgICAgICAgICAgICAgcmVzdWx0ICs9ICJib2R5IjsKICAgICAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHJlc3VsdCArPSAiY2hpbGQgIiArIFN0cmluZzo6 bnVtYmVyKG4tPm5vZGVJbmRleCgpKSArICIgeyIgKyBnZXRUYWdOYW1lKG4pICsgIn0iOworICAg ICAgICAgICAgaWYgKG4tPmlzU2hhZG93Qm91bmRhcnkoKSkKKyAgICAgICAgICAgICAgICByZXN1 bHQgKz0gInsiICsgZ2V0VGFnTmFtZShuKSArICJ9IjsKKyAgICAgICAgICAgIGVsc2UKKyAgICAg ICAgICAgICAgICByZXN1bHQgKz0gImNoaWxkICIgKyBTdHJpbmc6Om51bWJlcihuLT5ub2RlSW5k ZXgoKSkgKyAiIHsiICsgZ2V0VGFnTmFtZShuKSArICJ9IjsKICAgICAgICAgfSBlbHNlCiAgICAg ICAgICAgICByZXN1bHQgKz0gImRvY3VtZW50IjsKICAgICB9Cg==