58431 2011-04-13 04:26:32 -0700 [GTK] Consider editable and non editable nodes when calculating selection offsets 2011-04-13 09:33:19 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned mrobinson oldest_to_newest 384788 0 mario 2011-04-13 04:26:32 -0700 This bug is just to track a simple -yet needed- change in AccessibilityObjectWrapperAtk.cpp: replace usage of firstPositionInNode() with firstPositionInOrBeforeNode(), as well as lastPositionInNode() with lastPositionInOrAfterNode(). This is needed to ensure that the function getSelectionOffsetsForObject() works well both when non editable nodes can be present in the selection, since firstPositionInNode() and lastPositionInNode() don't work in those cases (they assume the node is editable). 384791 1 89364 mario 2011-04-13 04:29:09 -0700 Created attachment 89364 Patch proposal Attached patch proposal. Both API and Layout tests keep passing. 384904 2 89364 mrobinson 2011-04-13 08:25:20 -0700 Comment on attachment 89364 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=89364&action=review > Source/WebCore/ChangeLog:8 > + Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode(). Why not put the second paragraph of the bug description here? It will be useful for people looks through Trac or git. 384949 3 mario 2011-04-13 09:33:19 -0700 Committed r83747: <http://trac.webkit.org/changeset/83747> 89364 2011-04-13 04:29:09 -0700 2011-04-13 08:25:20 -0700 Patch proposal 0001-2011-04-13-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3410 mario RnJvbSBlMmZmMWVlNDQ5OGI4MjAyY2Y5MGYzZGJmNzIwMDFmMDI0ZWM4NGY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDEzIEFwciAyMDExIDEzOjA1OjI5ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0wNC0xMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBDb25z aWRlciBlZGl0YWJsZSBhbmQgbm9uIGVkaXRhYmxlIG5vZGVzIHdoZW4gY2FsY3VsYXRpbmcgc2Vs ZWN0aW9uIG9mZnNldHMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTg0MzEKCiAgICAgICAgVXNlIGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZSgpIGFu ZCBsYXN0UG9zaXRpb25Jbk9yQWZ0ZXJOb2RlKCkuCgogICAgICAgICogYWNjZXNzaWJpbGl0eS9n dGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgogICAgICAgIChnZXRTZWxlY3Rp b25PZmZzZXRzRm9yT2JqZWN0KTogVXBkYXRlZCBjYWxscy4KLS0tCiBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAu Li4vZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCAgICAgICAgICB8ICAgIDcg KysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA5YmUxMWJjLi5mMzA0OTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIs MTggQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBb R1RLXSBDb25zaWRlciBlZGl0YWJsZSBhbmQgbm9uIGVkaXRhYmxlIG5vZGVzIHdoZW4gY2FsY3Vs YXRpbmcgc2VsZWN0aW9uIG9mZnNldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU4NDMxCisKKyAgICAgICAgVXNlIGZpcnN0UG9zaXRpb25Jbk9yQmVm b3JlTm9kZSgpIGFuZCBsYXN0UG9zaXRpb25Jbk9yQWZ0ZXJOb2RlKCkuCisKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6CisgICAg ICAgIChnZXRTZWxlY3Rpb25PZmZzZXRzRm9yT2JqZWN0KTogVXBkYXRlZCBjYWxscy4KKworMjAx MS0wNC0xMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgW0dUS10gTWlzc2lu ZyBudWxsY2hlY2tzIGluIEdUSydzIGExMXkgd3JhcHBlcgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0MjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3Bw IGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdy YXBwZXJBdGsuY3BwCmluZGV4IGYzNGRhNjcuLmQwZDgyNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlckF0ay5jcHAKQEAgLTYzLDYgKzYzLDcgQEAKICNpbmNsdWRlICJUZXh0RW5jb2Rp bmcuaCIKICNpbmNsdWRlICJUZXh0SXRlcmF0b3IuaCIKICNpbmNsdWRlICJXZWJLaXRBY2Nlc3Np YmxlSHlwZXJsaW5rLmgiCisjaW5jbHVkZSAiaHRtbGVkaXRpbmcuaCIKICNpbmNsdWRlICJ2aXNp YmxlX3VuaXRzLmgiCiAKICNpbmNsdWRlIDxhdGsvYXRrLmg+CkBAIC0xNjIxLDcgKzE2MjIsNyBA QCBzdGF0aWMgdm9pZCBnZXRTZWxlY3Rpb25PZmZzZXRzRm9yT2JqZWN0KEFjY2Vzc2liaWxpdHlP YmplY3QqIGNvcmVPYmplY3QsIFZpc2libAogICAgIC8vIHN0YXJ0IHBvc2l0aW9uIChpdCB3b3Vs ZCBiZWxvbmcgdG8gdGhlIG5vZGUgYW55d2F5KS4KICAgICBOb2RlKiBmaXJzdExlYWZOb2RlID0g bm9kZS0+Zmlyc3REZXNjZW5kYW50KCk7CiAgICAgaWYgKHNlbFJhbmdlLT5pc1BvaW50SW5SYW5n ZShmaXJzdExlYWZOb2RlLCAwLCBlYykpCi0gICAgICAgIG5vZGVSYW5nZVN0YXJ0ID0gZmlyc3RQ b3NpdGlvbkluTm9kZShmaXJzdExlYWZOb2RlKTsKKyAgICAgICAgbm9kZVJhbmdlU3RhcnQgPSBm aXJzdFBvc2l0aW9uSW5PckJlZm9yZU5vZGUoZmlyc3RMZWFmTm9kZSk7CiAgICAgZWxzZQogICAg ICAgICBub2RlUmFuZ2VTdGFydCA9IHNlbFJhbmdlLT5zdGFydFBvc2l0aW9uKCk7CiAKQEAgLTE2 MzEsMTIgKzE2MzIsMTIgQEAgc3RhdGljIHZvaWQgZ2V0U2VsZWN0aW9uT2Zmc2V0c0Zvck9iamVj dChBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0LCBWaXNpYmwKICAgICAvLyBlbmQgcG9z aXRpb24gKGl0IHdvdWxkIGJlbG9uZyB0byB0aGUgbm9kZSBhbnl3YXkpLgogICAgIE5vZGUqIGxh c3RMZWFmTm9kZSA9IG5vZGUtPmxhc3REZXNjZW5kYW50KCk7CiAgICAgaWYgKHNlbFJhbmdlLT5p c1BvaW50SW5SYW5nZShsYXN0TGVhZk5vZGUsIGxhc3RPZmZzZXRJbk5vZGUobGFzdExlYWZOb2Rl KSwgZWMpKQotICAgICAgICBub2RlUmFuZ2VFbmQgPSBsYXN0UG9zaXRpb25Jbk5vZGUobGFzdExl YWZOb2RlKTsKKyAgICAgICAgbm9kZVJhbmdlRW5kID0gbGFzdFBvc2l0aW9uSW5PckFmdGVyTm9k ZShsYXN0TGVhZk5vZGUpOwogICAgIGVsc2UKICAgICAgICAgbm9kZVJhbmdlRW5kID0gc2VsUmFu Z2UtPmVuZFBvc2l0aW9uKCk7CiAKICAgICAvLyBDYWxjdWxhdGUgcG9zaXRpb24gb2YgdGhlIHNl bGVjdGVkIHJhbmdlIGluc2lkZSB0aGUgb2JqZWN0LgotICAgIFBvc2l0aW9uIHBhcmVudEZpcnN0 UG9zaXRpb24gPSBmaXJzdFBvc2l0aW9uSW5Ob2RlKG5vZGUpOworICAgIFBvc2l0aW9uIHBhcmVu dEZpcnN0UG9zaXRpb24gPSBmaXJzdFBvc2l0aW9uSW5PckJlZm9yZU5vZGUobm9kZSk7CiAgICAg UmVmUHRyPFJhbmdlPiByYW5nZUluUGFyZW50ID0gUmFuZ2U6OmNyZWF0ZShub2RlLT5kb2N1bWVu dCgpLCBwYXJlbnRGaXJzdFBvc2l0aW9uLCBub2RlUmFuZ2VTdGFydCk7CiAKICAgICAvLyBTZXQg dmFsdWVzIGZvciBzdGFydCBhbmQgZW5kIG9mZnNldHMuCi0tIAoxLjcuNC4yCgo=