58423 2011-04-13 02:26:57 -0700 Web Inspector: [REGRESSION] diffs in resource revisions are not displayed. 2011-04-13 04:39:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 384748 0 pfeldman 2011-04-13 02:26:57 -0700 Try editing css file live, save it multiple times. No clue on what has changed. 384792 1 89365 podivilov 2011-04-13 04:30:27 -0700 Created attachment 89365 Patch. 384795 2 89365 pfeldman 2011-04-13 04:32:06 -0700 Comment on attachment 89365 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89365&action=review > Source/WebCore/inspector/front-end/ResourceView.js:202 > + callback("Stylesheet not found."); Should you return empty content instead? 384796 3 podivilov 2011-04-13 04:34:42 -0700 (In reply to comment #2) > (From update of attachment 89365 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89365&action=review > > > Source/WebCore/inspector/front-end/ResourceView.js:202 > > + callback("Stylesheet not found."); > > Should you return empty content instead? This callback doesn't return content, it just notifies TextViewer whether new text was committed or rejected. 384797 4 podivilov 2011-04-13 04:39:15 -0700 Committed r83719: <http://trac.webkit.org/changeset/83719> 89365 2011-04-13 04:30:27 -0700 2011-04-13 04:32:06 -0700 Patch. patch text/plain 3252 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYjcwODRiLi5mOGYzMDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDQtMTMgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogaW5hY3RpdmUgc3R5bGUgc2hlZXRzIHNob3VsZCBiZSByZWFkIG9ubHkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01ODQyMworCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQ1NTU291cmNlRnJhbWUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1NvdXJj ZUZyYW1lLnByb3RvdHlwZS5pc0NvbnRlbnRFZGl0YWJsZSk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuQ1NTU291cmNlRnJhbWUucHJvdG90eXBlLl9sb2FkU3R5bGVTaGVldC5kaWRHZXRBbGxTdHls ZVNoZWV0cy5kaWRDcmVhdGVGb3JJZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTU291cmNl RnJhbWUucHJvdG90eXBlLl9sb2FkU3R5bGVTaGVldCk6CisKIDIwMTEtMDQtMTMgIEFsZXhhbmRl ciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9SZXNvdXJjZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlVmlldy5qcwppbmRleCA2NTg0ZGUzLi4zMjJiMzdkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVmlldy5qcwpAQCAtMTYwLDQ2 ICsxNjAsNDkgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlU291cmNlRnJhbWUucHJvdG90eXBlLl9f cHJvdG9fXyA9IFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS4KIFdlYkluc3BlY3Rvci5DU1NTb3Vy Y2VGcmFtZSA9IGZ1bmN0aW9uKHJlc291cmNlKQogewogICAgIFdlYkluc3BlY3Rvci5SZXNvdXJj ZVNvdXJjZUZyYW1lLmNhbGwodGhpcywgcmVzb3VyY2UpOworICAgIHRoaXMuX2xvYWRTdHlsZVNo ZWV0KCk7CiB9CiAKIFdlYkluc3BlY3Rvci5DU1NTb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAg ICAgaXNDb250ZW50RWRpdGFibGU6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0 cnVlOworICAgICAgICByZXR1cm4gISF0aGlzLl9zdHlsZVNoZWV0OwogICAgIH0sCiAKLSAgICBf ZWRpdENvbnRlbnQ6IGZ1bmN0aW9uKG5ld1RleHQsIGNhbGxiYWNrKQorICAgIF9sb2FkU3R5bGVT aGVldDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgZnVuY3Rpb24gaGFuZGxlU3R5bGVTaGVl dChuZXdUZXh0LCBzdHlsZVNoZWV0KQotICAgICAgICB7Ci0gICAgICAgICAgICB0aGlzLl9zdHls ZVNoZWV0ID0gc3R5bGVTaGVldDsKLSAgICAgICAgICAgIHRoaXMuX3NhdmVTdHlsZVNoZWV0KG5l d1RleHQsIGNhbGxiYWNrKTsKLSAgICAgICAgfQotCi0gICAgICAgIGZ1bmN0aW9uIGhhbmRsZUlu Zm9zKG5ld1RleHQsIGVycm9yLCBpbmZvcykKKyAgICAgICAgZnVuY3Rpb24gZGlkR2V0QWxsU3R5 bGVTaGVldHMoZXJyb3IsIGluZm9zKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoZXJyb3Ip IHsKLSAgICAgICAgICAgICAgICBjYWxsYmFjayhlcnJvcik7CisgICAgICAgICAgICBpZiAoZXJy b3IpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQogCisgICAgICAgICAg ICB2YXIgc3R5bGVzaGVldElkOwogICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBpbmZv cy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgICAgIHZhciBpbmZvID0gaW5mb3NbaV07CiAg ICAgICAgICAgICAgICAgaWYgKGluZm8uc291cmNlVVJMID09PSB0aGlzLl9yZXNvdXJjZS51cmwp IHsKLSAgICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLkNTU1N0eWxlU2hlZXQuY3JlYXRl Rm9ySWQoaW5mby5zdHlsZVNoZWV0SWQsIGhhbmRsZVN0eWxlU2hlZXQuYmluZCh0aGlzLCBuZXdU ZXh0KSk7CisgICAgICAgICAgICAgICAgICAgIHN0eWxlc2hlZXRJZCA9IGluZm8uc3R5bGVTaGVl dElkOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICB9Ci0gICAgICAgIH0KKyAgICAgICAgICAgIGlmICghc3R5bGVzaGVldElkKQorICAg ICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAodGhpcy5fc3R5bGVTaGVldCkKLSAg ICAgICAgICAgIHRoaXMuX3NhdmVTdHlsZVNoZWV0KG5ld1RleHQsIGNhbGxiYWNrKTsKLSAgICAg ICAgZWxzZQotICAgICAgICAgICAgQ1NTQWdlbnQuZ2V0QWxsU3R5bGVTaGVldHMoaGFuZGxlSW5m b3MuYmluZCh0aGlzLCBuZXdUZXh0KSk7CisgICAgICAgICAgICBmdW5jdGlvbiBkaWRDcmVhdGVG b3JJZChzdHlsZVNoZWV0KQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHRoaXMuX3N0 eWxlU2hlZXQgPSBzdHlsZVNoZWV0OworICAgICAgICAgICAgfQorICAgICAgICAgICAgV2ViSW5z cGVjdG9yLkNTU1N0eWxlU2hlZXQuY3JlYXRlRm9ySWQoc3R5bGVzaGVldElkLCBkaWRDcmVhdGVG b3JJZC5iaW5kKHRoaXMpKTsKKyAgICAgICAgfQorICAgICAgICBDU1NBZ2VudC5nZXRBbGxTdHls ZVNoZWV0cyhkaWRHZXRBbGxTdHlsZVNoZWV0cy5iaW5kKHRoaXMpKTsKICAgICB9LAogCi0gICAg X3NhdmVTdHlsZVNoZWV0OiBmdW5jdGlvbihuZXdUZXh0LCBjYWxsYmFjaykKKyAgICBfZWRpdENv bnRlbnQ6IGZ1bmN0aW9uKG5ld1RleHQsIGNhbGxiYWNrKQogICAgIHsKKyAgICAgICAgaWYgKCF0 aGlzLl9zdHlsZVNoZWV0KSB7CisgICAgICAgICAgICBjYWxsYmFjaygiU3R5bGVzaGVldCBub3Qg Zm91bmQuIik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwogICAgICAgICBmdW5j dGlvbiBkaWRTZXRUZXh0KHN1Y2Nlc3MpCiAgICAgICAgIHsKICAgICAgICAgICAgIHZhciBlcnJv cjsK