58405 2011-04-12 17:53:31 -0700 BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition 2011-04-13 01:15:01 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 pknight webkit-unassigned barraclough commit-queue ddkilzer joepeck pknight oldest_to_newest 384574 0 pknight 2011-04-12 17:53:31 -0700 The BACKTRACE() macro currently checks whether NDEBUG is defined in the implementation of WTFReportBacktrace, and not in the BACKTRACE() macro. This means you need a Debug JavaScriptCore in order for it to do anything. It seems the check should be moved to the header file, so you can use BACKTRACE() in a WebCore debug build and not need a Debug JavaScriptCore, similar to the way the other macros like ASSERT() work. 384670 1 89337 pknight 2011-04-12 21:53:10 -0700 Created attachment 89337 Proposed patch 384676 2 89337 barraclough 2011-04-12 22:10:24 -0700 Comment on attachment 89337 Proposed patch Looks great. 384727 3 89337 commit-queue 2011-04-13 01:14:56 -0700 Comment on attachment 89337 Proposed patch Clearing flags on attachment: 89337 Committed r83709: <http://trac.webkit.org/changeset/83709> 384728 4 commit-queue 2011-04-13 01:15:01 -0700 All reviewed patches have been landed. Closing bug. 89337 2011-04-12 21:53:10 -0700 2011-04-13 01:14:56 -0700 Proposed patch 58405.txt text/plain 2221 pknight SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Bc3NlcnRpb25zLmNwcAkocmV2aXNpb24g ODM2NzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMTUsNyArMjE1LDcgQEAKIAogdm9pZCBXVEZSZXBvcnRCYWNrdHJhY2Uo KQogewotI2lmIFBMQVRGT1JNKE1BQykgJiYgIWRlZmluZWQoTkRFQlVHKQorI2lmIFBMQVRGT1JN KE1BQykKICAgICBzdGF0aWMgY29uc3QgaW50IG1heEZyYW1lcyA9IDMyOwogICAgIHZvaWQqIHNh bXBsZXNbbWF4RnJhbWVzXTsKICAgICBpbnQgZnJhbWVzID0gYmFja3RyYWNlKHNhbXBsZXMsIG1h eEZyYW1lcyk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuaAkocmV2 aXNpb24gODM2NzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuaAko d29ya2luZyBjb3B5KQpAQCAtNzMsNiArNzMsMTAgQEAKICNkZWZpbmUgSEFWRV9WQVJJQURJQ19N QUNSTyAxCiAjZW5kaWYKIAorI2lmbmRlZiBCQUNLVFJBQ0VfRElTQUJMRUQKKyNkZWZpbmUgQkFD S1RSQUNFX0RJU0FCTEVEIEFTU0VSVElPTlNfRElTQUJMRURfREVGQVVMVAorI2VuZGlmCisKICNp Zm5kZWYgQVNTRVJUX0RJU0FCTEVECiAjZGVmaW5lIEFTU0VSVF9ESVNBQkxFRCBBU1NFUlRJT05T X0RJU0FCTEVEX0RFRkFVTFQKICNlbmRpZgpAQCAtMTg4LDEwICsxOTIsMTcgQEAKIAogICBQcmlu dCBhIGJhY2t0cmFjZSB0byB0aGUgc2FtZSBsb2NhdGlvbiBhcyBBU1NFUlQgbWVzc2FnZXMuCiAq LwotI2lmbmRlZiBCQUNLVFJBQ0UKKworI2lmIEJBQ0tUUkFDRV9ESVNBQkxFRAorCisjZGVmaW5l IEJBQ0tUUkFDRSgpICgodm9pZCkwKQorCisjZWxzZQorCiAjZGVmaW5lIEJBQ0tUUkFDRSgpIGRv IHsgXAogICAgIFdURlJlcG9ydEJhY2t0cmFjZSgpOyBcCiB9IHdoaWxlKGZhbHNlKQorCiAjZW5k aWYKIAogLyogQVNTRVJULCBBU1NFUlRfTk9UX1JFQUNIRUQsIEFTU0VSVF9VTlVTRUQKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODM2ODkpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MDQtMTIgIFBhdWwgS25pZ2h0ICA8cGtuaWdodEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQkFDS1RSQUNFKCkgbWFjcm8gc2hvdWxk IGNoZWNrIGZvciBEZWJ1ZyBjb25maWd1cmF0aW9uIGluIG1hY3JvLCBub3QgV1RGUmVwb3J0QmFj a3RyYWNlIGRlZmluaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU4NDA1CisKKyAgICAgICAgVGhlIEJBQ0tUUkFDRSgpIG1hY3JvIHJlcXVpcmVz IEphdmFTY3JpcHRDb3JlIGJlIGJ1aWx0IHdpdGggYSBEZWJ1ZworICAgICAgICBjb25maWd1cmF0 aW9uIGluIG9yZGVyIGZvciBpdCB0byBiZSBlbmFibGVkLiBNb3ZlIHRoZSBOREVCVUcgY2hlY2sg dG8KKyAgICAgICAgdGhlIGhlYWRlciBzbyBpdCB3aWxsIGJlIGVuYWJsZWQgd2hlbiB0aGUgY2Fs bGluZyBmcmFtZXdvcmsgb3IKKyAgICAgICAgYXBwbGljYXRpb24gaXMgYnVpbHQgd2l0aCBhIERl YnVnIGNvbmZpZ3VyYXRpb24sIHNpbWlsYXIgdG8gaG93CisgICAgICAgIEFTU0VSVCgpIGFuZCBm cmllbmRzIHdvcmsuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5jcHA6CisgICAgICAgICog d3RmL0Fzc2VydGlvbnMuaDoKKwogMjAxMS0wNC0xMiAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJy YWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCg==