58404 2011-04-12 17:30:02 -0700 REGRESSION (WebKit2): Input methods are active in non-editable content 2011-04-12 21:35:58 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue enrica oldest_to_newest 384552 0 ap 2011-04-12 17:30:02 -0700 Steps to reproduce: 1. Open any Web page. 2. Enable Kotoeri Hiragana (or any other input source that uses inline input) 3. Press any alphanimeric key when selection is in non-editable content. 4. Press F11. Expected results: Expose is invoked. Actual results: it's not. We should return nil from -[WKView inputContext] when the current selection is not editable. 384553 1 ap 2011-04-12 17:30:21 -0700 <rdar://problem/9275940> 384559 2 89317 ap 2011-04-12 17:37:27 -0700 Created attachment 89317 proposed fix Note that WK1 also calls -[NSApp updateWindows] to make sure that AppKit fetches the most up to date context. It's tricky to do, and I couldn't see any problems from not doing it on 10.6, so let's start without updateWindows calls to see if anything breaks. 384563 3 89317 oliver 2011-04-12 17:41:06 -0700 Comment on attachment 89317 proposed fix Is there a bug for the windows equivalent of this? 384568 4 89317 enrica 2011-04-12 17:42:48 -0700 Comment on attachment 89317 proposed fix The change looks good to me 384575 5 89317 ap 2011-04-12 17:54:05 -0700 Comment on attachment 89317 proposed fix I don't know if there is a Windows equivalent, I don't remember how Windows IM works. 384655 6 89317 commit-queue 2011-04-12 21:35:50 -0700 Comment on attachment 89317 proposed fix Clearing flags on attachment: 89317 Committed r83697: <http://trac.webkit.org/changeset/83697> 384657 7 commit-queue 2011-04-12 21:35:58 -0700 All reviewed patches have been landed. Closing bug. 89317 2011-04-12 17:37:27 -0700 2011-04-12 21:35:50 -0700 proposed fix NilContext.txt text/plain 2697 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjczKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTIgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTiAoV2ViS2l0Mik6IElucHV0IG1ldGhvZHMg YXJlIGFjdGl2ZSBpbiBub24tZWRpdGFibGUgY29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTg0MDQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzkyNzU5NDA+CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAg ICAgICgtW1dLVmlldyBpbnNlcnRUZXh0Ol0pOiBSZS1hZGQgdGhlIG9sZCB2YXJpYW50IG9mIHRo aXMgZnVuY3Rpb24sIGJlY2F1c2UgaXQncyBub3Qgb25seSBwYXJ0CisgICAgICAgIG9mIGRlcHJl Y2F0ZWQgTlNUZXh0SW5wdXQgcHJvdG9jb2wsIGJ1dCBpdCdzIGFsc28gcGFydCBvZiBOU1Jlc3Bv bmRlciwgYW5kIGl0J3MgY2FsbGVkIHdoZW4KKyAgICAgICAgdGhlIGlucHV0IGNvbnRleHQgaW4g bmlsLgorICAgICAgICAoLVtXS1ZpZXcgaW5wdXRDb250ZXh0XSk6IFJldHVybiBuaWwgd2hlbiBu b3QgaW4gZWRpdGFibGUgY29udGVudC4KKwogMjAxMS0wNC0xMiAgRW5yaWNhIENhc3VjY2kgIDxl bnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFr b3YgYW5kIFNhbSBXZWluaWcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA4MzUyMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTA0MSw2ICsxMDQxLDE0IEBA IC0gKHZvaWQpZG9Db21tYW5kQnlTZWxlY3RvcjooU0VMKXNlbGVjdG8KICAgICB9CiB9CiAKKy0g KHZvaWQpaW5zZXJ0VGV4dDooaWQpc3RyaW5nCit7CisgICAgLy8gVW5saWtlIGFuZCBOU1RleHRJ bnB1dENsaWVudCB2YXJpYW50IHdpdGggcmVwbGFjZW1lbnRSYW5nZSwgdGhpcyBOU1Jlc3BvbmRl ciBtZXRob2QgaXMgY2FsbGVkIHdoZW4gdGhlcmUgaXMgbm8gaW5wdXQgY29udGV4dCwKKyAgICAv LyBzbyB0ZXh0IGlucHV0IHByb2Nlc3NpbmcgaXNuJ3QgcGVyZm9ybWVkLiBXZSBhcmUgbm90IGdv aW5nIHRvIGFjdHVhbGx5IGluc2VydCBhbnkgdGV4dCBpbiB0aGF0IGNhc2UsIGJ1dCBzYXZpbmcg YW4gaW5zZXJ0VGV4dAorICAgIC8vIGNvbW1hbmQgZW5zdXJlcyB0aGF0IGEga2V5cHJlc3MgZXZl bnQgaXMgZGlzcGF0Y2hlZCBhcyBhcHByb3ByaWF0ZS4KKyAgICBbc2VsZiBpbnNlcnRUZXh0OnN0 cmluZyByZXBsYWNlbWVudFJhbmdlOk5TTWFrZVJhbmdlKE5TTm90Rm91bmQsIDApXTsKK30KKwog LSAodm9pZClpbnNlcnRUZXh0OihpZClzdHJpbmcgcmVwbGFjZW1lbnRSYW5nZTooTlNSYW5nZSly ZXBsYWNlbWVudFJhbmdlCiB7CiAgICAgQk9PTCBpc0F0dHJpYnV0ZWRTdHJpbmcgPSBbc3RyaW5n IGlzS2luZE9mQ2xhc3M6W05TQXR0cmlidXRlZFN0cmluZyBjbGFzc11dOwpAQCAtMTE5Niw5ICsx MjA0LDE3IEBAIC0gKHZvaWQpX2V4ZWN1dGVTYXZlZEtleXByZXNzQ29tbWFuZHMKIAogLSAoTlNU ZXh0SW5wdXRDb250ZXh0ICopaW5wdXRDb250ZXh0CiB7Ci0gICAgaWYgKF9kYXRhLT5fcGx1Z2lu Q29tcGxleFRleHRJbnB1dElkZW50aWZpZXIgJiYgIV9kYXRhLT5faW50ZXJwcmV0S2V5RXZlbnRz UGFyYW1ldGVycykKKyAgICBXS1ZpZXdJbnRlcnByZXRLZXlFdmVudHNQYXJhbWV0ZXJzKiBwYXJh bWV0ZXJzID0gX2RhdGEtPl9pbnRlcnByZXRLZXlFdmVudHNQYXJhbWV0ZXJzOworCisgICAgaWYg KF9kYXRhLT5fcGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXIgJiYgIXBhcmFtZXRlcnMp CiAgICAgICAgIHJldHVybiBbW1dLVGV4dElucHV0V2luZG93Q29udHJvbGxlciBzaGFyZWRUZXh0 SW5wdXRXaW5kb3dDb250cm9sbGVyXSBpbnB1dENvbnRleHRdOwogCisgICAgLy8gRGlzYWJsZSB0 ZXh0IGlucHV0IG1hY2hpbmVyeSB3aGVuIGluIG5vbi1lZGl0YWJsZSBjb250ZW50LiBBbiBpbnZp c2libGUgaW5saW5lIGlucHV0IGFyZWEgYWZmZWN0cyBwZXJmb3JtYW5jZSwgYW5kIGNhbiBwcmV2 ZW50IEV4cG9zZSBmcm9tIHdvcmtpbmcuCisgICAgaWYgKHBhcmFtZXRlcnMgJiYgIXBhcmFtZXRl cnMtPmNhY2hlZFRleHRJbnB1dFN0YXRlLnNlbGVjdGlvbklzRWRpdGFibGUpCisgICAgICAgIHJl dHVybiBuaWw7CisgICAgaWYgKCFfZGF0YS0+X3BhZ2UtPnNlbGVjdGlvblN0YXRlKCkuaXNDb250 ZW50RWRpdGFibGUpCisgICAgICAgIHJldHVybiBuaWw7CisKICAgICByZXR1cm4gW3N1cGVyIGlu cHV0Q29udGV4dF07CiB9CiAK