58403 2011-04-12 17:28:34 -0700 Rename onEndChain and make it a static method. 2011-04-12 18:37:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned eric oldest_to_newest 384548 0 yael 2011-04-12 17:28:34 -0700 The method onEndChain should be renamed and should become static. 384549 1 eric 2011-04-12 17:28:54 -0700 Thanks. 384555 2 89316 yael 2011-04-12 17:34:41 -0700 Created attachment 89316 Patch. 384571 3 89316 eric 2011-04-12 17:46:28 -0700 Comment on attachment 89316 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > Source/WebCore/rendering/InlineFlowBox.cpp:255 > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) Should mark it static and possibly inline. 384576 4 yael 2011-04-12 17:54:42 -0700 (In reply to comment #3) > (From update of attachment 89316 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review > > Otherwise LGTM. If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch. Thanks! > > > Source/WebCore/rendering/InlineFlowBox.cpp:255 > > +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child) > > Should mark it static and possibly inline. Terribly sorry, I forgot to mark it static. Thanks for catching it. I'll mark it inline if the compiler agrees :) 384603 5 yael 2011-04-12 18:37:32 -0700 Committed r83679: <http://trac.webkit.org/changeset/83679> 89316 2011-04-12 17:34:41 -0700 2011-04-12 17:46:28 -0700 Patch. 58403.patch text/plain 3415 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNjczKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTIgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbmFtZSBvbkVuZENoYWluIGFuZCBtYWtlIGl0IGEgc3Rh dGljIG1ldGhvZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTU4NDAzCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoaXMgaXMgcmVmYWN0b3Jp bmcgb25seS4KKworICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmlzTGFzdENoaWxkRm9yUmVuZGVyZXIpOgorICAgICAgICAoV2ViQ29yZTo6 SW5saW5lRmxvd0JveDo6ZGV0ZXJtaW5lU3BhY2luZ0ZvckZsb3dCb3hlcyk6CisgICAgICAgICog cmVuZGVyaW5nL0lubGluZUZsb3dCb3guaDoKKwogMjAxMS0wNC0xMiAgQ3NhYmEgT3N6dHJvZ29u w6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHI4MzYzNCBhbmQgcjgzNjU5LgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGlu ZUZsb3dCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9Jbmxp bmVGbG93Qm94LmNwcAkocmV2aXNpb24gODM2NjYpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvSW5saW5lRmxvd0JveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1MiwyMCArMjUyLDIwIEBA IFJlbmRlckxpbmVCb3hMaXN0KiBJbmxpbmVGbG93Qm94OjpyZW5kZXIKICAgICByZXR1cm4gdG9S ZW5kZXJJbmxpbmUocmVuZGVyZXIoKSktPmxpbmVCb3hlcygpOwogfQogCi1ib29sIElubGluZUZs b3dCb3g6Om9uRW5kQ2hhaW4oUmVuZGVyT2JqZWN0KiBlbmRPYmplY3QpCitib29sIGlzTGFzdENo aWxkRm9yUmVuZGVyZXIoUmVuZGVyT2JqZWN0KiBhbmNlc3RvciwgUmVuZGVyT2JqZWN0KiBjaGls ZCkKIHsKLSAgICBpZiAoIWVuZE9iamVjdCkKKyAgICBpZiAoIWNoaWxkKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgCi0gICAgaWYgKGVuZE9iamVjdCA9PSByZW5kZXJlcigpKQorICAgIGlm IChjaGlsZCA9PSBhbmNlc3RvcikKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBSZW5kZXJP YmplY3QqIGN1cnIgPSBlbmRPYmplY3Q7CisgICAgUmVuZGVyT2JqZWN0KiBjdXJyID0gY2hpbGQ7 CiAgICAgUmVuZGVyT2JqZWN0KiBwYXJlbnQgPSBjdXJyLT5wYXJlbnQoKTsKICAgICB3aGlsZSAo cGFyZW50ICYmICghcGFyZW50LT5pc1JlbmRlckJsb2NrKCkgfHwgcGFyZW50LT5pc0lubGluZSgp KSkgewogICAgICAgICBpZiAocGFyZW50LT5sYXN0Q2hpbGQoKSAhPSBjdXJyKQogICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBpZiAocGFyZW50ID09IHJlbmRlcmVyKCkpCisgICAg ICAgIGlmIChwYXJlbnQgPT0gYW5jZXN0b3IpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgICAgIAogICAgICAgICBjdXJyID0gcGFyZW50OwpAQCAtMzA5LDcgKzMwOSw3IEBAIHZv aWQgSW5saW5lRmxvd0JveDo6ZGV0ZXJtaW5lU3BhY2luZ0ZvckYKIAogICAgICAgICBpZiAoIWxp bmVCb3hMaXN0LT5sYXN0TGluZUJveCgpLT5pc0NvbnN0cnVjdGVkKCkpIHsKICAgICAgICAgICAg IFJlbmRlcklubGluZSogaW5saW5lRmxvdyA9IHRvUmVuZGVySW5saW5lKHJlbmRlcmVyKCkpOwot ICAgICAgICAgICAgYm9vbCBpc0xhc3RPYmplY3RPbkxpbmUgPSAhaXNBbnNlY3RvckFuZFdpdGhp bkJsb2NrKHJlbmRlcmVyKCksIGxvZ2ljYWxseUxhc3RSdW5SZW5kZXJlcikgfHwgKG9uRW5kQ2hh aW4obG9naWNhbGx5TGFzdFJ1blJlbmRlcmVyKSAmJiAhaXNMb2dpY2FsbHlMYXN0UnVuV3JhcHBl ZCk7CisgICAgICAgICAgICBib29sIGlzTGFzdE9iamVjdE9uTGluZSA9ICFpc0Fuc2VjdG9yQW5k V2l0aGluQmxvY2socmVuZGVyZXIoKSwgbG9naWNhbGx5TGFzdFJ1blJlbmRlcmVyKSB8fCAoaXNM YXN0Q2hpbGRGb3JSZW5kZXJlcihyZW5kZXJlcigpLCBsb2dpY2FsbHlMYXN0UnVuUmVuZGVyZXIp ICYmICFpc0xvZ2ljYWxseUxhc3RSdW5XcmFwcGVkKTsKIAogICAgICAgICAgICAgLy8gV2UgaW5j bHVkZSB0aGUgYm9yZGVyIHVuZGVyIHRoZXNlIGNvbmRpdGlvbnM6CiAgICAgICAgICAgICAvLyAo MSkgVGhlIG5leHQgbGluZSB3YXMgbm90IGNyZWF0ZWQsIG9yIGl0IGlzIGNvbnN0cnVjdGVkLiBX ZSBjaGVjayB0aGUgcHJldmlvdXMgbGluZSBmb3IgcnRsLgpJbmRleDogU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0lubGluZUZsb3dCb3guaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvSW5saW5lRmxvd0JveC5oCShyZXZpc2lvbiA4MzY2NikKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmgJKHdvcmtpbmcgY29weSkKQEAgLTE2MSw3ICsx NjEsNiBAQCBwdWJsaWM6CiAgICAgLy8gSGVscGVyIGZ1bmN0aW9ucyB1c2VkIGR1cmluZyBsaW5l IGNvbnN0cnVjdGlvbiBhbmQgcGxhY2VtZW50LgogICAgIHZvaWQgZGV0ZXJtaW5lU3BhY2luZ0Zv ckZsb3dCb3hlcyhib29sIGxhc3RMaW5lLCBib29sIGlzTG9naWNhbGx5TGFzdFJ1bldyYXBwZWQs IFJlbmRlck9iamVjdCogbG9naWNhbGx5TGFzdFJ1blJlbmRlcmVyKTsKICAgICBpbnQgZ2V0Rmxv d1NwYWNpbmdMb2dpY2FsV2lkdGgoKTsKLSAgICBib29sIG9uRW5kQ2hhaW4oUmVuZGVyT2JqZWN0 KiBlbmRPYmplY3QpOwogICAgIGZsb2F0IHBsYWNlQm94ZXNJbklubGluZURpcmVjdGlvbihmbG9h dCBsb2dpY2FsTGVmdCwgYm9vbCYgbmVlZHNXb3JkU3BhY2luZywgR2x5cGhPdmVyZmxvd0FuZEZh bGxiYWNrRm9udHNNYXAmKTsKICAgICB2b2lkIGNvbXB1dGVMb2dpY2FsQm94SGVpZ2h0cyhSb290 SW5saW5lQm94KiwgaW50JiBtYXhQb3NpdGlvblRvcCwgaW50JiBtYXhQb3NpdGlvbkJvdHRvbSwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQmIG1heEFzY2VudCwgaW50JiBt YXhEZXNjZW50LCBib29sJiBzZXRNYXhBc2NlbnQsIGJvb2wmIHNldE1heERlc2NlbnQsCg==